From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B16C433B4 for ; Fri, 2 Apr 2021 06:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 770A3610E7 for ; Fri, 2 Apr 2021 06:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbhDBGmq (ORCPT ); Fri, 2 Apr 2021 02:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhDBGmp (ORCPT ); Fri, 2 Apr 2021 02:42:45 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E6D9C0613E6 for ; Thu, 1 Apr 2021 23:42:45 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id n198so2283180iod.0 for ; Thu, 01 Apr 2021 23:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=yj6+vSRZLkkm8CHfCAHYPtQtKWMqvTFnQ6YMhgNKBnc=; b=qiWYH2oiUzVi6Ex79pPXPik+XUkqKcMptn6lKyCdQ4wWCJM0GnNPshmRPPcepCqNIV KJsBYAdAY9MSRQ4CTfQkneOFzz1VJsSD3/tBljlj/FhfzWQuPl30qRz9uKAtyOqMzMEx hHk3GOHDKTZpIqqzUEnS2McEvzxfr62M8OJq3U07xz6djly/pR9cutjbG9sPTuF2zncJ 3eni8RIBZwp7KcrPwzIclWXS6x5U4o7uiS5ZK5oEkAwf0rWmULB86Xiz0QqB80WoGNpx 7x3uAyU6KPrqOnIG2z96sU0c0V7KeV+3djxtfZvdibuF6bhJTmNhXT82h9ajmBGzcMH5 dENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=yj6+vSRZLkkm8CHfCAHYPtQtKWMqvTFnQ6YMhgNKBnc=; b=qKxUHJYdJpySewWNcmKy6Jd9UuM9Y0yyibg4nzoROJsKhBJLvH731NJprZT7tdmkU3 vhl1DQD30BrBZu1LMfmytt3MCHGD7k+C89opxb6tR/qH/pbcD/CueDB5gHbs8OG+lhpO kyd8Z03DQPzHuVYFGvvUA6vjYu7LdZ2BOAak7e6Wm6FOiGAdRv8PyDLDOU4qs/k+XpM/ WyLK/3W9i8t+SWP6/k21HuZC+Oo2Q4TGTYmZS+KRO9XW3RKs5NXSCxdV55B47XWKRxnL RbPGYILMZRx89MTePwLK9EbWEsqaoUBUw30fuQRA1AYphx6sfX+7BD7LvVVTwi5cHYwi 7IdQ== X-Gm-Message-State: AOAM532fINM7OgWjH6bnQ+3qOgtV59emGw5p4cFifrByKTklTEAN3QRL fMSFDx9+ga6qIj+baPQJ0ya4oG2/A3WTJ67CArdz5EMStOG7Ng== X-Google-Smtp-Source: ABdhPJz9e8u23bdl9W6P7q5ULqjRON5XoB6/o7v2BH97tDP2SNEtZQUtlKLox/z8j+wgSbu43gbCKyvpHGWIpyBE2ng= X-Received: by 2002:a5e:8610:: with SMTP id z16mr9600257ioj.57.1617345764402; Thu, 01 Apr 2021 23:42:44 -0700 (PDT) MIME-Version: 1.0 References: <20210211194258.4137998-1-nathan@kernel.org> <161428829728.2305454.15456455443457551559.b4-ty@chromium.org> In-Reply-To: <161428829728.2305454.15456455443457551559.b4-ty@chromium.org> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Fri, 2 Apr 2021 08:42:07 +0200 Message-ID: Subject: Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute To: Kees Cook Cc: Gabriel Somlo , Nathan Chancellor , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Nick Desaulniers , qemu-devel@nongnu.org, Clang-Built-Linux ML , Sami Tolvanen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > > which violates clang's CFI checking because fw_cfg_showrev()'s second > > parameter is 'struct attribute', whereas the ->show() member of 'struct > > kobj_structure' expects the second parameter to be of type 'struct > > kobj_attribute'. > > > > $ cat /sys/firmware/qemu_fw_cfg/rev > > 3 > > > > [...] > > Applied to kspp/cfi/cleanups, thanks! > > [1/1] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute > https://git.kernel.org/kees/c/f5c4679d6c49 > I have queued this up in my custom patchset (for-5.12/kspp-cfi-cleanups-20210225). What is the plan to get this upstream? Feel free to add my: Tested-by: Sedat Dilek - Sedat - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEC1C433B4 for ; Fri, 2 Apr 2021 06:43:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D9DE610CB for ; Fri, 2 Apr 2021 06:43:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D9DE610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSDXA-0000SB-TR for qemu-devel@archiver.kernel.org; Fri, 02 Apr 2021 02:43:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSDW6-0008Rg-IQ for qemu-devel@nongnu.org; Fri, 02 Apr 2021 02:42:50 -0400 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]:33756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSDW2-00036n-SI for qemu-devel@nongnu.org; Fri, 02 Apr 2021 02:42:50 -0400 Received: by mail-io1-xd36.google.com with SMTP id n198so2283199iod.0 for ; Thu, 01 Apr 2021 23:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=yj6+vSRZLkkm8CHfCAHYPtQtKWMqvTFnQ6YMhgNKBnc=; b=qiWYH2oiUzVi6Ex79pPXPik+XUkqKcMptn6lKyCdQ4wWCJM0GnNPshmRPPcepCqNIV KJsBYAdAY9MSRQ4CTfQkneOFzz1VJsSD3/tBljlj/FhfzWQuPl30qRz9uKAtyOqMzMEx hHk3GOHDKTZpIqqzUEnS2McEvzxfr62M8OJq3U07xz6djly/pR9cutjbG9sPTuF2zncJ 3eni8RIBZwp7KcrPwzIclWXS6x5U4o7uiS5ZK5oEkAwf0rWmULB86Xiz0QqB80WoGNpx 7x3uAyU6KPrqOnIG2z96sU0c0V7KeV+3djxtfZvdibuF6bhJTmNhXT82h9ajmBGzcMH5 dENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=yj6+vSRZLkkm8CHfCAHYPtQtKWMqvTFnQ6YMhgNKBnc=; b=ZWB5XBH2EQw8YkxX1zfqHuK0tGcgbxCgA/m58kbdFz2gW36LK9fuNOCAOtmBcOF5p9 J4iP1fqQD6wgkL5frj9frgn4XTYzuSetVlEZYj/EURFxeLrovpbPOvJ2XZeo3Cd5v6jZ 67idYqwrqMo5mp31cFB+iydrljSbf7Hcs3qi6WgASi8PC52PQswQNN52K+QZ4YZSuBpJ 5aOwsCxt+5+ZNKQ1cjLIsbqyZI+RaU6Gxn9sZMwz7GUHfWvDHDKIAKbUuT6q30G+0Vs+ an9RC5fc4N9F0wQS39+Ov87kuH1wx+zE5ovi7G3fWQa/Nq5Ki54G5jUFopb+5x0TJWFE zrHQ== X-Gm-Message-State: AOAM531ijzHxbl+Y10C5/2IVfQlHzHdM2i2Q3E/i/8oVT4LJVO66UoWc ogLa8CFrP+4zargpLmnR5O8Xrbmnf6PEj2QYaVE= X-Google-Smtp-Source: ABdhPJz9e8u23bdl9W6P7q5ULqjRON5XoB6/o7v2BH97tDP2SNEtZQUtlKLox/z8j+wgSbu43gbCKyvpHGWIpyBE2ng= X-Received: by 2002:a5e:8610:: with SMTP id z16mr9600257ioj.57.1617345764402; Thu, 01 Apr 2021 23:42:44 -0700 (PDT) MIME-Version: 1.0 References: <20210211194258.4137998-1-nathan@kernel.org> <161428829728.2305454.15456455443457551559.b4-ty@chromium.org> In-Reply-To: <161428829728.2305454.15456455443457551559.b4-ty@chromium.org> From: Sedat Dilek Date: Fri, 2 Apr 2021 08:42:07 +0200 Message-ID: Subject: Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute To: Kees Cook Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d36; envelope-from=sedat.dilek@gmail.com; helo=mail-io1-xd36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sedat.dilek@gmail.com Cc: "Michael S. Tsirkin" , Gabriel Somlo , Nick Desaulniers , qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Clang-Built-Linux ML , Sami Tolvanen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > > which violates clang's CFI checking because fw_cfg_showrev()'s second > > parameter is 'struct attribute', whereas the ->show() member of 'struct > > kobj_structure' expects the second parameter to be of type 'struct > > kobj_attribute'. > > > > $ cat /sys/firmware/qemu_fw_cfg/rev > > 3 > > > > [...] > > Applied to kspp/cfi/cleanups, thanks! > > [1/1] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute > https://git.kernel.org/kees/c/f5c4679d6c49 > I have queued this up in my custom patchset (for-5.12/kspp-cfi-cleanups-20210225). What is the plan to get this upstream? Feel free to add my: Tested-by: Sedat Dilek - Sedat -