From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?J=C3=A9r=C3=A9mie_Galarneau?= Subject: Re: [RFC PATCH v2 01/13] Extend health thread lifetime Date: Wed, 13 Dec 2017 20:54:08 -0500 Message-ID: References: <20170918225206.17725-1-jonathan.rajotte-julien@efficios.com> <20170918225206.17725-2-jonathan.rajotte-julien@efficios.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x242.google.com (mail-yb0-x242.google.com [IPv6:2607:f8b0:4002:c09::242]) by lists.lttng.org (Postfix) with ESMTPS id 3yxxSk3kmczhb0 for ; Thu, 14 Dec 2017 01:54:30 +0000 (UTC) Received: by mail-yb0-x242.google.com with SMTP id 5so2362963ybp.4 for ; Wed, 13 Dec 2017 17:54:30 -0800 (PST) In-Reply-To: <20170918225206.17725-2-jonathan.rajotte-julien@efficios.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" To: Jonathan Rajotte Cc: "lttng-dev@lists.lttng.org" , Jeremie Galarneau List-Id: lttng-dev@lists.lttng.org SGksCgpJIHJlYmFzZWQgdGhpcyBwYXRjaCBzZXQgb24gbWFzdGVyLgoKaHR0cHM6Ly9naXRodWIu Y29tL2pnYWxhci9sdHRuZy10b29scy90cmVlL3RlYXJkb3duLXJlYmFzZWQKCk1vc3QgcGF0Y2hl cyBzdGlsbCBhcHBsaWVkIGNsZWFubHksIGJ1dCBnaXQgcmVhbGx5IG1lc3NlZCB0aGlzIGZpcnN0 IG9uZSB1cAp3aGVuIHJlYmFzaW5nLiBUaGUgcGF0Y2ggYXBwbGllZCBhbmQgdGhlIGNvZGUgY29t cGlsZWQsIGJ1dApJIHJlYWxpemVkIGh1bmtzIGZyb20gdGhyZWFkX21hbmFnZV9oZWFsdGgoKSBh bmQgdGhyZWFkX21hbmFnZV9jbGllbnRzKCkKZW5kZWQgdXAgbWl4ZWQtdXAuLi4gKkZ1biogdGlt ZXMuCgpTZWUgY29tbWVudHMgYmVsb3cgYW5kIG9uIHRoZSBvdGhlciBwYXRjaGVzLgoKVGhhbmtz IQpKw6lyw6ltaWUKCk9uIDE4IFNlcHRlbWJlciAyMDE3IGF0IDE4OjUxLCBKb25hdGhhbiBSYWpv dHRlCjxqb25hdGhhbi5yYWpvdHRlLWp1bGllbkBlZmZpY2lvcy5jb20+IHdyb3RlOgo+IEFsbG93 IGVhc2llciBjb250cm9sIG92ZXIgdGhlIHRocmVhZCBieSBwcm92aWRpbmcgYSBkZWRpY2F0ZWQg cXVpdCBwaXBlLgoKb3ZlciB0aGUgaGVhbHRoIHRocmVhZCdzIGxpZmV0aW1lCgo+Cj4gU2lnbmVk LW9mZi1ieTogSm9uYXRoYW4gUmFqb3R0ZSA8am9uYXRoYW4ucmFqb3R0ZS1qdWxpZW5AZWZmaWNp b3MuY29tPgo+IC0tLQo+ICBzcmMvYmluL2x0dG5nLXNlc3Npb25kL21haW4uYyB8IDc0ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDU1IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3NyYy9i aW4vbHR0bmctc2Vzc2lvbmQvbWFpbi5jIGIvc3JjL2Jpbi9sdHRuZy1zZXNzaW9uZC9tYWluLmMK PiBpbmRleCAwM2Y2OTVlYy4uNWQ3ZGY3NDQgMTAwNjQ0Cj4gLS0tIGEvc3JjL2Jpbi9sdHRuZy1z ZXNzaW9uZC9tYWluLmMKPiArKysgYi9zcmMvYmluL2x0dG5nLXNlc3Npb25kL21haW4uYwo+IEBA IC0yMDQsNiArMjA0LDcgQEAgc3RhdGljIGludCBrZXJuZWxfcG9sbF9waXBlWzJdID0geyAtMSwg LTEgfTsKPiAgICogZm9yIGFsbCB0aHJlYWRzIHdoZW4gcmVjZWl2aW5nIGFuIGV2ZW50IG9uIHRo ZSBwaXBlLgo+ICAgKi8KPiAgc3RhdGljIGludCB0aHJlYWRfcXVpdF9waXBlWzJdID0geyAtMSwg LTEgfTsKPiArc3RhdGljIGludCB0aHJlYWRfaGVhbHRoX3RlYXJkb3duX3RyaWdnZXJfcGlwZVsy XSA9IHsgLTEsIC0xIH07Cj4KPiAgLyoKPiAgICogVGhpcyBwaXBlIGlzIHVzZWQgdG8gaW5mb3Jt IHRoZSB0aHJlYWQgbWFuYWdpbmcgYXBwbGljYXRpb24gY29tbXVuaWNhdGlvbgo+IEBAIC00Nzcs NiArNDc4LDExIEBAIHN0YXRpYyBpbnQgaW5pdF90aHJlYWRfcXVpdF9waXBlKHZvaWQpCj4gICAg ICAgICByZXR1cm4gX19pbml0X3RocmVhZF9xdWl0X3BpcGUodGhyZWFkX3F1aXRfcGlwZSk7Cj4g IH0KPgo+ICtzdGF0aWMgaW50IGluaXRfdGhyZWFkX2hlYWx0aF90ZWFyZG93bl90cmlnZ2VyX3Bp cGUodm9pZCkKPiArewo+ICsgICAgICAgcmV0dXJuIF9faW5pdF90aHJlYWRfcXVpdF9waXBlKHRo cmVhZF9oZWFsdGhfdGVhcmRvd25fdHJpZ2dlcl9waXBlKTsKPiArfQo+ICsKPiAgLyoKPiAgICog U3RvcCBhbGwgdGhyZWFkcyBieSBjbG9zaW5nIHRoZSB0aHJlYWQgcXVpdCBwaXBlLgo+ICAgKi8K PiBAQCAtNDI5NywxMSArNDMwMywxMyBAQCBzdGF0aWMgdm9pZCAqdGhyZWFkX21hbmFnZV9oZWFs dGgodm9pZCAqZGF0YSkKPiAgICAgICAgICAgICAgICAgZ290byBlcnJvcjsKPiAgICAgICAgIH0K Pgo+IC0gICAgICAgLyoKPiAtICAgICAgICAqIFBhc3MgMiBhcyBzaXplIGhlcmUgZm9yIHRoZSB0 aHJlYWQgcXVpdCBwaXBlIGFuZCBjbGllbnRfc29jay4gTm90aGluZwo+IC0gICAgICAgICogbW9y ZSB3aWxsIGJlIGFkZGVkIHRvIHRoaXMgcG9sbCBzZXQuCj4gLSAgICAgICAgKi8KPiAtICAgICAg IHJldCA9IHNlc3Npb25kX3NldF90aHJlYWRfcG9sbHNldCgmZXZlbnRzLCAyKTsKPiArICAgICAg IHJldCA9IGx0dG5nX3BvbGxfY3JlYXRlKCZldmVudHMsIDIsIExUVE5HX0NMT0VYRUMpOwoKUGxl YXNlIGFkZCBhIGNvbW1lbnQgYWJvdXQgdGhlICIyIiBiZWluZyB1c2VkIGhlcmUuCgo+ICsgICAg ICAgaWYgKHJldCA8IDApIHsKPiArICAgICAgICAgICAgICAgZ290byBlcnJvcjsKPiArICAgICAg IH0KPiArCj4gKyAgICAgICAvKiBBZGQgdGVhcmRvd24gdHJpZ2dlciAqLwo+ICsgICAgICAgcmV0 ID0gbHR0bmdfcG9sbF9hZGQoJmV2ZW50cywgdGhyZWFkX2hlYWx0aF90ZWFyZG93bl90cmlnZ2Vy X3BpcGVbMF0sIExQT0xMSU4gfCBMUE9MTEVSUik7Cj4gICAgICAgICBpZiAocmV0IDwgMCkgewo+ ICAgICAgICAgICAgICAgICBnb3RvIGVycm9yOwo+ICAgICAgICAgfQo+IEBAIC00MzQzLDEwICs0 MzUxLDE4IEBAIHJlc3RhcnQ6Cj4gICAgICAgICAgICAgICAgICAgICAgICAgfQo+Cj4gICAgICAg ICAgICAgICAgICAgICAgICAgLyogVGhyZWFkIHF1aXQgcGlwZSBoYXMgYmVlbiBjbG9zZWQuIEtp bGxpbmcgdGhyZWFkLiAqLwo+IC0gICAgICAgICAgICAgICAgICAgICAgIHJldCA9IHNlc3Npb25k X2NoZWNrX3RocmVhZF9xdWl0X3BpcGUocG9sbGZkLCByZXZlbnRzKTsKPiAtICAgICAgICAgICAg ICAgICAgICAgICBpZiAocmV0KSB7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBl cnIgPSAwOwo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBleGl0Owo+ICsg ICAgICAgICAgICAgICAgICAgICAgIGlmIChwb2xsZmQgPT0gdGhyZWFkX2hlYWx0aF90ZWFyZG93 bl90cmlnZ2VyX3BpcGVbMF0pIHsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlm IChyZXZlbnRzICYgTFBPTExJTikgewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAvKiBOb3JtYWwgZXhpdCAqLwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBlcnIgPSAwOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBnb3RvIGV4aXQ7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2Ug aWYgKHJldmVudHMgJiBMUE9MTEVSUikgewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBFUlIoIkhlYWx0aCB0ZWFyZG93biBwb2xsIGVycm9yIik7Cj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gZXJyb3I7Cj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB9IGVsc2Ugewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBFUlIoIlVuZXhwZWN0ZWQgcG9sbCBldmVudHMgJXUgZm9yIHRlYXJkb3du IHNvY2siLCByZXZlbnRzKTsKCnRlYXJkb3duIHNvY2tldCAtPiBwaXBlCgo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGVycm9yOwo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0KPgo+ICAgICAg ICAgICAgICAgICAgICAgICAgIC8qIEV2ZW50IG9uIHRoZSByZWdpc3RyYXRpb24gc29ja2V0ICov Cj4gQEAgLTQ0MTIsOCArNDQyOCwxMyBAQCByZXN0YXJ0Ogo+ICAgICAgICAgICAgICAgICB9Cj4g ICAgICAgICB9Cj4KPiAtZXhpdDoKPiAgZXJyb3I6Cj4gKyAgICAgICAvKgo+ICsgICAgICAgICog UGVyZm9ybSBzdG9wX3RocmVhZCBvbmx5IG9uIGVycm9yIHBhdGggc2luY2UgaW4gYSBub3JtYWwg dGVhcmRvd24gdGhlCj4gKyAgICAgICAgKiBoZWFsdGggdGhyZWFkIGlzIGluIHRoZSBsYXN0IHRo cmVhZCB0byB0ZXJtaW5hdGUuCgppcyB0aGUgbGFzdCB0aHJlYWQgdG8gdGVybWluYXRlCgo+ICsg ICAgICAgICovCj4gKyAgICAgICBzdG9wX3RocmVhZHMoKTsKPiArZXhpdDoKPiAgICAgICAgIGlm IChlcnIpIHsKPiAgICAgICAgICAgICAgICAgRVJSKCJIZWFsdGggZXJyb3Igb2NjdXJyZWQgaW4g JXMiLCBfX2Z1bmNfXyk7Cj4gICAgICAgICB9Cj4gQEAgLTQ0MjUsOSArNDQ0Niw3IEBAIGVycm9y Ogo+ICAgICAgICAgICAgICAgICAgICAgICAgIFBFUlJPUigiY2xvc2UiKTsKPiAgICAgICAgICAg ICAgICAgfQo+ICAgICAgICAgfQo+IC0KPiAgICAgICAgIGx0dG5nX3BvbGxfY2xlYW4oJmV2ZW50 cyk7Cj4gLSAgICAgICBzdG9wX3RocmVhZHMoKTsKPiAgICAgICAgIHJjdV91bnJlZ2lzdGVyX3Ro cmVhZCgpOwo+ICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gIH0KPiBAQCAtNTYzMSw2ICs1NjUwLDcg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAgICAgICAgICAgICAgICAgICAg ICAgICp1c3Q2NF9jaGFubmVsX21vbml0b3JfcGlwZSA9IE5VTEwsCj4gICAgICAgICAgICAgICAg ICAgICAgICAgKmtlcm5lbF9jaGFubmVsX21vbml0b3JfcGlwZSA9IE5VTEw7Cj4gICAgICAgICBi b29sIG5vdGlmaWNhdGlvbl90aHJlYWRfcnVubmluZyA9IGZhbHNlOwo+ICsgICAgICAgYm9vbCBo ZWFsdGhfdGhyZWFkX3J1bm5pbmcgPSBmYWxzZTsKPgo+ICAgICAgICAgaW5pdF9rZXJuZWxfd29y a2Fyb3VuZHMoKTsKPgo+IEBAIC01NzE3LDYgKzU3MzcsMTEgQEAgaW50IG1haW4oaW50IGFyZ2Ms IGNoYXIgKiphcmd2KQo+ICAgICAgICAgICAgICAgICBnb3RvIGV4aXRfaW5pdF9kYXRhOwo+ICAg ICAgICAgfQo+Cj4gKyAgICAgICBpZiAoaW5pdF90aHJlYWRfaGVhbHRoX3RlYXJkb3duX3RyaWdn ZXJfcGlwZSgpKSB7Cj4gKyAgICAgICAgICAgICAgIHJldHZhbCA9IC0xOwo+ICsgICAgICAgICAg ICAgICBnb3RvIGV4aXRfaW5pdF9kYXRhOwo+ICsgICAgICAgfQo+ICsKPiAgICAgICAgIC8qIENo ZWNrIGlmIGRhZW1vbiBpcyBVSUQgPSAwICovCj4gICAgICAgICBpc19yb290ID0gIWdldHVpZCgp Owo+Cj4gQEAgLTYxMTksNiArNjE0NCw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJn dikKPiAgICAgICAgICAgICAgICAgcmV0dmFsID0gLTE7Cj4gICAgICAgICAgICAgICAgIGdvdG8g ZXhpdF9oZWFsdGg7Cj4gICAgICAgICB9Cj4gKyAgICAgICBoZWFsdGhfdGhyZWFkX3J1bm5pbmcg PSB0cnVlOwo+Cj4gICAgICAgICAvKiBub3RpZmljYXRpb25fdGhyZWFkX2RhdGEgYWNxdWlyZXMg dGhlIHBpcGVzJyByZWFkIHNpZGUuICovCj4gICAgICAgICBub3RpZmljYXRpb25fdGhyZWFkX2hh bmRsZSA9IG5vdGlmaWNhdGlvbl90aHJlYWRfaGFuZGxlX2NyZWF0ZSgKPiBAQCAtNjMxMSwxMyAr NjMzNyw2IEBAIGV4aXRfZGlzcGF0Y2g6Cj4KPiAgZXhpdF9jbGllbnQ6Cj4gIGV4aXRfbm90aWZp Y2F0aW9uOgo+IC0gICAgICAgcmV0ID0gcHRocmVhZF9qb2luKGhlYWx0aF90aHJlYWQsICZzdGF0 dXMpOwo+IC0gICAgICAgaWYgKHJldCkgewo+IC0gICAgICAgICAgICAgICBlcnJubyA9IHJldDsK PiAtICAgICAgICAgICAgICAgUEVSUk9SKCJwdGhyZWFkX2pvaW4gaGVhbHRoIHRocmVhZCIpOwo+ IC0gICAgICAgICAgICAgICByZXR2YWwgPSAtMTsKPiAtICAgICAgIH0KPiAtCj4gIGV4aXRfaGVh bHRoOgo+ICBleGl0X2luaXRfZGF0YToKPiAgICAgICAgIC8qCj4gQEAgLTYzNTksNiArNjM3OCwy MCBAQCBleGl0X2luaXRfZGF0YToKPiAgICAgICAgICAgICAgICAgbm90aWZpY2F0aW9uX3RocmVh ZF9oYW5kbGVfZGVzdHJveShub3RpZmljYXRpb25fdGhyZWFkX2hhbmRsZSk7Cj4gICAgICAgICB9 Cj4KPiArICAgICAgIGlmIChoZWFsdGhfdGhyZWFkX3J1bm5pbmcpIHsKPiArICAgICAgICAgICAg ICAgcmV0ID0gbm90aWZ5X3RocmVhZF9waXBlKHRocmVhZF9oZWFsdGhfdGVhcmRvd25fdHJpZ2dl cl9waXBlWzFdKTsKPiArICAgICAgICAgICAgICAgaWYgKHJldCA8IDApIHsKPiArICAgICAgICAg ICAgICAgICAgICAgICBFUlIoIndyaXRlIGVycm9yIG9uIHRocmVhZCBxdWl0IHBpcGUiKTsKPiAr ICAgICAgICAgICAgICAgfQo+ICsKPiArICAgICAgICAgICAgICAgcmV0ID0gcHRocmVhZF9qb2lu KGhlYWx0aF90aHJlYWQsICZzdGF0dXMpOwo+ICsgICAgICAgICAgICAgICBpZiAocmV0KSB7Cj4g KyAgICAgICAgICAgICAgICAgICAgICAgZXJybm8gPSByZXQ7Cj4gKyAgICAgICAgICAgICAgICAg ICAgICAgUEVSUk9SKCJwdGhyZWFkX2pvaW4gaGVhbHRoIHRocmVhZCIpOwo+ICsgICAgICAgICAg ICAgICAgICAgICAgIHJldHZhbCA9IC0xOwo+ICsgICAgICAgICAgICAgICB9Cj4gKyAgICAgICB9 Cj4gKwo+ICAgICAgICAgcmN1X3RocmVhZF9vZmZsaW5lKCk7Cj4gICAgICAgICByY3VfdW5yZWdp c3Rlcl90aHJlYWQoKTsKPgo+IEBAIC02MzY2LDYgKzYzOTksOSBAQCBleGl0X2luaXRfZGF0YToK PiAgICAgICAgIGlmIChyZXQpIHsKPiAgICAgICAgICAgICAgICAgcmV0dmFsID0gLTE7Cj4gICAg ICAgICB9Cj4gKwo+ICsgICAgICAgLyogSGVhbHRoIHRocmVhZCB0ZWFyZG93biBwaXBlIGNsZWFu dXAgKi8KPiArICAgICAgIHV0aWxzX2Nsb3NlX3BpcGUodGhyZWFkX2hlYWx0aF90ZWFyZG93bl90 cmlnZ2VyX3BpcGUpOwo+ICAgICAgICAgbHR0bmdfcGlwZV9kZXN0cm95KHVzdDMyX2NoYW5uZWxf bW9uaXRvcl9waXBlKTsKPiAgICAgICAgIGx0dG5nX3BpcGVfZGVzdHJveSh1c3Q2NF9jaGFubmVs X21vbml0b3JfcGlwZSk7Cj4gICAgICAgICBsdHRuZ19waXBlX2Rlc3Ryb3koa2VybmVsX2NoYW5u ZWxfbW9uaXRvcl9waXBlKTsKPiAtLQo+IDIuMTEuMAo+CgoKCi0tIApKw6lyw6ltaWUgR2FsYXJu ZWF1CkVmZmljaU9TIEluYy4KaHR0cDovL3d3dy5lZmZpY2lvcy5jb20KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbHR0bmctZGV2IG1haWxpbmcgbGlzdAps dHRuZy1kZXZAbGlzdHMubHR0bmcub3JnCmh0dHBzOi8vbGlzdHMubHR0bmcub3JnL2NnaS1iaW4v bWFpbG1hbi9saXN0aW5mby9sdHRuZy1kZXYK