Re: [RFC PATCH v2 03/13] Terminate dispatch thread after reg_apps_thread is terminated

From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
To: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Cc: "lttng-dev@lists.lttng.org" <lttng-dev@lists.lttng.org>,
	Jeremie Galarneau <jgalar@efficios.com>
Subject: Re: [RFC PATCH v2 03/13] Terminate dispatch thread after reg_apps_thread is terminated
Date: Wed, 13 Dec 2017 20:55:26 -0500	[thread overview]
Message-ID: <CA+jJMxsM-9UbBtmuUuWwnccQmo3tSNLmiMQCwUDV69unPnsqbw__46886.1889829443$1513216557$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20170918225206.17725-4-jonathan.rajotte-julien@efficios.com>

No objection to the code, but please add a description and comment.

Jérémie

On 18 September 2017 at 18:51, Jonathan Rajotte
<jonathan.rajotte-julien@efficios.com> wrote:
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
>  src/bin/lttng-sessiond/main.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
> index 45c0270e..0ca72ec8 100644
> --- a/src/bin/lttng-sessiond/main.c
> +++ b/src/bin/lttng-sessiond/main.c
> @@ -497,9 +497,6 @@ static void stop_threads(void)
>                 ERR("write error on thread quit pipe");
>         }
>
> -       /* Dispatch thread */
> -       CMM_STORE_SHARED(dispatch_thread_exit, 1);
> -       futex_nto1_wake(&ust_cmd_queue.futex);
>  }
>
>  /*
> @@ -6306,6 +6303,10 @@ exit_client:
>                 retval = -1;
>         }
>  exit_reg_apps:
> +       /* Instruct the dispatch thread to quit */
> +       CMM_STORE_SHARED(dispatch_thread_exit, 1);
> +       futex_nto1_wake(&ust_cmd_queue.futex);
> +
>         ret = pthread_join(dispatch_thread, &status);
>         if (ret) {
>                 errno = ret;
> --
> 2.11.0
>

-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev