From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?J=E9r=E9mie_Galarneau?= Subject: Re: [PATCH lttng-ust] Add trace instrumentation for some pthread functions. Date: Wed, 31 Jul 2013 18:00:14 -0400 Message-ID: References: <51F97688.30704@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wg0-f53.google.com ([74.125.82.53]) by ltt.polymtl.ca with esmtp (Exim 4.72) (envelope-from ) id 1V4eRQ-0000uY-Hw for lttng-dev@lists.lttng.org; Wed, 31 Jul 2013 18:00:26 -0400 Received: by mail-wg0-f53.google.com with SMTP id c11so1067281wgh.8 for ; Wed, 31 Jul 2013 15:00:14 -0700 (PDT) In-Reply-To: <51F97688.30704@mentor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lttng-dev-bounces@lists.lttng.org To: Stefan Seefeld Cc: lttng-dev@lists.lttng.org List-Id: lttng-dev@lists.lttng.org Hi Stefan, Please inline your patches in the future as it makes the review process sim= pler. There are a number of stylistic problems, mostly misplaced braces. You can run your patches through the checkpatch.pl script found in lttng-tools/extras. It will spot most coding-style related problems right away. Also, I think lttng-ust-pthread-mutex.c may be a more appropriate name than pthread.c Thanks, J=E9r=E9mie On Wed, Jul 31, 2013 at 4:41 PM, Stefan Seefeld wrote: > The attached patch introduces a pthread wrapper library with initial > instrumentation for pthread_mutex_lock, pthread_mutex_trylock, and > pthread_mutex_unlock. > New tracepoints are introduced for each of those. For the lock function, > two distinct tracepoints are emitted: one before the lock is requested, > another after it has been acquired. > > -- > Stefan Seefeld > CodeSourcery / Mentor Graphics > http://www.mentor.com/embedded-software/ > > _______________________________________________ > lttng-dev mailing list > lttng-dev@lists.lttng.org > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > -- = J=E9r=E9mie Galarneau EfficiOS Inc. http://www.efficios.com