Re: [PATCH lttng-tools] Initialize ret to zero

From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
To: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>,
	Jeremie Galarneau <jgalar@efficios.com>
Subject: Re: [PATCH lttng-tools] Initialize ret to zero
Date: Wed, 2 May 2018 10:25:43 -0400	[thread overview]
Message-ID: <CA+jJMxuc1_JjE29Sw=iW9iGTs0EStLJwRktL_B_KP8SKBMR58g__36869.8943908841$1525271053$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20180430182735.12118-1-jonathan.rajotte-julien@efficios.com>

[-- Attachment #1.1: Type: text/plain, Size: 1247 bytes --]

Merged, thanks!

Jérémie

On 30 April 2018 at 14:27, Jonathan Rajotte <
jonathan.rajotte-julien@efficios.com> wrote:

> sample_channel_positions return garbage if cds_lfht_is_node_deleted(&
> stream->node.node)
> on first and "possibly" only iteration of the
> consumer_data.stream_per_chan_id_ht
> hash table.
>
> Found by scan-build
>
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
>  src/common/consumer/consumer-timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/common/consumer/consumer-timer.c b/src/common/consumer/
> consumer-timer.c
> index 721f146e..38b8b30d 100644
> --- a/src/common/consumer/consumer-timer.c
> +++ b/src/common/consumer/consumer-timer.c
> @@ -637,7 +637,7 @@ int sample_channel_positions(struct
> lttng_consumer_channel *channel,
>                 sample_positions_cb sample, get_consumed_cb get_consumed,
>                 get_produced_cb get_produced)
>  {
> -       int ret;
> +       int ret = 0;
>         struct lttng_ht_iter iter;
>         struct lttng_consumer_stream *stream;
>         bool empty_channel = true;
> --
> 2.17.0
>
>

-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

[-- Attachment #1.2: Type: text/html, Size: 1979 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev