Re: [PATCH lttng-tools 2/2] Fix: do not spawn sessiond on track/untrack commands

From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
To: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Cc: "lttng-dev@lists.lttng.org" <lttng-dev@lists.lttng.org>,
	Jeremie Galarneau <jgalar@efficios.com>
Subject: Re: [PATCH lttng-tools 2/2] Fix: do not spawn sessiond on track/untrack commands
Date: Mon, 27 Jul 2015 11:42:58 -0400	[thread overview]
Message-ID: <CA+jJMxueXdT_9MApXHvFwmOzQyw=xN=_kppoPu09+4tR4s_LOw__11177.8605067686$1438011844$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <1437774180-32746-2-git-send-email-jonathan.rajotte-julien@efficios.com>

[-- Attachment #1.1: Type: text/plain, Size: 1587 bytes --]

Hi Jonathan,

I have decided to apply a different fix which ensures that only the
"create" command actually spawns a session daemon.

https://github.com/lttng/lttng-tools/commit/92360082fd291a95695fb612d773ae1bb991c256

Thanks!
Jérémie

On Fri, Jul 24, 2015 at 5:43 PM, Jonathan Rajotte <
jonathan.rajotte-julien@efficios.com> wrote:

> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
>  src/bin/lttng/lttng.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
> index 13c7732..4cc320c 100644
> --- a/src/bin/lttng/lttng.c
> +++ b/src/bin/lttng/lttng.c
> @@ -432,7 +432,9 @@ static int check_args_no_sessiond(int argc, char
> **argv)
>                                 strncmp(argv[i], "--list-options",
> sizeof("--list-options")) == 0 ||
>                                 strncmp(argv[i], "--list-commands",
> sizeof("--list-commands")) == 0 ||
>                                 strncmp(argv[i], "version",
> sizeof("version")) == 0 ||
> -                               strncmp(argv[i], "view", sizeof("view"))
> == 0) {
> +                               strncmp(argv[i], "view", sizeof("view"))
> == 0 ||
> +                               strncmp(argv[i], "track", sizeof("track"))
> == 0 ||
> +                               strncmp(argv[i], "untrack",
> sizeof("untrack")) == 0) {
>                         return 1;
>                 }
>         }
> --
> 2.1.4
>
>

-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

[-- Attachment #1.2: Type: text/html, Size: 2621 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev