From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?J=C3=A9r=C3=A9mie_Galarneau?= Subject: Re: [RFC PATCH v2 02/13] Reorder pthread_join for easier ordering later on Date: Wed, 13 Dec 2017 20:54:33 -0500 Message-ID: References: <20170918225206.17725-1-jonathan.rajotte-julien@efficios.com> <20170918225206.17725-3-jonathan.rajotte-julien@efficios.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x242.google.com (mail-yb0-x242.google.com [IPv6:2607:f8b0:4002:c09::242]) by lists.lttng.org (Postfix) with ESMTPS id 3yxxTB2qmNzhbR for ; Thu, 14 Dec 2017 01:54:54 +0000 (UTC) Received: by mail-yb0-x242.google.com with SMTP id h28so2363790ybj.5 for ; Wed, 13 Dec 2017 17:54:54 -0800 (PST) In-Reply-To: <20170918225206.17725-3-jonathan.rajotte-julien@efficios.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" To: Jonathan Rajotte Cc: "lttng-dev@lists.lttng.org" , Jeremie Galarneau List-Id: lttng-dev@lists.lttng.org VGhpcyBwYXRjaCBjYWxscyBmb3IgYSBiZXR0ZXIgdGl0bGUgYW5kIGRlc2NyaXB0aW9uLiBJIHNl ZSB0aGF0IHlvdSBhcmUKc2h1ZmZsaW5nIHRoZSBvcmRlciBpbiB3aGljaCB0aGUgdGhyZWFkcyBh cmUgY3JlYXRlZCBhbmQgam9pbmVkLgoKSG93ZXZlciwgaXQgd291bGQgaGVscCB0byBjb250cmFz dCB0aGUgY3VycmVudCBhbmQgaW50ZW5kZWQgb3JkZXIgb2YKY3JlYXRpb24vam9pbiAoYW5kIHdo eSBpdCBpcyBkb25lKSBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgYW5kIGNvbW1lbnRzLgoKSsOpcsOp bWllCgpPbiAxOCBTZXB0ZW1iZXIgMjAxNyBhdCAxODo1MSwgSm9uYXRoYW4gUmFqb3R0ZQo8am9u YXRoYW4ucmFqb3R0ZS1qdWxpZW5AZWZmaWNpb3MuY29tPiB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5 OiBKb25hdGhhbiBSYWpvdHRlIDxqb25hdGhhbi5yYWpvdHRlLWp1bGllbkBlZmZpY2lvcy5jb20+ Cj4gLS0tCj4gIHNyYy9iaW4vbHR0bmctc2Vzc2lvbmQvbWFpbi5jIHwgOTYgKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDUgaW5z ZXJ0aW9ucygrKSwgNTEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9sdHRu Zy1zZXNzaW9uZC9tYWluLmMgYi9zcmMvYmluL2x0dG5nLXNlc3Npb25kL21haW4uYwo+IGluZGV4 IDVkN2RmNzQ0Li40NWMwMjcwZSAxMDA2NDQKPiAtLS0gYS9zcmMvYmluL2x0dG5nLXNlc3Npb25k L21haW4uYwo+ICsrKyBiL3NyYy9iaW4vbHR0bmctc2Vzc2lvbmQvbWFpbi5jCj4gQEAgLTYxNzAs MTUgKzYxNzAsMjYgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAgICAgICAg fQo+ICAgICAgICAgbm90aWZpY2F0aW9uX3RocmVhZF9ydW5uaW5nID0gdHJ1ZTsKPgo+IC0gICAg ICAgLyogQ3JlYXRlIHRocmVhZCB0byBtYW5hZ2UgdGhlIGNsaWVudCBzb2NrZXQgKi8KPiAtICAg ICAgIHJldCA9IHB0aHJlYWRfY3JlYXRlKCZjbGllbnRfdGhyZWFkLCBkZWZhdWx0X3B0aHJlYWRf YXR0cigpLAo+IC0gICAgICAgICAgICAgICAgICAgICAgIHRocmVhZF9tYW5hZ2VfY2xpZW50cywg KHZvaWQgKikgTlVMTCk7Cj4gKyAgICAgICAvKiBDcmVhdGUgdGhyZWFkIHRvIG1hbmFnZSBhcHBs aWNhdGlvbiBub3RpZnkgc29ja2V0ICovCj4gKyAgICAgICByZXQgPSBwdGhyZWFkX2NyZWF0ZSgm YXBwc19ub3RpZnlfdGhyZWFkLCBkZWZhdWx0X3B0aHJlYWRfYXR0cigpLAo+ICsgICAgICAgICAg ICAgICAgICAgICAgIHVzdF90aHJlYWRfbWFuYWdlX25vdGlmeSwgKHZvaWQgKikgTlVMTCk7Cj4g ICAgICAgICBpZiAocmV0KSB7Cj4gICAgICAgICAgICAgICAgIGVycm5vID0gcmV0Owo+IC0gICAg ICAgICAgICAgICBQRVJST1IoInB0aHJlYWRfY3JlYXRlIGNsaWVudHMiKTsKPiArICAgICAgICAg ICAgICAgUEVSUk9SKCJwdGhyZWFkX2NyZWF0ZSBub3RpZnkiKTsKPiAgICAgICAgICAgICAgICAg cmV0dmFsID0gLTE7Cj4gICAgICAgICAgICAgICAgIHN0b3BfdGhyZWFkcygpOwo+IC0gICAgICAg ICAgICAgICBnb3RvIGV4aXRfY2xpZW50Owo+ICsgICAgICAgICAgICAgICBnb3RvIGV4aXRfYXBw c19ub3RpZnk7Cj4gKyAgICAgICB9Cj4gKwo+ICsgICAgICAgLyogQ3JlYXRlIHRocmVhZCB0byBt YW5hZ2UgYXBwbGljYXRpb24gc29ja2V0ICovCj4gKyAgICAgICByZXQgPSBwdGhyZWFkX2NyZWF0 ZSgmYXBwc190aHJlYWQsIGRlZmF1bHRfcHRocmVhZF9hdHRyKCksCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgdGhyZWFkX21hbmFnZV9hcHBzLCAodm9pZCAqKSBOVUxMKTsKPiArICAgICAgIGlm IChyZXQpIHsKPiArICAgICAgICAgICAgICAgZXJybm8gPSByZXQ7Cj4gKyAgICAgICAgICAgICAg IFBFUlJPUigicHRocmVhZF9jcmVhdGUgYXBwcyIpOwo+ICsgICAgICAgICAgICAgICByZXR2YWwg PSAtMTsKPiArICAgICAgICAgICAgICAgc3RvcF90aHJlYWRzKCk7Cj4gKyAgICAgICAgICAgICAg IGdvdG8gZXhpdF9hcHBzOwo+ICAgICAgICAgfQo+Cj4gICAgICAgICAvKiBDcmVhdGUgdGhyZWFk IHRvIGRpc3BhdGNoIHJlZ2lzdHJhdGlvbiAqLwo+IEBAIC02MjAzLDI2ICs2MjE0LDE1IEBAIGlu dCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiAgICAgICAgICAgICAgICAgZ290byBleGl0 X3JlZ19hcHBzOwo+ICAgICAgICAgfQo+Cj4gLSAgICAgICAvKiBDcmVhdGUgdGhyZWFkIHRvIG1h bmFnZSBhcHBsaWNhdGlvbiBzb2NrZXQgKi8KPiAtICAgICAgIHJldCA9IHB0aHJlYWRfY3JlYXRl KCZhcHBzX3RocmVhZCwgZGVmYXVsdF9wdGhyZWFkX2F0dHIoKSwKPiAtICAgICAgICAgICAgICAg ICAgICAgICB0aHJlYWRfbWFuYWdlX2FwcHMsICh2b2lkICopIE5VTEwpOwo+ICsgICAgICAgLyog Q3JlYXRlIHRocmVhZCB0byBtYW5hZ2UgdGhlIGNsaWVudCBzb2NrZXQgKi8KPiArICAgICAgIHJl dCA9IHB0aHJlYWRfY3JlYXRlKCZjbGllbnRfdGhyZWFkLCBkZWZhdWx0X3B0aHJlYWRfYXR0cigp LAo+ICsgICAgICAgICAgICAgICAgICAgICAgIHRocmVhZF9tYW5hZ2VfY2xpZW50cywgKHZvaWQg KikgTlVMTCk7Cj4gICAgICAgICBpZiAocmV0KSB7Cj4gICAgICAgICAgICAgICAgIGVycm5vID0g cmV0Owo+IC0gICAgICAgICAgICAgICBQRVJST1IoInB0aHJlYWRfY3JlYXRlIGFwcHMiKTsKPiAr ICAgICAgICAgICAgICAgUEVSUk9SKCJwdGhyZWFkX2NyZWF0ZSBjbGllbnRzIik7Cj4gICAgICAg ICAgICAgICAgIHJldHZhbCA9IC0xOwo+ICAgICAgICAgICAgICAgICBzdG9wX3RocmVhZHMoKTsK PiAtICAgICAgICAgICAgICAgZ290byBleGl0X2FwcHM7Cj4gLSAgICAgICB9Cj4gLQo+IC0gICAg ICAgLyogQ3JlYXRlIHRocmVhZCB0byBtYW5hZ2UgYXBwbGljYXRpb24gbm90aWZ5IHNvY2tldCAq Lwo+IC0gICAgICAgcmV0ID0gcHRocmVhZF9jcmVhdGUoJmFwcHNfbm90aWZ5X3RocmVhZCwgZGVm YXVsdF9wdGhyZWFkX2F0dHIoKSwKPiAtICAgICAgICAgICAgICAgICAgICAgICB1c3RfdGhyZWFk X21hbmFnZV9ub3RpZnksICh2b2lkICopIE5VTEwpOwo+IC0gICAgICAgaWYgKHJldCkgewo+IC0g ICAgICAgICAgICAgICBlcnJubyA9IHJldDsKPiAtICAgICAgICAgICAgICAgUEVSUk9SKCJwdGhy ZWFkX2NyZWF0ZSBub3RpZnkiKTsKPiAtICAgICAgICAgICAgICAgcmV0dmFsID0gLTE7Cj4gLSAg ICAgICAgICAgICAgIHN0b3BfdGhyZWFkcygpOwo+IC0gICAgICAgICAgICAgICBnb3RvIGV4aXRf YXBwc19ub3RpZnk7Cj4gKyAgICAgICAgICAgICAgIGdvdG8gZXhpdF9jbGllbnQ7Cj4gICAgICAg ICB9Cj4KPiAgICAgICAgIC8qIENyZWF0ZSBhZ2VudCByZWdpc3RyYXRpb24gdGhyZWFkLiAqLwo+ IEBAIC02Mjc4LDEyICs2Mjc4LDEyIEBAIGV4aXRfbG9hZF9zZXNzaW9uOgo+ICAgICAgICAgICAg ICAgICByZXQgPSBwdGhyZWFkX2pvaW4oa2VybmVsX3RocmVhZCwgJnN0YXR1cyk7Cj4gICAgICAg ICAgICAgICAgIGlmIChyZXQpIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICBlcnJubyA9IHJl dDsKPiAtICAgICAgICAgICAgICAgICAgICAgICBQRVJST1IoInB0aHJlYWRfam9pbiIpOwo+ICsg ICAgICAgICAgICAgICAgICAgICAgIFBFUlJPUigicHRocmVhZF9qb2luIGtlcm5lbCIpOwo+ICAg ICAgICAgICAgICAgICAgICAgICAgIHJldHZhbCA9IC0xOwo+ICAgICAgICAgICAgICAgICB9Cj4g ICAgICAgICB9Cj4gLWV4aXRfa2VybmVsOgo+Cj4gK2V4aXRfa2VybmVsOgo+ICAgICAgICAgcmV0 ID0gcHRocmVhZF9qb2luKGFnZW50X3JlZ190aHJlYWQsICZzdGF0dXMpOwo+ICAgICAgICAgaWYg KHJldCkgewo+ICAgICAgICAgICAgICAgICBlcnJubyA9IHJldDsKPiBAQCAtNjI5MSw1MSArNjI5 MSw0NSBAQCBleGl0X2tlcm5lbDoKPiAgICAgICAgICAgICAgICAgcmV0dmFsID0gLTE7Cj4gICAg ICAgICB9Cj4gIGV4aXRfYWdlbnRfcmVnOgo+IC0KPiAtICAgICAgIHJldCA9IHB0aHJlYWRfam9p bihhcHBzX25vdGlmeV90aHJlYWQsICZzdGF0dXMpOwo+ICsgICAgICAgcmV0ID0gcHRocmVhZF9q b2luKGNsaWVudF90aHJlYWQsICZzdGF0dXMpOwo+ICAgICAgICAgaWYgKHJldCkgewo+ICAgICAg ICAgICAgICAgICBlcnJubyA9IHJldDsKPiAtICAgICAgICAgICAgICAgUEVSUk9SKCJwdGhyZWFk X2pvaW4gYXBwcyBub3RpZnkiKTsKPiArICAgICAgICAgICAgICAgUEVSUk9SKCJwdGhyZWFkX2pv aW4gY2xpZW50Iik7Cj4gICAgICAgICAgICAgICAgIHJldHZhbCA9IC0xOwo+ICAgICAgICAgfQo+ IC1leGl0X2FwcHNfbm90aWZ5Ogo+Cj4gK2V4aXRfY2xpZW50Ogo+ICsgICAgICAgcmV0ID0gcHRo cmVhZF9qb2luKHJlZ19hcHBzX3RocmVhZCwgJnN0YXR1cyk7Cj4gKyAgICAgICBpZiAocmV0KSB7 Cj4gKyAgICAgICAgICAgICAgIGVycm5vID0gcmV0Owo+ICsgICAgICAgICAgICAgICBQRVJST1Io InB0aHJlYWRfam9pbiByZWdpc3RyYXRpb24gYXBwIiApOwo+ICsgICAgICAgICAgICAgICByZXR2 YWwgPSAtMTsKPiArICAgICAgIH0KPiArZXhpdF9yZWdfYXBwczoKPiArICAgICAgIHJldCA9IHB0 aHJlYWRfam9pbihkaXNwYXRjaF90aHJlYWQsICZzdGF0dXMpOwo+ICsgICAgICAgaWYgKHJldCkg ewo+ICsgICAgICAgICAgICAgICBlcnJubyA9IHJldDsKPiArICAgICAgICAgICAgICAgUEVSUk9S KCJwdGhyZWFkX2pvaW4gZGlzcGF0Y2giKTsKPiArICAgICAgICAgICAgICAgcmV0dmFsID0gLTE7 Cj4gKyAgICAgICB9Cj4gKwo+ICtleGl0X2Rpc3BhdGNoOgo+ICAgICAgICAgcmV0ID0gcHRocmVh ZF9qb2luKGFwcHNfdGhyZWFkLCAmc3RhdHVzKTsKPiAgICAgICAgIGlmIChyZXQpIHsKPiAgICAg ICAgICAgICAgICAgZXJybm8gPSByZXQ7Cj4gICAgICAgICAgICAgICAgIFBFUlJPUigicHRocmVh ZF9qb2luIGFwcHMiKTsKPiAgICAgICAgICAgICAgICAgcmV0dmFsID0gLTE7Cj4gICAgICAgICB9 Cj4gKwo+ICBleGl0X2FwcHM6Cj4gLQo+IC0gICAgICAgcmV0ID0gcHRocmVhZF9qb2luKHJlZ19h cHBzX3RocmVhZCwgJnN0YXR1cyk7Cj4gKyAgICAgICByZXQgPSBwdGhyZWFkX2pvaW4oYXBwc19u b3RpZnlfdGhyZWFkLCAmc3RhdHVzKTsKPiAgICAgICAgIGlmIChyZXQpIHsKPiAgICAgICAgICAg ICAgICAgZXJybm8gPSByZXQ7Cj4gLSAgICAgICAgICAgICAgIFBFUlJPUigicHRocmVhZF9qb2lu Iik7Cj4gLSAgICAgICAgICAgICAgIHJldHZhbCA9IC0xOwo+IC0gICAgICAgfQo+IC1leGl0X3Jl Z19hcHBzOgo+IC0KPiAtICAgICAgIC8qCj4gLSAgICAgICAgKiBKb2luIGRpc3BhdGNoIHRocmVh ZCBhZnRlciBqb2luaW5nIHJlZ19hcHBzX3RocmVhZCB0byBlbnN1cmUKPiAtICAgICAgICAqIHdl IGRvbid0IGxlYWsgYXBwbGljYXRpb25zIGluIHRoZSBxdWV1ZS4KPiAtICAgICAgICAqLwo+IC0g ICAgICAgcmV0ID0gcHRocmVhZF9qb2luKGRpc3BhdGNoX3RocmVhZCwgJnN0YXR1cyk7Cj4gLSAg ICAgICBpZiAocmV0KSB7Cj4gLSAgICAgICAgICAgICAgIGVycm5vID0gcmV0Owo+IC0gICAgICAg ICAgICAgICBQRVJST1IoInB0aHJlYWRfam9pbiIpOwo+IC0gICAgICAgICAgICAgICByZXR2YWwg PSAtMTsKPiAtICAgICAgIH0KPiAtZXhpdF9kaXNwYXRjaDoKPiAtCj4gLSAgICAgICByZXQgPSBw dGhyZWFkX2pvaW4oY2xpZW50X3RocmVhZCwgJnN0YXR1cyk7Cj4gLSAgICAgICBpZiAocmV0KSB7 Cj4gLSAgICAgICAgICAgICAgIGVycm5vID0gcmV0Owo+IC0gICAgICAgICAgICAgICBQRVJST1Io InB0aHJlYWRfam9pbiIpOwo+ICsgICAgICAgICAgICAgICBQRVJST1IoInB0aHJlYWRfam9pbiBh cHBzIG5vdGlmeSIpOwo+ICAgICAgICAgICAgICAgICByZXR2YWwgPSAtMTsKPiAgICAgICAgIH0K Pgo+IC1leGl0X2NsaWVudDoKPiArZXhpdF9hcHBzX25vdGlmeToKPiAgZXhpdF9ub3RpZmljYXRp b246Cj4gIGV4aXRfaGVhbHRoOgo+ICBleGl0X2luaXRfZGF0YToKPiAtLQo+IDIuMTEuMAo+CgoK Ci0tIApKw6lyw6ltaWUgR2FsYXJuZWF1CkVmZmljaU9TIEluYy4KaHR0cDovL3d3dy5lZmZpY2lv cy5jb20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbHR0 bmctZGV2IG1haWxpbmcgbGlzdApsdHRuZy1kZXZAbGlzdHMubHR0bmcub3JnCmh0dHBzOi8vbGlz dHMubHR0bmcub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9sdHRuZy1kZXYK