Re: [PATCH 3/3] cm-fx6:machine: add cm-x6 machine configuration

From: Daiane Angolini <daiane.list@gmail.com>
To: Valentin Raevsky <valentin@compulab.co.il>
Cc: "meta-freescale@yoctoproject.org"
	<meta-freescale@yoctoproject.org>,
	Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: [PATCH 3/3] cm-fx6:machine: add cm-x6 machine configuration
Date: Thu, 9 Apr 2015 08:45:08 -0300	[thread overview]
Message-ID: <CA+jg_OXgELd==7OwOwvzbn+FWQ4XSe0Z3rbkXYb5P-LvnHd=NA@mail.gmail.com> (raw)
In-Reply-To: <1428563107-28112-3-git-send-email-valentin@compulab.co.il>

On Thu, Apr 9, 2015 at 4:05 AM, Valentin Raevsky
<valentin@compulab.co.il> wrote:
> Add cm-fx6 machine configuration: u-boot and kernel.

Please, add more information on the machine description, maybe a URL
pointing to some place where I could see a board picture, and hardware
description.

I prefer if you could change the commit subject and use something like:

"cm-fx6: Add cm-x6 machine configuration"

You can use as an example this commit:
https://github.com/Freescale/meta-fsl-arm-extra/commit/5fadb641dffe91ec9dedafcb1e27add3e45255dc

>
> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
> ---
>  conf/machine/cm-fx6.conf |   26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 conf/machine/cm-fx6.conf
>
> diff --git a/conf/machine/cm-fx6.conf b/conf/machine/cm-fx6.conf
> new file mode 100644
> index 0000000..2e0afdf
> --- /dev/null
> +++ b/conf/machine/cm-fx6.conf
> @@ -0,0 +1,26 @@
> +#@TYPE: Machine
> +#@NAME: CompuLab CM-FX6
> +#@SOC: i.MX6 Q/DL
> +#@DESCRIPTION: Machine configuration for CompuLab CM-FX6 machines
> +#@MAINTAINER: Valentin Raevsky <valentin@compulab.co.il>
> +
> +# require conf/machine/include/imx-base.inc

Can you, please double check this line?

I would follow the BSP layer standard, however I would accept not
using imx-base.inc with a good argument.

If you really don't like to include imx-base.inc, please remove the
commented line.

> +require conf/machine/include/tune-cortexa9.inc
> +
> +SOC_FAMILY = "mx6:mx6dl:mx6q"
> +
> +PREFERRED_PROVIDER_u-boot = "u-boot-cm-fx6"
> +PREFERRED_PROVIDER_virtual/kernel = "linux-cm-fx6"
> +
> +# Use SPI NOR U-Boot by default
> +# IMAGE_BOOTLOADER ?= ""

Please, clean up the commented source code.

> +
> +UBOOT_MACHINE ?= "cm_fx6_defconfig"
> +
> +KERNEL_IMAGETYPE = "zImage"
> +KERNEL_DEVICETREE = "imx6dl-cm-fx6.dtb  imx6dl-sbc-fx6.dtb  imx6dl-sbc-fx6m.dtb  imx6q-cm-fx6.dtb  imx6q-sbc-fx6.dtb  imx6q-sbc-fx6m.dtb"
> +
> +MACHINE_FEATURES += "pci wifi bluetooth alsa bluetooth serial usbhost wifi"
> +# MACHINE_FIRMWARE_append_mx6 = " linux-firmware-mrvl"

Please, clean up the commented source code.

Daiane

> +
> +SERIAL_CONSOLE = "115200 ttymxc3"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale