All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Johnson <teknotus@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Aviv Greenberg <avivgr@gmail.com>,
	Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] V4L: add Y12I, Y8I and Z16 pixel format documentation
Date: Mon, 11 Jan 2016 12:22:33 -0800	[thread overview]
Message-ID: <CA+nDE0hdhrFfeVU_OsO847ehMdLtj7bjbC6E4an0s963jjXKTg@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1601091126170.15612@axis700.grange>

On Sat, Jan 9, 2016 at 2:27 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> Hi Mauro,
>
> Ping - what about this patch? If there are no comments - would you like me
> to push it via my tree?

In testing the V4L2_PIX_FMT_Z16 ('Z16 ') format documentation seems to
be incomplete.

uvc_xu_control_query unit=2 selector=4 seems to be a z scale factor.
Changing the value of that control greatly changes the value of
pixels. Millimeters seems to be correct for the default value of that
control. This control is on the /dev node for the infrared camera
rather than the node using the Z16 depth format.

The one thing that every depth camera I've ever used has in common is
factory calibration. Translating pixel values to Z is only 1/3 of what
is needed to translate a depth image into a point cloud. The
calibration is needed to translate X and Y pixel indexes into
positions in 3d space. Documentation on fetching, and parsing the
factory calibration would make the camera much more usable.

Documentation on the 21 UVC controls would be helpful, but less
critical than the calibration data.

  reply	other threads:[~2016-01-11 20:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 16:46 [PATCH] V4L: add Y12I, Y8I and Z16 pixel format documentation Guennadi Liakhovetski
2016-01-09 10:27 ` Guennadi Liakhovetski
2016-01-11 20:22   ` Daniel Johnson [this message]
2016-01-12 16:12     ` Guennadi Liakhovetski
2016-01-13 10:24 ` Sakari Ailus
2016-01-14 11:12   ` Guennadi Liakhovetski
2016-01-14 11:29     ` Sakari Ailus
2016-01-18 11:55       ` Guennadi Liakhovetski
2016-01-18 12:21         ` Sakari Ailus
2016-01-18 12:36           ` Guennadi Liakhovetski
2016-01-18 14:37             ` Sakari Ailus
2016-01-18 12:14   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+nDE0hdhrFfeVU_OsO847ehMdLtj7bjbC6E4an0s963jjXKTg@mail.gmail.com \
    --to=teknotus@gmail.com \
    --cc=avivgr@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.