From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: Re: [PATCH 10/28] libxl: only free cpupoolinfo if necessary in libxl_list_cpupool Date: Wed, 18 Sep 2013 20:58:24 +1200 Message-ID: References: <1379475484-25993-1-git-send-email-mattjd@gmail.com> <1379475484-25993-11-git-send-email-mattjd@gmail.com> <1379491616.18543.46.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379491616.18543.46.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Juergen Gross , Stefano Stabellini , Ian Jackson , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Sep 18, 2013 at 8:06 PM, Dario Faggioli wrote: > I'm less confident about libxl_cpupoolinfo_list_* than about topology > and numa info handling via libxl, but I suspect this is something > similar to what I just said in my reply to 12/28 ("libxl: only free > cputopology if it was allocated in libxl__get_numa_candidate"). > > That is to say, this does not look necessary to me, as > libxl_cpupoolinfo_list_free() seems to cope well with a non-allocated > prt, and making it like this deviates from the usual libxl exit > pattern/error handling style. > > Thoughts? I think you're right, again ;) Please ignore this patch, too. - Matthew