All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brandon Casey <drafnel@gmail.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Junio C Hamano <gitster@pobox.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"Tom G. Christensen" <tgc@statsbiblioteket.dk>
Subject: Re: [PATCH 1/2] git-send-email.perl: support no- prefix with older GetOptions
Date: Sun, 15 Feb 2015 17:35:20 -0800	[thread overview]
Message-ID: <CA+sFfMcpGfF+KaPk-jOPaueHS01rZ5fZws8Czavf6b0cUWxrbw@mail.gmail.com> (raw)
In-Reply-To: <031750B1-259D-4F19-8484-98A7A1266248@gmail.com>

On Sun, Feb 15, 2015 at 1:51 AM, Kyle J. McKay <mackyle@gmail.com> wrote:
> On Feb 14, 2015, at 22:32, Brandon Casey wrote:
>
>> On Fri, Feb 13, 2015 at 12:19 PM, Junio C Hamano <gitster@pobox.com>
>> wrote:
>>>
>>> From: "Kyle J. McKay" <mackyle@gmail.com>
>>>
>>> Only Perl version 5.8.0 or later is required, but that comes with
>>> an older Getopt::Long (2.32) that does not support the 'no-'
>>> prefix.  Support for that was added in Getopt::Long version 2.33.
>>>
>>> Since the help only mentions the 'no-' prefix and not the 'no'
>>> prefix, add explicit support for the 'no-' prefix when running
>>> with older GetOptions versions.
>>
>>
>> ultra-ultra-nit: s/when running/for when running/
>
>
> So it would say "add explicit support for the 'no-'prefix for when running
> with"...  That doesn't make sense to me.
>
>> The current wording
>> makes it sound like the explicit support is only enabled when running
>> with older GetOpt versions.
>
>
> How about this instead:
>
> Since the help only mentions the 'no-' prefix and not the 'no'
> prefix, add explicit support for the 'no-' prefix to support
> older GetOptions versions.

Works for me.

-Brandon

  parent reply	other threads:[~2015-02-16  1:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 23:35 [ANNOUNCE] Git v2.3.0-rc2 Junio C Hamano
2015-01-29 12:58 ` Broken makefile check for curl version on el4 [Re: [ANNOUNCE] Git v2.3.0-rc2] Tom G. Christensen
2015-01-30  9:52   ` [PATCH] Makefile: Handle broken curl version number in version check Tom G. Christensen
2015-01-30 14:50     ` Andreas Schwab
2015-01-30 15:34       ` Tom G. Christensen
2015-01-30 15:41       ` Kyle J. McKay
2015-01-30 22:09     ` Junio C Hamano
2015-01-29 13:11 ` All gnupg tests broken on el4 [Re: [ANNOUNCE] Git v2.3.0-rc2] Tom G. Christensen
2015-01-29 15:43   ` Jeff King
2015-01-29 15:51     ` Jeff King
2015-01-29 17:34     ` Tom G. Christensen
2015-01-29 18:48       ` Junio C Hamano
2015-01-29 13:30 ` Testsuite regression with perl 5.8.0 " Tom G. Christensen
2015-01-29 15:52   ` Jeff King
2015-01-30  9:53     ` Tom G. Christensen
2015-01-30  6:24   ` [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-' Tom G. Christensen
2015-01-30 23:05     ` brian m. carlson
2015-01-31  2:40       ` Kyle J. McKay
2015-02-02  1:33         ` Junio C Hamano
2015-02-02 16:11           ` Kyle J. McKay
2015-02-02 20:12             ` Junio C Hamano
2015-02-12 23:12         ` Junio C Hamano
2015-02-13 20:19           ` [PATCH 0/2] Getopt::Long workaround in send-email Junio C Hamano
2015-02-13 20:19             ` [PATCH 1/2] git-send-email.perl: support no- prefix with older GetOptions Junio C Hamano
2015-02-15  6:32               ` Brandon Casey
     [not found]                 ` <031750B1-259D-4F19-8484-98A7A1266248@gmail.com>
2015-02-16  1:35                   ` Brandon Casey [this message]
2015-02-13 20:19             ` [PATCH 2/2] SQUASH??? t9001: turn --no$option workarounds to --no-$option Junio C Hamano
2015-02-13 20:30             ` [PATCH 0/2] Getopt::Long workaround in send-email Kyle J. McKay
2015-02-13 22:21             ` brian m. carlson
2015-02-15  6:13             ` Brandon Casey
2015-02-16  9:58             ` Tom G. Christensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+sFfMcpGfF+KaPk-jOPaueHS01rZ5fZws8Czavf6b0cUWxrbw@mail.gmail.com \
    --to=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mackyle@gmail.com \
    --cc=mst@redhat.com \
    --cc=tgc@statsbiblioteket.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.