From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbaI3JLj (ORCPT ); Tue, 30 Sep 2014 05:11:39 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:56240 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbaI3JLh (ORCPT ); Tue, 30 Sep 2014 05:11:37 -0400 MIME-Version: 1.0 In-Reply-To: References: <1411573068-12952-1-git-send-email-rric@kernel.org> <1411573068-12952-4-git-send-email-rric@kernel.org> <3082935.e3X4GsVUDn@wuerfel> Date: Tue, 30 Sep 2014 14:41:35 +0530 Message-ID: Subject: Re: [PATCH 3/6] pci, thunder: Add PCIe host controller devicetree bindings From: Sunil Kovvuri To: Rob Herring Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Robert Richter , Bjorn Helgaas , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Liviu Dudau , "linux-kernel@vger.kernel.org" , Robert Richter , Sunil Goutham Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for pointing correction ROB. Will fix it. On Fri, Sep 26, 2014 at 11:56 PM, Rob Herring wrote: > On Wed, Sep 24, 2014 at 11:06 AM, Arnd Bergmann wrote: >> On Wednesday 24 September 2014 17:37:45 Robert Richter wrote: >>> >>> + pcie0@0x8480,00000000 { >> >> The name should be pci, not pci0. > > And the address should be "@848000000000". There was some confusion > about when the comma should be used and it is only if you have things > like PCI bus, device, function for the addressing. > > >> >>> + compatible = "cavium,thunder-pcie"; > > A bit too generic as many of the Cavium bindings have been. > > Rob > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sunil Kovvuri Subject: Re: [PATCH 3/6] pci, thunder: Add PCIe host controller devicetree bindings Date: Tue, 30 Sep 2014 14:41:35 +0530 Message-ID: References: <1411573068-12952-1-git-send-email-rric@kernel.org> <1411573068-12952-4-git-send-email-rric@kernel.org> <3082935.e3X4GsVUDn@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Rob Herring Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Robert Richter , Bjorn Helgaas , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Liviu Dudau , "linux-kernel@vger.kernel.org" , Robert Richter , Sunil Goutham List-Id: devicetree@vger.kernel.org Thanks for pointing correction ROB. Will fix it. On Fri, Sep 26, 2014 at 11:56 PM, Rob Herring wrote: > On Wed, Sep 24, 2014 at 11:06 AM, Arnd Bergmann wrote: >> On Wednesday 24 September 2014 17:37:45 Robert Richter wrote: >>> >>> + pcie0@0x8480,00000000 { >> >> The name should be pci, not pci0. > > And the address should be "@848000000000". There was some confusion > about when the comma should be used and it is only if you have things > like PCI bus, device, function for the addressing. > > >> >>> + compatible = "cavium,thunder-pcie"; > > A bit too generic as many of the Cavium bindings have been. > > Rob > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sunil.kovvuri@gmail.com (Sunil Kovvuri) Date: Tue, 30 Sep 2014 14:41:35 +0530 Subject: [PATCH 3/6] pci, thunder: Add PCIe host controller devicetree bindings In-Reply-To: References: <1411573068-12952-1-git-send-email-rric@kernel.org> <1411573068-12952-4-git-send-email-rric@kernel.org> <3082935.e3X4GsVUDn@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thanks for pointing correction ROB. Will fix it. On Fri, Sep 26, 2014 at 11:56 PM, Rob Herring wrote: > On Wed, Sep 24, 2014 at 11:06 AM, Arnd Bergmann wrote: >> On Wednesday 24 September 2014 17:37:45 Robert Richter wrote: >>> >>> + pcie0 at 0x8480,00000000 { >> >> The name should be pci, not pci0. > > And the address should be "@848000000000". There was some confusion > about when the comma should be used and it is only if you have things > like PCI bus, device, function for the addressing. > > >> >>> + compatible = "cavium,thunder-pcie"; > > A bit too generic as many of the Cavium bindings have been. > > Rob > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html