From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <521CE10A.9060505@compro.net> References: <1377136122-13338-1-git-send-email-lidza.louina@gmail.com> <1377136122-13338-8-git-send-email-lidza.louina@gmail.com> <20130823202349.GW22811@mwanda> <521CE10A.9060505@compro.net> Date: Tue, 27 Aug 2013 13:50:35 -0400 Message-ID: Subject: Re: [PATCH 08/12] staging: dgap: tty.c: fixes ioctl param list From: Lidza Louina Content-Type: text/plain; charset=ISO-8859-1 List-ID: To: Mark Hounschell Cc: Dan Carpenter , "driverdev-devel@linuxdriverproject.org" , Greg KH On Tue, Aug 27, 2013 at 1:25 PM, Mark Hounschell wrote: > On 08/27/2013 01:20 PM, Lidza Louina wrote: >> >> On Fri, Aug 23, 2013 at 4:23 PM, Dan Carpenter >> wrote: >>> >>> On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote: >>>> >>>> -static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file, >>>> unsigned int cmd, >>>> +static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd, >>>> unsigned long arg) >>> >>> >>> Btw, now that this file compiles I see it in my static checker runs. >>> >>> dgap_tty_ioctl() takes a lock but always returns before unlocking. >>> >>>> { >>>> struct board_t *bd; >>>> @@ -3423,41 +3423,6 @@ static int dgap_tty_ioctl(struct tty_struct *tty, >>>> struct file *file, unsigned in >>>> >>>> return(-ENOIOCTLCMD); >>> >>> >>> In other words, these return statements should be breaks so we hit >>> the call to: >>> >>> DGNC_UNLOCK(ch->ch_lock, lock_flags); >> >> >> Hmm, I looked thru the code a few times, and it seems like >> it unlocks before every return. Can you paste an example >> where it does this? >> > > FYI, there is no DGNC_UNLOCK in the dgap driver? Maybe he was looking at the > dgnc while commenting on the dgap??? Just a guess. > > Mark Ah, ok, I don't see anything unusual in that file either. I'll wait to see what he was talking about.