[PATCH] staging: dgnc: tty.c: fixes pointer syntax

[PATCH] staging: dgnc: tty.c: fixes pointer syntax

[Lidza Louina]

This patch fixes the error: "foo* bar" should be "foo *bar".

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
---
 drivers/staging/dgnc/dgnc_tty.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 5938c4a..da035a5 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -114,9 +114,9 @@ static int dgnc_block_til_ready(struct tty_struct *tty, struct file *file, struc
 static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd, unsigned long arg);
 static int dgnc_tty_digigeta(struct tty_struct *tty, struct digi_t __user *retinfo);
 static int dgnc_tty_digiseta(struct tty_struct *tty, struct digi_t __user *new_info);
-static int dgnc_tty_write_room(struct tty_struct* tty);
+static int dgnc_tty_write_room(struct tty_struct *tty);
 static int dgnc_tty_put_char(struct tty_struct *tty, unsigned char c);
-static int dgnc_tty_chars_in_buffer(struct tty_struct* tty);
+static int dgnc_tty_chars_in_buffer(struct tty_struct *tty);
 static void dgnc_tty_start(struct tty_struct *tty);
 static void dgnc_tty_stop(struct tty_struct *tty);
 static void dgnc_tty_throttle(struct tty_struct *tty);
-- 
1.8.1.2

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgnc: tty.c: fixes pointer syntax

[Dan Carpenter]

On Wed, Aug 21, 2013 at 01:27:15PM -0400, Lidza Louina wrote:
> This patch fixes the error: "foo* bar" should be "foo *bar".
> 

I have a nit pick about this changelog.  It's not something to
resend over, of course, but for future patches.  The word "fix"
should only be used for bugfixes.  The word "clean up" is the
opposite and should not be used for changes which affect how the
code works.

It's pretty much kernel standard to separate fixes and cleanups as
two different things.
https://www.google.com/search?q=fix+clean+ups+linux+kernel

A "syntax error" means something that breaks the compile.  So I was
expecting a fix for the compile.  A better subject would be:
"[PATCH] staging: dgnc: tty.c: clean up pointer white space"

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgnc: tty.c: fixes pointer syntax

[Lidza Louina]

On Fri, Aug 23, 2013 at 4:40 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Aug 21, 2013 at 01:27:15PM -0400, Lidza Louina wrote:
>> This patch fixes the error: "foo* bar" should be "foo *bar".
>>
>
> I have a nit pick about this changelog.  It's not something to
> resend over, of course, but for future patches.  The word "fix"
> should only be used for bugfixes.  The word "clean up" is the
> opposite and should not be used for changes which affect how the
> code works.

Ahh, ok. I see, that makes sense.

> It's pretty much kernel standard to separate fixes and cleanups as
> two different things.
> https://www.google.com/search?q=fix+clean+ups+linux+kernel
>
> A "syntax error" means something that breaks the compile.  So I was
> expecting a fix for the compile.  A better subject would be:
> "[PATCH] staging: dgnc: tty.c: clean up pointer white space"

Okay, I'll change my language when sending more patches that
clean up code. Thanks for the tip. =]