* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
[not found] <cki.3F4F097E3B.299V5OKJ7M@redhat.com>
@ 2021-06-21 19:20 ` Veronika Kabatova
2021-06-21 20:57 ` Veronika Kabatova
0 siblings, 1 reply; 13+ messages in thread
From: Veronika Kabatova @ 2021-06-21 19:20 UTC (permalink / raw)
To: CKI Project; +Cc: linux-block, axboe
On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>
>
> Hello,
>
> We ran automated tests on a recent commit from this kernel tree:
>
> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>
> The results of these automated tests are provided below.
>
> Overall result: FAILED (see details below)
> Merge: OK
> Compile: FAILED
>
Hi,
the failure is introduced between this commit and d142f908ebab64955eb48e.
Currently seeing if I can bisect it closer but maybe someone already has an
idea what went wrong.
Veronika
> All kernel binaries, config files, and logs are available for download here:
>
> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
>
> We attempted to compile the kernel for multiple architectures, but the compile
> failed on one or more architectures:
>
> aarch64: FAILED (see build-aarch64.log.xz attachment)
> ppc64le: FAILED (see build-ppc64le.log.xz attachment)
> s390x: FAILED (see build-s390x.log.xz attachment)
> x86_64: FAILED (see build-x86_64.log.xz attachment)
>
> We hope that these logs can help you find the problem quickly. For the full
> detail on our testing procedures, please scroll to the bottom of this message.
>
> Please reply to this email if you have any questions about the tests that we
> ran or if you have any suggestions on how to make future tests more effective.
>
> ,-. ,-.
> ( C ) ( K ) Continuous
> `-',-.`-' Kernel
> ( I ) Integration
> `-'
> ______________________________________________________________________________
>
> Compile testing
> ---------------
>
> We compiled the kernel for 4 architectures:
>
> aarch64:
> make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
>
> ppc64le:
> make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
>
> s390x:
> make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
>
> x86_64:
> make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 19:20 ` ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3) Veronika Kabatova
@ 2021-06-21 20:57 ` Veronika Kabatova
2021-06-21 21:00 ` Jens Axboe
0 siblings, 1 reply; 13+ messages in thread
From: Veronika Kabatova @ 2021-06-21 20:57 UTC (permalink / raw)
To: CKI Project; +Cc: linux-block, axboe
On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>
> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
> >
> >
> > Hello,
> >
> > We ran automated tests on a recent commit from this kernel tree:
> >
> > Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> > Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
> >
> > The results of these automated tests are provided below.
> >
> > Overall result: FAILED (see details below)
> > Merge: OK
> > Compile: FAILED
> >
>
> Hi,
>
> the failure is introduced between this commit and d142f908ebab64955eb48e.
> Currently seeing if I can bisect it closer but maybe someone already has an
> idea what went wrong.
>
First commit failing the compilation is 7a2b0ef2a3b83733d7.
Veronika
> Veronika
>
> > All kernel binaries, config files, and logs are available for download here:
> >
> > https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
> >
> > We attempted to compile the kernel for multiple architectures, but the compile
> > failed on one or more architectures:
> >
> > aarch64: FAILED (see build-aarch64.log.xz attachment)
> > ppc64le: FAILED (see build-ppc64le.log.xz attachment)
> > s390x: FAILED (see build-s390x.log.xz attachment)
> > x86_64: FAILED (see build-x86_64.log.xz attachment)
> >
> > We hope that these logs can help you find the problem quickly. For the full
> > detail on our testing procedures, please scroll to the bottom of this message.
> >
> > Please reply to this email if you have any questions about the tests that we
> > ran or if you have any suggestions on how to make future tests more effective.
> >
> > ,-. ,-.
> > ( C ) ( K ) Continuous
> > `-',-.`-' Kernel
> > ( I ) Integration
> > `-'
> > ______________________________________________________________________________
> >
> > Compile testing
> > ---------------
> >
> > We compiled the kernel for 4 architectures:
> >
> > aarch64:
> > make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
> >
> > ppc64le:
> > make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
> >
> > s390x:
> > make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
> >
> > x86_64:
> > make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg
> >
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 20:57 ` Veronika Kabatova
@ 2021-06-21 21:00 ` Jens Axboe
2021-06-21 21:07 ` Veronika Kabatova
2021-06-21 21:10 ` Keith Busch
0 siblings, 2 replies; 13+ messages in thread
From: Jens Axboe @ 2021-06-21 21:00 UTC (permalink / raw)
To: Veronika Kabatova, CKI Project; +Cc: linux-block, Matthew Wilcox
On 6/21/21 2:57 PM, Veronika Kabatova wrote:
> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>
>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>
>>>
>>> Hello,
>>>
>>> We ran automated tests on a recent commit from this kernel tree:
>>>
>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>
>>> The results of these automated tests are provided below.
>>>
>>> Overall result: FAILED (see details below)
>>> Merge: OK
>>> Compile: FAILED
>>>
>>
>> Hi,
>>
>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>> Currently seeing if I can bisect it closer but maybe someone already has an
>> idea what went wrong.
>>
>
> First commit failing the compilation is 7a2b0ef2a3b83733d7.
Where's the log? Adding Willy...
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 21:00 ` Jens Axboe
@ 2021-06-21 21:07 ` Veronika Kabatova
2021-06-21 21:58 ` Matthew Wilcox
2021-06-21 21:10 ` Keith Busch
1 sibling, 1 reply; 13+ messages in thread
From: Veronika Kabatova @ 2021-06-21 21:07 UTC (permalink / raw)
To: Jens Axboe; +Cc: CKI Project, linux-block, Matthew Wilcox
On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
> > On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
> >>
> >> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
> >>>
> >>>
> >>> Hello,
> >>>
> >>> We ran automated tests on a recent commit from this kernel tree:
> >>>
> >>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> >>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
> >>>
> >>> The results of these automated tests are provided below.
> >>>
> >>> Overall result: FAILED (see details below)
> >>> Merge: OK
> >>> Compile: FAILED
> >>>
> >>
> >> Hi,
> >>
> >> the failure is introduced between this commit and d142f908ebab64955eb48e.
> >> Currently seeing if I can bisect it closer but maybe someone already has an
> >> idea what went wrong.
> >>
> >
> > First commit failing the compilation is 7a2b0ef2a3b83733d7.
>
> Where's the log? Adding Willy...
>
Logs and kernel configs for each arch are linked in the original email at
https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
Veronika
> --
> Jens Axboe
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 21:00 ` Jens Axboe
2021-06-21 21:07 ` Veronika Kabatova
@ 2021-06-21 21:10 ` Keith Busch
2021-06-21 21:13 ` Jens Axboe
1 sibling, 1 reply; 13+ messages in thread
From: Keith Busch @ 2021-06-21 21:10 UTC (permalink / raw)
To: Jens Axboe; +Cc: Veronika Kabatova, CKI Project, linux-block, Matthew Wilcox
On Mon, Jun 21, 2021 at 03:00:48PM -0600, Jens Axboe wrote:
> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
> > On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
> >>
> >> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
> >>>
> >>>
> >>> Hello,
> >>>
> >>> We ran automated tests on a recent commit from this kernel tree:
> >>>
> >>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> >>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
> >>>
> >>> The results of these automated tests are provided below.
> >>>
> >>> Overall result: FAILED (see details below)
> >>> Merge: OK
> >>> Compile: FAILED
> >>>
> >>
> >> Hi,
> >>
> >> the failure is introduced between this commit and d142f908ebab64955eb48e.
> >> Currently seeing if I can bisect it closer but maybe someone already has an
> >> idea what went wrong.
> >>
> >
> > First commit failing the compilation is 7a2b0ef2a3b83733d7.
>
> Where's the log? Adding Willy...
I think the result was from 1f26b0627b461. There's an implied header
inclusion order such that linux/fs.h must be included before
linux/fileattr.h. The reported error for fs/orangefs/inode.c had been
getting the inclusion correct by chance through:
linux/bvec.h
linux/mm.h
linux/huge_mm.h
linux/fs.h
7a2b0ef2a3b83733d7 replaced bvec.h's mm.h inclusion with mm_types.h, so
now orangefs.h doesn't have the inclusion order correct anymore.
But we usually don't like inlcusion order dependencies in kernel, so I
think linux/fileattr.h needs to directly include the files it depends
on.
---
diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h
index 9e37e063ac69..34e153172a85 100644
--- a/include/linux/fileattr.h
+++ b/include/linux/fileattr.h
@@ -3,6 +3,8 @@
#ifndef _LINUX_FILEATTR_H
#define _LINUX_FILEATTR_H
+#include <linux/fs.h>
+
/* Flags shared betwen flags/xflags */
#define FS_COMMON_FL \
(FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
--
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 21:10 ` Keith Busch
@ 2021-06-21 21:13 ` Jens Axboe
0 siblings, 0 replies; 13+ messages in thread
From: Jens Axboe @ 2021-06-21 21:13 UTC (permalink / raw)
To: Keith Busch; +Cc: Veronika Kabatova, CKI Project, linux-block, Matthew Wilcox
On 6/21/21 3:10 PM, Keith Busch wrote:
> On Mon, Jun 21, 2021 at 03:00:48PM -0600, Jens Axboe wrote:
>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>>>
>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>
>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>>>
>>>>> The results of these automated tests are provided below.
>>>>>
>>>>> Overall result: FAILED (see details below)
>>>>> Merge: OK
>>>>> Compile: FAILED
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>>>> Currently seeing if I can bisect it closer but maybe someone already has an
>>>> idea what went wrong.
>>>>
>>>
>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
>>
>> Where's the log? Adding Willy...
>
> I think the result was from 1f26b0627b461. There's an implied header
> inclusion order such that linux/fs.h must be included before
> linux/fileattr.h. The reported error for fs/orangefs/inode.c had been
> getting the inclusion correct by chance through:
>
> linux/bvec.h
> linux/mm.h
> linux/huge_mm.h
> linux/fs.h
>
> 7a2b0ef2a3b83733d7 replaced bvec.h's mm.h inclusion with mm_types.h, so
> now orangefs.h doesn't have the inclusion order correct anymore.
>
> But we usually don't like inlcusion order dependencies in kernel, so I
> think linux/fileattr.h needs to directly include the files it depends
> on.
>
> ---
> diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h
> index 9e37e063ac69..34e153172a85 100644
> --- a/include/linux/fileattr.h
> +++ b/include/linux/fileattr.h
> @@ -3,6 +3,8 @@
> #ifndef _LINUX_FILEATTR_H
> #define _LINUX_FILEATTR_H
>
> +#include <linux/fs.h>
> +
> /* Flags shared betwen flags/xflags */
> #define FS_COMMON_FL \
> (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
> --
I found the error and came to the same conclusion as you. That's always
the worry with patches like this, that some unrelated implicit include
gets broken.
FWIW, I just dropped the bvec patch. We can try again when the orangefs
-> fileattr.h dependency is fixed.
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 21:07 ` Veronika Kabatova
@ 2021-06-21 21:58 ` Matthew Wilcox
2021-06-21 22:57 ` Pavel Begunkov
2021-06-21 23:36 ` Jens Axboe
0 siblings, 2 replies; 13+ messages in thread
From: Matthew Wilcox @ 2021-06-21 21:58 UTC (permalink / raw)
To: Veronika Kabatova; +Cc: Jens Axboe, CKI Project, linux-block
On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > On 6/21/21 2:57 PM, Veronika Kabatova wrote:
> > > On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
> > >>
> > >> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
> > >>>
> > >>>
> > >>> Hello,
> > >>>
> > >>> We ran automated tests on a recent commit from this kernel tree:
> > >>>
> > >>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> > >>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
> > >>>
> > >>> The results of these automated tests are provided below.
> > >>>
> > >>> Overall result: FAILED (see details below)
> > >>> Merge: OK
> > >>> Compile: FAILED
> > >>>
> > >>
> > >> Hi,
> > >>
> > >> the failure is introduced between this commit and d142f908ebab64955eb48e.
> > >> Currently seeing if I can bisect it closer but maybe someone already has an
> > >> idea what went wrong.
> > >>
> > >
> > > First commit failing the compilation is 7a2b0ef2a3b83733d7.
> >
> > Where's the log? Adding Willy...
> >
>
> Logs and kernel configs for each arch are linked in the original email at
> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
Which aren't there by the time they get to the original commit author.
You need to do better than this; the Intel build-bot bisects to the
commit which actually causes the error.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 21:58 ` Matthew Wilcox
@ 2021-06-21 22:57 ` Pavel Begunkov
2021-06-21 23:32 ` Matthew Wilcox
2021-06-21 23:36 ` Jens Axboe
1 sibling, 1 reply; 13+ messages in thread
From: Pavel Begunkov @ 2021-06-21 22:57 UTC (permalink / raw)
To: Matthew Wilcox, Veronika Kabatova; +Cc: Jens Axboe, CKI Project, linux-block
On 6/21/21 10:58 PM, Matthew Wilcox wrote:
> On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
>> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>
>>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
>>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>>>>
>>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>>>>
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>>
>>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>>>>
>>>>>> The results of these automated tests are provided below.
>>>>>>
>>>>>> Overall result: FAILED (see details below)
>>>>>> Merge: OK
>>>>>> Compile: FAILED
>>>>>>
>>>>>
>>>>> Hi,
>>>>>
>>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>>>>> Currently seeing if I can bisect it closer but maybe someone already has an
>>>>> idea what went wrong.
>>>>>
>>>>
>>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
>>>
>>> Where's the log? Adding Willy...
>>>
>>
>> Logs and kernel configs for each arch are linked in the original email at
>> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
>
> Which aren't there by the time they get to the original commit author.
> You need to do better than this; the Intel build-bot bisects to the
> commit which actually causes the error.
Matthew, I've just followed the link out of curiosity:
...
00:04:22 In file included from fs/orangefs/inode.c:14:
00:04:22 ./include/linux/fileattr.h:36:60: warning: ‘struct fsxattr’ declared inside parameter list will not be visible outside of this definition or declaration
00:04:22 36 | int copy_fsxattr_to_user(const struct fileattr *fa, struct fsxattr __user *ufa);
00:04:22 | ^~~~~~~
00:04:22 ./include/linux/fileattr.h: In function ‘fileattr_has_fsx’:
00:04:22 ./include/linux/fileattr.h:13:10: error: ‘FS_XFLAG_SYNC’ undeclared (first use in this function)
00:04:22 13 | (FS_XFLAG_SYNC | FS_XFLAG_IMMUTABLE | FS_XFLAG_APPEND | \
00:04:22 | ^~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:13:10: note: each undeclared identifier is reported only once for each function it appears in
00:04:22 13 | (FS_XFLAG_SYNC | FS_XFLAG_IMMUTABLE | FS_XFLAG_APPEND | \
00:04:22 | ^~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:13:26: error: ‘FS_XFLAG_IMMUTABLE’ undeclared (first use in this function)
00:04:22 13 | (FS_XFLAG_SYNC | FS_XFLAG_IMMUTABLE | FS_XFLAG_APPEND | \
00:04:22 | ^~~~~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:13:47: error: ‘FS_XFLAG_APPEND’ undeclared (first use in this function)
00:04:22 13 | (FS_XFLAG_SYNC | FS_XFLAG_IMMUTABLE | FS_XFLAG_APPEND | \
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:14:10: error: ‘FS_XFLAG_NODUMP’ undeclared (first use in this function); did you mean ‘FS_XFLAG_COMMON’?
00:04:22 14 | FS_XFLAG_NODUMP | FS_XFLAG_NOATIME | FS_XFLAG_DAX | \
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:14:28: error: ‘FS_XFLAG_NOATIME’ undeclared (first use in this function)
00:04:22 14 | FS_XFLAG_NODUMP | FS_XFLAG_NOATIME | FS_XFLAG_DAX | \
00:04:22 | ^~~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:14:47: error: ‘FS_XFLAG_DAX’ undeclared (first use in this function)
00:04:22 14 | FS_XFLAG_NODUMP | FS_XFLAG_NOATIME | FS_XFLAG_DAX | \
00:04:22 | ^~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:15:10: error: ‘FS_XFLAG_PROJINHERIT’ undeclared (first use in this function)
00:04:22 15 | FS_XFLAG_PROJINHERIT)
00:04:22 | ^~~~~~~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h:51:37: note: in expansion of macro ‘FS_XFLAG_COMMON’
00:04:22 51 | ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 ||
00:04:22 | ^~~~~~~~~~~~~~~
00:04:22 ./include/linux/fileattr.h: At top level:
00:04:22 ./include/linux/fileattr.h:55:29: warning: ‘struct dentry’ declared inside parameter list will not be visible outside of this definition or declaration
00:04:22 55 | int vfs_fileattr_get(struct dentry *dentry, struct fileattr *fa);
00:04:22 | ^~~~~~
00:04:22 ./include/linux/fileattr.h:56:64: warning: ‘struct dentry’ declared inside parameter list will not be visible outside of this definition or declaration
00:04:22 56 | int vfs_fileattr_set(struct user_namespace *mnt_userns, struct dentry *dentry,
00:04:22 | ^~~~~~
00:04:22 ./include/linux/fileattr.h: In function ‘fileattr_has_fsx’:
00:04:22 ./include/linux/fileattr.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
00:04:22 53 | }
00:04:22 | ^
00:04:22 cc1: some warnings being treated as errors
...
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 22:57 ` Pavel Begunkov
@ 2021-06-21 23:32 ` Matthew Wilcox
2021-06-21 23:42 ` Jens Axboe
0 siblings, 1 reply; 13+ messages in thread
From: Matthew Wilcox @ 2021-06-21 23:32 UTC (permalink / raw)
To: Pavel Begunkov; +Cc: Veronika Kabatova, Jens Axboe, CKI Project, linux-block
On Mon, Jun 21, 2021 at 11:57:06PM +0100, Pavel Begunkov wrote:
> On 6/21/21 10:58 PM, Matthew Wilcox wrote:
> > On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
> >> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
> >>>
> >>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
> >>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
> >>>>>
> >>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
> >>>>>>
> >>>>>>
> >>>>>> Hello,
> >>>>>>
> >>>>>> We ran automated tests on a recent commit from this kernel tree:
> >>>>>>
> >>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> >>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
> >>>>>>
> >>>>>> The results of these automated tests are provided below.
> >>>>>>
> >>>>>> Overall result: FAILED (see details below)
> >>>>>> Merge: OK
> >>>>>> Compile: FAILED
> >>>>>>
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
> >>>>> Currently seeing if I can bisect it closer but maybe someone already has an
> >>>>> idea what went wrong.
> >>>>>
> >>>>
> >>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
> >>>
> >>> Where's the log? Adding Willy...
> >>>
> >>
> >> Logs and kernel configs for each arch are linked in the original email at
> >> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
> >
> > Which aren't there by the time they get to the original commit author.
> > You need to do better than this; the Intel build-bot bisects to the
> > commit which actually causes the error.
>
> Matthew, I've just followed the link out of curiosity:
the link _which isn't in the first email i got_. the redhat cki system
is not very useful _because it doesn't do an automatic bisect and cc the
author of the commit_.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 21:58 ` Matthew Wilcox
2021-06-21 22:57 ` Pavel Begunkov
@ 2021-06-21 23:36 ` Jens Axboe
1 sibling, 0 replies; 13+ messages in thread
From: Jens Axboe @ 2021-06-21 23:36 UTC (permalink / raw)
To: Matthew Wilcox, Veronika Kabatova; +Cc: CKI Project, linux-block
On 6/21/21 3:58 PM, Matthew Wilcox wrote:
> On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
>> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>
>>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
>>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>>>>
>>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>>>>
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>>
>>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>>>>
>>>>>> The results of these automated tests are provided below.
>>>>>>
>>>>>> Overall result: FAILED (see details below)
>>>>>> Merge: OK
>>>>>> Compile: FAILED
>>>>>>
>>>>>
>>>>> Hi,
>>>>>
>>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>>>>> Currently seeing if I can bisect it closer but maybe someone already has an
>>>>> idea what went wrong.
>>>>>
>>>>
>>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
>>>
>>> Where's the log? Adding Willy...
>>>
>>
>> Logs and kernel configs for each arch are linked in the original email at
>> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
>
> Which aren't there by the time they get to the original commit author.
> You need to do better than this; the Intel build-bot bisects to the
> commit which actually causes the error.
If you'd actually read the email you're replying to, the commit is right
there:
First commit failing the compilation is 7a2b0ef2a3b83733d7.
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 23:32 ` Matthew Wilcox
@ 2021-06-21 23:42 ` Jens Axboe
2021-06-21 23:49 ` Matthew Wilcox
0 siblings, 1 reply; 13+ messages in thread
From: Jens Axboe @ 2021-06-21 23:42 UTC (permalink / raw)
To: Matthew Wilcox, Pavel Begunkov
Cc: Veronika Kabatova, CKI Project, linux-block
On 6/21/21 5:32 PM, Matthew Wilcox wrote:
> On Mon, Jun 21, 2021 at 11:57:06PM +0100, Pavel Begunkov wrote:
>> On 6/21/21 10:58 PM, Matthew Wilcox wrote:
>>> On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
>>>> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>
>>>>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
>>>>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>>>>>>
>>>>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>>>>
>>>>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>>>>>>
>>>>>>>> The results of these automated tests are provided below.
>>>>>>>>
>>>>>>>> Overall result: FAILED (see details below)
>>>>>>>> Merge: OK
>>>>>>>> Compile: FAILED
>>>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>>>>>>> Currently seeing if I can bisect it closer but maybe someone already has an
>>>>>>> idea what went wrong.
>>>>>>>
>>>>>>
>>>>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
>>>>>
>>>>> Where's the log? Adding Willy...
>>>>>
>>>>
>>>> Logs and kernel configs for each arch are linked in the original email at
>>>> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
>>>
>>> Which aren't there by the time they get to the original commit author.
>>> You need to do better than this; the Intel build-bot bisects to the
>>> commit which actually causes the error.
>>
>> Matthew, I've just followed the link out of curiosity:
>
> the link _which isn't in the first email i got_. the redhat cki system
> is not very useful _because it doesn't do an automatic bisect and cc the
> author of the commit_.
Kinks are still being worked out on that, nobody has claimed it's
perfect yet. Some manual input/labor is still required.
But it's useful, as this report has indicated. So maybe try and be a bit
nicer and appreciative, instead of grumpy and dismissive. It did find a
problem with YOUR patch, fwiw.
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 23:42 ` Jens Axboe
@ 2021-06-21 23:49 ` Matthew Wilcox
2021-06-22 0:48 ` Jens Axboe
0 siblings, 1 reply; 13+ messages in thread
From: Matthew Wilcox @ 2021-06-21 23:49 UTC (permalink / raw)
To: Jens Axboe; +Cc: Pavel Begunkov, Veronika Kabatova, CKI Project, linux-block
On Mon, Jun 21, 2021 at 05:42:15PM -0600, Jens Axboe wrote:
> On 6/21/21 5:32 PM, Matthew Wilcox wrote:
> > On Mon, Jun 21, 2021 at 11:57:06PM +0100, Pavel Begunkov wrote:
> >> On 6/21/21 10:58 PM, Matthew Wilcox wrote:
> >>> On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
> >>>> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
> >>>>>
> >>>>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
> >>>>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
> >>>>>>>
> >>>>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Hello,
> >>>>>>>>
> >>>>>>>> We ran automated tests on a recent commit from this kernel tree:
> >>>>>>>>
> >>>>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> >>>>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
> >>>>>>>>
> >>>>>>>> The results of these automated tests are provided below.
> >>>>>>>>
> >>>>>>>> Overall result: FAILED (see details below)
> >>>>>>>> Merge: OK
> >>>>>>>> Compile: FAILED
> >>>>>>>>
> >>>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
> >>>>>>> Currently seeing if I can bisect it closer but maybe someone already has an
> >>>>>>> idea what went wrong.
> >>>>>>>
> >>>>>>
> >>>>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
> >>>>>
> >>>>> Where's the log? Adding Willy...
> >>>>>
> >>>>
> >>>> Logs and kernel configs for each arch are linked in the original email at
> >>>> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
> >>>
> >>> Which aren't there by the time they get to the original commit author.
> >>> You need to do better than this; the Intel build-bot bisects to the
> >>> commit which actually causes the error.
> >>
> >> Matthew, I've just followed the link out of curiosity:
> >
> > the link _which isn't in the first email i got_. the redhat cki system
> > is not very useful _because it doesn't do an automatic bisect and cc the
> > author of the commit_.
>
> Kinks are still being worked out on that, nobody has claimed it's
> perfect yet. Some manual input/labor is still required.
>
> But it's useful, as this report has indicated. So maybe try and be a bit
> nicer and appreciative, instead of grumpy and dismissive. It did find a
> problem with YOUR patch, fwiw.
and i've already fixed it, and tested it with a make allmodconfig.
turned out to be the only missing place.
i get grumpy when people implement auto-harassing systems badly.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)
2021-06-21 23:49 ` Matthew Wilcox
@ 2021-06-22 0:48 ` Jens Axboe
0 siblings, 0 replies; 13+ messages in thread
From: Jens Axboe @ 2021-06-22 0:48 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Pavel Begunkov, Veronika Kabatova, CKI Project, linux-block
On 6/21/21 5:49 PM, Matthew Wilcox wrote:
> On Mon, Jun 21, 2021 at 05:42:15PM -0600, Jens Axboe wrote:
>> On 6/21/21 5:32 PM, Matthew Wilcox wrote:
>>> On Mon, Jun 21, 2021 at 11:57:06PM +0100, Pavel Begunkov wrote:
>>>> On 6/21/21 10:58 PM, Matthew Wilcox wrote:
>>>>> On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
>>>>>> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>>
>>>>>>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
>>>>>>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>>>>>>>>
>>>>>>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>>>>>>
>>>>>>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>>>>>>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>>>>>>>>
>>>>>>>>>> The results of these automated tests are provided below.
>>>>>>>>>>
>>>>>>>>>> Overall result: FAILED (see details below)
>>>>>>>>>> Merge: OK
>>>>>>>>>> Compile: FAILED
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>>>>>>>>> Currently seeing if I can bisect it closer but maybe someone already has an
>>>>>>>>> idea what went wrong.
>>>>>>>>>
>>>>>>>>
>>>>>>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
>>>>>>>
>>>>>>> Where's the log? Adding Willy...
>>>>>>>
>>>>>>
>>>>>> Logs and kernel configs for each arch are linked in the original email at
>>>>>> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
>>>>>
>>>>> Which aren't there by the time they get to the original commit author.
>>>>> You need to do better than this; the Intel build-bot bisects to the
>>>>> commit which actually causes the error.
>>>>
>>>> Matthew, I've just followed the link out of curiosity:
>>>
>>> the link _which isn't in the first email i got_. the redhat cki system
>>> is not very useful _because it doesn't do an automatic bisect and cc the
>>> author of the commit_.
>>
>> Kinks are still being worked out on that, nobody has claimed it's
>> perfect yet. Some manual input/labor is still required.
>>
>> But it's useful, as this report has indicated. So maybe try and be a bit
>> nicer and appreciative, instead of grumpy and dismissive. It did find a
>> problem with YOUR patch, fwiw.
>
> and i've already fixed it, and tested it with a make allmodconfig.
Which should have been done before submitting a patch like this.
> turned out to be the only missing place.
>
> i get grumpy when people implement auto-harassing systems badly.
It's a bad look of entitlement when complaints are made about everything
not being served on a silver platter. The service has been useful to me,
and it was useful in this particular case. Can it be improved? Surely,
everything can, and this one is a bit more rough around the edges than
the intel build bot. Which, coincidentally, has been around for many
years, so hardly surprising. This one triggered quickly, the intel bot
sometimes takes _days_ to produce anything. Improvements can be made in
both cases.
And _I_ was the one that CC'ed you on the report, as it was your commit
that broke the build, not the bot. Nobody got auto-harassed here.
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-06-22 0:48 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cki.3F4F097E3B.299V5OKJ7M@redhat.com>
2021-06-21 19:20 ` ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3) Veronika Kabatova
2021-06-21 20:57 ` Veronika Kabatova
2021-06-21 21:00 ` Jens Axboe
2021-06-21 21:07 ` Veronika Kabatova
2021-06-21 21:58 ` Matthew Wilcox
2021-06-21 22:57 ` Pavel Begunkov
2021-06-21 23:32 ` Matthew Wilcox
2021-06-21 23:42 ` Jens Axboe
2021-06-21 23:49 ` Matthew Wilcox
2021-06-22 0:48 ` Jens Axboe
2021-06-21 23:36 ` Jens Axboe
2021-06-21 21:10 ` Keith Busch
2021-06-21 21:13 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.