From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [Patch] Enable SMEP CPU feature support for  XEN
	itself
Date: Fri, 03 Jun 2011 13:34:04 +0100
Message-ID: <CA0E934C.1B90C%keir.xen@gmail.com>
References: <FC2FB65B4D919844ADE4BE3C2BB739AD5AB9EC67@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD5AB9EC67@shsmsx501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Li, Xin" <xin.li@intel.com>, Jan Beulich <JBeulich@novell.com>, "Yang, Wei Y" <wei.y.yang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 03/06/2011 12:54, "Li, Xin" <xin.li@intel.com> wrote:

>>> The whole point of setup_clear_cpu_cap() is that it only needs to run on the
>>> BP and the change gets picked up by every AP automatically as it boots.
>> 
>> Yeah, and we can't do leaf 7.0 detect in generic_identify. Or will again set
>> SMEP in
>> capabilities, but it should be ok.
> 
> I tried to not do leaf 7.0 detect on AP booting code, but system behaves
> abnormally
> (not hang, but "su -" never returns, after just revert the change, it runs
> well).
> 
> While at this point I want to focus on SMEP logic, we can make the
> improvements,
> to move such initialization to BP code only, later.  Also it makes no much
> sense to only
> move disable_smep that way, we should move all such variables.

Just get another rev of the patches out and we'll iterate if necessary.

 -- Keir

> Thanks!
> -Xin