All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew.wilcox@oracle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Kernel Team <Kernel-team@fb.com>,
	"William Kucharski" <william.kucharski@oracle.com>,
	"srikar@linux.vnet.ibm.com" <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] uprobe: collapse THP pmd after removing all uprobes
Date: Wed, 31 Jul 2019 16:36:15 +0000	[thread overview]
Message-ID: <CA691086-51F2-47AD-B280-8A9F9CF91804@fb.com> (raw)
In-Reply-To: <20190731161614.GC25078@redhat.com>



> On Jul 31, 2019, at 9:16 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> 
> On 07/28, Song Liu wrote:
>> 
>> @@ -525,6 +527,9 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
>> 
>> 				/* dec_mm_counter for old_page */
>> 				dec_mm_counter(mm, MM_ANONPAGES);
>> +
>> +				if (PageCompound(orig_page))
>> +					orig_page_huge = true;
> 
> I am wondering how find_get_page() can return a PageCompound() page...
> 
> IIUC, this is only possible if shmem_file(), right?

Yes, this is the case at the moment. We will be able to do it for other
file systems when this set gets in: 

	https://lkml.org/lkml/2019/6/24/1531

Thanks,
Song

      reply	other threads:[~2019-07-31 16:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  5:43 [PATCH 0/2] khugepaged: collapse pmd for pte-mapped THP Song Liu
2019-07-29  5:43 ` [PATCH 1/2] khugepaged: enable " Song Liu
2019-07-30 14:59   ` Kirill A. Shutemov
2019-07-30 17:28     ` Song Liu
2019-07-30 18:39       ` Song Liu
2019-07-29  5:43 ` [PATCH 2/2] uprobe: collapse THP pmd after removing all uprobes Song Liu
2019-07-30 15:01   ` Kirill A. Shutemov
2019-07-30 17:02     ` Song Liu
2019-07-31 16:16   ` Oleg Nesterov
2019-07-31 16:36     ` Song Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA691086-51F2-47AD-B280-8A9F9CF91804@fb.com \
    --to=songliubraving@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew.wilcox@oracle.com \
    --cc=oleg@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=william.kucharski@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.