From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3781CC388F9 for ; Wed, 11 Nov 2020 07:48:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAA0B2072C for ; Wed, 11 Nov 2020 07:48:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="Qul+UKxN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbgKKHs2 (ORCPT ); Wed, 11 Nov 2020 02:48:28 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:15730 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgKKHs1 (ORCPT ); Wed, 11 Nov 2020 02:48:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605080905; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=UipCBNxvSkYMD0ld5DKa/yFCoPhHKzPCKQYEYVERROM=; b=Qul+UKxNBBZxJKkoP7KqJytJNyOa1nEO0FHHNlBf4O2vguMqh3pAVDkTkiL+R2c5td uRFUoLP4EWWNwJit5/rm+erTcaBCz68ISaE97xAS0MY6wSbaafJYDINxaqJOr13PPVRb iV+1y4J2JUkHlDRAXV3MkGdXzMSTRT4yhpbcVA1gDU9LyHRbQQGhvybAFQFsE+Ra4n26 z2Gy0Zwfktzcdf9TcYXIphS81c7wGd3Zh+1GF/EbNG6wc9orRYflCCuu3IFJO0ajsXIh 0Xfwv/dboHpklVO10DzHs8idhiHvLi2K626kXRiZJNthHHWkglSeVMTiZ3CSylYEY/Tp qSGw== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmAvw43o9ik=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id N02faawAB7m96cA (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 11 Nov 2020 08:48:09 +0100 (CET) Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 11 Nov 2020 08:48:09 +0100 Cc: Sebastian Reichel , Laurent Pinchart , Nikhil Devshatwar , Linux-OMAP , dri-devel , Sekhar Nori , Tony Lindgren , Discussions about the Letux Kernel Content-Transfer-Encoding: quoted-printable Message-Id: References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <579243AA-014A-411B-9014-F5846C9B8137@goldelico.com> <837EA533-9946-43B3-B058-69060EC43981@goldelico.com> <08589e51-f5e6-2743-57ec-8ac509f97ff0@ti.com> <1f1afce4-c822-0fbf-1ce3-dda0064b65c6@ti.com> <67786545-23D2-444F-85B8-7A030070B317@goldelico.com> <17F5238B-1CC3-4764-B744-C57D9CE4EB42@goldelico.com> <6A9407FC-69F7-4E30-B4A3-FFB2E91CAE3B@goldelico.com> <1cf563e5-2dc0-1802-86e3-3e24150f0651@ti.com> <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> <0AF59BFD-89F2-46D3-9EB6-F47FBB52B183@goldelico.com> <917fe1c6-4009-7788-f815-fcc1fc2ba7df@ti.com> <2265AEF5-42BC-4E7B-B263-D0B93B78DE91@goldelico.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org > Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : >=20 > On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >>=20 >>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen = : >>>=20 >>> On 10/11/2020 18:49, H. Nikolaus Schaller wrote: >>>=20 >>> I guess you have the same issue. It goes to dsi_bridge_mode_valid, = then __dsi_calc_config, and stays >>> there finding good clocks. >>=20 >=20 > drm_display_mode.clock is in kHz, but the panel driver writes Hz = (w677l_PIXELCLOCK) to it. Ok, fixing this removes the stuck thread issue. Thanks for pointing this = out! > But > there's more after fixing that. The DSI gets configured in bridge's = modeset, which I think is before > w677l_prepare where the panel already sends DSI commands. Also, the = dsi driver fails to lock the > PLL, so possibly the clock calcs are still wrong. What I now get is [ 131.035006] [drm:drm_atomic_helper_wait_for_dependencies = [drm_kms_helper]] *ERROR* [CRTC:55:crtc-0] flip_done timed out [ 141.272174] [drm:drm_atomic_helper_wait_for_dependencies = [drm_kms_helper]] *ERROR* [CONNECTOR:54:DSI-1] flip_done timed out I think for further experiments we could hack the device tree to = compatible =3D "orisetech,otm8009a"; and configure for panel-orisetech-otm8009a.ko. Since this panel driver = is known to work elsewhere we could exclude panel driver issues for the moment. To be safe we can = modify otm8009a_dcs_write_buf() to just print what it would be doing. BR, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747FAC56201 for ; Wed, 11 Nov 2020 07:55:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E264C206B5 for ; Wed, 11 Nov 2020 07:55:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="AFnrbbzQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E264C206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55C5A89F6E; Wed, 11 Nov 2020 07:54:51 +0000 (UTC) Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id D52C389D99 for ; Wed, 11 Nov 2020 07:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605080903; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=UipCBNxvSkYMD0ld5DKa/yFCoPhHKzPCKQYEYVERROM=; b=AFnrbbzQAG4N3X41nePG1z/Bsr8PK0s7UfUXML1ySLYCaIDfUJw0ZHEIwH8dz+ETHZ D+B1fEtFONXwjBZ/udYbpLXa4KZW7zQgPYuFp1NhHdMuVMfyKA5uSAubRVyn35vJgLbv JLU+sNM3kGdc9poKsl5GpQ/GiBTN1bOu6IALyT76FGm+BUdAPEhC/vf9PEnPKF4DE2nY Yk9vqnmL9TN8wUZM4LX2O8ChvGiy6f92TfIE9bKTUCJ4MiChgBoDtRuYHpfwTbjTQJXk ZvzJOouX4JkThNviKyV/SuB8xSbgisX/o4eddTTH5USOobc23Qpot4/yofcoTc/6nfrm hksQ== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmAvw43o9ik=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id N02faawAB7m96cA (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 11 Nov 2020 08:48:09 +0100 (CET) Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 11 Nov 2020 08:48:09 +0100 Message-Id: References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <579243AA-014A-411B-9014-F5846C9B8137@goldelico.com> <837EA533-9946-43B3-B058-69060EC43981@goldelico.com> <08589e51-f5e6-2743-57ec-8ac509f97ff0@ti.com> <1f1afce4-c822-0fbf-1ce3-dda0064b65c6@ti.com> <67786545-23D2-444F-85B8-7A030070B317@goldelico.com> <17F5238B-1CC3-4764-B744-C57D9CE4EB42@goldelico.com> <6A9407FC-69F7-4E30-B4A3-FFB2E91CAE3B@goldelico.com> <1cf563e5-2dc0-1802-86e3-3e24150f0651@ti.com> <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> <0AF59BFD-89F2-46D3-9EB6-F47FBB52B183@goldelico.com> <917fe1c6-4009-7788-f815-fcc1fc2ba7df@ti.com> <2265AEF5-42BC-4E7B-B263-D0B93B78DE91@goldelico.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) X-Mailman-Approved-At: Wed, 11 Nov 2020 07:54:43 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Discussions about the Letux Kernel , Tony Lindgren , Sekhar Nori , Sebastian Reichel , dri-devel , Laurent Pinchart , Linux-OMAP , Nikhil Devshatwar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : > > On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >> >>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : >>> >>> On 10/11/2020 18:49, H. Nikolaus Schaller wrote: >>> >>> I guess you have the same issue. It goes to dsi_bridge_mode_valid, then __dsi_calc_config, and stays >>> there finding good clocks. >> > > drm_display_mode.clock is in kHz, but the panel driver writes Hz (w677l_PIXELCLOCK) to it. Ok, fixing this removes the stuck thread issue. Thanks for pointing this out! > But > there's more after fixing that. The DSI gets configured in bridge's modeset, which I think is before > w677l_prepare where the panel already sends DSI commands. Also, the dsi driver fails to lock the > PLL, so possibly the clock calcs are still wrong. What I now get is [ 131.035006] [drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR* [CRTC:55:crtc-0] flip_done timed out [ 141.272174] [drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR* [CONNECTOR:54:DSI-1] flip_done timed out I think for further experiments we could hack the device tree to compatible = "orisetech,otm8009a"; and configure for panel-orisetech-otm8009a.ko. Since this panel driver is known to work elsewhere we could exclude panel driver issues for the moment. To be safe we can modify otm8009a_dcs_write_buf() to just print what it would be doing. BR, Nikolaus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel