From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC7CEC00140 for ; Tue, 16 Aug 2022 02:35:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D6B0AE9; Tue, 16 Aug 2022 04:35:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D6B0AE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1660617350; bh=AmNDxQynnfU8gQLSBs9FFFGwaI9fBDyRCqhRZACAAlM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gr0UR/dx3+ui32RujyPeGpn4/bIh2vId+2w/FqN2NiWS2EzQkmyg60J9NHUSso1PF 7fYI9/RZ/DmSiLlNB/hg8vKdCndn7dnZ4PORgfPDC1rlaOqjMCNfL9WJtJJksPLI9c aKSp8of0eb0SsCwWhUgqdtbz9yu/eI6YBPpd06nk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2AEF7F80238; Tue, 16 Aug 2022 04:35:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 01B49F8032D; Tue, 16 Aug 2022 04:34:57 +0200 (CEST) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 37B94F80082 for ; Tue, 16 Aug 2022 04:34:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 37B94F80082 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SxF1uTOE" Received: by mail-lj1-x231.google.com with SMTP id j3so9386324ljo.0 for ; Mon, 15 Aug 2022 19:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vmY+LUCJruKF8uLc3XlHm/fJT0a+m0ghSI6+yD5XTag=; b=SxF1uTOEDfk3qpRS8vrws1X9rPL0pWXqD5SeWgJSoSEIxAe2LjVcSc2Ms2uC/MzoSr b1KL0gMu7nxtqlDHUvsHX90BIlV4ErkwKvUp9vO8f8Ug3u1o8UQ5hEnApbhdpIxgJDsT Uq3MeuEfM/Jn7wsR+xlbtjiMtwGGpvuaQYsBSEgM4FxWmr7MSFPT+C/W6IZnlLoT3UyM +fuRhM63M30hg6vQhOyKe9yUugiJGNCnjkZHsKQ64wqd8RFxcZeq+H+sZo+NpTcAJWSr LqOzUpPy4Jov7HqZFDhweENUQl5ojcHj7CQBjW9cEKibR/enBOhWomaKKekIB63g65Fv rkEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vmY+LUCJruKF8uLc3XlHm/fJT0a+m0ghSI6+yD5XTag=; b=fN+2802D+C5X7/CggjQ6esWJb2wU4JsyBaAEa+aM00/EpO+DAgFOWSt2LrgFKX/nYA J07QiCM6KrlDePnZAe/9/Es8heDyw6y2rRd3WUB7ObR6n4fq9pKpT0fYaC1RnnsEbhyK udSjAYNxrCepj3kqLqhQ6i8IRMpVJB4ve1PZ2bYwkOmD6ajzE7B3Vyi8bIzDxEFojyyD jtd/P4z/w3w85Ag3qoqox/e8MYQEuE6tdVOJWJDjiZk8vMk53DC6gw4CqUgnssFZnkXS fxyVoNqZAo7JeaiT0+Ddrn428h5SBppHdOGadYfrqR4znJKVg+EjIqcxCUuyV1jDfI3Z 6MUg== X-Gm-Message-State: ACgBeo1O9x4twQTKy49VKsLFXaxVLTXDb/fnft2NqGsVll5uWWW63uJi Y9akrxxh0n4jM4wUp8FiU4PgrbMHY0K+TtYrDBo= X-Google-Smtp-Source: AA6agR4pZpz+E+mZWSp2TEXSFno6q0tnw2P+5v+jTyqjZvCeszMWPDWVBLCrJh6OVtSiGey7VZVViK56eitP0OvMchg= X-Received: by 2002:a05:651c:ba5:b0:25e:c5d4:4341 with SMTP id bg37-20020a05651c0ba500b0025ec5d44341mr6095297ljb.272.1660617291087; Mon, 15 Aug 2022 19:34:51 -0700 (PDT) MIME-Version: 1.0 References: <20220813083353.8959-1-pieterjan.camerlynck@gmail.com> In-Reply-To: <20220813083353.8959-1-pieterjan.camerlynck@gmail.com> From: Shengjiu Wang Date: Tue, 16 Aug 2022 10:34:39 +0800 Message-ID: Subject: Re: [PATCH v2] ASoC: fsl_sai: fix incorrect mclk number in error message To: Pieterjan Camerlynck Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: alsa-devel@alsa-project.org, Xiubo Li , linuxppc-dev , Takashi Iwai , Liam Girdwood , Nicolin Chen , Mark Brown , Fabio Estevam , linux-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Aug 13, 2022 at 4:34 PM Pieterjan Camerlynck < pieterjan.camerlynck@gmail.com> wrote: > In commit c3ecef21c3f26 ("ASoC: fsl_sai: add sai master mode support") > the loop was changed to start iterating from 1 instead of 0. The error > message however was not updated, reporting the wrong clock to the user. > > Signed-off-by: Pieterjan Camerlynck > Acked-by: Shengjiu Wang Best regards Wang shengjiu > --- > V2: rebase against latest version > --- > sound/soc/fsl/fsl_sai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 7523bb944b21..d430eece1d6b 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1306,7 +1306,7 @@ static int fsl_sai_probe(struct platform_device > *pdev) > sai->mclk_clk[i] = devm_clk_get(dev, tmp); > if (IS_ERR(sai->mclk_clk[i])) { > dev_err(dev, "failed to get mclk%d clock: %ld\n", > - i + 1, PTR_ERR(sai->mclk_clk[i])); > + i, PTR_ERR(sai->mclk_clk[i])); > sai->mclk_clk[i] = NULL; > } > } > -- > 2.25.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9E63C2BB41 for ; Tue, 16 Aug 2022 08:00:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M6Nq6022zz3cCk for ; Tue, 16 Aug 2022 18:00:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=SxF1uTOE; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::22a; helo=mail-lj1-x22a.google.com; envelope-from=shengjiu.wang@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=SxF1uTOE; dkim-atps=neutral Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M6Fc36M11z2xGQ for ; Tue, 16 Aug 2022 12:34:57 +1000 (AEST) Received: by mail-lj1-x22a.google.com with SMTP id bx38so9324146ljb.10 for ; Mon, 15 Aug 2022 19:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vmY+LUCJruKF8uLc3XlHm/fJT0a+m0ghSI6+yD5XTag=; b=SxF1uTOEDfk3qpRS8vrws1X9rPL0pWXqD5SeWgJSoSEIxAe2LjVcSc2Ms2uC/MzoSr b1KL0gMu7nxtqlDHUvsHX90BIlV4ErkwKvUp9vO8f8Ug3u1o8UQ5hEnApbhdpIxgJDsT Uq3MeuEfM/Jn7wsR+xlbtjiMtwGGpvuaQYsBSEgM4FxWmr7MSFPT+C/W6IZnlLoT3UyM +fuRhM63M30hg6vQhOyKe9yUugiJGNCnjkZHsKQ64wqd8RFxcZeq+H+sZo+NpTcAJWSr LqOzUpPy4Jov7HqZFDhweENUQl5ojcHj7CQBjW9cEKibR/enBOhWomaKKekIB63g65Fv rkEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vmY+LUCJruKF8uLc3XlHm/fJT0a+m0ghSI6+yD5XTag=; b=OA06MTzCG4Dn++SBHw5QyhMJCIdjkd97NQ8yvcYvjfY4P6uidF5+Z8DEcSBx1nc0eO fQdP4JzET1WjicKei44qqiIJbFJ7QV8eEJ/gsCG5eAXxJnt8QNHeBIKb/imLP0T7et4L Xmst2RJOHUjxN29UXhdx8o8B7a2We7r8uH5AV27HuwQT22jFd81EnYenB3z377AKh3+Q Spqf68k4fjOftaP6nSubNKDYVjQuxqvj1OinrTw4mOPs3OkewhCXuhKiPmWOb4EmgL7H hxf3s3ADKhrTiydksWqFau0ucycVSBH5WcDt5RxUMwMNbV0BIv/PKDlp3Q/u2Vp76T+J /GWA== X-Gm-Message-State: ACgBeo1I7sZUxpXjO+RlfXSH2t+bfxIw+TVjt+OEQPxREbCXw0qWdqye S7vITUd21ySHXq8eLUM0uEjD9tzrbf/780pOTFA= X-Google-Smtp-Source: AA6agR4pZpz+E+mZWSp2TEXSFno6q0tnw2P+5v+jTyqjZvCeszMWPDWVBLCrJh6OVtSiGey7VZVViK56eitP0OvMchg= X-Received: by 2002:a05:651c:ba5:b0:25e:c5d4:4341 with SMTP id bg37-20020a05651c0ba500b0025ec5d44341mr6095297ljb.272.1660617291087; Mon, 15 Aug 2022 19:34:51 -0700 (PDT) MIME-Version: 1.0 References: <20220813083353.8959-1-pieterjan.camerlynck@gmail.com> In-Reply-To: <20220813083353.8959-1-pieterjan.camerlynck@gmail.com> From: Shengjiu Wang Date: Tue, 16 Aug 2022 10:34:39 +0800 Message-ID: Subject: Re: [PATCH v2] ASoC: fsl_sai: fix incorrect mclk number in error message To: Pieterjan Camerlynck Content-Type: multipart/alternative; boundary="000000000000be455305e65297c1" X-Mailman-Approved-At: Tue, 16 Aug 2022 17:59:28 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Xiubo Li , linuxppc-dev , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Nicolin Chen , Mark Brown , Fabio Estevam , linux-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --000000000000be455305e65297c1 Content-Type: text/plain; charset="UTF-8" On Sat, Aug 13, 2022 at 4:34 PM Pieterjan Camerlynck < pieterjan.camerlynck@gmail.com> wrote: > In commit c3ecef21c3f26 ("ASoC: fsl_sai: add sai master mode support") > the loop was changed to start iterating from 1 instead of 0. The error > message however was not updated, reporting the wrong clock to the user. > > Signed-off-by: Pieterjan Camerlynck > Acked-by: Shengjiu Wang Best regards Wang shengjiu > --- > V2: rebase against latest version > --- > sound/soc/fsl/fsl_sai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 7523bb944b21..d430eece1d6b 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1306,7 +1306,7 @@ static int fsl_sai_probe(struct platform_device > *pdev) > sai->mclk_clk[i] = devm_clk_get(dev, tmp); > if (IS_ERR(sai->mclk_clk[i])) { > dev_err(dev, "failed to get mclk%d clock: %ld\n", > - i + 1, PTR_ERR(sai->mclk_clk[i])); > + i, PTR_ERR(sai->mclk_clk[i])); > sai->mclk_clk[i] = NULL; > } > } > -- > 2.25.1 > > --000000000000be455305e65297c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Aug 13, 2022 at 4:34 PM Piete= rjan Camerlynck <piete= rjan.camerlynck@gmail.com> wrote:
In commit c3ecef21c3f26 ("ASoC: fsl_sai: add = sai master mode support")
the loop was changed to start iterating from 1 instead of 0. The error
message however was not updated, reporting the wrong clock to the user.

Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
=

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

=
Best regards
Wang shengjiu
=C2=A0
---
V2: rebase against latest version
---
=C2=A0sound/soc/fsl/fsl_sai.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 7523bb944b21..d430eece1d6b 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -1306,7 +1306,7 @@ static int fsl_sai_probe(struct platform_device *pdev= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sai->mclk_clk[i]= =3D devm_clk_get(dev, tmp);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (IS_ERR(sai->= mclk_clk[i])) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 dev_err(dev, "failed to get mclk%d clock: %ld\n",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i + 1, PT= R_ERR(sai->mclk_clk[i]));
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i, PTR_ER= R(sai->mclk_clk[i]));
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 sai->mclk_clk[i] =3D NULL;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
--
2.25.1

--000000000000be455305e65297c1--