From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA7AC433F5 for ; Fri, 8 Oct 2021 04:12:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D1D360F6E for ; Fri, 8 Oct 2021 04:12:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbhJHEON (ORCPT ); Fri, 8 Oct 2021 00:14:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhJHEOM (ORCPT ); Fri, 8 Oct 2021 00:14:12 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E384DC061570; Thu, 7 Oct 2021 21:12:17 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id r1so8374773qta.12; Thu, 07 Oct 2021 21:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kpVveClApwG0f1MnOqx8Bs+gZiIua6pFcbtmAW5z2vE=; b=HFR4Iurmu8llLf9/t436kyERqMxFzX0S9BXVmQphHY+eC094l2FixYiSO/6IyRNrzg aGnSn1JLegb+klcmlL9c1FHA6kv8ooUumw8gQ/zUrSEVix7JDROjy1ggNEtJ5OPfIKAE DubkE0HzXEtoETInYz7iIkiFfSQcsa4UsOs6OumtJY+ohNxSwbSF3OxjqFAGOzJJ8Q75 zraUH9qJ/pgTZXCCXZj605AfcXXwEqvIf0LSSOmIvjgDCjW1EfRmaibzdvqNIpR+HJFp LuKOKTNDsKsjt5X0SjEDa/dxID3ceTSPG9OgLZlioueIvqUmCwSxrW1ydmNwRjkabnca Hzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kpVveClApwG0f1MnOqx8Bs+gZiIua6pFcbtmAW5z2vE=; b=HLoI2Hlz4FSXG/MSelvtfuVPLZOW0SJcPzQ3Q00eaggOMkDB+FT2WAQr2RrUUSjZfc UJWr+zvPSPnBiDingvTYXtZrLoNp1WBn8n3Dk2QFkDSlSxdR3YqNR5uGFDs6e+652rF+ c/dba00KFXs5RywOgn2iuazz7PxYpmwEADAGuViCMPRPYSqPu+L1lFZiiX8PzATNW9HP AP/+UGPGGzWFFORNvEVAQQFXKQ3auh+VDJNpirFprK4Ff71EZSfhtK6578DhmWIM7RoH 7YMzDv1C15Dy9/c3JxR9ulEHwKXS8xQ9etAvYG1gDShexWw1Rd0JSlrSSUVmVWg3PZj4 PpAw== X-Gm-Message-State: AOAM530I/lMuNaaLXGCSyfS+Lry15A3ews6dlWRfPRvKzYB9W/VGAce6 R/wP4md+RUELvHZlkg4e9aQf2sH7zQkBU0s1K10= X-Google-Smtp-Source: ABdhPJzb94QCdtXn2IloaHOWQOje6kwaxFQI1o2Yjku+KrGOvzD0W8w4bJY53EmcCjFfEfO5v9EsOb93TC2vxJ2i4kM= X-Received: by 2002:ac8:1e06:: with SMTP id n6mr9069200qtl.365.1633666337060; Thu, 07 Oct 2021 21:12:17 -0700 (PDT) MIME-Version: 1.0 References: <1632625630-784-1-git-send-email-shengjiu.wang@nxp.com> <1632625630-784-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Fri, 8 Oct 2021 12:12:06 +0800 Message-ID: Subject: Re: [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Rob Herring Cc: Shengjiu Wang , Ohad Ben Cohen , Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Rob On Sat, Oct 2, 2021 at 12:40 AM Rob Herring wrote: > > On Wed, Sep 29, 2021 at 9:34 PM Shengjiu Wang wrote: > > > > Hi Rob > > > > On Thu, Sep 30, 2021 at 6:40 AM Rob Herring wrote: > > > > > > On Sun, Sep 26, 2021 at 11:07:10AM +0800, Shengjiu Wang wrote: > > > > As there are two drivers for DSP on i.MX, one is for sound open > > > > firmware, another is for remote processor framework. In order to > > > > distinguish two kinds of driver, defining different compatible strings. > > > > > > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > > > are needed and the mailbox channel is different with SOF. > > > > > > > > Signed-off-by: Shengjiu Wang > > > > Acked-by: Daniel Baluta > > > > --- > > > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > > index 7afc9f2be13a..51ea657f6d42 100644 > > > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > > > > > maintainers: > > > > - Daniel Baluta > > > > + - Shengjiu Wang > > > > > > > > description: | > > > > Some boards from i.MX8 family contain a DSP core used for > > > > @@ -19,6 +20,10 @@ properties: > > > > - fsl,imx8qxp-dsp > > > > - fsl,imx8qm-dsp > > > > - fsl,imx8mp-dsp > > > > + - fsl,imx8qxp-hifi4 > > > > + - fsl,imx8qm-hifi4 > > > > + - fsl,imx8mp-hifi4 > > > > + - fsl,imx8ulp-hifi4 > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -28,37 +33,63 @@ properties: > > > > - description: ipg clock > > > > - description: ocram clock > > > > - description: core clock > > > > + - description: debug interface clock > > > > + - description: message unit clock > > > > + minItems: 3 > > > > + maxItems: 5 > > > > > > Don't need maxItems. > > > > Ok, I will update it. > > > > > > > > > > > > > clock-names: > > > > items: > > > > - const: ipg > > > > - const: ocram > > > > - const: core > > > > + - const: debug > > > > + - const: mu > > > > + minItems: 3 > > > > + maxItems: 5 > > > > > > ditto > > > > Ok, I will update it. > > > > > > > > > > > > > power-domains: > > > > description: > > > > List of phandle and PM domain specifier as documented in > > > > Documentation/devicetree/bindings/power/power_domain.txt > > > > + minItems: 1 > > > > > > This is curious. The h/w sometimes has fewer power domains? > > > > On i.MX8QM/8QXP, there are independent power domains for DSP core, > > DSP's RAM and DSP's MU. > > But on i.MX8MP, all these DSP components are in same audio subsystem > > There is only one power domain for whole audio subsystem, when > > power on audio subsystem, the DSP's components are powered on also. > > > > So the number of power domain depends on how the DSP component > > integrated in SoC. > > Sounds like you can write an if/then schema for this difference. > I try this: allOf: - if: properties: compatible: contains: enum: - fsl,imx8mp-hifi4 - fsl,imx8mp-dsp then: properties: power-domains: maxItems: 1 else: properties: power-domains: maxItems: 4 But the dt_binding_check report error: DTEX Documentation/devicetree/bindings/dsp/fsl,dsp.example.dts DTC Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml CHECK Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml /opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml: dsp@3b6e8000: power-domains: [[4294967295]] is too short From schema: /opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml I don't know the reason, could you please help to have a look what is wrong? Best regards Wang Shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E35C433F5 for ; Fri, 8 Oct 2021 04:13:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3E9160E73 for ; Fri, 8 Oct 2021 04:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E3E9160E73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vUjpmFi+lXExCnEzzqOu2NF0q1PjBmq9HzFalM6q6Oo=; b=zF6mkxn4pHn31F 05+3HZ9132nQbLuFgr7Z3Awc6xB0R+wJJ2cCXpy6CgmdJO/7LdX2r8hi40YzhKgFavOaSyTC3Ew5Z rAHV1TU1WJXeUosUkChkhT24omwg+vRx795Cy/rvRsQkllUXtVYFBXaFqwfGMFpVqNFz/xazbMb3Z 67Nc7wLbVFm4+rFPnMo0heGuIO8NeRG7Bu2FzLO4AgRGL3x1bD4sTX3an08SxtIYgpCphl1WLpzp/ lY4O6KPwZlvjutkVPnlfQNw3mNTrcWewgT115g36jYkdkTsfrmdsfBvNN7UY8BoWEgAhVPvfG6SWY MZoM3iKHvpauTS7KKLyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYhF9-001Xjr-0X; Fri, 08 Oct 2021 04:12:23 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYhF4-001Xiz-9n for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 04:12:19 +0000 Received: by mail-qt1-x82d.google.com with SMTP id r17so3101426qtx.10 for ; Thu, 07 Oct 2021 21:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kpVveClApwG0f1MnOqx8Bs+gZiIua6pFcbtmAW5z2vE=; b=HFR4Iurmu8llLf9/t436kyERqMxFzX0S9BXVmQphHY+eC094l2FixYiSO/6IyRNrzg aGnSn1JLegb+klcmlL9c1FHA6kv8ooUumw8gQ/zUrSEVix7JDROjy1ggNEtJ5OPfIKAE DubkE0HzXEtoETInYz7iIkiFfSQcsa4UsOs6OumtJY+ohNxSwbSF3OxjqFAGOzJJ8Q75 zraUH9qJ/pgTZXCCXZj605AfcXXwEqvIf0LSSOmIvjgDCjW1EfRmaibzdvqNIpR+HJFp LuKOKTNDsKsjt5X0SjEDa/dxID3ceTSPG9OgLZlioueIvqUmCwSxrW1ydmNwRjkabnca Hzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kpVveClApwG0f1MnOqx8Bs+gZiIua6pFcbtmAW5z2vE=; b=eNGFU8XLjnZaGqrjE1IiOafLg72YF+8vU7O5j5OuSK0poxlWBdbBA7ITJg+2HrQ3UN TzPUioZsLwTe9ia0+XjB1mkcUfqfpVQvpb9LD9kuMCGb57Wz+IrzDkcDcbK3aPO6pGdH jJjUSogt3lBqQhtZtJLscXRIXnAKkRIFvBcvJcnFOqk3wY+5N6Kc7egbt2MrVcTONjen IiBDeT7qQubLc+rh/BXFS6ExOHwBljtDPXdumt7HYPXIINlsk0eOSusfX5+AyBY4jzhC PwKKeN3iEWnrd5m2Sta7Nb68zc6qL/UvVEFrg7JgBC7bCex0QJkrgj4F90JiiMjqsT6W rMxg== X-Gm-Message-State: AOAM533NxSY+qvdbhZxu6ITP3lk+BIBGAVnQuH4JGei96JYb4nkdFMUf WD1+C11xD8okvNgQr2RlKRt0G1X7U3jOAGVhh2U= X-Google-Smtp-Source: ABdhPJzb94QCdtXn2IloaHOWQOje6kwaxFQI1o2Yjku+KrGOvzD0W8w4bJY53EmcCjFfEfO5v9EsOb93TC2vxJ2i4kM= X-Received: by 2002:ac8:1e06:: with SMTP id n6mr9069200qtl.365.1633666337060; Thu, 07 Oct 2021 21:12:17 -0700 (PDT) MIME-Version: 1.0 References: <1632625630-784-1-git-send-email-shengjiu.wang@nxp.com> <1632625630-784-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Fri, 8 Oct 2021 12:12:06 +0800 Message-ID: Subject: Re: [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Rob Herring Cc: Shengjiu Wang , Ohad Ben Cohen , Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_211218_378475_42488266 X-CRM114-Status: GOOD ( 32.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob On Sat, Oct 2, 2021 at 12:40 AM Rob Herring wrote: > > On Wed, Sep 29, 2021 at 9:34 PM Shengjiu Wang wrote: > > > > Hi Rob > > > > On Thu, Sep 30, 2021 at 6:40 AM Rob Herring wrote: > > > > > > On Sun, Sep 26, 2021 at 11:07:10AM +0800, Shengjiu Wang wrote: > > > > As there are two drivers for DSP on i.MX, one is for sound open > > > > firmware, another is for remote processor framework. In order to > > > > distinguish two kinds of driver, defining different compatible strings. > > > > > > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > > > are needed and the mailbox channel is different with SOF. > > > > > > > > Signed-off-by: Shengjiu Wang > > > > Acked-by: Daniel Baluta > > > > --- > > > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > > index 7afc9f2be13a..51ea657f6d42 100644 > > > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > > > > > maintainers: > > > > - Daniel Baluta > > > > + - Shengjiu Wang > > > > > > > > description: | > > > > Some boards from i.MX8 family contain a DSP core used for > > > > @@ -19,6 +20,10 @@ properties: > > > > - fsl,imx8qxp-dsp > > > > - fsl,imx8qm-dsp > > > > - fsl,imx8mp-dsp > > > > + - fsl,imx8qxp-hifi4 > > > > + - fsl,imx8qm-hifi4 > > > > + - fsl,imx8mp-hifi4 > > > > + - fsl,imx8ulp-hifi4 > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -28,37 +33,63 @@ properties: > > > > - description: ipg clock > > > > - description: ocram clock > > > > - description: core clock > > > > + - description: debug interface clock > > > > + - description: message unit clock > > > > + minItems: 3 > > > > + maxItems: 5 > > > > > > Don't need maxItems. > > > > Ok, I will update it. > > > > > > > > > > > > > clock-names: > > > > items: > > > > - const: ipg > > > > - const: ocram > > > > - const: core > > > > + - const: debug > > > > + - const: mu > > > > + minItems: 3 > > > > + maxItems: 5 > > > > > > ditto > > > > Ok, I will update it. > > > > > > > > > > > > > power-domains: > > > > description: > > > > List of phandle and PM domain specifier as documented in > > > > Documentation/devicetree/bindings/power/power_domain.txt > > > > + minItems: 1 > > > > > > This is curious. The h/w sometimes has fewer power domains? > > > > On i.MX8QM/8QXP, there are independent power domains for DSP core, > > DSP's RAM and DSP's MU. > > But on i.MX8MP, all these DSP components are in same audio subsystem > > There is only one power domain for whole audio subsystem, when > > power on audio subsystem, the DSP's components are powered on also. > > > > So the number of power domain depends on how the DSP component > > integrated in SoC. > > Sounds like you can write an if/then schema for this difference. > I try this: allOf: - if: properties: compatible: contains: enum: - fsl,imx8mp-hifi4 - fsl,imx8mp-dsp then: properties: power-domains: maxItems: 1 else: properties: power-domains: maxItems: 4 But the dt_binding_check report error: DTEX Documentation/devicetree/bindings/dsp/fsl,dsp.example.dts DTC Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml CHECK Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml /opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml: dsp@3b6e8000: power-domains: [[4294967295]] is too short From schema: /opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml I don't know the reason, could you please help to have a look what is wrong? Best regards Wang Shengjiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel