From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2B4C433F5 for ; Thu, 30 Sep 2021 02:34:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F037861439 for ; Thu, 30 Sep 2021 02:34:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347777AbhI3Cgk (ORCPT ); Wed, 29 Sep 2021 22:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347759AbhI3Cgj (ORCPT ); Wed, 29 Sep 2021 22:36:39 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEDB8C06161C; Wed, 29 Sep 2021 19:34:57 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id m7so4383251qke.8; Wed, 29 Sep 2021 19:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5H3zl6oYi2k/pahNWHm1qYAiJEHuNXY47Unp3/acgsA=; b=ZWVqNdXJefB3MNBd7cVgBZxBZthq+q6h0PLTl/PWYzH0mbOaYjPeVKBTRPZDBb1Fnv KhfowHhhakCGH2Olp+bCfriV0pQuFhBg0VXvLjYEelptqSsjQc175ANwQjswGiw5VsT7 0TbUdrVWoPVPcANFr+KEG1Go8FgaSvG4XJWGCcJ1fjh+TnaKKCtiodlsvVgImU92YmEl THg79NjpOBfgytWQolN5U2Bk1YRjqNyyPvnFIexpNjzclGsYfygrzJNpqhht1AMSSoUs LpeQRb7DfjTX/XYJ9CN2pAiFJmhm4xGL3+EafRK4+cizjxpX/q5BBZfhNUAORHzPvq3/ 7RNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5H3zl6oYi2k/pahNWHm1qYAiJEHuNXY47Unp3/acgsA=; b=y3AH1NUQK3NIZI77w4QZH7vbpogCybwjF7C0wSZ7MUbze6iCD9XKeXin8ZBwXmlqON ocIZiNqEJK7aQbkEO9+ConZmFOmw2GVGr+ylKr/lT8uppYnagcv/UZogwRk7wXKtqVV3 nSykmlx79TpDf26dLBYcrYjuoEG6S8BFK8N5wUfuVxEUSQfzQJn6ZSnPpymxzAur4y74 zAQEH+wgV6CRPyxmYIjDKnMiAtliQJP2d5DtzPnDV7jisePuTt6v5vIMxLYFXApZPpbW mkyUrBhXZa4aRwvd2Zms5y1/w+G5WExKdxQz9fecwsizr8xwiH7jCmxz2zWGmh6FUuCy YOzQ== X-Gm-Message-State: AOAM533ydQd6NS4DphiGaIUQBqxAiLohpxZqPFWxFHjeTVuANl4ABS5A rjQ+ELiOVZWNKcp0zk3P92W9XbsGR8srf1UBmc0= X-Google-Smtp-Source: ABdhPJwtPGdTpTNc5xgsgBlvtb/Wau0tzIHEBNiDnQI1DOjcDsVINKS3Mt8l/3BoBpDXW5kArtbRpujHlvw/FPwlBcA= X-Received: by 2002:a37:b087:: with SMTP id z129mr2754043qke.392.1632969297030; Wed, 29 Sep 2021 19:34:57 -0700 (PDT) MIME-Version: 1.0 References: <1632625630-784-1-git-send-email-shengjiu.wang@nxp.com> <1632625630-784-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Thu, 30 Sep 2021 10:34:46 +0800 Message-ID: Subject: Re: [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Rob Herring Cc: Shengjiu Wang , Ohad Ben Cohen , Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Rob On Thu, Sep 30, 2021 at 6:40 AM Rob Herring wrote: > > On Sun, Sep 26, 2021 at 11:07:10AM +0800, Shengjiu Wang wrote: > > As there are two drivers for DSP on i.MX, one is for sound open > > firmware, another is for remote processor framework. In order to > > distinguish two kinds of driver, defining different compatible strings. > > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > are needed and the mailbox channel is different with SOF. > > > > Signed-off-by: Shengjiu Wang > > Acked-by: Daniel Baluta > > --- > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > index 7afc9f2be13a..51ea657f6d42 100644 > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > maintainers: > > - Daniel Baluta > > + - Shengjiu Wang > > > > description: | > > Some boards from i.MX8 family contain a DSP core used for > > @@ -19,6 +20,10 @@ properties: > > - fsl,imx8qxp-dsp > > - fsl,imx8qm-dsp > > - fsl,imx8mp-dsp > > + - fsl,imx8qxp-hifi4 > > + - fsl,imx8qm-hifi4 > > + - fsl,imx8mp-hifi4 > > + - fsl,imx8ulp-hifi4 > > > > reg: > > maxItems: 1 > > @@ -28,37 +33,63 @@ properties: > > - description: ipg clock > > - description: ocram clock > > - description: core clock > > + - description: debug interface clock > > + - description: message unit clock > > + minItems: 3 > > + maxItems: 5 > > Don't need maxItems. Ok, I will update it. > > > > > clock-names: > > items: > > - const: ipg > > - const: ocram > > - const: core > > + - const: debug > > + - const: mu > > + minItems: 3 > > + maxItems: 5 > > ditto Ok, I will update it. > > > > > power-domains: > > description: > > List of phandle and PM domain specifier as documented in > > Documentation/devicetree/bindings/power/power_domain.txt > > + minItems: 1 > > This is curious. The h/w sometimes has fewer power domains? On i.MX8QM/8QXP, there are independent power domains for DSP core, DSP's RAM and DSP's MU. But on i.MX8MP, all these DSP components are in same audio subsystem There is only one power domain for whole audio subsystem, when power on audio subsystem, the DSP's components are powered on also. So the number of power domain depends on how the DSP component integrated in SoC. Best regards Wang Shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B37C433F5 for ; Thu, 30 Sep 2021 02:36:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DC9161164 for ; Thu, 30 Sep 2021 02:36:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3DC9161164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9d9yqFjv5nes+76Ou4G5E90aj0xWBb8AsJ6XeiaBcHk=; b=ERHkHWQd5PFfhj 1fF9qu06/qm/STdNcbgWKApdsB5cewTxhmRpbmkih7uFxB5MbU6mAVn/0vF2xBvGkBMZgM1TKrPa6 ylmyZ2npjaAs1LfyIwpNqOLAWhv2EOc/REfbOFgSPXqpQxLbIvcyVW41VnTRxTRrphvxwiDtiXjw2 pIOz+CbX8I1QrucO0tesKFmVFTFJYfL3mcNYCE8ZIavJZ4zN7MZO/9qAz1zt8BI0aXUlH9vO6yqrq V5SVBLIBaZuDauftZPFCggpVwYVKDnBIE0ndI1ivsaa7BO0vq5kxX3CCMBebxtY7j1yUdw9uGxzOn gUI0Ir+vWk0zwp+PmpTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVluX-00CmYq-J0; Thu, 30 Sep 2021 02:35:01 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVluU-00CmY2-Jk for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 02:35:00 +0000 Received: by mail-qk1-x72c.google.com with SMTP id 194so4371758qkj.11 for ; Wed, 29 Sep 2021 19:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5H3zl6oYi2k/pahNWHm1qYAiJEHuNXY47Unp3/acgsA=; b=ZWVqNdXJefB3MNBd7cVgBZxBZthq+q6h0PLTl/PWYzH0mbOaYjPeVKBTRPZDBb1Fnv KhfowHhhakCGH2Olp+bCfriV0pQuFhBg0VXvLjYEelptqSsjQc175ANwQjswGiw5VsT7 0TbUdrVWoPVPcANFr+KEG1Go8FgaSvG4XJWGCcJ1fjh+TnaKKCtiodlsvVgImU92YmEl THg79NjpOBfgytWQolN5U2Bk1YRjqNyyPvnFIexpNjzclGsYfygrzJNpqhht1AMSSoUs LpeQRb7DfjTX/XYJ9CN2pAiFJmhm4xGL3+EafRK4+cizjxpX/q5BBZfhNUAORHzPvq3/ 7RNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5H3zl6oYi2k/pahNWHm1qYAiJEHuNXY47Unp3/acgsA=; b=vsTBO/KX3nwGmfXhFLAAHZ30e41oIgz1S54a5Gy+Ne9k6GkhBu7346xfOqUgwWKrUI yfz93oqhP9zZPx/AvUgFVPg4dXow2EsJ1pQomSyBiKBH2RHNwopQRnHdIZFGgqWGW2Rz n80zVbCqlUlVH8lM3Yz5VRIaUcgq0YvXvM0FHxJSNS2f0im8ATzB/6as8XWSwLzSg/Uf prlOrXvMk+tfbA8ofVTztuQ1XM39tBf8KKjsEJC41zaErJwjzC/hBzvuu5s/JPQ7G4Kh DzFbe51sYroPz1JI2tPgDCovp4nDPcsDYNl35gmhxUqxsWSr7iIqGCLPNyAognOlFAPv eHVg== X-Gm-Message-State: AOAM531y3iRZIKTmxTr3Xmn2JCCxjqivnLRMB+tqBKmidpuPue8iApIk uGdpDEhadIOVAJ2N/Uz71QdfU7yHDEfjsgNpieg= X-Google-Smtp-Source: ABdhPJwtPGdTpTNc5xgsgBlvtb/Wau0tzIHEBNiDnQI1DOjcDsVINKS3Mt8l/3BoBpDXW5kArtbRpujHlvw/FPwlBcA= X-Received: by 2002:a37:b087:: with SMTP id z129mr2754043qke.392.1632969297030; Wed, 29 Sep 2021 19:34:57 -0700 (PDT) MIME-Version: 1.0 References: <1632625630-784-1-git-send-email-shengjiu.wang@nxp.com> <1632625630-784-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Thu, 30 Sep 2021 10:34:46 +0800 Message-ID: Subject: Re: [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Rob Herring Cc: Shengjiu Wang , Ohad Ben Cohen , Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_193458_672915_1A32EE70 X-CRM114-Status: GOOD ( 24.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob On Thu, Sep 30, 2021 at 6:40 AM Rob Herring wrote: > > On Sun, Sep 26, 2021 at 11:07:10AM +0800, Shengjiu Wang wrote: > > As there are two drivers for DSP on i.MX, one is for sound open > > firmware, another is for remote processor framework. In order to > > distinguish two kinds of driver, defining different compatible strings. > > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > are needed and the mailbox channel is different with SOF. > > > > Signed-off-by: Shengjiu Wang > > Acked-by: Daniel Baluta > > --- > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > index 7afc9f2be13a..51ea657f6d42 100644 > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > maintainers: > > - Daniel Baluta > > + - Shengjiu Wang > > > > description: | > > Some boards from i.MX8 family contain a DSP core used for > > @@ -19,6 +20,10 @@ properties: > > - fsl,imx8qxp-dsp > > - fsl,imx8qm-dsp > > - fsl,imx8mp-dsp > > + - fsl,imx8qxp-hifi4 > > + - fsl,imx8qm-hifi4 > > + - fsl,imx8mp-hifi4 > > + - fsl,imx8ulp-hifi4 > > > > reg: > > maxItems: 1 > > @@ -28,37 +33,63 @@ properties: > > - description: ipg clock > > - description: ocram clock > > - description: core clock > > + - description: debug interface clock > > + - description: message unit clock > > + minItems: 3 > > + maxItems: 5 > > Don't need maxItems. Ok, I will update it. > > > > > clock-names: > > items: > > - const: ipg > > - const: ocram > > - const: core > > + - const: debug > > + - const: mu > > + minItems: 3 > > + maxItems: 5 > > ditto Ok, I will update it. > > > > > power-domains: > > description: > > List of phandle and PM domain specifier as documented in > > Documentation/devicetree/bindings/power/power_domain.txt > > + minItems: 1 > > This is curious. The h/w sometimes has fewer power domains? On i.MX8QM/8QXP, there are independent power domains for DSP core, DSP's RAM and DSP's MU. But on i.MX8MP, all these DSP components are in same audio subsystem There is only one power domain for whole audio subsystem, when power on audio subsystem, the DSP's components are powered on also. So the number of power domain depends on how the DSP component integrated in SoC. Best regards Wang Shengjiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel