From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F02AC433E0 for ; Sun, 7 Feb 2021 09:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 307F964DFD for ; Sun, 7 Feb 2021 09:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbhBGJuC (ORCPT ); Sun, 7 Feb 2021 04:50:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhBGJtw (ORCPT ); Sun, 7 Feb 2021 04:49:52 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD01AC061756; Sun, 7 Feb 2021 01:49:11 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id r77so11524888qka.12; Sun, 07 Feb 2021 01:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbbpsfQOSGbGs7R9zUS8hYozEigpvRyjnIt3/cvm3W4=; b=diViRcfhsBkjhy6mWySEJOvsQpOFK8pZMbHHTOXwUoPo1Ufs827UZAvqXypn/cYfbC w6BVY6DkW3CKlG2KmSRpgU5z2KocTnpA6/MSr+resHu5Lry5t6So7Ij6KP0YOIUAM9W/ huFYnUNtqpAcUFTaoClhw4N7n27WmMKnsKfev01KHJxc+8bzxTWIJGGdzL6ZJgkcbpJg IdB8X6n+ct1xkjqGPnj+HWL0/tirsOdYu2VRr7ftt2i//YyLHiP9LHr7JFBytNJUAaI1 5cgpzZ3gAIyg49t2FiBhrd7VMbFLD9n5qn+iTRwhsPWZI1OMMqICxBPAgxO5SQLVPtx/ NDuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbbpsfQOSGbGs7R9zUS8hYozEigpvRyjnIt3/cvm3W4=; b=S2sN5X3+CKTIEKySU/HdJfUJqkf3RZGejze9h79tt2SUy+oUxw1Bfatvu5mExexaBE qgZt4e4OBBpPTTRSZCyvXhV5rCXx33IYMmEv/cbpTLMPAbIQcXJKwGEuGCBKB93kHq+7 yMai9M94TzvyN5qfD5RP7GMoFXBcMeqTtcJ+2Y20fhALxn8EssX1YhqJzfURW4FlkBIG tpFmzsaUBc4GjhY+iUJ4VxjZc9rR9gyrYvbWjxuQBrX1eM2OP5twDS5MtqhC8CUVDgAk 89DsEygo+WNpFkHJ5asoW79oLU5Mk0pe0HKbhjDfBUSGzLTZ+BusJluZAtJlJaDf1lON qhJg== X-Gm-Message-State: AOAM531w36QWr3EDAqzrw1hzEkgwGosUNoNaV7YiJQW1RTi58lf+g3K4 7UoBVMPi/0fXEtLXY0Ep7ZBpSXXCZCsOVznLj+Y= X-Google-Smtp-Source: ABdhPJz7+XOZYuIE5pcblvhRQewVLTixRZW/R/cp3G96D5R/aLCDqK4IrND0zV4hhmv9HidC2Ycs1HEyKDlklGV2C98= X-Received: by 2002:ae9:e80e:: with SMTP id a14mr2346374qkg.103.1612691351108; Sun, 07 Feb 2021 01:49:11 -0800 (PST) MIME-Version: 1.0 References: <1612508250-10586-1-git-send-email-shengjiu.wang@nxp.com> <1612508250-10586-3-git-send-email-shengjiu.wang@nxp.com> <20210205140251.GB4720@sirena.org.uk> In-Reply-To: <20210205140251.GB4720@sirena.org.uk> From: Shengjiu Wang Date: Sun, 7 Feb 2021 17:49:00 +0800 Message-ID: Subject: Re: [PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg To: Mark Brown Cc: Shengjiu Wang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , alsa-devel@alsa-project.org, Timur Tabi , Liam Girdwood , linuxppc-dev@lists.ozlabs.org, Xiubo Li , linux-kernel , Takashi Iwai , Nicolin Chen , Rob Herring , Fabio Estevam Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 10:04 PM Mark Brown wrote: > > On Fri, Feb 05, 2021 at 02:57:25PM +0800, Shengjiu Wang wrote: > > This is a dummy cpu dai driver for rpmsg audio use case, > > which is mainly used for getting the user's configuration > > This is actually doing stuff, it's not a dummy driver. > > > +static int fsl_rpmsg_remove(struct platform_device *pdev) > > +{ > > + return 0; > > +} > > If this isn't needed just remove it. Thanks Mark. I will update them. Best regards Wang shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CEDC433DB for ; Sun, 7 Feb 2021 09:50:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D5E564E0F for ; Sun, 7 Feb 2021 09:50:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D5E564E0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D8D96886; Sun, 7 Feb 2021 10:49:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D8D96886 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612691410; bh=irKxt+IhPdN/gZ9oFXpChHN70D4VkSPYO6KBp0Yd9oY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ILLk6Kxa9bGIOGl9ep1NjWyISVs2oUXpRK0qBkGyJltZcL+7iqPcOSrfTK0+I5EuK QUuGRClTuURkh3Fr/UCn3GgqTIUbdu9Uw9nWE35ksqB1vBAohKNmses2/aD857OHR7 7sv9myFrsaNrx0WnBSiIs4DB//UjZTCO26BQpgP8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F0246F8016B; Sun, 7 Feb 2021 10:49:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0CFC8F801D5; Sun, 7 Feb 2021 10:49:17 +0100 (CET) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7749CF80129 for ; Sun, 7 Feb 2021 10:49:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7749CF80129 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="diViRcfh" Received: by mail-qk1-x732.google.com with SMTP id s77so11571615qke.4 for ; Sun, 07 Feb 2021 01:49:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbbpsfQOSGbGs7R9zUS8hYozEigpvRyjnIt3/cvm3W4=; b=diViRcfhsBkjhy6mWySEJOvsQpOFK8pZMbHHTOXwUoPo1Ufs827UZAvqXypn/cYfbC w6BVY6DkW3CKlG2KmSRpgU5z2KocTnpA6/MSr+resHu5Lry5t6So7Ij6KP0YOIUAM9W/ huFYnUNtqpAcUFTaoClhw4N7n27WmMKnsKfev01KHJxc+8bzxTWIJGGdzL6ZJgkcbpJg IdB8X6n+ct1xkjqGPnj+HWL0/tirsOdYu2VRr7ftt2i//YyLHiP9LHr7JFBytNJUAaI1 5cgpzZ3gAIyg49t2FiBhrd7VMbFLD9n5qn+iTRwhsPWZI1OMMqICxBPAgxO5SQLVPtx/ NDuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbbpsfQOSGbGs7R9zUS8hYozEigpvRyjnIt3/cvm3W4=; b=GCHz2rGdEzg9i0fVlw4QrQAkVLK6mPLx0uVhbvv1YrOpTPE3Faua/RfFqljafGA0Yb 6NgTrpyJ1s5Pm7SKtQB4Mf7UL8UMUJnZP829570UmKezVrgSBMJ+5vvXbh8umR07YYq9 V8oqlXfUBnKf+6SoAjkfgmjdcDQFWk1ylht2lFV2dqGE1CuH3uwIDsuEPZ1Z0pp6BdV9 mYSBXVaQis1ZMtfhCwCub6hsgFOJLp+H44EA7DLyT+Yfc0s0GiYT6a18p6GNFe8p27Tb tFU7/GX8HM+cuOEKFqOi90VSaCtLJv83CTTS3irSJ7c2IFr1ku2F+fOjq9bC1uZ6QQY8 MQiA== X-Gm-Message-State: AOAM531TbQaeqc75YuLSxTOhONE/b1Rq3vVaSZC7Krf5zIU/IQcXhva2 bpgwXynkFax/dwCWk6tOi8TnX0O+AxHzKi29x7I= X-Google-Smtp-Source: ABdhPJz7+XOZYuIE5pcblvhRQewVLTixRZW/R/cp3G96D5R/aLCDqK4IrND0zV4hhmv9HidC2Ycs1HEyKDlklGV2C98= X-Received: by 2002:ae9:e80e:: with SMTP id a14mr2346374qkg.103.1612691351108; Sun, 07 Feb 2021 01:49:11 -0800 (PST) MIME-Version: 1.0 References: <1612508250-10586-1-git-send-email-shengjiu.wang@nxp.com> <1612508250-10586-3-git-send-email-shengjiu.wang@nxp.com> <20210205140251.GB4720@sirena.org.uk> In-Reply-To: <20210205140251.GB4720@sirena.org.uk> From: Shengjiu Wang Date: Sun, 7 Feb 2021 17:49:00 +0800 Message-ID: Subject: Re: [PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg To: Mark Brown Content-Type: text/plain; charset="UTF-8" Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , Shengjiu Wang , Takashi Iwai , Liam Girdwood , linux-kernel , Nicolin Chen , Rob Herring , linuxppc-dev@lists.ozlabs.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Feb 5, 2021 at 10:04 PM Mark Brown wrote: > > On Fri, Feb 05, 2021 at 02:57:25PM +0800, Shengjiu Wang wrote: > > This is a dummy cpu dai driver for rpmsg audio use case, > > which is mainly used for getting the user's configuration > > This is actually doing stuff, it's not a dummy driver. > > > +static int fsl_rpmsg_remove(struct platform_device *pdev) > > +{ > > + return 0; > > +} > > If this isn't needed just remove it. Thanks Mark. I will update them. Best regards Wang shengjiu