From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E051C433DF for ; Wed, 20 May 2020 11:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0E8520758 for ; Wed, 20 May 2020 11:22:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzRhD8IV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726729AbgETLWm (ORCPT ); Wed, 20 May 2020 07:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbgETLWl (ORCPT ); Wed, 20 May 2020 07:22:41 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84E79C061A0E; Wed, 20 May 2020 04:22:41 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id f83so3029080qke.13; Wed, 20 May 2020 04:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=LzRhD8IVgnmIVQzzoYcQc9SGvryKW9AvjBv+5xt1U5TlXPqkgWZYhhLZ+fDOiIMJVE j8fn5+fABxBNdukYPVM+l0vF16UvWxzpEJBJLKCW56Z4DkC5xa0rvUGkgFzj9G0Agcbl CR4ePEwCrdO65XTKv1Q7qKPo1V5T2jQjs+MOPyTun845of6hg3kQqItmtboNDlREjJcu Z2pKrl+oLt5umJH0Z+pIMp+EXFb7tOaN6BDew0UWwQ+/7bg+moQfUGPSduuzZJPyI5/X 2YFdC3nAFQopV7V8BMDEMRy8CAn1JlcOebH4yDfMrImRBq3nMNW49Dcoe93t2TjTRQsi 5qvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=tGKfvQOLbYU/CCvevpp/elZsTM7jW2xKsLaADafhQe+knI3smKvwcOGAaZ+Vm+A4I/ VUF5yGRw2wmZ8G+jz6LpMGsbWmPi7M+w7yvwfPBLr0wMTYZC2K1yVBSrEF0pefuHaehF 0VmXDY0KIIPqj2xQeI0qGhQrc7tcktsceAhq2P2/9YrsUR+2Z0+gbbgTb7qCCIl69Jbc Wa12BS5zRf/QzTvFKR1162IKOeUZK50fCX8VcsdFQ0gaOaLwot1y1Lr08MH7JTJa1Fun uqNJnq05p2q+nAZneJjjBpvOmmkIAytpzfQLzAB32nmy4tLgxBTazuTFuhcPvL8IfZDW XqIw== X-Gm-Message-State: AOAM532jmsvr7fhp83fnG/0ifx+WTD/JtVFX/YK7qkPl8+ForL6i7RsG 3LfwpUMPIOJAD2UO8FoFmoxxg82yspwqdbu9AhI= X-Google-Smtp-Source: ABdhPJxBdmgJNCR88xlbXPGclNlO2GaIwRkfV+dyapGMbu4Q9RuUthOHvMqPP4yv8y1KdCvdCmqnj7BHtLVZZI62f64= X-Received: by 2002:a37:a50d:: with SMTP id o13mr4087174qke.121.1589973760794; Wed, 20 May 2020 04:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> In-Reply-To: <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> From: Shengjiu Wang Date: Wed, 20 May 2020 19:22:19 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Lucas Stach Cc: Shengjiu Wang , Timur Tabi , Nicolin Chen , Xiubo Li , Fabio Estevam , Liam Girdwood , Mark Brown , perex@perex.cz, Takashi Iwai , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, sumit.semwal@linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wr= ote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements that we need to move the request > > > > of dma channel from probe to open. > > > > > > How do you handle -EPROBE_DEFER return code from the channel request = if > > > you don't do it in probe? > > > > I use the dma_request_slave_channel or dma_request_channel instead > > of dmaengine_pcm_request_chan_of. so there should be not -EPROBE_DEFER > > return code. > > This is a pretty weak argument. The dmaengine device might probe after > you try to get the channel. Using a function to request the channel > that doesn't allow you to handle probe deferral is IMHO a bug and > should be fixed, instead of building even more assumptions on top of > it. > I see some driver also request dma channel in open() or hw_params(). how can they avoid the defer probe issue? for example=EF=BC=9A sound/arm/pxa2xx-pcm-lib.c sound/soc/sprd/sprd-pcm-dma.c > > > > - When dma device binds with power-domains, the power will > > > > be enabled when we request dma channel. If the request of dma > > > > channel happen on probe, then the power-domains will be always > > > > enabled after kernel boot up, which is not good for power > > > > saving, so we need to move the request of dma channel to .open(); > > > > > > This is certainly something which could be fixed in the dmaengine > > > driver. > > > > Dma driver always call the pm_runtime_get_sync in > > device_alloc_chan_resources, the device_alloc_chan_resources is > > called when channel is requested. so power is enabled on channel > > request. > > So why can't you fix the dmaengine driver to do that RPM call at a > later time when the channel is actually going to be used? This will > allow further power savings with other slave devices than the audio > PCM. > > Regards, > Lucas > It seems the best place for calling pm_runtime_get_sync is the device_alloc_chan_resources, and calling pm_runtime_put_sync in the .device_free_chan_resources For the slave_sg mode, the .device_prep_slave_sg and .device_issue_pending will be called many times after .device_alloc_chan_resources. so it is not good to call pm_runtime_get_sync in .device_prep_slave_sg or .device_issue_pending best regards wang shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F53C433DF for ; Wed, 20 May 2020 11:23:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2356207C4 for ; Wed, 20 May 2020 11:23:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="YUUbeHBK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzRhD8IV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2356207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F2C5617BE; Wed, 20 May 2020 13:22:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F2C5617BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589973822; bh=saXS62aM5DoR6XRhBW8l0McmytiX79WnVlfDhs1aKSI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YUUbeHBK8Sk4VLcvgjOATBrzzS4XABb8hx1QfnMMw+bVV4iKs2YQ9EwDLsngToRRF xNKWyIMYNuFkHCwzlfL6l5gOUdIKJZ/0yvUhJlr/9vcH9NrIAnYL9TKiuZUAj7rdas SuhevDrMXJPTI8m67yWC+U7MQUb0AiFYmChpC9tQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6465CF80132; Wed, 20 May 2020 13:22:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 22EC3F801F9; Wed, 20 May 2020 13:22:50 +0200 (CEST) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 26D6EF80132 for ; Wed, 20 May 2020 13:22:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 26D6EF80132 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzRhD8IV" Received: by mail-qk1-x741.google.com with SMTP id m11so3118372qka.4 for ; Wed, 20 May 2020 04:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=LzRhD8IVgnmIVQzzoYcQc9SGvryKW9AvjBv+5xt1U5TlXPqkgWZYhhLZ+fDOiIMJVE j8fn5+fABxBNdukYPVM+l0vF16UvWxzpEJBJLKCW56Z4DkC5xa0rvUGkgFzj9G0Agcbl CR4ePEwCrdO65XTKv1Q7qKPo1V5T2jQjs+MOPyTun845of6hg3kQqItmtboNDlREjJcu Z2pKrl+oLt5umJH0Z+pIMp+EXFb7tOaN6BDew0UWwQ+/7bg+moQfUGPSduuzZJPyI5/X 2YFdC3nAFQopV7V8BMDEMRy8CAn1JlcOebH4yDfMrImRBq3nMNW49Dcoe93t2TjTRQsi 5qvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=QQYSf7XhF3WneYwk9wpiMPYDVDKA9nnhhENGMuvRaNoeNtJo7tZzWaTK60y4TN/s5Z FhDcK5CaeIUqQT7ohtFugkVaPzX1DzcSavgkK6hrRAOvKqsJE9tA4jG5doLKau8orTln rCqVbb7dohXA2zM1/hRL3QikZJC9COcxz40jNt4B5uCZuXlhzQ594bY32IM+laHx9Fbt 0gYKN7eftDCfZuZx2FviBeWoDy3ObOy4WiewdC6itSMLTh7Gka56Xhp/xxWTCZXXLtd1 AJi8L73bIBBuO263vCb5CeJD7MV0Lxk4n0iYuuwOdRQld4KJ95FpGcKEy+6kAddMPP8F oKFw== X-Gm-Message-State: AOAM532ZUN797x7CmSBNQUMTfAILZQd6VXZrq3gkTsaOriYBkMUiuaPz VlvE4GwOj/ECvwYODDDxxFzOn5kBZw+heuIbmHY= X-Google-Smtp-Source: ABdhPJxBdmgJNCR88xlbXPGclNlO2GaIwRkfV+dyapGMbu4Q9RuUthOHvMqPP4yv8y1KdCvdCmqnj7BHtLVZZI62f64= X-Received: by 2002:a37:a50d:: with SMTP id o13mr4087174qke.121.1589973760794; Wed, 20 May 2020 04:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> In-Reply-To: <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> From: Shengjiu Wang Date: Wed, 20 May 2020 19:22:19 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Lucas Stach Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: sumit.semwal@linaro.org, linaro-mm-sig@lists.linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, Shengjiu Wang , Takashi Iwai , Liam Girdwood , dri-devel@lists.freedesktop.org, Nicolin Chen , Mark Brown , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wr= ote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements that we need to move the request > > > > of dma channel from probe to open. > > > > > > How do you handle -EPROBE_DEFER return code from the channel request = if > > > you don't do it in probe? > > > > I use the dma_request_slave_channel or dma_request_channel instead > > of dmaengine_pcm_request_chan_of. so there should be not -EPROBE_DEFER > > return code. > > This is a pretty weak argument. The dmaengine device might probe after > you try to get the channel. Using a function to request the channel > that doesn't allow you to handle probe deferral is IMHO a bug and > should be fixed, instead of building even more assumptions on top of > it. > I see some driver also request dma channel in open() or hw_params(). how can they avoid the defer probe issue? for example=EF=BC=9A sound/arm/pxa2xx-pcm-lib.c sound/soc/sprd/sprd-pcm-dma.c > > > > - When dma device binds with power-domains, the power will > > > > be enabled when we request dma channel. If the request of dma > > > > channel happen on probe, then the power-domains will be always > > > > enabled after kernel boot up, which is not good for power > > > > saving, so we need to move the request of dma channel to .open(); > > > > > > This is certainly something which could be fixed in the dmaengine > > > driver. > > > > Dma driver always call the pm_runtime_get_sync in > > device_alloc_chan_resources, the device_alloc_chan_resources is > > called when channel is requested. so power is enabled on channel > > request. > > So why can't you fix the dmaengine driver to do that RPM call at a > later time when the channel is actually going to be used? This will > allow further power savings with other slave devices than the audio > PCM. > > Regards, > Lucas > It seems the best place for calling pm_runtime_get_sync is the device_alloc_chan_resources, and calling pm_runtime_put_sync in the .device_free_chan_resources For the slave_sg mode, the .device_prep_slave_sg and .device_issue_pending will be called many times after .device_alloc_chan_resources. so it is not good to call pm_runtime_get_sync in .device_prep_slave_sg or .device_issue_pending best regards wang shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D4B3C433DF for ; Wed, 20 May 2020 11:38:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2DA720671 for ; Wed, 20 May 2020 11:38:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzRhD8IV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2DA720671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49RrNz3qs5zDqrm for ; Wed, 20 May 2020 21:38:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::742; helo=mail-qk1-x742.google.com; envelope-from=shengjiu.wang@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=LzRhD8IV; dkim-atps=neutral Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Rr2X6TdfzDqPS for ; Wed, 20 May 2020 21:22:44 +1000 (AEST) Received: by mail-qk1-x742.google.com with SMTP id 142so3098252qkl.6 for ; Wed, 20 May 2020 04:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=LzRhD8IVgnmIVQzzoYcQc9SGvryKW9AvjBv+5xt1U5TlXPqkgWZYhhLZ+fDOiIMJVE j8fn5+fABxBNdukYPVM+l0vF16UvWxzpEJBJLKCW56Z4DkC5xa0rvUGkgFzj9G0Agcbl CR4ePEwCrdO65XTKv1Q7qKPo1V5T2jQjs+MOPyTun845of6hg3kQqItmtboNDlREjJcu Z2pKrl+oLt5umJH0Z+pIMp+EXFb7tOaN6BDew0UWwQ+/7bg+moQfUGPSduuzZJPyI5/X 2YFdC3nAFQopV7V8BMDEMRy8CAn1JlcOebH4yDfMrImRBq3nMNW49Dcoe93t2TjTRQsi 5qvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=jwke02MMumN5ZWsTBZpUQFG+wckEEnaRJ7bb3XfFiTh7J04Td2JPe14AGu1Sv/zOdW esgCwR+k48k8nFwrwgYTzP7sTXbfF6nHgrp1dvCutniWeC31v7pToDqWf5iUeqqaknC3 //Muh2IPZmH6fSRhtpsBFXtgjC4nE/9T+YV920UvxYEPapzRT1Tjro7OTkR+EMTtGjtS vEOMadp+6YuPtVwWjjDcPXcyh0z1wwWH52JbZBfye5sV0/VKgqe0foGCoBnAgCbVbsPI IbrSRx/+t10e0HfzM1bmi4yATddAjfV5DvONzUF/i32M8hU2Ku0nAC53lbnOWeWOey7I RFXA== X-Gm-Message-State: AOAM5330R4Gu6CQNiq+ti5bfZ3JD2ndld3n67NYJDOSFQpJeh7pdvpU7 qb0X2LPXf77n/ztPOC+4656VwayyfzoJnGRt9oI= X-Google-Smtp-Source: ABdhPJxBdmgJNCR88xlbXPGclNlO2GaIwRkfV+dyapGMbu4Q9RuUthOHvMqPP4yv8y1KdCvdCmqnj7BHtLVZZI62f64= X-Received: by 2002:a37:a50d:: with SMTP id o13mr4087174qke.121.1589973760794; Wed, 20 May 2020 04:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> In-Reply-To: <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> From: Shengjiu Wang Date: Wed, 20 May 2020 19:22:19 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Lucas Stach Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sumit.semwal@linaro.org, linaro-mm-sig@lists.linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, Shengjiu Wang , Takashi Iwai , Liam Girdwood , dri-devel@lists.freedesktop.org, perex@perex.cz, Nicolin Chen , Mark Brown , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wr= ote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements that we need to move the request > > > > of dma channel from probe to open. > > > > > > How do you handle -EPROBE_DEFER return code from the channel request = if > > > you don't do it in probe? > > > > I use the dma_request_slave_channel or dma_request_channel instead > > of dmaengine_pcm_request_chan_of. so there should be not -EPROBE_DEFER > > return code. > > This is a pretty weak argument. The dmaengine device might probe after > you try to get the channel. Using a function to request the channel > that doesn't allow you to handle probe deferral is IMHO a bug and > should be fixed, instead of building even more assumptions on top of > it. > I see some driver also request dma channel in open() or hw_params(). how can they avoid the defer probe issue? for example=EF=BC=9A sound/arm/pxa2xx-pcm-lib.c sound/soc/sprd/sprd-pcm-dma.c > > > > - When dma device binds with power-domains, the power will > > > > be enabled when we request dma channel. If the request of dma > > > > channel happen on probe, then the power-domains will be always > > > > enabled after kernel boot up, which is not good for power > > > > saving, so we need to move the request of dma channel to .open(); > > > > > > This is certainly something which could be fixed in the dmaengine > > > driver. > > > > Dma driver always call the pm_runtime_get_sync in > > device_alloc_chan_resources, the device_alloc_chan_resources is > > called when channel is requested. so power is enabled on channel > > request. > > So why can't you fix the dmaengine driver to do that RPM call at a > later time when the channel is actually going to be used? This will > allow further power savings with other slave devices than the audio > PCM. > > Regards, > Lucas > It seems the best place for calling pm_runtime_get_sync is the device_alloc_chan_resources, and calling pm_runtime_put_sync in the .device_free_chan_resources For the slave_sg mode, the .device_prep_slave_sg and .device_issue_pending will be called many times after .device_alloc_chan_resources. so it is not good to call pm_runtime_get_sync in .device_prep_slave_sg or .device_issue_pending best regards wang shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DF2C433E0 for ; Wed, 20 May 2020 11:22:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD2F3207F9 for ; Wed, 20 May 2020 11:22:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nK3fZo3S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzRhD8IV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD2F3207F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2co3GDE7rWPgz5jGUS/Dd4VTW1hlFKQMVIJtz+RHQNA=; b=nK3fZo3SL6gTWY YxwwYlt+lSMC/deIfmrisYBBt4uBQXsPXQHWIXhxJDLIal7clwKT283ayH6ByeO2EI9QUhNGrhkHo hFoXkK7OmR+2RDPKxR5nmT2W7LtWSO52dE5k5Nsc/YmJcrRb/wsAvn6QK9T9NWGF4juT85vU6BdvZ D/4ZUT0dEIzyUaSF40B2PB9Ya+JYq8T0cwipgVVMkCnIH0JjvRSb+w0aiRq5L7b4gcjH1uP6UF4JG pWLOpzJMWY81s/Rcwk162+8FVlX1CIbIwU8RoJj24O6iYyIRdi+GblJMmjWU5BWz3K91qv8FqjwYe fnEE/a6LAJG5zUtsQqGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbMo9-00042Y-9i; Wed, 20 May 2020 11:22:45 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbMo5-00041X-Pe for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 11:22:43 +0000 Received: by mail-qk1-x741.google.com with SMTP id f13so3142030qkh.2 for ; Wed, 20 May 2020 04:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=LzRhD8IVgnmIVQzzoYcQc9SGvryKW9AvjBv+5xt1U5TlXPqkgWZYhhLZ+fDOiIMJVE j8fn5+fABxBNdukYPVM+l0vF16UvWxzpEJBJLKCW56Z4DkC5xa0rvUGkgFzj9G0Agcbl CR4ePEwCrdO65XTKv1Q7qKPo1V5T2jQjs+MOPyTun845of6hg3kQqItmtboNDlREjJcu Z2pKrl+oLt5umJH0Z+pIMp+EXFb7tOaN6BDew0UWwQ+/7bg+moQfUGPSduuzZJPyI5/X 2YFdC3nAFQopV7V8BMDEMRy8CAn1JlcOebH4yDfMrImRBq3nMNW49Dcoe93t2TjTRQsi 5qvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=uP//lPCSiYpvN6pH0nSs5+vmHWMajzHGMdndBh9mp1oANNxpVAv8/DQPYUgxd/gWvV 2Li2mlUHx4ENggtAX8dGBWuhIh2eZ9k5iLRQDIm2K3bkdR8PwDV+sHA14Nr4LBtgRiHM m1AVyM8hCSO2XR2v0SYDUw58lMpyHq6JDb3WybaYJd1uOOAuyTzuo6FnF3oYie3pqoxm vpOmRmVY9aV+x3aqQmxv3q0+rplrvS44OzYpH60AWHEqBURxvESg2/FSyyBrH56Kwojg QZ6Gb0PVU4Sh4YkLhx5t3qWM91FCksw7O3uOxzm6nrF54TRaKviPTGEC75uuHyGg4Ja8 ZCZw== X-Gm-Message-State: AOAM531RS8nNAVfSUtbSyrAj4CNpfwditoOB3MKo/vg+77Kpuw6bbk/c NBU9nVcN1xWPNkIIp/AMS0xjmaDg08AYlZwa+uQ= X-Google-Smtp-Source: ABdhPJxBdmgJNCR88xlbXPGclNlO2GaIwRkfV+dyapGMbu4Q9RuUthOHvMqPP4yv8y1KdCvdCmqnj7BHtLVZZI62f64= X-Received: by 2002:a37:a50d:: with SMTP id o13mr4087174qke.121.1589973760794; Wed, 20 May 2020 04:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> In-Reply-To: <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> From: Shengjiu Wang Date: Wed, 20 May 2020 19:22:19 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Lucas Stach X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_042241_848821_1854AFC5 X-CRM114-Status: GOOD ( 23.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sumit.semwal@linaro.org, linaro-mm-sig@lists.linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, Shengjiu Wang , Takashi Iwai , Liam Girdwood , dri-devel@lists.freedesktop.org, perex@perex.cz, Nicolin Chen , Mark Brown , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkKCk9uIFdlZCwgTWF5IDIwLCAyMDIwIGF0IDU6NDIgUE0gTHVjYXMgU3RhY2ggPGwuc3RhY2hA cGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+Cj4gQW0gTWl0dHdvY2gsIGRlbiAyMC4wNS4yMDIwLCAx NjoyMCArMDgwMCBzY2hyaWViIFNoZW5naml1IFdhbmc6Cj4gPiBIaQo+ID4KPiA+IE9uIFR1ZSwg TWF5IDE5LCAyMDIwIGF0IDY6MDQgUE0gTHVjYXMgU3RhY2ggPGwuc3RhY2hAcGVuZ3V0cm9uaXgu ZGU+IHdyb3RlOgo+ID4gPiBBbSBEaWVuc3RhZywgZGVuIDE5LjA1LjIwMjAsIDE3OjQxICswODAw IHNjaHJpZWIgU2hlbmdqaXUgV2FuZzoKPiA+ID4gPiBUaGVyZSBhcmUgdHdvIHJlcXVpcmVtZW50 cyB0aGF0IHdlIG5lZWQgdG8gbW92ZSB0aGUgcmVxdWVzdAo+ID4gPiA+IG9mIGRtYSBjaGFubmVs IGZyb20gcHJvYmUgdG8gb3Blbi4KPiA+ID4KPiA+ID4gSG93IGRvIHlvdSBoYW5kbGUgLUVQUk9C RV9ERUZFUiByZXR1cm4gY29kZSBmcm9tIHRoZSBjaGFubmVsIHJlcXVlc3QgaWYKPiA+ID4geW91 IGRvbid0IGRvIGl0IGluIHByb2JlPwo+ID4KPiA+IEkgdXNlIHRoZSBkbWFfcmVxdWVzdF9zbGF2 ZV9jaGFubmVsIG9yIGRtYV9yZXF1ZXN0X2NoYW5uZWwgaW5zdGVhZAo+ID4gb2YgZG1hZW5naW5l X3BjbV9yZXF1ZXN0X2NoYW5fb2YuIHNvIHRoZXJlIHNob3VsZCBiZSBub3QgLUVQUk9CRV9ERUZF Ugo+ID4gcmV0dXJuIGNvZGUuCj4KPiBUaGlzIGlzIGEgcHJldHR5IHdlYWsgYXJndW1lbnQuIFRo ZSBkbWFlbmdpbmUgZGV2aWNlIG1pZ2h0IHByb2JlIGFmdGVyCj4geW91IHRyeSB0byBnZXQgdGhl IGNoYW5uZWwuIFVzaW5nIGEgZnVuY3Rpb24gdG8gcmVxdWVzdCB0aGUgY2hhbm5lbAo+IHRoYXQg ZG9lc24ndCBhbGxvdyB5b3UgdG8gaGFuZGxlIHByb2JlIGRlZmVycmFsIGlzIElNSE8gYSBidWcg YW5kCj4gc2hvdWxkIGJlIGZpeGVkLCBpbnN0ZWFkIG9mIGJ1aWxkaW5nIGV2ZW4gbW9yZSBhc3N1 bXB0aW9ucyBvbiB0b3Agb2YKPiBpdC4KPgoKSSBzZWUgc29tZSBkcml2ZXIgYWxzbyByZXF1ZXN0 IGRtYSBjaGFubmVsIGluIG9wZW4oKSBvciBod19wYXJhbXMoKS4KaG93IGNhbiB0aGV5IGF2b2lk IHRoZSBkZWZlciBwcm9iZSBpc3N1ZT8KZm9yIGV4YW1wbGXvvJoKc291bmQvYXJtL3B4YTJ4eC1w Y20tbGliLmMKc291bmQvc29jL3NwcmQvc3ByZC1wY20tZG1hLmMKCj4gPiA+ID4gLSBXaGVuIGRt YSBkZXZpY2UgYmluZHMgd2l0aCBwb3dlci1kb21haW5zLCB0aGUgcG93ZXIgd2lsbAo+ID4gPiA+ IGJlIGVuYWJsZWQgd2hlbiB3ZSByZXF1ZXN0IGRtYSBjaGFubmVsLiBJZiB0aGUgcmVxdWVzdCBv ZiBkbWEKPiA+ID4gPiBjaGFubmVsIGhhcHBlbiBvbiBwcm9iZSwgdGhlbiB0aGUgcG93ZXItZG9t YWlucyB3aWxsIGJlIGFsd2F5cwo+ID4gPiA+IGVuYWJsZWQgYWZ0ZXIga2VybmVsIGJvb3QgdXAs ICB3aGljaCBpcyBub3QgZ29vZCBmb3IgcG93ZXIKPiA+ID4gPiBzYXZpbmcsICBzbyB3ZSBuZWVk IHRvIG1vdmUgdGhlIHJlcXVlc3Qgb2YgZG1hIGNoYW5uZWwgdG8gLm9wZW4oKTsKPiA+ID4KPiA+ ID4gVGhpcyBpcyBjZXJ0YWlubHkgc29tZXRoaW5nIHdoaWNoIGNvdWxkIGJlIGZpeGVkIGluIHRo ZSBkbWFlbmdpbmUKPiA+ID4gZHJpdmVyLgo+ID4KPiA+IERtYSBkcml2ZXIgYWx3YXlzIGNhbGwg dGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMgaW4KPiA+IGRldmljZV9hbGxvY19jaGFuX3Jlc291cmNl cywgdGhlIGRldmljZV9hbGxvY19jaGFuX3Jlc291cmNlcyBpcwo+ID4gY2FsbGVkIHdoZW4gY2hh bm5lbCBpcyByZXF1ZXN0ZWQuIHNvIHBvd2VyIGlzIGVuYWJsZWQgb24gY2hhbm5lbAo+ID4gcmVx dWVzdC4KPgo+IFNvIHdoeSBjYW4ndCB5b3UgZml4IHRoZSBkbWFlbmdpbmUgZHJpdmVyIHRvIGRv IHRoYXQgUlBNIGNhbGwgYXQgYQo+IGxhdGVyIHRpbWUgd2hlbiB0aGUgY2hhbm5lbCBpcyBhY3R1 YWxseSBnb2luZyB0byBiZSB1c2VkPyBUaGlzIHdpbGwKPiBhbGxvdyBmdXJ0aGVyIHBvd2VyIHNh dmluZ3Mgd2l0aCBvdGhlciBzbGF2ZSBkZXZpY2VzIHRoYW4gdGhlIGF1ZGlvCj4gUENNLgo+Cj4g UmVnYXJkcywKPiBMdWNhcwo+CgpJdCBzZWVtcyB0aGUgYmVzdCBwbGFjZSBmb3IgY2FsbGluZyBw bV9ydW50aW1lX2dldF9zeW5jIGlzIHRoZQpkZXZpY2VfYWxsb2NfY2hhbl9yZXNvdXJjZXMsIGFu ZCBjYWxsaW5nIHBtX3J1bnRpbWVfcHV0X3N5bmMKaW4gdGhlIC5kZXZpY2VfZnJlZV9jaGFuX3Jl c291cmNlcwoKRm9yIHRoZSBzbGF2ZV9zZyBtb2RlLCB0aGUgLmRldmljZV9wcmVwX3NsYXZlX3Nn IGFuZAouZGV2aWNlX2lzc3VlX3BlbmRpbmcgIHdpbGwgYmUgY2FsbGVkIG1hbnkgdGltZXMgYWZ0 ZXIKLmRldmljZV9hbGxvY19jaGFuX3Jlc291cmNlcy4gc28gaXQgaXMgbm90IGdvb2QgdG8gY2Fs bApwbV9ydW50aW1lX2dldF9zeW5jIGluIC5kZXZpY2VfcHJlcF9zbGF2ZV9zZyBvcgouZGV2aWNl X2lzc3VlX3BlbmRpbmcKCmJlc3QgcmVnYXJkcwp3YW5nIHNoZW5naml1CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBAEC433DF for ; Fri, 22 May 2020 06:56:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 965782073B for ; Fri, 22 May 2020 06:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzRhD8IV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 965782073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43C946E34B; Fri, 22 May 2020 06:56:08 +0000 (UTC) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADE4B6E5D4 for ; Wed, 20 May 2020 11:22:41 +0000 (UTC) Received: by mail-qk1-x744.google.com with SMTP id n14so3078450qke.8 for ; Wed, 20 May 2020 04:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=LzRhD8IVgnmIVQzzoYcQc9SGvryKW9AvjBv+5xt1U5TlXPqkgWZYhhLZ+fDOiIMJVE j8fn5+fABxBNdukYPVM+l0vF16UvWxzpEJBJLKCW56Z4DkC5xa0rvUGkgFzj9G0Agcbl CR4ePEwCrdO65XTKv1Q7qKPo1V5T2jQjs+MOPyTun845of6hg3kQqItmtboNDlREjJcu Z2pKrl+oLt5umJH0Z+pIMp+EXFb7tOaN6BDew0UWwQ+/7bg+moQfUGPSduuzZJPyI5/X 2YFdC3nAFQopV7V8BMDEMRy8CAn1JlcOebH4yDfMrImRBq3nMNW49Dcoe93t2TjTRQsi 5qvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZjqVhvVauJwxzdubRCxzpwyDgNZsr/jK/zmF2UGqkm0=; b=s22FzT6bk0J4lD5aCgR73MB5Uo7xf3J8vraNMdTFtMo+JSjTCUVjs3uBXChm/I7ETx 6MVkK/Zq++5O0boZMGeNtHtzeEmjRIqSymySCf7yvb117iEAtHmhLz5MsgehzV3uqGuM KrphhJoEWyVIT8XbpsRowHiPZVs4uCHHPXLy7XdojMA5z9fEk7UEgwJLOzi2uaAgcwDE ST7MpQTz50KrHhN/UsIudal4k+I0wK5ArcOdzoQChea76C+ggpq0Yq2DRmocyRhPOpa8 YSuHePP/XfWsJ7f/WQYeTNoE0gF23EGZmlcS9Jyu6f8hpgVDOi4MzdErHc1+SH/+ysc3 SbLA== X-Gm-Message-State: AOAM532KIWEZsZvcm7NNMNpMRO+FUh6iyw64fw8wjPdsEORDkqW7iXIW jl5n9mYKnOC/g7GSWTU5neFoqvlCG1lBQICyrn8= X-Google-Smtp-Source: ABdhPJxBdmgJNCR88xlbXPGclNlO2GaIwRkfV+dyapGMbu4Q9RuUthOHvMqPP4yv8y1KdCvdCmqnj7BHtLVZZI62f64= X-Received: by 2002:a37:a50d:: with SMTP id o13mr4087174qke.121.1589973760794; Wed, 20 May 2020 04:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> In-Reply-To: <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> From: Shengjiu Wang Date: Wed, 20 May 2020 19:22:19 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Lucas Stach X-Mailman-Approved-At: Fri, 22 May 2020 06:56:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linaro-mm-sig@lists.linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, Shengjiu Wang , Takashi Iwai , Liam Girdwood , dri-devel@lists.freedesktop.org, perex@perex.cz, Nicolin Chen , Mark Brown , linux-imx@nxp.com, kernel@pengutronix.de, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkKCk9uIFdlZCwgTWF5IDIwLCAyMDIwIGF0IDU6NDIgUE0gTHVjYXMgU3RhY2ggPGwuc3RhY2hA cGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+Cj4gQW0gTWl0dHdvY2gsIGRlbiAyMC4wNS4yMDIwLCAx NjoyMCArMDgwMCBzY2hyaWViIFNoZW5naml1IFdhbmc6Cj4gPiBIaQo+ID4KPiA+IE9uIFR1ZSwg TWF5IDE5LCAyMDIwIGF0IDY6MDQgUE0gTHVjYXMgU3RhY2ggPGwuc3RhY2hAcGVuZ3V0cm9uaXgu ZGU+IHdyb3RlOgo+ID4gPiBBbSBEaWVuc3RhZywgZGVuIDE5LjA1LjIwMjAsIDE3OjQxICswODAw IHNjaHJpZWIgU2hlbmdqaXUgV2FuZzoKPiA+ID4gPiBUaGVyZSBhcmUgdHdvIHJlcXVpcmVtZW50 cyB0aGF0IHdlIG5lZWQgdG8gbW92ZSB0aGUgcmVxdWVzdAo+ID4gPiA+IG9mIGRtYSBjaGFubmVs IGZyb20gcHJvYmUgdG8gb3Blbi4KPiA+ID4KPiA+ID4gSG93IGRvIHlvdSBoYW5kbGUgLUVQUk9C RV9ERUZFUiByZXR1cm4gY29kZSBmcm9tIHRoZSBjaGFubmVsIHJlcXVlc3QgaWYKPiA+ID4geW91 IGRvbid0IGRvIGl0IGluIHByb2JlPwo+ID4KPiA+IEkgdXNlIHRoZSBkbWFfcmVxdWVzdF9zbGF2 ZV9jaGFubmVsIG9yIGRtYV9yZXF1ZXN0X2NoYW5uZWwgaW5zdGVhZAo+ID4gb2YgZG1hZW5naW5l X3BjbV9yZXF1ZXN0X2NoYW5fb2YuIHNvIHRoZXJlIHNob3VsZCBiZSBub3QgLUVQUk9CRV9ERUZF Ugo+ID4gcmV0dXJuIGNvZGUuCj4KPiBUaGlzIGlzIGEgcHJldHR5IHdlYWsgYXJndW1lbnQuIFRo ZSBkbWFlbmdpbmUgZGV2aWNlIG1pZ2h0IHByb2JlIGFmdGVyCj4geW91IHRyeSB0byBnZXQgdGhl IGNoYW5uZWwuIFVzaW5nIGEgZnVuY3Rpb24gdG8gcmVxdWVzdCB0aGUgY2hhbm5lbAo+IHRoYXQg ZG9lc24ndCBhbGxvdyB5b3UgdG8gaGFuZGxlIHByb2JlIGRlZmVycmFsIGlzIElNSE8gYSBidWcg YW5kCj4gc2hvdWxkIGJlIGZpeGVkLCBpbnN0ZWFkIG9mIGJ1aWxkaW5nIGV2ZW4gbW9yZSBhc3N1 bXB0aW9ucyBvbiB0b3Agb2YKPiBpdC4KPgoKSSBzZWUgc29tZSBkcml2ZXIgYWxzbyByZXF1ZXN0 IGRtYSBjaGFubmVsIGluIG9wZW4oKSBvciBod19wYXJhbXMoKS4KaG93IGNhbiB0aGV5IGF2b2lk IHRoZSBkZWZlciBwcm9iZSBpc3N1ZT8KZm9yIGV4YW1wbGXvvJoKc291bmQvYXJtL3B4YTJ4eC1w Y20tbGliLmMKc291bmQvc29jL3NwcmQvc3ByZC1wY20tZG1hLmMKCj4gPiA+ID4gLSBXaGVuIGRt YSBkZXZpY2UgYmluZHMgd2l0aCBwb3dlci1kb21haW5zLCB0aGUgcG93ZXIgd2lsbAo+ID4gPiA+ IGJlIGVuYWJsZWQgd2hlbiB3ZSByZXF1ZXN0IGRtYSBjaGFubmVsLiBJZiB0aGUgcmVxdWVzdCBv ZiBkbWEKPiA+ID4gPiBjaGFubmVsIGhhcHBlbiBvbiBwcm9iZSwgdGhlbiB0aGUgcG93ZXItZG9t YWlucyB3aWxsIGJlIGFsd2F5cwo+ID4gPiA+IGVuYWJsZWQgYWZ0ZXIga2VybmVsIGJvb3QgdXAs ICB3aGljaCBpcyBub3QgZ29vZCBmb3IgcG93ZXIKPiA+ID4gPiBzYXZpbmcsICBzbyB3ZSBuZWVk IHRvIG1vdmUgdGhlIHJlcXVlc3Qgb2YgZG1hIGNoYW5uZWwgdG8gLm9wZW4oKTsKPiA+ID4KPiA+ ID4gVGhpcyBpcyBjZXJ0YWlubHkgc29tZXRoaW5nIHdoaWNoIGNvdWxkIGJlIGZpeGVkIGluIHRo ZSBkbWFlbmdpbmUKPiA+ID4gZHJpdmVyLgo+ID4KPiA+IERtYSBkcml2ZXIgYWx3YXlzIGNhbGwg dGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMgaW4KPiA+IGRldmljZV9hbGxvY19jaGFuX3Jlc291cmNl cywgdGhlIGRldmljZV9hbGxvY19jaGFuX3Jlc291cmNlcyBpcwo+ID4gY2FsbGVkIHdoZW4gY2hh bm5lbCBpcyByZXF1ZXN0ZWQuIHNvIHBvd2VyIGlzIGVuYWJsZWQgb24gY2hhbm5lbAo+ID4gcmVx dWVzdC4KPgo+IFNvIHdoeSBjYW4ndCB5b3UgZml4IHRoZSBkbWFlbmdpbmUgZHJpdmVyIHRvIGRv IHRoYXQgUlBNIGNhbGwgYXQgYQo+IGxhdGVyIHRpbWUgd2hlbiB0aGUgY2hhbm5lbCBpcyBhY3R1 YWxseSBnb2luZyB0byBiZSB1c2VkPyBUaGlzIHdpbGwKPiBhbGxvdyBmdXJ0aGVyIHBvd2VyIHNh dmluZ3Mgd2l0aCBvdGhlciBzbGF2ZSBkZXZpY2VzIHRoYW4gdGhlIGF1ZGlvCj4gUENNLgo+Cj4g UmVnYXJkcywKPiBMdWNhcwo+CgpJdCBzZWVtcyB0aGUgYmVzdCBwbGFjZSBmb3IgY2FsbGluZyBw bV9ydW50aW1lX2dldF9zeW5jIGlzIHRoZQpkZXZpY2VfYWxsb2NfY2hhbl9yZXNvdXJjZXMsIGFu ZCBjYWxsaW5nIHBtX3J1bnRpbWVfcHV0X3N5bmMKaW4gdGhlIC5kZXZpY2VfZnJlZV9jaGFuX3Jl c291cmNlcwoKRm9yIHRoZSBzbGF2ZV9zZyBtb2RlLCB0aGUgLmRldmljZV9wcmVwX3NsYXZlX3Nn IGFuZAouZGV2aWNlX2lzc3VlX3BlbmRpbmcgIHdpbGwgYmUgY2FsbGVkIG1hbnkgdGltZXMgYWZ0 ZXIKLmRldmljZV9hbGxvY19jaGFuX3Jlc291cmNlcy4gc28gaXQgaXMgbm90IGdvb2QgdG8gY2Fs bApwbV9ydW50aW1lX2dldF9zeW5jIGluIC5kZXZpY2VfcHJlcF9zbGF2ZV9zZyBvcgouZGV2aWNl X2lzc3VlX3BlbmRpbmcKCmJlc3QgcmVnYXJkcwp3YW5nIHNoZW5naml1Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=