From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3821C433E6 for ; Fri, 12 Mar 2021 10:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BD186500F for ; Fri, 12 Mar 2021 10:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233903AbhCLK5d (ORCPT ); Fri, 12 Mar 2021 05:57:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233938AbhCLK5T (ORCPT ); Fri, 12 Mar 2021 05:57:19 -0500 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F5AC061574; Fri, 12 Mar 2021 02:57:19 -0800 (PST) Received: by mail-oi1-x22d.google.com with SMTP id o22so16677709oic.3; Fri, 12 Mar 2021 02:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Re/sVsmBKkgQS7T3jsEZ8uLYcWyloCgtQxS6quxCRa8=; b=WzR2cLUCq9W7AQs5i7c8ZW+dkW/V88JPEHTSLN+9/h1pReLWpshsk7raOvQ5KuQz0F rRcVEjIheaW8BVO5jffqGJs8vpPXJUGW2ZEayRd0UM8y/U3w6YlMIQRVHCOZt5z+7mHj SyENCSE0p+2Ku0PbJUNZGDSiDU8KFodVzEofoo3La0j4UarcrXiUbbwJAr1smp2vQRGM WPy7i8WaoPNLG+XXIcb1MKzjTmEqBKEmf6JZamBizEsiRKzlHScAwEJC1umHrbKwyHKq LkiDVUi9+qFssrZJeSfiBZt6lQCNlBKVRQxhOnJ5Y1CFxJcP+aUOjLmHk7qGEueGr6sI BIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Re/sVsmBKkgQS7T3jsEZ8uLYcWyloCgtQxS6quxCRa8=; b=O3Fmb3kWnw4me7dW2FtdWNw8raI8Yi3XTM0rDO0YFMmhtauJG1IioDJ2Z/s9JJeFjy HRR7G7YKXDbC1dDNO1ibSD6YarZt4Dnt360EvjFL+wDo1XmckAus7PcO4lTa8e0HBodD K/DbWZzP0NlUmsSZpMbhwx7M3ttjjPSN9odZZnQ+/5omIs8N/aYIianuQ8NZwqsjNWiz XhmVTNd6zz/PnDYStJS3yNgToBOtw7ps/7Az32Mn/lCzJ3xkB3UTOm76HmqQrCLbTFI4 PbkN8NAdkmDA4U+Dh3omTqcLyryi5tbLNkcvv8UmdKWgLOvFDGaTSN3KKa0gYyJP/S9x T/8w== X-Gm-Message-State: AOAM531Yy4Y01NO66KNutUgfGcjHlCApglMtfSm0kt6A4bNnCBKZnz2i O4ywT91/BfFqrejrsTmDfvyLC0I2sM5WDt3cMMM= X-Google-Smtp-Source: ABdhPJz5Ixj8gOwOqP8ZLI2mb/Jxa1pBK/7L/I1Crrz11Uqdate3gpI/2mWpDU7wlr7hRKBzXZpN11joAEEKXrte6nU= X-Received: by 2002:aca:ab86:: with SMTP id u128mr9636637oie.47.1615546638373; Fri, 12 Mar 2021 02:57:18 -0800 (PST) MIME-Version: 1.0 References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-8-git-send-email-aisheng.dong@nxp.com> <31be2267-8988-f162-f5a6-6e6389bbf1fb@samsung.com> In-Reply-To: From: Dong Aisheng Date: Fri, 12 Mar 2021 18:57:14 +0800 Message-ID: Subject: Re: [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor To: Chanwoo Choi Cc: Chanwoo Choi , Dong Aisheng , Linux PM , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Shawn Guo , dl-linux-imx , open list , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Abel Vesa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 11, 2021 at 2:54 PM Chanwoo Choi wrote: > > On 3/10/21 1:56 PM, Dong Aisheng wrote: > > On Wed, Mar 10, 2021 at 11:08 AM Chanwoo Choi w= rote: > >> > >> On 3/10/21 11:56 AM, Dong Aisheng wrote: > >>> On Wed, Mar 10, 2021 at 12:12 AM Chanwoo Choi wr= ote: > >>>> > >>>> On 21. 3. 10. =EC=98=A4=EC=A0=84 12:58, Chanwoo Choi wrote: > >>>>> On 21. 3. 9. =EC=98=A4=ED=9B=84 9:58, Dong Aisheng wrote: > >>>>>> The devfreq monitor depends on the device to provide load informat= ion > >>>>>> by .get_dev_status() to calculate the next target freq. > >>>>>> > >>>>>> And this will cause changing governor to simple ondemand fail > >>>>>> if device can't support. > >>>>>> > >>>>>> Signed-off-by: Dong Aisheng > >>>>>> --- > >>>>>> drivers/devfreq/devfreq.c | 10 +++++++--- > >>>>>> drivers/devfreq/governor.h | 2 +- > >>>>>> drivers/devfreq/governor_simpleondemand.c | 3 +-- > >>>>>> 3 files changed, 9 insertions(+), 6 deletions(-) > >>>>>> > >>>>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > >>>>>> index 7231fe6862a2..d1787b6c7d7c 100644 > >>>>>> --- a/drivers/devfreq/devfreq.c > >>>>>> +++ b/drivers/devfreq/devfreq.c > >>>>>> @@ -482,10 +482,13 @@ static void devfreq_monitor(struct work_stru= ct > >>>>>> *work) > >>>>>> * to be called from governor in response to DEVFREQ_GOV_START > >>>>>> * event when device is added to devfreq framework. > >>>>>> */ > >>>>>> -void devfreq_monitor_start(struct devfreq *devfreq) > >>>>>> +int devfreq_monitor_start(struct devfreq *devfreq) > >>>>>> { > >>>>>> if (IS_SUPPORTED_FLAG(devfreq->governor->flags, IRQ_DRIVEN)) > >>>>>> - return; > >>>>>> + return 0; > >>>>>> + > >>>>>> + if (!devfreq->profile->get_dev_status) > >>>>>> + return -EINVAL; > >>>> > >>>> Again, I think that get_dev_status is not used for all governors. > >>>> So that it cause the governor start fail. Don't check whether > >>>> .get_dev_status is NULL or not. > >>>> > >>> > >>> I'm not quite understand your point. > >>> it is used by governor_simpleondemand.c and tegra_devfreq_governor. > >>> get_target_freq -> devfreq_update_stats -> get_dev_status > >> > >> The devfreq can add the new governor by anyone. > >> So these functions like devfreq_monitor_* have to support > >> the governors and also must support the governor to be added > >> in the future. > > > > Yes, but devfreq_monitor_* is only used by polling mode, right? > > The governor using it has to implement get_dev_status unless > > there's an exception in the future. > > > > Currently this patch wants to address the issue that user can switch > > to ondemand governor (polling mode) by sysfs even devices does > > not support it (no get_dev_status implemented). > > As I commented, I'll fix this issue. If devfreq driver doesn't implement > the .get_dev_status, don't show it via available_governors. I think that > it is fundamental solution to fix this issue. Sounds good > So on this version, > don't add the this conditional statement on this function > Almost all this patch did is adding a checking for get_dev_status. So do you mean drop this patch? I wonder it's still a necessary checking to explicitly tell devfreq monitor users that get_dev_status is needed during governor startup. > And on next version, please use the capital letter for first character > on patch title as following: > > - PM / devfreq: Check get_dev_status before start monitor > Okay to me. Thanks for the suggestion. Regards Aisheng > > > > Regards > > Aisheng > > > >> > >>> > >>> Without checking, device can switch to ondemand governor if it does n= ot support. > >>> > >>> Am i missed something? > >>> > >>> Regards > >>> Aisheng > >>> > >>>>>> switch (devfreq->profile->timer) { > >>>>>> case DEVFREQ_TIMER_DEFERRABLE: > >>>>>> @@ -495,12 +498,13 @@ void devfreq_monitor_start(struct devfreq *d= evfreq) > >>>>>> INIT_DELAYED_WORK(&devfreq->work, devfreq_monitor); > >>>>>> break; > >>>>>> default: > >>>>>> - return; > >>>>>> + return -EINVAL; > >>>>>> } > >>>>>> if (devfreq->profile->polling_ms) > >>>>>> queue_delayed_work(devfreq_wq, &devfreq->work, > >>>>>> msecs_to_jiffies(devfreq->profile->polling_ms)); > >>>>>> + return 0; > >>>>>> } > >>>>>> EXPORT_SYMBOL(devfreq_monitor_start); > >>>>>> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor= .h > >>>>>> index 5cee3f64fe2b..31af6d072a10 100644 > >>>>>> --- a/drivers/devfreq/governor.h > >>>>>> +++ b/drivers/devfreq/governor.h > >>>>>> @@ -75,7 +75,7 @@ struct devfreq_governor { > >>>>>> unsigned int event, void *data); > >>>>>> }; > >>>>>> -void devfreq_monitor_start(struct devfreq *devfreq); > >>>>>> +int devfreq_monitor_start(struct devfreq *devfreq); > >>>>>> void devfreq_monitor_stop(struct devfreq *devfreq); > >>>>>> void devfreq_monitor_suspend(struct devfreq *devfreq); > >>>>>> void devfreq_monitor_resume(struct devfreq *devfreq); > >>>>>> diff --git a/drivers/devfreq/governor_simpleondemand.c > >>>>>> b/drivers/devfreq/governor_simpleondemand.c > >>>>>> index d57b82a2b570..ea287b57cbf3 100644 > >>>>>> --- a/drivers/devfreq/governor_simpleondemand.c > >>>>>> +++ b/drivers/devfreq/governor_simpleondemand.c > >>>>>> @@ -89,8 +89,7 @@ static int devfreq_simple_ondemand_handler(struc= t > >>>>>> devfreq *devfreq, > >>>>>> { > >>>>>> switch (event) { > >>>>>> case DEVFREQ_GOV_START: > >>>>>> - devfreq_monitor_start(devfreq); > >>>>>> - break; > >>>>>> + return devfreq_monitor_start(devfreq); > >>>>>> case DEVFREQ_GOV_STOP: > >>>>>> devfreq_monitor_stop(devfreq); > >>>>>> > >>>>> > >>>>> Need to handle the all points of devfreq_monitor_start() usage. > >>>>> please check the tegra30-devfreq.c for this update. > >>>>> > >>>>> $ grep -rn "devfreq_monitor_start" drivers/ > >>>>> drivers/devfreq/governor_simpleondemand.c:92: > >>>>> devfreq_monitor_start(devfreq); > >>>>> drivers/devfreq/tegra30-devfreq.c:744: > >>>>> devfreq_monitor_start(devfreq); > >>>>> ...... > >>>>> > >>>> > >>>> > >>>> -- > >>>> Best Regards, > >>>> Samsung Electronics > >>>> Chanwoo Choi > >>> > >>> > >> > >> > >> -- > >> Best Regards, > >> Chanwoo Choi > >> Samsung Electronics > > > > > > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8DCC433E0 for ; Fri, 12 Mar 2021 10:58:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6525564F23 for ; Fri, 12 Mar 2021 10:58:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6525564F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hdLMOIJHs6tKa6EnJPk7lpVRZ2Qr9KazrwZo1sDb0hc=; b=VUqg1tISFcL+WrXutm673ZUW/ pcoktil+fiHel3dELB1t32uYkwioVXzWmOSMXHHQ2nBxB8EpNSEs3bbrkMFuBcMCbegA2uaHHcBtX cUOInXVAXVOfsy/rRaNCvz9J8GopHyAvbmJaQPds5wX075pjyRSqYzoENhlzS2pqulvFCkhoXNmPx IW+ZI3RNyIWpABa4TjqRgeCT0QU1Ry/09KpAGJoEegmrP0cxCJt1IDWXG4eYKCLbAfbCZgBmxLBhq r1cY26TpJO6RlyaSz+kdt96/I+T5pUWjt25H/fagKFc52mH94rD2yWbK4foihpTc0w+Gi2FmTy79e WS5oq5SPw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKfTv-00BEFf-Tf; Fri, 12 Mar 2021 10:57:24 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKfTs-00BEEp-8Z for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 10:57:22 +0000 Received: by mail-oi1-x22e.google.com with SMTP id v192so18832770oia.5 for ; Fri, 12 Mar 2021 02:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Re/sVsmBKkgQS7T3jsEZ8uLYcWyloCgtQxS6quxCRa8=; b=WzR2cLUCq9W7AQs5i7c8ZW+dkW/V88JPEHTSLN+9/h1pReLWpshsk7raOvQ5KuQz0F rRcVEjIheaW8BVO5jffqGJs8vpPXJUGW2ZEayRd0UM8y/U3w6YlMIQRVHCOZt5z+7mHj SyENCSE0p+2Ku0PbJUNZGDSiDU8KFodVzEofoo3La0j4UarcrXiUbbwJAr1smp2vQRGM WPy7i8WaoPNLG+XXIcb1MKzjTmEqBKEmf6JZamBizEsiRKzlHScAwEJC1umHrbKwyHKq LkiDVUi9+qFssrZJeSfiBZt6lQCNlBKVRQxhOnJ5Y1CFxJcP+aUOjLmHk7qGEueGr6sI BIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Re/sVsmBKkgQS7T3jsEZ8uLYcWyloCgtQxS6quxCRa8=; b=boIt//J0XH8ootN8duPvAMtPPyG8mtAQ7YYMxqSfWeyw5qLf7qmvK1gbl/4OPxesZB +q4YPbuRlyZLQoQL9UyblTllPlSQTbRFfQs+21kgmIOkj05/69joiQonrYxahAXlmHMw QOPJkTsjEe1d2eZETIX9Suk7p3CVeN2QcNvCh1dEHj/XXIMNVZIyY7Wte6ozET0LLGS1 MhDFBjUDfgunUPRY4odZS70iJYO79wu2evmv5rTxEBBSQvx5r/yVuRhK1Dh0wRXcnnEs o59/gDqNQo9SEYFD8T0ejTbjbbX7EAW1ZmfOVgUKx9GTkOh0qkR9ae1ZWxS2C9lma/YM h7mg== X-Gm-Message-State: AOAM533AfH576GHu1RnTxQPTA8zGnNXesDwPkTpGZNjSi+jmMqy+vC5g AfovCbDEm170Y/6LPcO5VJ7dYFe1ircowsMoRzw= X-Google-Smtp-Source: ABdhPJz5Ixj8gOwOqP8ZLI2mb/Jxa1pBK/7L/I1Crrz11Uqdate3gpI/2mWpDU7wlr7hRKBzXZpN11joAEEKXrte6nU= X-Received: by 2002:aca:ab86:: with SMTP id u128mr9636637oie.47.1615546638373; Fri, 12 Mar 2021 02:57:18 -0800 (PST) MIME-Version: 1.0 References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-8-git-send-email-aisheng.dong@nxp.com> <31be2267-8988-f162-f5a6-6e6389bbf1fb@samsung.com> In-Reply-To: From: Dong Aisheng Date: Fri, 12 Mar 2021 18:57:14 +0800 Message-ID: Subject: Re: [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor To: Chanwoo Choi Cc: Chanwoo Choi , Dong Aisheng , Linux PM , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Shawn Guo , dl-linux-imx , open list , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Abel Vesa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_105720_394130_44C763BA X-CRM114-Status: GOOD ( 40.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMTEsIDIwMjEgYXQgMjo1NCBQTSBDaGFud29vIENob2kgPGN3MDAuY2hvaUBz YW1zdW5nLmNvbT4gd3JvdGU6Cj4KPiBPbiAzLzEwLzIxIDE6NTYgUE0sIERvbmcgQWlzaGVuZyB3 cm90ZToKPiA+IE9uIFdlZCwgTWFyIDEwLCAyMDIxIGF0IDExOjA4IEFNIENoYW53b28gQ2hvaSA8 Y3cwMC5jaG9pQHNhbXN1bmcuY29tPiB3cm90ZToKPiA+Pgo+ID4+IE9uIDMvMTAvMjEgMTE6NTYg QU0sIERvbmcgQWlzaGVuZyB3cm90ZToKPiA+Pj4gT24gV2VkLCBNYXIgMTAsIDIwMjEgYXQgMTI6 MTIgQU0gQ2hhbndvbyBDaG9pIDxjd2Nob2kwMEBnbWFpbC5jb20+IHdyb3RlOgo+ID4+Pj4KPiA+ Pj4+IE9uIDIxLiAzLiAxMC4g7Jik7KCEIDEyOjU4LCBDaGFud29vIENob2kgd3JvdGU6Cj4gPj4+ Pj4gT24gMjEuIDMuIDkuIOyYpO2bhCA5OjU4LCBEb25nIEFpc2hlbmcgd3JvdGU6Cj4gPj4+Pj4+ IFRoZSBkZXZmcmVxIG1vbml0b3IgZGVwZW5kcyBvbiB0aGUgZGV2aWNlIHRvIHByb3ZpZGUgbG9h ZCBpbmZvcm1hdGlvbgo+ID4+Pj4+PiBieSAuZ2V0X2Rldl9zdGF0dXMoKSB0byBjYWxjdWxhdGUg dGhlIG5leHQgdGFyZ2V0IGZyZXEuCj4gPj4+Pj4+Cj4gPj4+Pj4+IEFuZCB0aGlzIHdpbGwgY2F1 c2UgY2hhbmdpbmcgZ292ZXJub3IgdG8gc2ltcGxlIG9uZGVtYW5kIGZhaWwKPiA+Pj4+Pj4gaWYg ZGV2aWNlIGNhbid0IHN1cHBvcnQuCj4gPj4+Pj4+Cj4gPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IERv bmcgQWlzaGVuZyA8YWlzaGVuZy5kb25nQG54cC5jb20+Cj4gPj4+Pj4+IC0tLQo+ID4+Pj4+PiAg IGRyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMgICAgICAgICAgICAgICAgIHwgMTAgKysrKysrKy0t LQo+ID4+Pj4+PiAgIGRyaXZlcnMvZGV2ZnJlcS9nb3Zlcm5vci5oICAgICAgICAgICAgICAgIHwg IDIgKy0KPiA+Pj4+Pj4gICBkcml2ZXJzL2RldmZyZXEvZ292ZXJub3Jfc2ltcGxlb25kZW1hbmQu YyB8ICAzICstLQo+ID4+Pj4+PiAgIDMgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQo+ID4+Pj4+Pgo+ID4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kZXZm cmVxL2RldmZyZXEuYyBiL2RyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMKPiA+Pj4+Pj4gaW5kZXgg NzIzMWZlNjg2MmEyLi5kMTc4N2I2YzdkN2MgMTAwNjQ0Cj4gPj4+Pj4+IC0tLSBhL2RyaXZlcnMv ZGV2ZnJlcS9kZXZmcmVxLmMKPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy9kZXZmcmVxL2RldmZyZXEu Ywo+ID4+Pj4+PiBAQCAtNDgyLDEwICs0ODIsMTMgQEAgc3RhdGljIHZvaWQgZGV2ZnJlcV9tb25p dG9yKHN0cnVjdCB3b3JrX3N0cnVjdAo+ID4+Pj4+PiAqd29yaykKPiA+Pj4+Pj4gICAgKiB0byBi ZSBjYWxsZWQgZnJvbSBnb3Zlcm5vciBpbiByZXNwb25zZSB0byBERVZGUkVRX0dPVl9TVEFSVAo+ ID4+Pj4+PiAgICAqIGV2ZW50IHdoZW4gZGV2aWNlIGlzIGFkZGVkIHRvIGRldmZyZXEgZnJhbWV3 b3JrLgo+ID4+Pj4+PiAgICAqLwo+ID4+Pj4+PiAtdm9pZCBkZXZmcmVxX21vbml0b3Jfc3RhcnQo c3RydWN0IGRldmZyZXEgKmRldmZyZXEpCj4gPj4+Pj4+ICtpbnQgZGV2ZnJlcV9tb25pdG9yX3N0 YXJ0KHN0cnVjdCBkZXZmcmVxICpkZXZmcmVxKQo+ID4+Pj4+PiAgIHsKPiA+Pj4+Pj4gICAgICAg aWYgKElTX1NVUFBPUlRFRF9GTEFHKGRldmZyZXEtPmdvdmVybm9yLT5mbGFncywgSVJRX0RSSVZF TikpCj4gPj4+Pj4+IC0gICAgICAgIHJldHVybjsKPiA+Pj4+Pj4gKyAgICAgICAgcmV0dXJuIDA7 Cj4gPj4+Pj4+ICsKPiA+Pj4+Pj4gKyAgICBpZiAoIWRldmZyZXEtPnByb2ZpbGUtPmdldF9kZXZf c3RhdHVzKQo+ID4+Pj4+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+Pj4+Cj4gPj4+PiBB Z2FpbiwgSSB0aGluayB0aGF0IGdldF9kZXZfc3RhdHVzIGlzIG5vdCB1c2VkIGZvciBhbGwgZ292 ZXJub3JzLgo+ID4+Pj4gU28gdGhhdCBpdCBjYXVzZSB0aGUgZ292ZXJub3Igc3RhcnQgZmFpbC4g RG9uJ3QgY2hlY2sgd2hldGhlcgo+ID4+Pj4gLmdldF9kZXZfc3RhdHVzIGlzIE5VTEwgb3Igbm90 Lgo+ID4+Pj4KPiA+Pj4KPiA+Pj4gSSdtIG5vdCBxdWl0ZSB1bmRlcnN0YW5kIHlvdXIgcG9pbnQu Cj4gPj4+IGl0IGlzIHVzZWQgYnkgZ292ZXJub3Jfc2ltcGxlb25kZW1hbmQuYyBhbmQgdGVncmFf ZGV2ZnJlcV9nb3Zlcm5vci4KPiA+Pj4gZ2V0X3RhcmdldF9mcmVxIC0+IGRldmZyZXFfdXBkYXRl X3N0YXRzIC0+IGdldF9kZXZfc3RhdHVzCj4gPj4KPiA+PiBUaGUgZGV2ZnJlcSBjYW4gYWRkIHRo ZSBuZXcgZ292ZXJub3IgYnkgYW55b25lLgo+ID4+IFNvIHRoZXNlIGZ1bmN0aW9ucyBsaWtlIGRl dmZyZXFfbW9uaXRvcl8qIGhhdmUgdG8gc3VwcG9ydAo+ID4+IHRoZSBnb3Zlcm5vcnMgYW5kIGFs c28gbXVzdCBzdXBwb3J0IHRoZSBnb3Zlcm5vciB0byBiZSBhZGRlZAo+ID4+IGluIHRoZSBmdXR1 cmUuCj4gPgo+ID4gWWVzLCBidXQgZGV2ZnJlcV9tb25pdG9yXyogaXMgb25seSB1c2VkIGJ5IHBv bGxpbmcgbW9kZSwgcmlnaHQ/Cj4gPiBUaGUgZ292ZXJub3IgdXNpbmcgaXQgaGFzIHRvIGltcGxl bWVudCBnZXRfZGV2X3N0YXR1cyB1bmxlc3MKPiA+IHRoZXJlJ3MgYW4gZXhjZXB0aW9uIGluIHRo ZSBmdXR1cmUuCj4gPgo+ID4gQ3VycmVudGx5IHRoaXMgcGF0Y2ggd2FudHMgdG8gYWRkcmVzcyB0 aGUgaXNzdWUgdGhhdCB1c2VyIGNhbiBzd2l0Y2gKPiA+IHRvIG9uZGVtYW5kIGdvdmVybm9yIChw b2xsaW5nIG1vZGUpIGJ5IHN5c2ZzIGV2ZW4gZGV2aWNlcyBkb2VzCj4gPiBub3Qgc3VwcG9ydCBp dCAobm8gZ2V0X2Rldl9zdGF0dXMgaW1wbGVtZW50ZWQpLgo+Cj4gQXMgSSBjb21tZW50ZWQsIEkn bGwgZml4IHRoaXMgaXNzdWUuIElmIGRldmZyZXEgZHJpdmVyIGRvZXNuJ3QgaW1wbGVtZW50Cj4g dGhlIC5nZXRfZGV2X3N0YXR1cywgZG9uJ3Qgc2hvdyBpdCB2aWEgYXZhaWxhYmxlX2dvdmVybm9y cy4gSSB0aGluayB0aGF0Cj4gaXQgaXMgZnVuZGFtZW50YWwgc29sdXRpb24gdG8gZml4IHRoaXMg aXNzdWUuCgpTb3VuZHMgZ29vZAoKPiBTbyBvbiB0aGlzIHZlcnNpb24sCj4gZG9uJ3QgYWRkIHRo ZSB0aGlzIGNvbmRpdGlvbmFsIHN0YXRlbWVudCBvbiB0aGlzIGZ1bmN0aW9uCj4KCkFsbW9zdCBh bGwgdGhpcyBwYXRjaCBkaWQgaXMgYWRkaW5nIGEgY2hlY2tpbmcgZm9yIGdldF9kZXZfc3RhdHVz LgpTbyBkbyB5b3UgbWVhbiBkcm9wIHRoaXMgcGF0Y2g/Ckkgd29uZGVyIGl0J3Mgc3RpbGwgYSBu ZWNlc3NhcnkgY2hlY2tpbmcgdG8gZXhwbGljaXRseSB0ZWxsIGRldmZyZXEgbW9uaXRvcgp1c2Vy cyB0aGF0IGdldF9kZXZfc3RhdHVzIGlzIG5lZWRlZCBkdXJpbmcgZ292ZXJub3Igc3RhcnR1cC4K Cj4gQW5kIG9uIG5leHQgdmVyc2lvbiwgcGxlYXNlIHVzZSB0aGUgY2FwaXRhbCBsZXR0ZXIgZm9y IGZpcnN0IGNoYXJhY3Rlcgo+IG9uIHBhdGNoIHRpdGxlIGFzIGZvbGxvd2luZzoKPgo+IC0gUE0g LyBkZXZmcmVxOiBDaGVjayBnZXRfZGV2X3N0YXR1cyBiZWZvcmUgc3RhcnQgbW9uaXRvcgo+CgpP a2F5IHRvIG1lLgpUaGFua3MgZm9yIHRoZSBzdWdnZXN0aW9uLgoKUmVnYXJkcwpBaXNoZW5nCgo+ ID4KPiA+IFJlZ2FyZHMKPiA+IEFpc2hlbmcKPiA+Cj4gPj4KPiA+Pj4KPiA+Pj4gV2l0aG91dCBj aGVja2luZywgZGV2aWNlIGNhbiBzd2l0Y2ggdG8gb25kZW1hbmQgZ292ZXJub3IgaWYgaXQgZG9l cyBub3Qgc3VwcG9ydC4KPiA+Pj4KPiA+Pj4gQW0gaSBtaXNzZWQgc29tZXRoaW5nPwo+ID4+Pgo+ ID4+PiBSZWdhcmRzCj4gPj4+IEFpc2hlbmcKPiA+Pj4KPiA+Pj4+Pj4gICAgICAgc3dpdGNoIChk ZXZmcmVxLT5wcm9maWxlLT50aW1lcikgewo+ID4+Pj4+PiAgICAgICBjYXNlIERFVkZSRVFfVElN RVJfREVGRVJSQUJMRToKPiA+Pj4+Pj4gQEAgLTQ5NSwxMiArNDk4LDEzIEBAIHZvaWQgZGV2ZnJl cV9tb25pdG9yX3N0YXJ0KHN0cnVjdCBkZXZmcmVxICpkZXZmcmVxKQo+ID4+Pj4+PiAgICAgICAg ICAgSU5JVF9ERUxBWUVEX1dPUksoJmRldmZyZXEtPndvcmssIGRldmZyZXFfbW9uaXRvcik7Cj4g Pj4+Pj4+ICAgICAgICAgICBicmVhazsKPiA+Pj4+Pj4gICAgICAgZGVmYXVsdDoKPiA+Pj4+Pj4g LSAgICAgICAgcmV0dXJuOwo+ID4+Pj4+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+Pj4+ Pj4gICAgICAgfQo+ID4+Pj4+PiAgICAgICBpZiAoZGV2ZnJlcS0+cHJvZmlsZS0+cG9sbGluZ19t cykKPiA+Pj4+Pj4gICAgICAgICAgIHF1ZXVlX2RlbGF5ZWRfd29yayhkZXZmcmVxX3dxLCAmZGV2 ZnJlcS0+d29yaywKPiA+Pj4+Pj4gICAgICAgICAgICAgICBtc2Vjc190b19qaWZmaWVzKGRldmZy ZXEtPnByb2ZpbGUtPnBvbGxpbmdfbXMpKTsKPiA+Pj4+Pj4gKyAgICByZXR1cm4gMDsKPiA+Pj4+ Pj4gICB9Cj4gPj4+Pj4+ICAgRVhQT1JUX1NZTUJPTChkZXZmcmVxX21vbml0b3Jfc3RhcnQpOwo+ ID4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yLmggYi9kcml2ZXJz L2RldmZyZXEvZ292ZXJub3IuaAo+ID4+Pj4+PiBpbmRleCA1Y2VlM2Y2NGZlMmIuLjMxYWY2ZDA3 MmExMCAxMDA2NDQKPiA+Pj4+Pj4gLS0tIGEvZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yLmgKPiA+ Pj4+Pj4gKysrIGIvZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yLmgKPiA+Pj4+Pj4gQEAgLTc1LDcg Kzc1LDcgQEAgc3RydWN0IGRldmZyZXFfZ292ZXJub3Igewo+ID4+Pj4+PiAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZXZlbnQsIHZvaWQgKmRhdGEpOwo+ID4+Pj4+PiAgIH07Cj4gPj4+ Pj4+IC12b2lkIGRldmZyZXFfbW9uaXRvcl9zdGFydChzdHJ1Y3QgZGV2ZnJlcSAqZGV2ZnJlcSk7 Cj4gPj4+Pj4+ICtpbnQgZGV2ZnJlcV9tb25pdG9yX3N0YXJ0KHN0cnVjdCBkZXZmcmVxICpkZXZm cmVxKTsKPiA+Pj4+Pj4gICB2b2lkIGRldmZyZXFfbW9uaXRvcl9zdG9wKHN0cnVjdCBkZXZmcmVx ICpkZXZmcmVxKTsKPiA+Pj4+Pj4gICB2b2lkIGRldmZyZXFfbW9uaXRvcl9zdXNwZW5kKHN0cnVj dCBkZXZmcmVxICpkZXZmcmVxKTsKPiA+Pj4+Pj4gICB2b2lkIGRldmZyZXFfbW9uaXRvcl9yZXN1 bWUoc3RydWN0IGRldmZyZXEgKmRldmZyZXEpOwo+ID4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9kZXZmcmVxL2dvdmVybm9yX3NpbXBsZW9uZGVtYW5kLmMKPiA+Pj4+Pj4gYi9kcml2ZXJzL2Rl dmZyZXEvZ292ZXJub3Jfc2ltcGxlb25kZW1hbmQuYwo+ID4+Pj4+PiBpbmRleCBkNTdiODJhMmI1 NzAuLmVhMjg3YjU3Y2JmMyAxMDA2NDQKPiA+Pj4+Pj4gLS0tIGEvZHJpdmVycy9kZXZmcmVxL2dv dmVybm9yX3NpbXBsZW9uZGVtYW5kLmMKPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy9kZXZmcmVxL2dv dmVybm9yX3NpbXBsZW9uZGVtYW5kLmMKPiA+Pj4+Pj4gQEAgLTg5LDggKzg5LDcgQEAgc3RhdGlj IGludCBkZXZmcmVxX3NpbXBsZV9vbmRlbWFuZF9oYW5kbGVyKHN0cnVjdAo+ID4+Pj4+PiBkZXZm cmVxICpkZXZmcmVxLAo+ID4+Pj4+PiAgIHsKPiA+Pj4+Pj4gICAgICAgc3dpdGNoIChldmVudCkg ewo+ID4+Pj4+PiAgICAgICBjYXNlIERFVkZSRVFfR09WX1NUQVJUOgo+ID4+Pj4+PiAtICAgICAg ICBkZXZmcmVxX21vbml0b3Jfc3RhcnQoZGV2ZnJlcSk7Cj4gPj4+Pj4+IC0gICAgICAgIGJyZWFr Owo+ID4+Pj4+PiArICAgICAgICByZXR1cm4gZGV2ZnJlcV9tb25pdG9yX3N0YXJ0KGRldmZyZXEp Owo+ID4+Pj4+PiAgICAgICBjYXNlIERFVkZSRVFfR09WX1NUT1A6Cj4gPj4+Pj4+ICAgICAgICAg ICBkZXZmcmVxX21vbml0b3Jfc3RvcChkZXZmcmVxKTsKPiA+Pj4+Pj4KPiA+Pj4+Pgo+ID4+Pj4+ IE5lZWQgdG8gaGFuZGxlIHRoZSBhbGwgcG9pbnRzIG9mIGRldmZyZXFfbW9uaXRvcl9zdGFydCgp IHVzYWdlLgo+ID4+Pj4+IHBsZWFzZSBjaGVjayB0aGUgdGVncmEzMC1kZXZmcmVxLmMgZm9yIHRo aXMgdXBkYXRlLgo+ID4+Pj4+Cj4gPj4+Pj4gJCBncmVwIC1ybiAiZGV2ZnJlcV9tb25pdG9yX3N0 YXJ0IiBkcml2ZXJzLwo+ID4+Pj4+IGRyaXZlcnMvZGV2ZnJlcS9nb3Zlcm5vcl9zaW1wbGVvbmRl bWFuZC5jOjkyOgo+ID4+Pj4+IGRldmZyZXFfbW9uaXRvcl9zdGFydChkZXZmcmVxKTsKPiA+Pj4+ PiBkcml2ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmM6NzQ0Ogo+ID4+Pj4+IGRldmZyZXFf bW9uaXRvcl9zdGFydChkZXZmcmVxKTsKPiA+Pj4+PiAuLi4uLi4KPiA+Pj4+Pgo+ID4+Pj4KPiA+ Pj4+Cj4gPj4+PiAtLQo+ID4+Pj4gQmVzdCBSZWdhcmRzLAo+ID4+Pj4gU2Ftc3VuZyBFbGVjdHJv bmljcwo+ID4+Pj4gQ2hhbndvbyBDaG9pCj4gPj4+Cj4gPj4+Cj4gPj4KPiA+Pgo+ID4+IC0tCj4g Pj4gQmVzdCBSZWdhcmRzLAo+ID4+IENoYW53b28gQ2hvaQo+ID4+IFNhbXN1bmcgRWxlY3Ryb25p Y3MKPiA+Cj4gPgo+Cj4KPiAtLQo+IEJlc3QgUmVnYXJkcywKPiBDaGFud29vIENob2kKPiBTYW1z dW5nIEVsZWN0cm9uaWNzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==