From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F23BC433E6 for ; Tue, 9 Mar 2021 15:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 283BF6528C for ; Tue, 9 Mar 2021 15:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231825AbhCIPPI (ORCPT ); Tue, 9 Mar 2021 10:15:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231239AbhCIPOk (ORCPT ); Tue, 9 Mar 2021 10:14:40 -0500 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8708DC06174A; Tue, 9 Mar 2021 07:14:40 -0800 (PST) Received: by mail-ot1-x32f.google.com with SMTP id t16so13115464ott.3; Tue, 09 Mar 2021 07:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CoPe10wguFXwv3/ydJS6p2Kjhu16+mc1rW6ZkeWWHc8=; b=ItAedlJzt/oJL4OJXf668TlbTxtv36IlRzlJcF3Q6nUZwFrWZX5RtaAIXJWv/0BqEq /XinWTOkkcHCkJoddzmcnj890fg/l9Y2WICSCMA32pi4ho+toMkEdpriF+2GIKH2V6TX noi6P7w7a3Z27pw4wz7w/90aqp/bMcb0saKtAp1pI4a4rkmYxVl8lxowZ0XWMePVu/a8 gsgcCumom6KlJkTMppMwjLYJS6UZcCnfKkFniXHgdAMBnxiCELBtZCo1YCG/HpuR84hf oDSKhBvYgwQv215FUoOQo+0HGZRTSWp5SuFF7zWDjushFgRLc0KdTLne51IyCJTw2A+n W75w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CoPe10wguFXwv3/ydJS6p2Kjhu16+mc1rW6ZkeWWHc8=; b=CpQHgo5a45GbxBQ2hgRlhNrvR+4KYmdaIhiwc4GQGGyxczugFHTJ4qt7IUeqyzLu9c /Nx51ybn2au1Vnf39V7P+WoZZMsfysBiq0cyfgi5FXkXFOKrZahhIoXtTFYkvnDt1aGI ukf8IOErr68kIpuKGlt3PGFInR9TB4iHLJvQZD+w3KBu2iWWp/Nbbr/c+tEqkCD5cO/7 h2W1mnv4qLSfdxm2nBlZRcTNnUqh+UJQvBgk1EQudbR0cUfZJeT/GeSNHjGtLZcX5qj7 Wmoir16i6zG+WfThu/bh+3RAiMDRju3jHNyayCv9eEziNtTg0uerHsmY99MgefNP8D3N Wdbg== X-Gm-Message-State: AOAM530Oa/m8+kuF5lSoJy0sgjRwdXaNUAdUZP1fO07B7dco++eZp1ar Ux3mWdNJqkM8dEyLyGVODcyHMp3yNq8zxqCwvAU= X-Google-Smtp-Source: ABdhPJz/9WEWu5Vn12lWGJUpod4XmOCfX9tjjMYE/Ae1aVmqOJnlj0VdR1lBTPvsjnBDPEdQB8GpZarKdRjlpykxyR4= X-Received: by 2002:a9d:62d1:: with SMTP id z17mr9233998otk.118.1615302879997; Tue, 09 Mar 2021 07:14:39 -0800 (PST) MIME-Version: 1.0 References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-3-git-send-email-aisheng.dong@nxp.com> In-Reply-To: From: Dong Aisheng Date: Tue, 9 Mar 2021 23:14:39 +0800 Message-ID: Subject: Re: [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq To: Chanwoo Choi Cc: Dong Aisheng , Linux PM , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Shawn Guo , dl-linux-imx , open list , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Chanwoo Choi , Abel Vesa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 11:02 PM Chanwoo Choi wrote: > > On 21. 3. 9. =EC=98=A4=ED=9B=84 9:58, Dong Aisheng wrote: > > First of all, no_central_polling was removed since > > commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices > > which can idle") > > Secondly, get_target_freq() is not only called only with update_devfreq= () > > notified by OPP now, but also min/max freq qos notifier. > > > > So remove this invalid description now to avoid confusing. > > > > Signed-off-by: Dong Aisheng > > --- > > drivers/devfreq/governor.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h > > index 70f44b3ca42e..5cee3f64fe2b 100644 > > --- a/drivers/devfreq/governor.h > > +++ b/drivers/devfreq/governor.h > > @@ -57,8 +57,6 @@ > > * Basically, get_target_freq will run > > * devfreq_dev_profile.get_dev_status() to get the > > * status of the device (load =3D busy_time / total_= time). > > - * If no_central_polling is set, this callback is ca= lled > > - * only with update_devfreq() notified by OPP. > > * @event_handler: Callback for devfreq core framework to notify= events > > * to governors. Events include per device gover= nor > > * init and exit, opp changes out of devfreq, su= spend > > > > As I replied from patch1, I recommend that squash it with patch1. Got it, i will squash when sending the next version. Thanks Regards Aisheng > > -- > Best Regards, > Samsung Electronics > Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDEA6C433E0 for ; Tue, 9 Mar 2021 15:16:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 578226526E for ; Tue, 9 Mar 2021 15:16:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578226526E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BmPU83imFCsFvgIg5JvyDxwxOa7Lii1ZVmL8gIw4dP4=; b=O8uKUvwk1gEvI22xoM/og3jq3 zQOG+GkEHVVybcGdX83Sy1aYv3Bw9W6D4661KI2HAzT7I49NTg+oYliaY5mPxmnTQktsh9spvZ9N3 yiVsh+kTZETEnYa3I9a48yGPvp2UoZXolO29niamDIhtdUf9TaF83A2qEqn9tehPvKGxxqU3Atsuk P8aPPsckrHFOTJQTWXdC2qPuIPTI4X1bDWRIsoCkYOzSYq5kJkitJWjO3FFyXjDzMxGe9TuJV6RRi aUy5H6rwoZSjTo7Jub51C2bw6ppJ3TckAkVcjtcNfUgO/yj1K10F69eD+AXLWeaVHEvrS+CirkUhP h/TrVjomA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJe4M-004vwb-IL; Tue, 09 Mar 2021 15:14:47 +0000 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJe4H-004vvA-OR for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 15:14:43 +0000 Received: by mail-ot1-x32a.google.com with SMTP id j8so13161563otc.0 for ; Tue, 09 Mar 2021 07:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CoPe10wguFXwv3/ydJS6p2Kjhu16+mc1rW6ZkeWWHc8=; b=ItAedlJzt/oJL4OJXf668TlbTxtv36IlRzlJcF3Q6nUZwFrWZX5RtaAIXJWv/0BqEq /XinWTOkkcHCkJoddzmcnj890fg/l9Y2WICSCMA32pi4ho+toMkEdpriF+2GIKH2V6TX noi6P7w7a3Z27pw4wz7w/90aqp/bMcb0saKtAp1pI4a4rkmYxVl8lxowZ0XWMePVu/a8 gsgcCumom6KlJkTMppMwjLYJS6UZcCnfKkFniXHgdAMBnxiCELBtZCo1YCG/HpuR84hf oDSKhBvYgwQv215FUoOQo+0HGZRTSWp5SuFF7zWDjushFgRLc0KdTLne51IyCJTw2A+n W75w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CoPe10wguFXwv3/ydJS6p2Kjhu16+mc1rW6ZkeWWHc8=; b=XdhubBPvP3NPq6wf1hZ96D8dACMJcbWYTICGk+rQslPIihqq70Jw2zUkJoPhBxvidt njLK+PIHj6TDeyDl/mTxnDcjM6g3SePcIaSzfAy3x/9ipqpTPd0Nawu3YTDotLCFl9Uo 7wvDH6P6nKll3zWZ5dM0kfr02a9EbyA1oA14XGL/4ett79HcA0DxjEBOs4CPDgBItQBd is5CH3TEM/S6JPn31xzq7BGEAnddfVQV5G/+LKF5qf2od3+PM+waGvuCIvmGl/nsifzQ B75yjnZVfFQZLFyUUBP3+Tzt0dE9N6rkKe2e3TDdgbM69lgPYHZ7fhlyFJ7gOAsjvkcA Qwdg== X-Gm-Message-State: AOAM5317OXv2YNEHwkxcpVu9OZe+8WDNMBEmoT/pMkDlXqEFeO/LEAui MhKePDsZj7EuLWHiK+JSNhvx59NgyjIz5Sl8dI8= X-Google-Smtp-Source: ABdhPJz/9WEWu5Vn12lWGJUpod4XmOCfX9tjjMYE/Ae1aVmqOJnlj0VdR1lBTPvsjnBDPEdQB8GpZarKdRjlpykxyR4= X-Received: by 2002:a9d:62d1:: with SMTP id z17mr9233998otk.118.1615302879997; Tue, 09 Mar 2021 07:14:39 -0800 (PST) MIME-Version: 1.0 References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-3-git-send-email-aisheng.dong@nxp.com> In-Reply-To: From: Dong Aisheng Date: Tue, 9 Mar 2021 23:14:39 +0800 Message-ID: Subject: Re: [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq To: Chanwoo Choi Cc: Dong Aisheng , Linux PM , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Shawn Guo , dl-linux-imx , open list , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Chanwoo Choi , Abel Vesa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_151441_913109_B1303FA6 X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXIgOSwgMjAyMSBhdCAxMTowMiBQTSBDaGFud29vIENob2kgPGN3Y2hvaTAwQGdt YWlsLmNvbT4gd3JvdGU6Cj4KPiBPbiAyMS4gMy4gOS4g7Jik7ZuEIDk6NTgsIERvbmcgQWlzaGVu ZyB3cm90ZToKPiA+IEZpcnN0IG9mIGFsbCwgbm9fY2VudHJhbF9wb2xsaW5nIHdhcyByZW1vdmVk IHNpbmNlCj4gPiBjb21taXQgN2U2ZmRkNGJhZDAzICgiUE0gLyBkZXZmcmVxOiBDb3JlIHVwZGF0 ZXMgdG8gc3VwcG9ydCBkZXZpY2VzCj4gPiB3aGljaCBjYW4gaWRsZSIpCj4gPiBTZWNvbmRseSwg Z2V0X3RhcmdldF9mcmVxKCkgaXMgbm90IG9ubHkgY2FsbGVkIG9ubHkgd2l0aCB1cGRhdGVfZGV2 ZnJlcSgpCj4gPiBub3RpZmllZCBieSBPUFAgbm93LCBidXQgYWxzbyBtaW4vbWF4IGZyZXEgcW9z IG5vdGlmaWVyLgo+ID4KPiA+IFNvIHJlbW92ZSB0aGlzIGludmFsaWQgZGVzY3JpcHRpb24gbm93 IHRvIGF2b2lkIGNvbmZ1c2luZy4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEb25nIEFpc2hlbmcg PGFpc2hlbmcuZG9uZ0BueHAuY29tPgo+ID4gLS0tCj4gPiAgIGRyaXZlcnMvZGV2ZnJlcS9nb3Zl cm5vci5oIHwgMiAtLQo+ID4gICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkKPiA+Cj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yLmggYi9kcml2ZXJzL2RldmZy ZXEvZ292ZXJub3IuaAo+ID4gaW5kZXggNzBmNDRiM2NhNDJlLi41Y2VlM2Y2NGZlMmIgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2RldmZyZXEvZ292ZXJub3IuaAo+ID4gKysrIGIvZHJpdmVycy9k ZXZmcmVxL2dvdmVybm9yLmgKPiA+IEBAIC01Nyw4ICs1Nyw2IEBACj4gPiAgICAqICAgICAgICAg ICAgICAgICAgQmFzaWNhbGx5LCBnZXRfdGFyZ2V0X2ZyZXEgd2lsbCBydW4KPiA+ICAgICogICAg ICAgICAgICAgICAgICBkZXZmcmVxX2Rldl9wcm9maWxlLmdldF9kZXZfc3RhdHVzKCkgdG8gZ2V0 IHRoZQo+ID4gICAgKiAgICAgICAgICAgICAgICAgIHN0YXR1cyBvZiB0aGUgZGV2aWNlIChsb2Fk ID0gYnVzeV90aW1lIC8gdG90YWxfdGltZSkuCj4gPiAtICogICAgICAgICAgICAgICAgICAgSWYg bm9fY2VudHJhbF9wb2xsaW5nIGlzIHNldCwgdGhpcyBjYWxsYmFjayBpcyBjYWxsZWQKPiA+IC0g KiAgICAgICAgICAgICAgICAgICBvbmx5IHdpdGggdXBkYXRlX2RldmZyZXEoKSBub3RpZmllZCBi eSBPUFAuCj4gPiAgICAqIEBldmVudF9oYW5kbGVyOiAgICAgIENhbGxiYWNrIGZvciBkZXZmcmVx IGNvcmUgZnJhbWV3b3JrIHRvIG5vdGlmeSBldmVudHMKPiA+ICAgICogICAgICAgICAgICAgICAg ICAgICAgdG8gZ292ZXJub3JzLiBFdmVudHMgaW5jbHVkZSBwZXIgZGV2aWNlIGdvdmVybm9yCj4g PiAgICAqICAgICAgICAgICAgICAgICAgICAgIGluaXQgYW5kIGV4aXQsIG9wcCBjaGFuZ2VzIG91 dCBvZiBkZXZmcmVxLCBzdXNwZW5kCj4gPgo+Cj4gQXMgSSByZXBsaWVkIGZyb20gcGF0Y2gxLCBJ IHJlY29tbWVuZCB0aGF0IHNxdWFzaCBpdCB3aXRoIHBhdGNoMS4KCkdvdCBpdCwgaSB3aWxsIHNx dWFzaCB3aGVuIHNlbmRpbmcgdGhlIG5leHQgdmVyc2lvbi4KVGhhbmtzCgpSZWdhcmRzCkFpc2hl bmcKCj4KPiAtLQo+IEJlc3QgUmVnYXJkcywKPiBTYW1zdW5nIEVsZWN0cm9uaWNzCj4gQ2hhbndv byBDaG9pCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==