From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbdDLQLi (ORCPT ); Wed, 12 Apr 2017 12:11:38 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:35354 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753458AbdDLQLg (ORCPT ); Wed, 12 Apr 2017 12:11:36 -0400 MIME-Version: 1.0 In-Reply-To: <20170412154909.hhv3kexadbqsekkr@sirena.org.uk> References: <1491962327-12477-1-git-send-email-aisheng.dong@nxp.com> <1491962327-12477-6-git-send-email-aisheng.dong@nxp.com> <20170411204003.avoe5a6o52kx5on2@sirena.org.uk> <20170413074103.GC23163@b29396-OptiPlex-7040> <20170412154909.hhv3kexadbqsekkr@sirena.org.uk> From: Dong Aisheng Date: Thu, 13 Apr 2017 00:11:35 +0800 Message-ID: Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie To: Mark Brown Cc: Dong Aisheng , "linux-kernel@vger.kernel.org" , Shawn Guo , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , Liam Girdwood , yibin.gong@nxp.com, Richard Zhu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 11:49 PM, Mark Brown wrote: > On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote: >> On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > >> > Why is this the only anatop regulator which can have this problem and >> > how do we know this is a good value? > >> Anatop regulator has no separate gate bit. >> e.g. >> 00000 Power gated off >> 00001 Target core voltage = 0.725V >> ... >> So it may have no valid default voltage in case it's disabled in >> bootloader. >> e.g. regulator_enable() may not work. > > That doesn't answer my question. What I'm asking is why another anatop > regulator might not end up disabled like this one. > Well, that's true and i once thought of it. Currently it is probably a quick fix and we did not see any others up till now for all MX6&7 platforms based on NXP internal tree. If we do see it in the future, then probably a better solution is constructing a staticly defined default voltage table in anatop driver and do dynamically check. >> The default voltage 1.100v this patch sets is defined in reference >> manual. > > For the SoC you're currently looking at... might another have a > different value? No, only MX6SX has it currently. Regards Dong Aisheng From mboxrd@z Thu Jan 1 00:00:00 1970 From: dongas86@gmail.com (Dong Aisheng) Date: Thu, 13 Apr 2017 00:11:35 +0800 Subject: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie In-Reply-To: <20170412154909.hhv3kexadbqsekkr@sirena.org.uk> References: <1491962327-12477-1-git-send-email-aisheng.dong@nxp.com> <1491962327-12477-6-git-send-email-aisheng.dong@nxp.com> <20170411204003.avoe5a6o52kx5on2@sirena.org.uk> <20170413074103.GC23163@b29396-OptiPlex-7040> <20170412154909.hhv3kexadbqsekkr@sirena.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Apr 12, 2017 at 11:49 PM, Mark Brown wrote: > On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote: >> On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > >> > Why is this the only anatop regulator which can have this problem and >> > how do we know this is a good value? > >> Anatop regulator has no separate gate bit. >> e.g. >> 00000 Power gated off >> 00001 Target core voltage = 0.725V >> ... >> So it may have no valid default voltage in case it's disabled in >> bootloader. >> e.g. regulator_enable() may not work. > > That doesn't answer my question. What I'm asking is why another anatop > regulator might not end up disabled like this one. > Well, that's true and i once thought of it. Currently it is probably a quick fix and we did not see any others up till now for all MX6&7 platforms based on NXP internal tree. If we do see it in the future, then probably a better solution is constructing a staticly defined default voltage table in anatop driver and do dynamically check. >> The default voltage 1.100v this patch sets is defined in reference >> manual. > > For the SoC you're currently looking at... might another have a > different value? No, only MX6SX has it currently. Regards Dong Aisheng