From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFBCC433E6 for ; Wed, 10 Mar 2021 03:05:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C69E864FF4 for ; Wed, 10 Mar 2021 03:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232270AbhCJDEb (ORCPT ); Tue, 9 Mar 2021 22:04:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbhCJDE3 (ORCPT ); Tue, 9 Mar 2021 22:04:29 -0500 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07A4EC06174A; Tue, 9 Mar 2021 19:04:29 -0800 (PST) Received: by mail-ot1-x32f.google.com with SMTP id e45so14992035ote.9; Tue, 09 Mar 2021 19:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RlvYSlMGFakV6EZ71l2kmuNwcjNHwB/5cpbhUPGNlFo=; b=Ymhm6AGbF73/NtXz6qjQa7Nq6KQ1El27u5C9zQpjjFTtgnewFCaPulP7KpFhte+OnR +Bk1SUlKBn1T7dKylK81LuAJuxSdAmjcd4bIaFDcvi4r8xwhZ4094wF5CHXkm2adngzY jZv1BwB1SUhcoWpGQ3VI0H1Y94u/wY7hs3Q/VTDnv5LeiQ4pch2olyJqZ9fl7nJo85G0 4HIRUOKr3cwTgUJSi1OtVDoS+lD2vm8VFS+BEsGMqnStS55K7BFRvn0H53MkQdnsrjWO IYQvEoFclHOBpzUhOBgZHZqxnxsXhNnAvmSYNYCEVC6qcE073GjRmROOy4vd0IHvh3rG EmnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RlvYSlMGFakV6EZ71l2kmuNwcjNHwB/5cpbhUPGNlFo=; b=uXc0qvZ96UN2huysVjvditdqZO6+R1IF8xpvVP/owF1asJwGnC1hT8IQuMdZ1sPwcs v2ZkLdYzjfgF4HEBlrbaRdhQTkA78fNsEgkPpGyHAileGIEXDvdaDfc5Bj+POlEVu1Xs Y8/sqNaY9F9EwnLPnrc7BF1nM/nQa7kQbuvfhoYm+Rv3gRaQCGsEfWppORi0TIu5ZPAN CHw7884T8qoB+LTSue7lZdHRzHe7CIo52wzSNGLm1brR+JzzuPtXwS8lZmN1Rkroweux E0j9E0fSDcoxfGWCIAlKs7R432vnoeoIYea2MzVlMN1tOSq2/w+/v0SMnlQ9wLPuYTPO Bpcw== X-Gm-Message-State: AOAM533FAqC1qO9HClgLWP3c8pIt568tfmNTMGRaF8XjmAR/OtM/XqAu wMgPbzycTjcibMEQUygf9RYr01VXTVLFaCwejoI= X-Google-Smtp-Source: ABdhPJwL0ArhZYYUkwkBR9P+n5Fba1TwhZrF/S2JuQ+llk3dsIR7GBNc6wPV4sBRlA3kJsIFUBmGw/Np7Sw3Ya2O7e4= X-Received: by 2002:a05:6830:408a:: with SMTP id x10mr1040106ott.248.1615345468504; Tue, 09 Mar 2021 19:04:28 -0800 (PST) MIME-Version: 1.0 References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-6-git-send-email-aisheng.dong@nxp.com> <83240e9d-383a-74a9-3222-68cf42d3d0e1@gmail.com> In-Reply-To: From: Dong Aisheng Date: Wed, 10 Mar 2021 11:04:27 +0800 Message-ID: Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq To: Chanwoo Choi Cc: Chanwoo Choi , Dong Aisheng , Linux PM , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Shawn Guo , dl-linux-imx , open list , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Abel Vesa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 10:50 AM Chanwoo Choi wrote= : > > On 3/10/21 11:43 AM, Dong Aisheng wrote: > > On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi wrote= : > >> > >> On 21. 3. 9. =EC=98=A4=ED=9B=84 9:58, Dong Aisheng wrote: > >>> Use the more accurate returned new_freq as resume_freq. > >>> It's the same as how devfreq->previous_freq was updated. > >>> > >>> Signed-off-by: Dong Aisheng > >>> --- > >>> drivers/devfreq/devfreq.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > >>> index 6e80bf70e7b3..ce569bd9adfa 100644 > >>> --- a/drivers/devfreq/devfreq.c > >>> +++ b/drivers/devfreq/devfreq.c > >>> @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *dev= freq, unsigned long new_freq, > >>> devfreq->previous_freq =3D new_freq; > >>> > >>> if (devfreq->suspend_freq) > >>> - devfreq->resume_freq =3D cur_freq; > >>> + devfreq->resume_freq =3D new_freq; > >>> > >>> return err; > >>> } > >>> > >> > >> This patch fixes the previous patch[1]. So that you need to > >> add 'Fixes' tag as following: > >> > >> Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of= a > >> devfreq device") > >> > > > > Will add Fixes tag in next version. > > > On next version, recommend to place this patch at the first. Yes, good practice as it's a fix. Regards Aisheng > > > > >> commit 83f8ca45afbf041e312909f442128b99657d90b7 > >> Refs: v4.20-rc6-2-g83f8ca45afbf > >> Author: Lukasz Luba > >> AuthorDate: Wed Dec 5 12:05:53 2018 +0100 > >> Commit: MyungJoo Ham > >> CommitDate: Tue Dec 11 11:09:47 2018 +0900 > >> > >> PM / devfreq: add support for suspend/resume of a devfreq device > >> > >> > >> -- > >> Best Regards, > >> Samsung Electronics > >> Chanwoo Choi > > > > > > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B38C433E6 for ; Wed, 10 Mar 2021 03:07:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A05DE64FE8 for ; Wed, 10 Mar 2021 03:07:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A05DE64FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vo1ChWJeVD3+4N/jpaGXi64aKhWeoeeQdULJ75rM6Zs=; b=cCZa/3VDubKV4ZaOSRVrFnHi3 G2kPwZ9cas8sa9fNwEfhSmhwTp8S47R5HlOJAZvdsK4rIQ2Sx677LUGISt5RTy21Yz/cPz5iVz3yw QhWMDOepODjdVtJ+ABk6F3nyqpLfp1Tmsu4V6sVXAKzTHkjXKicgBqpVkK1a9X39DmmKF/ozuJHWi HkPxxuPt4A2AO4yjmsSUBWCr7jRpbwDFLGTUWgLXl0mMhvXo1zpkUwp5w4nom/SjMs79CG2I49UBi kNxJd+rI/k8NGtWeYfONecxNCANiFz3zIcuYN+UwjiK0ul4lle/FEU7hbWJ0qXRtpmXbzjlXMFOnG piBH7+92Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJp9T-005s4H-9B; Wed, 10 Mar 2021 03:04:52 +0000 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJp9C-005ry9-01 for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 03:04:39 +0000 Received: by mail-ot1-x32c.google.com with SMTP id r24so7926098otq.13 for ; Tue, 09 Mar 2021 19:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RlvYSlMGFakV6EZ71l2kmuNwcjNHwB/5cpbhUPGNlFo=; b=Ymhm6AGbF73/NtXz6qjQa7Nq6KQ1El27u5C9zQpjjFTtgnewFCaPulP7KpFhte+OnR +Bk1SUlKBn1T7dKylK81LuAJuxSdAmjcd4bIaFDcvi4r8xwhZ4094wF5CHXkm2adngzY jZv1BwB1SUhcoWpGQ3VI0H1Y94u/wY7hs3Q/VTDnv5LeiQ4pch2olyJqZ9fl7nJo85G0 4HIRUOKr3cwTgUJSi1OtVDoS+lD2vm8VFS+BEsGMqnStS55K7BFRvn0H53MkQdnsrjWO IYQvEoFclHOBpzUhOBgZHZqxnxsXhNnAvmSYNYCEVC6qcE073GjRmROOy4vd0IHvh3rG EmnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RlvYSlMGFakV6EZ71l2kmuNwcjNHwB/5cpbhUPGNlFo=; b=SH00/Dl/Kxq0ZVFjs1HnwN9RjwsbnYzvpXhhJLqwExYdTDkvBQ4dVTPiq3JgpDhVmf xmEOjY5lWN65MpJBw5nU+ZWQK5QdsAbf2myII642kvZEgeRGwKOHC2XcTrlOvfqaW6cj 03Cevqrf8EY0Sp3r+/VeMGgmvKXm7OK6i2ZGFBSLiYyHo0wG3pLmTAjlRNgnR82yNsOi ouaff5d6Qkx+RRfweSUQ9AirF89HbwYm/Jwv4MKl6g7gLel9P6AyC3TMiguqE0330tzz NsrmC2gndgt+FhBDWfxA2CRbuschGdMVGAFJuwlQzPjafhaB1V8XucO7HyPBWpGJrZvN D/Sg== X-Gm-Message-State: AOAM531Bkh5vhUsYdHyAT2C+wD+E+6t9H2z9n2O3Kin0lYV8gtaYk1CE Txk2pfnzuZAWR05966/EtD87XvmdWlRF2XZ7pyYPegBh X-Google-Smtp-Source: ABdhPJwL0ArhZYYUkwkBR9P+n5Fba1TwhZrF/S2JuQ+llk3dsIR7GBNc6wPV4sBRlA3kJsIFUBmGw/Np7Sw3Ya2O7e4= X-Received: by 2002:a05:6830:408a:: with SMTP id x10mr1040106ott.248.1615345468504; Tue, 09 Mar 2021 19:04:28 -0800 (PST) MIME-Version: 1.0 References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-6-git-send-email-aisheng.dong@nxp.com> <83240e9d-383a-74a9-3222-68cf42d3d0e1@gmail.com> In-Reply-To: From: Dong Aisheng Date: Wed, 10 Mar 2021 11:04:27 +0800 Message-ID: Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq To: Chanwoo Choi Cc: Chanwoo Choi , Dong Aisheng , Linux PM , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Shawn Guo , dl-linux-imx , open list , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Abel Vesa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_030430_516040_694057CD X-CRM114-Status: GOOD ( 22.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMTAsIDIwMjEgYXQgMTA6NTAgQU0gQ2hhbndvbyBDaG9pIDxjdzAwLmNob2lA c2Ftc3VuZy5jb20+IHdyb3RlOgo+Cj4gT24gMy8xMC8yMSAxMTo0MyBBTSwgRG9uZyBBaXNoZW5n IHdyb3RlOgo+ID4gT24gVHVlLCBNYXIgOSwgMjAyMSBhdCAxMTo1MyBQTSBDaGFud29vIENob2kg PGN3Y2hvaTAwQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPj4KPiA+PiBPbiAyMS4gMy4gOS4g7Jik7ZuE IDk6NTgsIERvbmcgQWlzaGVuZyB3cm90ZToKPiA+Pj4gVXNlIHRoZSBtb3JlIGFjY3VyYXRlIHJl dHVybmVkIG5ld19mcmVxIGFzIHJlc3VtZV9mcmVxLgo+ID4+PiBJdCdzIHRoZSBzYW1lIGFzIGhv dyBkZXZmcmVxLT5wcmV2aW91c19mcmVxIHdhcyB1cGRhdGVkLgo+ID4+Pgo+ID4+PiBTaWduZWQt b2ZmLWJ5OiBEb25nIEFpc2hlbmcgPGFpc2hlbmcuZG9uZ0BueHAuY29tPgo+ID4+PiAtLS0KPiA+ Pj4gICBkcml2ZXJzL2RldmZyZXEvZGV2ZnJlcS5jIHwgMiArLQo+ID4+PiAgIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4+Pgo+ID4+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9kZXZmcmVxL2RldmZyZXEuYyBiL2RyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMK PiA+Pj4gaW5kZXggNmU4MGJmNzBlN2IzLi5jZTU2OWJkOWFkZmEgMTAwNjQ0Cj4gPj4+IC0tLSBh L2RyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMKPiA+Pj4gKysrIGIvZHJpdmVycy9kZXZmcmVxL2Rl dmZyZXEuYwo+ID4+PiBAQCAtMzkwLDcgKzM5MCw3IEBAIHN0YXRpYyBpbnQgZGV2ZnJlcV9zZXRf dGFyZ2V0KHN0cnVjdCBkZXZmcmVxICpkZXZmcmVxLCB1bnNpZ25lZCBsb25nIG5ld19mcmVxLAo+ ID4+PiAgICAgICBkZXZmcmVxLT5wcmV2aW91c19mcmVxID0gbmV3X2ZyZXE7Cj4gPj4+Cj4gPj4+ ICAgICAgIGlmIChkZXZmcmVxLT5zdXNwZW5kX2ZyZXEpCj4gPj4+IC0gICAgICAgICAgICAgZGV2 ZnJlcS0+cmVzdW1lX2ZyZXEgPSBjdXJfZnJlcTsKPiA+Pj4gKyAgICAgICAgICAgICBkZXZmcmVx LT5yZXN1bWVfZnJlcSA9IG5ld19mcmVxOwo+ID4+Pgo+ID4+PiAgICAgICByZXR1cm4gZXJyOwo+ ID4+PiAgIH0KPiA+Pj4KPiA+Pgo+ID4+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIHByZXZpb3VzIHBh dGNoWzFdLiBTbyB0aGF0IHlvdSBuZWVkIHRvCj4gPj4gYWRkICdGaXhlcycgdGFnIGFzIGZvbGxv d2luZzoKPiA+Pgo+ID4+IEZpeGVzOiA4M2Y4Y2E0NWFmYmYwICgiUE0gLyBkZXZmcmVxOiBhZGQg c3VwcG9ydCBmb3Igc3VzcGVuZC9yZXN1bWUgb2YgYQo+ID4+IGRldmZyZXEgZGV2aWNlIikKPiA+ Pgo+ID4KPiA+IFdpbGwgYWRkIEZpeGVzIHRhZyBpbiBuZXh0IHZlcnNpb24uCj4KPgo+IE9uIG5l eHQgdmVyc2lvbiwgcmVjb21tZW5kIHRvIHBsYWNlIHRoaXMgcGF0Y2ggYXQgdGhlIGZpcnN0LgoK WWVzLCBnb29kIHByYWN0aWNlIGFzIGl0J3MgYSBmaXguCgpSZWdhcmRzCkFpc2hlbmcKCj4KPiA+ Cj4gPj4gY29tbWl0IDgzZjhjYTQ1YWZiZjA0MWUzMTI5MDlmNDQyMTI4Yjk5NjU3ZDkwYjcKPiA+ PiBSZWZzOiB2NC4yMC1yYzYtMi1nODNmOGNhNDVhZmJmCj4gPj4gQXV0aG9yOiAgICAgTHVrYXN6 IEx1YmEgPGx1a2Fzei5sdWJhQGFybS5jb20+Cj4gPj4gQXV0aG9yRGF0ZTogV2VkIERlYyA1IDEy OjA1OjUzIDIwMTggKzAxMDAKPiA+PiBDb21taXQ6ICAgICBNeXVuZ0pvbyBIYW0gPG15dW5nam9v LmhhbUBzYW1zdW5nLmNvbT4KPiA+PiBDb21taXREYXRlOiBUdWUgRGVjIDExIDExOjA5OjQ3IDIw MTggKzA5MDAKPiA+Pgo+ID4+ICAgICAgUE0gLyBkZXZmcmVxOiBhZGQgc3VwcG9ydCBmb3Igc3Vz cGVuZC9yZXN1bWUgb2YgYSBkZXZmcmVxIGRldmljZQo+ID4+Cj4gPj4KPiA+PiAtLQo+ID4+IEJl c3QgUmVnYXJkcywKPiA+PiBTYW1zdW5nIEVsZWN0cm9uaWNzCj4gPj4gQ2hhbndvbyBDaG9pCj4g Pgo+ID4KPgo+Cj4gLS0KPiBCZXN0IFJlZ2FyZHMsCj4gQ2hhbndvbyBDaG9pCj4gU2Ftc3VuZyBF bGVjdHJvbmljcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=