All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wesley W. Terpstra" <wesley@terpstra.ca>
To: linux-raid@vger.kernel.org
Subject: Re: BUG drivers/md/md.c: data-offset reshape renders array unloadable
Date: Sat, 24 Jan 2015 23:23:18 +0100	[thread overview]
Message-ID: <CAA-O0XgXc0H4H__8ygLzt_BBW3NpEseG9NZBTZ_syMdir8D=mA@mail.gmail.com> (raw)
In-Reply-To: <CAA-O0Xjustt5=nNoDzXukY=f-7OwRk=yqug8MCpxcXCt4MdiTw@mail.gmail.com>

On Sat, Jan 24, 2015 at 10:44 PM, Wesley W. Terpstra <wesley@terpstra.ca> wrote:
> The reshape was going fine and was probably
> around 50% done when the system was rebooted.

It is also possible the system was hung, but continued the reshape
until completion.

> First, it is obviously the last test in super_1_load that is rejecting
> the array. The superblock reports more sectors than are calculated, so
> the check
>         if (sectors < le64_to_cpu(sb->data_size)) {
> fails.

Thus, an alternative explanation could be that the the sb->data_size
was not updated after the reshape completed. The superblocks have a
"Feature Map: 0x0" according to mdadm. I gather from reading
linux/raid/md_p.h that it should at least have
MD_FEATURE_RESHAPE_ACTIVE, if the reshape were still in progress.

  reply	other threads:[~2015-01-24 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24 21:44 BUG drivers/md/md.c: data-offset reshape renders array unloadable Wesley W. Terpstra
2015-01-24 22:23 ` Wesley W. Terpstra [this message]
2015-01-25 16:46   ` Wesley W. Terpstra
2015-02-05  6:14     ` NeilBrown
2015-02-05  8:17       ` Wesley W. Terpstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA-O0XgXc0H4H__8ygLzt_BBW3NpEseG9NZBTZ_syMdir8D=mA@mail.gmail.com' \
    --to=wesley@terpstra.ca \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.