All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luigi Semenzato <semenzato@google.com>
To: Chris Down <chris@chrisdown.name>
Cc: Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH 1/2] Documentation: clarify limitations of hibernation
Date: Thu, 2 Jan 2020 11:29:30 -0800	[thread overview]
Message-ID: <CAA25o9S0w51hA480r4JMDY79XeUY2ce-YP2GNVLqST5woh5j4g@mail.gmail.com> (raw)
In-Reply-To: <20191228002503.GB544630@chrisdown.name>

Thank you Chris, those are excellent comments.

I am replacing "memory pressure" with "memory usage".  I had used
"pressure" because "usage" is vague and here we specifically refer to
non-reclaimable pages.  But it's true that "pressure" has a different,
specific meaning for the mm, so "usage" is better.  The example should
clarify the problem.

I am also removing the workaround.  I thought it may be useful, but as
you said, it's quite debatable that it belongs here.

On Fri, Dec 27, 2019 at 4:25 PM Chris Down <chris@chrisdown.name> wrote:
>
> Oh, and:
>
> Luigi Semenzato writes:
> >+system to be present for the underlying CPU architecture.  Additionally, the
> >+current implementation can enter the hibernation state only when memory
> >+pressure is low (see "Limitations" below).
>
> This doesn't seem to make much sense to me. You claim it only works when
> pressure is low, but then suggest people raise pressure to fix it.
>
> I suppose you mean "only when memory *usage* is low"? I mean, if memory
> pressure is low, then it's likely to result in these cold pages sitting around
> in the first place.


  reply	other threads:[~2020-01-02 19:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-27 21:34 [PATCH 0/2] clarify limitations of hibernation Luigi Semenzato
2019-12-27 21:34 ` [PATCH 1/2] Documentation: " Luigi Semenzato
2019-12-28  0:23   ` Chris Down
2019-12-28  0:25   ` Chris Down
2020-01-02 19:29     ` Luigi Semenzato [this message]
2019-12-27 21:34 ` [PATCH 2/2] pm: add more logging on hibernation failure Luigi Semenzato
  -- strict thread matches above, loose matches on Subject: below --
2019-12-26 22:02 [PATCH 0/2] clarify limitations of hibernation Luigi Semenzato
2019-12-26 22:02 ` [PATCH 1/2] Documentation: " Luigi Semenzato
2019-12-26 22:02   ` Luigi Semenzato
2020-01-06 12:53   ` Michal Hocko
2020-01-06 19:08     ` Luigi Semenzato
2020-01-06 19:08       ` Luigi Semenzato
2020-01-08 11:49       ` Michal Hocko
2020-01-24 16:37         ` Luigi Semenzato
2020-01-24 16:37           ` Luigi Semenzato
2020-01-27 14:16           ` Michal Hocko
2020-01-27 16:13             ` Luigi Semenzato
2020-01-27 16:13               ` Luigi Semenzato
2020-01-27 16:28               ` Rafael J. Wysocki
2020-01-27 16:28                 ` Rafael J. Wysocki
2020-01-27 17:21                 ` Luigi Semenzato
2020-01-27 17:21                   ` Luigi Semenzato
2020-01-30 20:50                   ` Rafael J. Wysocki
2020-01-30 20:50                     ` Rafael J. Wysocki
2020-01-30 21:10                     ` Luigi Semenzato
2020-01-30 21:10                       ` Luigi Semenzato
2020-01-30 21:29                       ` Rafael J. Wysocki
2020-01-30 21:29                         ` Rafael J. Wysocki
2020-01-30 21:36                         ` Luigi Semenzato
2020-01-30 21:36                           ` Luigi Semenzato
2020-01-27 16:14             ` Rafael J. Wysocki
2020-01-27 16:14               ` Rafael J. Wysocki
2020-01-07 10:04     ` Rafael J. Wysocki
2020-01-07 10:04       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA25o9S0w51hA480r4JMDY79XeUY2ce-YP2GNVLqST5woh5j4g@mail.gmail.com \
    --to=semenzato@google.com \
    --cc=chris@chrisdown.name \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.