All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] mt76: fix per-chain signal strength reporting
Date: Wed, 23 Jan 2019 13:10:59 +0100	[thread overview]
Message-ID: <CAA2SeN+MJhwYq+c=R9cLZJqXGa_amvjpWF-bDHoLp1GXfzGVfA@mail.gmail.com> (raw)
In-Reply-To: <20190122153823.46270-1-nbd@nbd.name>

>
> Fix an off-by-one error that resulted in not reporting the signal strength
> for the first chain
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> index ce9bb702045f..63fa27d2c404 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> @@ -648,7 +648,7 @@ int mt76x02_mac_process_rx(struct mt76x02_dev *dev, struct sk_buff *skb,
>
>         status->chains = BIT(0);
>         signal = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0);

Here I guess we can do:

 signal = status->chain_signal[0] = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0);

and avoid duplicated operations.

Regards,
Lorenzo

> -       for (i = 1; i < nstreams; i++) {
> +       for (i = 0; i < nstreams; i++) {
>                 status->chains |= BIT(i);
>                 status->chain_signal[i] = mt76x02_mac_get_rssi(dev,
>                                                                rxwi->rssi[i],
> --
> 2.17.0
>


-- 
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep

      parent reply	other threads:[~2019-01-23 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 15:38 [PATCH 1/2] mt76: fix per-chain signal strength reporting Felix Fietkau
2019-01-22 15:38 ` [PATCH 2/2] mt76: avoid scheduling tx queues for powersave stations Felix Fietkau
2019-01-23 10:20 ` [PATCH 1/2] mt76: fix per-chain signal strength reporting Stanislaw Gruszka
2019-01-23 12:10 ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA2SeN+MJhwYq+c=R9cLZJqXGa_amvjpWF-bDHoLp1GXfzGVfA@mail.gmail.com' \
    --to=lorenzo.bianconi83@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.