All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: pull request: mt76 2018-10-05
Date: Sat, 6 Oct 2018 12:04:20 +0200	[thread overview]
Message-ID: <CAA2SeNK58MmxfrKgiLrp=swveJOURwWQcua3MWyQp9njssAbOA@mail.gmail.com> (raw)
In-Reply-To: <87sh1jh0fo.fsf@kamboji.qca.qualcomm.com>

>
> Felix Fietkau <nbd@nbd.name> writes:
>
> > Here's another large batch of mt76 code cleanup / deduplication / fixes
> >
> > - Felix
> >
> > The following changes since commit e1c02eb16a9c742178874a7d1a08d300981715fb:
> >
> >   qtnfmac: implement dump_station support for STA mode (2018-10-05 14:01:44 +0300)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/nbd168/wireless tags/mt76-for-kvalo-2018-10-05
> >
> > for you to fetch changes up to 06ac97c2e58c7b32bf950ac53976c4260687d386:
> >
> >   mt76x0: pci: report firmware version using ethtool (2018-10-05 20:05:46 +0200)
> >
> > ----------------------------------------------------------------
> > mt76 patches for 4.20
> >
> > * unify code between mt76x0, mt76x2
> > * mt76x0 fixes
> > * another fix for rx buffer allocation regression on usb
> > * move mt76x2 source files to mt76x2 folder
> > * more work on mt76x0e support
> >
> > ----------------------------------------------------------------
>
> I have to drop this as it doesn't build for me:
>
> drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c: In function 'mt76x0e_load_firmware':
> drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c:119:28: error: passing argument 1 of 'mt76x02_set_ethtool_fwver' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   mt76x02_set_ethtool_fwver(dev, hdr);
>                             ^~~
> In file included from drivers/net/wireless/mediatek/mt76/mt76x0/mcu.h:18:0,
>                  from drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c:20:
> drivers/net/wireless/mediatek/mt76/mt76x0/../mt76x02_mcu.h:108:6: note: expected 'struct mt76_dev *' but argument is of type 'struct mt76x02_dev *'
>  void mt76x02_set_ethtool_fwver(struct mt76_dev *dev,
>       ^~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> scripts/Makefile.build:305: recipe for target 'drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.o' failed
>
> --
> Kalle Valo

Hi Kalle,

I guess we can just drop this patch since it is based on 'use
mt76x02_dev instead of mt76_dev as reference' series, sent just as RFC
for the moment.
I will resend this patch on top of other series. Sorry for the noise

Regards,
Lorenzo

--
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep

      parent reply	other threads:[~2018-10-06 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 18:10 pull request: mt76 2018-10-05 Felix Fietkau
2018-10-06  9:46 ` Kalle Valo
2018-10-06 10:03   ` pull request: mt76 2018-10-05 v2 Felix Fietkau
2018-10-06 11:29     ` Kalle Valo
2018-10-06 10:04   ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA2SeNK58MmxfrKgiLrp=swveJOURwWQcua3MWyQp9njssAbOA@mail.gmail.com' \
    --to=lorenzo.bianconi83@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.