From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luke Gorrie <luke@snabb.co>
Subject: Possible bug in mlx5_tx_burst_mpw?
Date: Wed, 14 Sep 2016 15:24:07 +0200
Message-ID: <CAA2XHbd+c2vuFKu7CivDkAG+1KEhq28yKd+-GsJjMVukS-2CxA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
To: "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id B53D98D4D
 for <dev@dpdk.org>; Wed, 14 Sep 2016 15:24:08 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id i130so48465878wmf.0
 for <dev@dpdk.org>; Wed, 14 Sep 2016 06:24:08 -0700 (PDT)
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Howdy,

Just noticed a line of code that struck me as odd and so I am writing just
in case it is a bug:

http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/mlx5_rxtx.c#n1014

Specifically the check "(mpw.length != length)" in mlx_tx_burst_mpw() looks
like a descriptor-format optimization for the special case where
consecutive packets on the wire are exactly the same size. This would
strike me as peculiar.

Just wanted to check, is that interpretation correct and if so then is this
intentional?

Cheers,
-Luke