From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Date: Sun, 15 Jul 2012 02:11:07 +0400 Subject: [U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment In-Reply-To: <201207100355.29187.marex@denx.de> References: <1341716895-31089-1-git-send-email-marex@denx.de> <1341716895-31089-2-git-send-email-marex@denx.de> <201207100355.29187.marex@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek, On Tue, Jul 10, 2012 at 5:55 AM, Marek Vasut wrote: > > > > + invalidate_dcache_range((uint32_t)buffer, > > > + ALIGN_END_ADDR(u8, buffer, length)); > > > > We shouldn't use ALIGN_END_ADDR here. This can lead to strange results on > > systems with ARCH_DMA_MINALIGN < 32. > > > Good point, ALIGN_END_ADDR should align it to max(32, length) ? > > Hm.. no, actually we should align buffer length to ARCH_DMA_MINALIGN. Regards, Ilya.