All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dexuan-Linux Cui <dexuan.linux@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: valdis.kletnieks@vt.edu, netdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dexuan Cui <decui@microsoft.com>
Subject: Re: next-20180605 - BUG in ipv6_add_addr
Date: Fri, 8 Jun 2018 19:54:30 -0700	[thread overview]
Message-ID: <CAA42JLYGOR1hJnOvdvSbyK6z7wb0jG8TtXsXoNZU9xnK1cKjVA@mail.gmail.com> (raw)
In-Reply-To: <6471e14e-2872-3ba4-7336-7c5840d28c12@gmail.com>

On Thu, Jun 7, 2018 at 5:51 PM, David Ahern <dsahern@gmail.com> wrote:
>
> ...
> I know you don't have a reliable reproducer, but I did find one spot
> where I was too clever and did not initialize a new cfg variable:
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 89019bf59f46..59c22a25e654 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -1324,6 +1324,7 @@ static int ipv6_create_tempaddr(struct
> inet6_ifaddr *ifp,
>                 }
>         }
>
> +       memset(&cfg, 0, sizeof(cfg));
>         cfg.valid_lft = min_t(__u32, ifp->valid_lft,
>                               idev->cnf.temp_valid_lft + age);
>         cfg.preferred_lft = cnf_temp_preferred_lft + age -
> idev->desync_factor;

This works for me. Great!

Thanks,
-- Dexuan

      reply	other threads:[~2018-06-09  2:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 20:17 next-20180605 - BUG in ipv6_add_addr valdis.kletnieks
2018-06-07 23:49 ` David Ahern
2018-06-08  0:03   ` valdis.kletnieks
2018-06-08  0:51     ` David Ahern
2018-06-09  2:54       ` Dexuan-Linux Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA42JLYGOR1hJnOvdvSbyK6z7wb0jG8TtXsXoNZU9xnK1cKjVA@mail.gmail.com \
    --to=dexuan.linux@gmail.com \
    --cc=decui@microsoft.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.