From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935219AbbCPTDf (ORCPT ); Mon, 16 Mar 2015 15:03:35 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:35989 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932978AbbCPTDc (ORCPT ); Mon, 16 Mar 2015 15:03:32 -0400 MIME-Version: 1.0 In-Reply-To: <1426503069-27901-1-git-send-email-ricardo.ribalda@gmail.com> References: <1426503069-27901-1-git-send-email-ricardo.ribalda@gmail.com> From: Lorenzo Stoakes Date: Mon, 16 Mar 2015 19:03:12 +0000 Message-ID: Subject: Re: [PATCH] staging/sm75fb: Declare static functions as such To: Ricardo Ribalda Delgado Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16 March 2015 at 10:51, Ricardo Ribalda Delgado wrote: > This patch fixes this sparse warning Hi Ricardo, I currently have a patch series awaiting the final ok which includes fixes for these warnings (http://lkml.iu.edu/hypermail/linux/kernel/1503.1/02535.html), apologies but assuming there isn't something hideously wrong with my series I suspect they supersedes this patch :( It's really easy to accidentally submit a patch that has already been covered elsewhere; I, as a rather new kernel contributor, always find I have to search quite a bit to be *sure* that it's not been covered already. Additionally, your subject line is 'staging/sm75fb: Declare static functions as such' which ought to be 'staging: sm750fb: Declare static functions as such' - there's a typo in the device name and I think the convention is always to use colons in subject lines. Best, -- Lorenzo Stoakes https:/ljs.io