From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Schwarz <simonschwarzcor@googlemail.com>
Date: Fri, 15 Jul 2011 14:31:38 +0200
Subject: [U-Boot] [RFC PATCH v1 6/9] scaled down version of generic
	libraries for SPL
In-Reply-To: <1310569869-31810-7-git-send-email-daniel.schwierzeck@googlemail.com>
References: <4DF9B9E0.8020206@ti.com>
	<1310569869-31810-1-git-send-email-daniel.schwierzeck@googlemail.com>
	<1310569869-31810-7-git-send-email-daniel.schwierzeck@googlemail.com>
Message-ID: <CAA5zgp9b6c_YgoYSfqY-2AHM0BwMJGiwfg_zzb2SZs=0uFTwpQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Daniel,

at the moment I'am playing a bit with your patch.

I stumbled over this:
> diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile
> index d31321a..300c8fa 100644
> --- a/arch/arm/lib/Makefile
> +++ b/arch/arm/lib/Makefile
> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
> ?LIB ? ?= $(obj)lib$(ARCH).o
> ?LIBGCC = $(obj)libgcc.o
>
> +ifndef CONFIG_SPL_BUILD
> ?GLSOBJS ? ? ? ?+= _ashldi3.o
> ?GLSOBJS ? ? ? ?+= _ashrdi3.o
> ?GLSOBJS ? ? ? ?+= _divsi3.o
> @@ -45,6 +46,7 @@ COBJS-y ? ? ? += interrupts.o
> ?COBJS-y ? ? ? ?+= reset.o
> ?SOBJS-$(CONFIG_USE_ARCH_MEMSET) += memset.o
> ?SOBJS-$(CONFIG_USE_ARCH_MEMCPY) += memcpy.o
> +endif

Is it really your intention here to exclude board.c from the SPL? Or
do i misinterpret something? Also cache.c I would include to a
standard SPL.

I really like the new SPL - good work! ;)

Regards
Simon