All of lore.kernel.org
 help / color / mirror / Atom feed
From: Weiping Zhang <zwp10758@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	sagi@grimberg.me, Weiping Zhang <zhangweiping@didiglobal.com>,
	linux-nvme@lists.infradead.org,
	weiping zhang <zhangweiping@didichuxing.com>,
	Keith Busch <kbusch@kernel.org>, Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH] nvme: align io queue count with allocted nvme_queue in nvme_probe
Date: Thu, 23 Apr 2020 15:59:24 +0800	[thread overview]
Message-ID: <CAA70yB4onUh4iOGd_rfK8J918Rdn+zkko-LHjiFBVTaSnmPPNg@mail.gmail.com> (raw)
In-Reply-To: <20200422165731.GA8218@infradead.org>

On Thu, Apr 23, 2020 at 12:57 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Apr 22, 2020 at 05:24:27PM +0800, weiping zhang wrote:
> > > The problem with PCIe is that we only have a per-controller interface
> > > once the controller is probed.  So a global paramter that can be
> > > changed, but only is sampled once at probe time seems the easiest to
> > > me.  We could also allow a per-controller sysfs file that only takes
> > > effect after a reset, which seems a little nicer, but adds a lot of
> > > boilerplate for just being a little nicer, so I'm not entirely sure
> > > if it is worth the effort.
> > Hi Christoph,
> >
> > Because in the real user case, the number of each type queue may
> > not very suitable, it needs a ability to adjust them without hotplug.
> >
> > If so, the nvme_dev needs record how many write/poll
> > queues saved in nvme_probe, and then use them in reset flow.
>
> When I wrote probe above I meant to include reset, sorry.

Hi Christoph,

I send V2 base on nvme-5.8 0e6e74230.

Thanks

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2020-04-23  7:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10  9:57 [PATCH] nvme: align io queue count with allocted nvme_queue in nvme_probe Weiping Zhang
2020-04-12 12:38 ` Max Gurtovoy
2020-04-13  1:01   ` Weiping Zhang
2020-04-13  9:37     ` Max Gurtovoy
2020-04-13 12:00       ` Weiping Zhang
2020-04-14 12:59         ` Max Gurtovoy
2020-04-22  8:37           ` Christoph Hellwig
2020-04-22  9:24             ` weiping zhang
2020-04-22 16:57               ` Christoph Hellwig
2020-04-23  7:59                 ` Weiping Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA70yB4onUh4iOGd_rfK8J918Rdn+zkko-LHjiFBVTaSnmPPNg@mail.gmail.com \
    --to=zwp10758@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=zhangweiping@didichuxing.com \
    --cc=zhangweiping@didiglobal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.