From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B263C43331 for ; Tue, 31 Mar 2020 16:31:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDA3B21473 for ; Tue, 31 Mar 2020 16:31:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFffBG1O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731098AbgCaQba (ORCPT ); Tue, 31 Mar 2020 12:31:30 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:38369 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731081AbgCaQb3 (ORCPT ); Tue, 31 Mar 2020 12:31:29 -0400 Received: by mail-qk1-f193.google.com with SMTP id h14so23688972qke.5; Tue, 31 Mar 2020 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3e9ikjR7lUfigAH3hUl/FtkvucG7jL188AkHtbtxXwU=; b=JFffBG1O7hZhrL4iWKk+o5lwqbdFv84JlaqpK1TtGAaPpOY13zvdft43vmDz/CcmTQ nIHnNWsxIL0clp4kNgoxK0yQlGE98tVc7k9BZ+Aqj6wYm5nS2HCVA2SbKrU9fXydw8IB iWd7CDUllGJqvAqA8gggeh9RXn3bjDLGVF8C90bnvIopC1wIOhQ36QT3f0aufrC/iC/T SYPRvEgdHQcCB9EB5fGpEsED3mwVOy9S3w3yMl9SdggcVFZBQW9UvaTeJ2Both4xMGzZ lDLNirOa07shniq/V7jr1WOxVJ3IVPZJQlvZa+1IcsAKyOO8UT9j4q1l9/1ctw0DOTLF A+Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3e9ikjR7lUfigAH3hUl/FtkvucG7jL188AkHtbtxXwU=; b=CBkeOc0Ad9un/cu8UHhd60liPejJle0uZJnVLsPrGT7ftg5I3IbB88FGiUT3rqyaps mbw80miybL1heKY/Qi1yb91J7R8f4SyxxgQTE9yPJfIe0u/bS5jruvJbaBu4IDj/Is3i zj6MAW6d7YuKa3n2z83N5BSXr/+Lt1h958TkeVQMIlrsnvCI5mbPwawMQ3KeX33y4rzb Vx32yy0Zxg9H+pXOIt1/a4El/krtsTEXMfYXB8wYeczrBMOVVM0yAO8g9+jXB5JfxEJz E+GWlqciZj4qzc8hyqOE3dnXRLYUL75j738A4y+TnFDvx8aP2j7E4bTKQB6TwXyIm/t/ um/g== X-Gm-Message-State: ANhLgQ2nP8IuAhT60uzrZObBzFeq9fKKijJdk7ZH+m2sDLHK+J51hE8O 26K5NDdHKFDiejK//0gjAbIMN9JtJBZWqrVqAak= X-Google-Smtp-Source: ADFU+vv7XLsSmd0U+NVmBqN6EeeGNyZH+7V3R7M+qo+XNg5DADsMkKTg2jxXha8xl3BLAFxZYuJpn4eJIrre1h9PmJM= X-Received: by 2002:a37:bf06:: with SMTP id p6mr5907892qkf.477.1585672288628; Tue, 31 Mar 2020 09:31:28 -0700 (PDT) MIME-Version: 1.0 References: <20200204154200.GA5831@redsun51.ssa.fujisawa.hgst.com> <20200331143635.GS162390@mtj.duckdns.org> <20200331155139.GT162390@mtj.duckdns.org> <20200331155257.GA22994@lst.de> In-Reply-To: <20200331155257.GA22994@lst.de> From: Weiping Zhang Date: Wed, 1 Apr 2020 00:31:17 +0800 Message-ID: Subject: Re: [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme To: Christoph Hellwig Cc: Tejun Heo , Keith Busch , Jens Axboe , Bart Van Assche , Minwoo Im , Thomas Gleixner , Ming Lei , "Nadolski, Edmund" , linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Christoph Hellwig =E4=BA=8E2020=E5=B9=B43=E6=9C=8831=E6=97=A5= =E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=8811:52=E5=86=99=E9=81=93=EF=BC=9A > > On Tue, Mar 31, 2020 at 11:51:39AM -0400, Tejun Heo wrote: > > Hello, > > > > On Tue, Mar 31, 2020 at 11:47:41PM +0800, Weiping Zhang wrote: > > > Do you means drop the "io.wrr" or "blkio.wrr" in cgroup, and use a > > > dedicated interface > > > like /dev/xxx or /proc/xxx? > > > > Yes, something along that line. Given that it's nvme specific, it'd be = best if > > the interface reflects that too - e.g. through a file under > > /sys/block/nvme*/device/. Jens, Christoph, what do you guys think? > > I'm pretty sure I voiced my opinion before - I think the NVMe WRR > queueing concept is completely broken and I do not thing we should > support it at all. Hi Christoph, Would you like to share more detail about why NVMe WRR is broken? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8565C43331 for ; Tue, 31 Mar 2020 16:31:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7539A20784 for ; Tue, 31 Mar 2020 16:31:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QRxdHF6f"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFffBG1O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7539A20784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PZdy/p5XcuEj4pv7OxMQ7D3fwCGOv2oJsH5IMprpTkg=; b=QRxdHF6feetq3e EUSE6/YxRU6iPiA6Drk1qSHXMb+r4SJFdQymnkmPYiMEjpeK7ZEIIj4v6FRzUW6e+o0QTSXO91aGN KGfnxwM0uvWVaXJHRs188gdvLxm8UPnxIKetSuIuiS2UQQ49AbQWXHwCtgl2rLfibR4mQnTZP6i+B uMLTwXETh5ahtfbWnFfz3jvg8XhPz29OTkPqNuKGWs0YGEW3rL+2+sqm66O92oogRjSG8f7H7DIhj kBiygEbGq025MBmnbRzkxXvvacjl+DQE/sAg5lG18qWnicAH6hl21EQoJI+/zult95YHlzIoxJtrU hNTWu2Yv/mRY2h7p4FDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJnb-0004wE-6e; Tue, 31 Mar 2020 16:31:35 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJnY-0004ud-GY for linux-nvme@lists.infradead.org; Tue, 31 Mar 2020 16:31:33 +0000 Received: by mail-qk1-x743.google.com with SMTP id k13so23697424qki.2 for ; Tue, 31 Mar 2020 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3e9ikjR7lUfigAH3hUl/FtkvucG7jL188AkHtbtxXwU=; b=JFffBG1O7hZhrL4iWKk+o5lwqbdFv84JlaqpK1TtGAaPpOY13zvdft43vmDz/CcmTQ nIHnNWsxIL0clp4kNgoxK0yQlGE98tVc7k9BZ+Aqj6wYm5nS2HCVA2SbKrU9fXydw8IB iWd7CDUllGJqvAqA8gggeh9RXn3bjDLGVF8C90bnvIopC1wIOhQ36QT3f0aufrC/iC/T SYPRvEgdHQcCB9EB5fGpEsED3mwVOy9S3w3yMl9SdggcVFZBQW9UvaTeJ2Both4xMGzZ lDLNirOa07shniq/V7jr1WOxVJ3IVPZJQlvZa+1IcsAKyOO8UT9j4q1l9/1ctw0DOTLF A+Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3e9ikjR7lUfigAH3hUl/FtkvucG7jL188AkHtbtxXwU=; b=BazCHu4kGz8guKeR3N67XtE1XfQ4eik7FYr0OmI2db9wtvJBr+jTBL7nu30mrrqLh1 opNCvwLoVaMtzQxEku9xnjV8Hr7212odjRlEdy4WHBtCIKBcB9S2xK+79hLYzgkMomWI RlAWot/kU5iobJCuXOElMHhBJe/ab9pnzjqsb/ok3zf98G7Wivb6IL47J2TZgkZ0dGWK XlNkiuNS7Cr2gR7iXPLTFTWYUF0UzArrwV9YnwzMoCz8VgyFMU0dHIkBOHvt/ofn3j4I tzFy002t9JNK7+0Ru0gvaQPQkvE+WeeJ4E2DaqJH42HIT4sXh1uyYP/JxFNnpv4VZoEx eGeA== X-Gm-Message-State: ANhLgQ11zr/eFXE4yQwa2WTlNj3aj13cM9EIn7sWXD9RGe3FzjYAi8/F hWuotUmYB4PHwQMDjSc/f+XSdx01sUN5zzgp8Xg= X-Google-Smtp-Source: ADFU+vv7XLsSmd0U+NVmBqN6EeeGNyZH+7V3R7M+qo+XNg5DADsMkKTg2jxXha8xl3BLAFxZYuJpn4eJIrre1h9PmJM= X-Received: by 2002:a37:bf06:: with SMTP id p6mr5907892qkf.477.1585672288628; Tue, 31 Mar 2020 09:31:28 -0700 (PDT) MIME-Version: 1.0 References: <20200204154200.GA5831@redsun51.ssa.fujisawa.hgst.com> <20200331143635.GS162390@mtj.duckdns.org> <20200331155139.GT162390@mtj.duckdns.org> <20200331155257.GA22994@lst.de> In-Reply-To: <20200331155257.GA22994@lst.de> From: Weiping Zhang Date: Wed, 1 Apr 2020 00:31:17 +0800 Message-ID: Subject: Re: [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme To: Christoph Hellwig X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_093132_543757_7455DA19 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Bart Van Assche , linux-nvme@lists.infradead.org, Ming Lei , linux-block@vger.kernel.org, Keith Busch , Minwoo Im , cgroups@vger.kernel.org, Tejun Heo , "Nadolski, Edmund" , Thomas Gleixner Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Q2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+IOS6jjIwMjDlubQz5pyIMzHml6Xlkajkuowg 5LiL5Y2IMTE6NTLlhpnpgZPvvJoKPgo+IE9uIFR1ZSwgTWFyIDMxLCAyMDIwIGF0IDExOjUxOjM5 QU0gLTA0MDAsIFRlanVuIEhlbyB3cm90ZToKPiA+IEhlbGxvLAo+ID4KPiA+IE9uIFR1ZSwgTWFy IDMxLCAyMDIwIGF0IDExOjQ3OjQxUE0gKzA4MDAsIFdlaXBpbmcgWmhhbmcgd3JvdGU6Cj4gPiA+ IERvIHlvdSBtZWFucyBkcm9wIHRoZSAiaW8ud3JyIiBvciAiYmxraW8ud3JyIiBpbiBjZ3JvdXAs IGFuZCB1c2UgYQo+ID4gPiBkZWRpY2F0ZWQgaW50ZXJmYWNlCj4gPiA+IGxpa2UgL2Rldi94eHgg b3IgL3Byb2MveHh4Pwo+ID4KPiA+IFllcywgc29tZXRoaW5nIGFsb25nIHRoYXQgbGluZS4gR2l2 ZW4gdGhhdCBpdCdzIG52bWUgc3BlY2lmaWMsIGl0J2QgYmUgYmVzdCBpZgo+ID4gdGhlIGludGVy ZmFjZSByZWZsZWN0cyB0aGF0IHRvbyAtIGUuZy4gdGhyb3VnaCBhIGZpbGUgdW5kZXIKPiA+IC9z eXMvYmxvY2svbnZtZSovZGV2aWNlLy4gSmVucywgQ2hyaXN0b3BoLCB3aGF0IGRvIHlvdSBndXlz IHRoaW5rPwo+Cj4gSSdtIHByZXR0eSBzdXJlIEkgdm9pY2VkIG15IG9waW5pb24gYmVmb3JlIC0g SSB0aGluayB0aGUgTlZNZSBXUlIKPiBxdWV1ZWluZyBjb25jZXB0IGlzIGNvbXBsZXRlbHkgYnJv a2VuIGFuZCBJIGRvIG5vdCB0aGluZyB3ZSBzaG91bGQKPiBzdXBwb3J0IGl0IGF0IGFsbC4KSGkg Q2hyaXN0b3BoLAoKV291bGQgeW91IGxpa2UgdG8gc2hhcmUgbW9yZSBkZXRhaWwgYWJvdXQgd2h5 IE5WTWUgV1JSIGlzIGJyb2tlbj8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LW52bWUgbWFpbGluZyBsaXN0CmxpbnV4LW52bWVAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW52bWUK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Weiping Zhang Subject: Re: [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme Date: Wed, 1 Apr 2020 00:31:17 +0800 Message-ID: References: <20200204154200.GA5831@redsun51.ssa.fujisawa.hgst.com> <20200331143635.GS162390@mtj.duckdns.org> <20200331155139.GT162390@mtj.duckdns.org> <20200331155257.GA22994@lst.de> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3e9ikjR7lUfigAH3hUl/FtkvucG7jL188AkHtbtxXwU=; b=JFffBG1O7hZhrL4iWKk+o5lwqbdFv84JlaqpK1TtGAaPpOY13zvdft43vmDz/CcmTQ nIHnNWsxIL0clp4kNgoxK0yQlGE98tVc7k9BZ+Aqj6wYm5nS2HCVA2SbKrU9fXydw8IB iWd7CDUllGJqvAqA8gggeh9RXn3bjDLGVF8C90bnvIopC1wIOhQ36QT3f0aufrC/iC/T SYPRvEgdHQcCB9EB5fGpEsED3mwVOy9S3w3yMl9SdggcVFZBQW9UvaTeJ2Both4xMGzZ lDLNirOa07shniq/V7jr1WOxVJ3IVPZJQlvZa+1IcsAKyOO8UT9j4q1l9/1ctw0DOTLF A+Zw== In-Reply-To: <20200331155257.GA22994-jcswGhMUV9g@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="utf-8" To: Christoph Hellwig Cc: Tejun Heo , Keith Busch , Jens Axboe , Bart Van Assche , Minwoo Im , Thomas Gleixner , Ming Lei , "Nadolski, Edmund" , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Christoph Hellwig =E4=BA=8E2020=E5=B9=B43=E6=9C=8831=E6=97=A5= =E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=8811:52=E5=86=99=E9=81=93=EF=BC=9A > > On Tue, Mar 31, 2020 at 11:51:39AM -0400, Tejun Heo wrote: > > Hello, > > > > On Tue, Mar 31, 2020 at 11:47:41PM +0800, Weiping Zhang wrote: > > > Do you means drop the "io.wrr" or "blkio.wrr" in cgroup, and use a > > > dedicated interface > > > like /dev/xxx or /proc/xxx? > > > > Yes, something along that line. Given that it's nvme specific, it'd be = best if > > the interface reflects that too - e.g. through a file under > > /sys/block/nvme*/device/. Jens, Christoph, what do you guys think? > > I'm pretty sure I voiced my opinion before - I think the NVMe WRR > queueing concept is completely broken and I do not thing we should > support it at all. Hi Christoph, Would you like to share more detail about why NVMe WRR is broken?