All of lore.kernel.org
 help / color / mirror / Atom feed
From: VDR User <user.vdr@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: r8169 driver from kernel 5.0 crashing
Date: Thu, 14 Mar 2019 14:36:59 -0700	[thread overview]
Message-ID: <CAA7C2qgC6VfFVidcxOBkeT0a1B1ZL7_O-WfgXZgAWBNvtHJY0A@mail.gmail.com> (raw)
In-Reply-To: <02388deb-0a06-95ae-1aac-b39c108fc2e7@gmail.com>

> >> Thanks for the additional info and for testing 4.20.15.
> >> To rule out that the issue is caused by a regression in network or
> >> some other subsystem: Can you take the r8169.c from 4.20.15 and test
> >> it on top of 5.0?
> >> Meanwhile I'll look at the changes in the driver between 4.20 and 5.0.
> >
> > Sure, no problem! I'll copy the driver & recompile now actually.
> > Hopefully there aren't a ton of changes to r8169.c to sift through and
> > the cause isn't good at hiding itself!
> >
> I checked the driver changes new in 5.0 and there are very few
> functional changes. You could try to revert the following:
>
> 5317d5c6d47e ("r8169: use napi_consume_skb where possible")

Will do, and fwiw, while I haven't been able to do tons of testing
today, I haven't been able to trigger the crash after replacing
5.0.0's r8169.c with 4.20.15's r8169.c this morning. I'll restore the
file and revert the change you mentioned, and report back my findings.

Thanks,
Derek

  reply	other threads:[~2019-03-14 21:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10 19:02 r8169 driver from kernel 5.0 crashing VDR User
2019-03-10 19:35 ` Heiner Kallweit
2019-03-14  3:04   ` VDR User
2019-03-14  6:43     ` Heiner Kallweit
2019-03-14 15:10       ` VDR User
2019-03-14 18:08         ` Heiner Kallweit
2019-03-14 21:36           ` VDR User [this message]
2019-03-15 20:09             ` VDR User
2019-03-15 20:26               ` r8169 driver from kernel 5.0 crashing - napi_consume_skb Heiner Kallweit
2019-03-15 20:40                 ` Alexander Duyck
2019-03-15 20:46                   ` Heiner Kallweit
2019-03-15 22:09                     ` Alexander Duyck
2019-03-15 22:27                       ` Heiner Kallweit
     [not found]                         ` <b470f0ee6071bded8e78e15e18df14ffbc32cd18.camel@linux.intel.com>
2019-03-16  9:07                           ` Heiner Kallweit
2019-03-16 14:38                           ` VDR User
2019-03-16 15:10                             ` Heiner Kallweit
2019-03-16 17:08                               ` Alexander Duyck
2019-03-17  8:25                                 ` Heiner Kallweit
2019-03-17 11:35                             ` Heiner Kallweit
2019-03-17 15:23                               ` VDR User
2019-03-17 15:41                               ` VDR User
2019-03-17 15:49                                 ` Heiner Kallweit
2019-03-18 16:17                                   ` VDR User
2019-03-18 18:36                                     ` Heiner Kallweit
2019-03-21 19:35                                       ` VDR User
2019-03-22 19:03                                         ` Heiner Kallweit
2019-03-22 20:44                                           ` VDR User
2019-04-04 14:28                                             ` VDR User
2019-04-04 19:41                                               ` Heiner Kallweit
2019-04-04 22:11                                                 ` VDR User

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA7C2qgC6VfFVidcxOBkeT0a1B1ZL7_O-WfgXZgAWBNvtHJY0A@mail.gmail.com \
    --to=user.vdr@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.