From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D480C43381 for ; Fri, 15 Mar 2019 20:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D189C218A1 for ; Fri, 15 Mar 2019 20:09:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJOScsna" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbfCOUJR (ORCPT ); Fri, 15 Mar 2019 16:09:17 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:39063 "EHLO mail-lf1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbfCOUJR (ORCPT ); Fri, 15 Mar 2019 16:09:17 -0400 Received: by mail-lf1-f47.google.com with SMTP id m13so7773141lfb.6 for ; Fri, 15 Mar 2019 13:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kD3+UNi6hkLsa1Q0zOz2RAe6UWR0AvCv9C0a1MvATto=; b=tJOScsnancaD9wi0MykOP8CCheDXVByRNpSk+rTHNQWx4aHz6uWDrA4u0/UiGZR9gh vgNbM8sWv9yt4lwmJduOfwqePXSgnTB3L9nyh9iiGcvM3/v9GlBH0fc4QOBsKLzBFtcr e+WN6t5Zxh5CAZZADpBTgCFgYaeMlVN4NgCaY1Qu0tXaYOT63yrTWcM2XtK911tmtuc+ 4qgSvFH5W/oyoaG0GKvxCzQVW4abJ6sG+KFicBv2vuITVMPJpNPpvKz4FY/GTxw9/iqg pGYv9nXVnP4uUHUGuwgyY8k6/tMZi7tCQ6obM06b81C3YhrZEhqVXVMXgUTCiRScN4MS aZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kD3+UNi6hkLsa1Q0zOz2RAe6UWR0AvCv9C0a1MvATto=; b=tvTyZuoftCx6PK7eOOqV/QOcBnfOMbUyuUMKlVLrKJD5zf3gAN37jpWmmC0pd2yaaC otVMy01XI7h81I7djEytQcZcuIoelqy49RvF4GG1QMHq96jSK56WtT+9eb7alz6evU/H CO2p6m9muD4dpy2JxCEncZKAXdTZ6cItvdvX3LGTzrHcKGDS5Ny8hP25WMuf9UC7JJXM kq4aL3M4b9VuuXzp7fdv09Mm8O5ApA+kl885r7y2W+2uTD1oWkAQGZaKnSPfcbdApXXW ugg1aYlGjJc3zZ1v2bcePXIccEAP+hs8y91eksIhdmx5THk/KmAQg06Z1JIKMmhkv9ZH HwpA== X-Gm-Message-State: APjAAAV+bi6WtZUHcoF6KwPpBAGGc7DHzyRDEQp2gvt4vN46qpBD8k1i 8JLyhd4FCit8Jb058cEaHCRbWMF7tcejYU10u6n/LNKE09o= X-Google-Smtp-Source: APXvYqw3nAt/J+xr+XWaYa1fx1hcm9GrVar8pidSnnWZKZf6WDo6o6y8NFSVLvdVrglldWvyYQGkwil8cwrWc2ewIhM= X-Received: by 2002:ac2:482f:: with SMTP id 15mr2121844lft.57.1552680555407; Fri, 15 Mar 2019 13:09:15 -0700 (PDT) MIME-Version: 1.0 References: <753b56b8-f1ab-82f5-f9b5-089fbb638989@gmail.com> <02388deb-0a06-95ae-1aac-b39c108fc2e7@gmail.com> In-Reply-To: From: VDR User Date: Fri, 15 Mar 2019 13:09:03 -0700 Message-ID: Subject: Re: r8169 driver from kernel 5.0 crashing To: Heiner Kallweit Cc: netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > >> Thanks for the additional info and for testing 4.20.15. > > >> To rule out that the issue is caused by a regression in network or > > >> some other subsystem: Can you take the r8169.c from 4.20.15 and test > > >> it on top of 5.0? > > >> Meanwhile I'll look at the changes in the driver between 4.20 and 5.0. > > > > > > Sure, no problem! I'll copy the driver & recompile now actually. > > > Hopefully there aren't a ton of changes to r8169.c to sift through and > > > the cause isn't good at hiding itself! > > > > > I checked the driver changes new in 5.0 and there are very few > > functional changes. You could try to revert the following: > > > > 5317d5c6d47e ("r8169: use napi_consume_skb where possible") > > Will do, and fwiw, while I haven't been able to do tons of testing > today, I haven't been able to trigger the crash after replacing > 5.0.0's r8169.c with 4.20.15's r8169.c this morning. I'll restore the > file and revert the change you mentioned, and report back my findings. Heiner, After going back to vanilla kernel 5.0 and then reverting 5317d5c6d47e ("r8169: use napi_consume_skb where possible"), I so far have not had any crashes after transferring roughly 30GB back & forth. I'm not completely confident yet the crash is resolve with that revert and will continue to do further testing throughout the weekend as well. What confidence level do you have that 5317d5c6d47e is the culprit at this point? Thanks, Derek