* hwmontempsensor issue in dbus-sensor
@ 2021-12-16 8:26 Kumar Thangavel
2021-12-20 5:12 ` Kumar Thangavel
0 siblings, 1 reply; 13+ messages in thread
From: Kumar Thangavel @ 2021-12-16 8:26 UTC (permalink / raw)
To: OpenBMC Maillist; +Cc: bruce.mitchell, velumanit, Jayashree D
[-- Attachment #1: Type: text/plain, Size: 2602 bytes --]
Hi All,
In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
While testing those changes in my platform, I found that each sensor in
hwmon temp has been creating twice.
After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is
created twice.
/sys/class/hwmon/hwmon2/temp2_input
/sys/class/hwmon/hwmon2/temp1_input
Before your change, hwmon temp sensor will check whether the path is
already exists or not.
If it exists, it will skip and proceed with next path.
https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
Could you please explain why it is creating twice in hwmon temp ?
Journalctl log before your changes applied :
Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
"/sys/class/hwmon/hwmon2/temp2_input"
Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
xyz.openbmc_project.Configuration.TMP421
Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
/xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
/xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
"/sys/class/hwmon/hwmon2/temp1_input"
Journalctl log after your changes applied :
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
"/sys/class/hwmon/hwmon2/temp2_input"
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
xyz.openbmc_project.Configuration.TMP421
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
/xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
/xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
"/sys/class/hwmon/hwmon2/temp1_input"
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
xyz.openbmc_project.Configuration.TMP421
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
/xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
/xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
Thanks,
Kumar.
[-- Attachment #2: Type: text/html, Size: 10799 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2021-12-16 8:26 hwmontempsensor issue in dbus-sensor Kumar Thangavel
@ 2021-12-20 5:12 ` Kumar Thangavel
2021-12-20 18:29 ` Ed Tanous
0 siblings, 1 reply; 13+ messages in thread
From: Kumar Thangavel @ 2021-12-20 5:12 UTC (permalink / raw)
To: OpenBMC Maillist; +Cc: bruce.mitchell, velumanit, Jayashree D
[-- Attachment #1: Type: text/plain, Size: 2866 bytes --]
Hi All,
Gentle Reminder on this.
Thanks,
Kumar.
On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <
kumarthangavel.hcl@gmail.com> wrote:
> Hi All,
>
>
> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
>
>
> While testing those changes in my platform, I found that each sensor in
> hwmon temp has been creating twice.
> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is
> created twice.
>
>
> /sys/class/hwmon/hwmon2/temp2_input
> /sys/class/hwmon/hwmon2/temp1_input
>
>
> Before your change, hwmon temp sensor will check whether the path is
> already exists or not.
> If it exists, it will skip and proceed with next path.
>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
>
>
> Could you please explain why it is creating twice in hwmon temp ?
>
>
> Journalctl log before your changes applied :
>
>
> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
> xyz.openbmc_project.Configuration.TMP421
> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
>
>
>
> Journalctl log after your changes applied :
>
>
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> xyz.openbmc_project.Configuration.TMP421
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>
>
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> xyz.openbmc_project.Configuration.TMP421
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>
>
>
> Thanks,
>
> Kumar.
>
[-- Attachment #2: Type: text/html, Size: 11259 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2021-12-20 5:12 ` Kumar Thangavel
@ 2021-12-20 18:29 ` Ed Tanous
2021-12-31 17:30 ` Bruce Mitchell
0 siblings, 1 reply; 13+ messages in thread
From: Ed Tanous @ 2021-12-20 18:29 UTC (permalink / raw)
To: Kumar Thangavel; +Cc: bruce.mitchell, Jayashree D, OpenBMC Maillist, velumanit
On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
<kumarthangavel.hcl@gmail.com> wrote:
>
> Hi All,
>
> Gentle Reminder on this.
>
> Thanks,
> Kumar.
>
> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <kumarthangavel.hcl@gmail.com> wrote:
>>
>> Hi All,
>>
>>
>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
Bruce, this is your patch. Could you take a look at the below and
provide your input?
>>
>>
>> While testing those changes in my platform, I found that each sensor in hwmon temp has been creating twice.
>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is created twice.
>>
>>
>> /sys/class/hwmon/hwmon2/temp2_input
>> /sys/class/hwmon/hwmon2/temp1_input
>>
>>
>> Before your change, hwmon temp sensor will check whether the path is already exists or not.
>> If it exists, it will skip and proceed with next path.
>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
>>
>>
>> Could you please explain why it is creating twice in hwmon temp ?
>>
>>
>> Journalctl log before your changes applied :
>>
>>
>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type : xyz.openbmc_project.Configuration.TMP421
>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
>>
>>
>>
>> Journalctl log after your changes applied :
>>
>>
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>
>>
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>
>>
>>
>> Thanks,
>>
>> Kumar.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2021-12-20 18:29 ` Ed Tanous
@ 2021-12-31 17:30 ` Bruce Mitchell
2021-12-31 20:12 ` Bruce Mitchell
2022-01-03 17:20 ` Ed Tanous
0 siblings, 2 replies; 13+ messages in thread
From: Bruce Mitchell @ 2021-12-31 17:30 UTC (permalink / raw)
To: Ed Tanous, Kumar Thangavel; +Cc: velumanit, OpenBMC Maillist, Jayashree D
On 12/20/2021 10:29, Ed Tanous wrote:
> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> <kumarthangavel.hcl@gmail.com> wrote:
>>
>> Hi All,
>>
>> Gentle Reminder on this.
>>
>> Thanks,
>> Kumar.
>>
>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <kumarthangavel.hcl@gmail.com> wrote:
>>>
>>> Hi All,
>>>
>>>
>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
>
> Bruce, this is your patch. Could you take a look at the below and
> provide your input?
>
>>>
>>>
>>> While testing those changes in my platform, I found that each sensor in hwmon temp has been creating twice.
>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is created twice.
>>>
>>>
>>> /sys/class/hwmon/hwmon2/temp2_input
>>> /sys/class/hwmon/hwmon2/temp1_input
>>>
>>>
>>> Before your change, hwmon temp sensor will check whether the path is already exists or not.
>>> If it exists, it will skip and proceed with next path.
>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
>>>
>>>
>>> Could you please explain why it is creating twice in hwmon temp ?
>>>
>>>
>>> Journalctl log before your changes applied :
>>>
>>>
>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type : xyz.openbmc_project.Configuration.TMP421
>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
>>>
>>>
>>>
>>> Journalctl log after your changes applied :
>>>
>>>
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>
>>>
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>
>>>
>>>
>>> Thanks,
>>>
>>> Kumar.
I will give it quick look today. Also today is my last day at IBM.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2021-12-31 17:30 ` Bruce Mitchell
@ 2021-12-31 20:12 ` Bruce Mitchell
2022-01-03 7:10 ` Kumar Thangavel
2022-01-03 17:20 ` Ed Tanous
1 sibling, 1 reply; 13+ messages in thread
From: Bruce Mitchell @ 2021-12-31 20:12 UTC (permalink / raw)
To: Ed Tanous, Kumar Thangavel; +Cc: velumanit, OpenBMC Maillist, Jayashree D
On 12/31/2021 09:30, Bruce Mitchell wrote:
> On 12/20/2021 10:29, Ed Tanous wrote:
>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
>> <kumarthangavel.hcl@gmail.com> wrote:
>>>
>>> Hi All,
>>>
>>> Gentle Reminder on this.
>>>
>>> Thanks,
>>> Kumar.
>>>
>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel
>>> <kumarthangavel.hcl@gmail.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>>
>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
>>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
>>>>
>>
>> Bruce, this is your patch. Could you take a look at the below and
>> provide your input?
>>
>>>>
>>>>
>>>> While testing those changes in my platform, I found that each sensor
>>>> in hwmon temp has been creating twice.
>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is
>>>> created twice.
>>>>
>>>>
>>>> /sys/class/hwmon/hwmon2/temp2_input
>>>> /sys/class/hwmon/hwmon2/temp1_input
>>>>
>>>>
>>>> Before your change, hwmon temp sensor will check whether the path is
>>>> already exists or not.
>>>> If it exists, it will skip and proceed with next path.
>>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
>>>>
>>>>
>>>>
>>>> Could you please explain why it is creating twice in hwmon temp ?
>>>>
>>>>
>>>> Journalctl log before your changes applied :
>>>>
>>>>
>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
>>>> "/sys/class/hwmon/hwmon2/temp2_input"
>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
>>>> xyz.openbmc_project.Configuration.TMP421
>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
>>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
>>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
>>>> "/sys/class/hwmon/hwmon2/temp1_input"
>>>>
>>>>
>>>>
>>>> Journalctl log after your changes applied :
>>>>
>>>>
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
>>>> "/sys/class/hwmon/hwmon2/temp2_input"
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
>>>> xyz.openbmc_project.Configuration.TMP421
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
>>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
>>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>>
>>>>
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
>>>> "/sys/class/hwmon/hwmon2/temp1_input"
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
>>>> xyz.openbmc_project.Configuration.TMP421
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
>>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
>>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>>
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Kumar.
>
> I will give it quick look today. Also today is my last day at IBM.
>
The problem I had to solve was that I was adding devices
(DPS310 and Si7020 type) that has more than one sensor type
per device, in this case under /sys/bus/iio/devices .
So the loop cannot continue after finding the first sensor of
the device. I have not seen p10bmc /sys/class/hwmon temperature
sensors being created twice, in this case the TMP75.
What is the entity-manager configuration for your system?
I suspect that the dbus-sensors Hwmon does not take into account
some detail that is needs to related to entity-manager.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2021-12-31 20:12 ` Bruce Mitchell
@ 2022-01-03 7:10 ` Kumar Thangavel
0 siblings, 0 replies; 13+ messages in thread
From: Kumar Thangavel @ 2022-01-03 7:10 UTC (permalink / raw)
To: Bruce Mitchell; +Cc: velumanit, Ed Tanous, Jayashree D, OpenBMC Maillist
[-- Attachment #1: Type: text/plain, Size: 4542 bytes --]
Thanks Bruce for your response.
Please find below the entitymanager hwmon sensor configuration path for our
system.
https://github.com/openbmc/entity-manager/blob/master/configurations/FBYV2.json#L434
Thanks,
Kumar.
On Sat, Jan 1, 2022 at 1:42 AM Bruce Mitchell <
bruce.mitchell@linux.vnet.ibm.com> wrote:
> On 12/31/2021 09:30, Bruce Mitchell wrote:
> > On 12/20/2021 10:29, Ed Tanous wrote:
> >> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> >> <kumarthangavel.hcl@gmail.com> wrote:
> >>>
> >>> Hi All,
> >>>
> >>> Gentle Reminder on this.
> >>>
> >>> Thanks,
> >>> Kumar.
> >>>
> >>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel
> >>> <kumarthangavel.hcl@gmail.com> wrote:
> >>>>
> >>>> Hi All,
> >>>>
> >>>>
> >>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp
> Sensor.
> >>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> >>>>
> >>
> >> Bruce, this is your patch. Could you take a look at the below and
> >> provide your input?
> >>
> >>>>
> >>>>
> >>>> While testing those changes in my platform, I found that each sensor
> >>>> in hwmon temp has been creating twice.
> >>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is
> >>>> created twice.
> >>>>
> >>>>
> >>>> /sys/class/hwmon/hwmon2/temp2_input
> >>>> /sys/class/hwmon/hwmon2/temp1_input
> >>>>
> >>>>
> >>>> Before your change, hwmon temp sensor will check whether the path is
> >>>> already exists or not.
> >>>> If it exists, it will skip and proceed with next path.
> >>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> >>>>
> >>>>
> >>>>
> >>>> Could you please explain why it is creating twice in hwmon temp ?
> >>>>
> >>>>
> >>>> Journalctl log before your changes applied :
> >>>>
> >>>>
> >>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> >>>> "/sys/class/hwmon/hwmon2/temp2_input"
> >>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
> >>>> xyz.openbmc_project.Configuration.TMP421
> >>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
> >>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> >>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> >>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> >>>> "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>
> >>>>
> >>>>
> >>>> Journalctl log after your changes applied :
> >>>>
> >>>>
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> >>>> "/sys/class/hwmon/hwmon2/temp2_input"
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> >>>> xyz.openbmc_project.Configuration.TMP421
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> >>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> >>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>
> >>>>
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> >>>> "/sys/class/hwmon/hwmon2/temp1_input"
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> >>>> xyz.openbmc_project.Configuration.TMP421
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> >>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> >>>> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>
> >>>>
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Kumar.
> >
> > I will give it quick look today. Also today is my last day at IBM.
> >
>
> The problem I had to solve was that I was adding devices
> (DPS310 and Si7020 type) that has more than one sensor type
> per device, in this case under /sys/bus/iio/devices .
> So the loop cannot continue after finding the first sensor of
> the device. I have not seen p10bmc /sys/class/hwmon temperature
> sensors being created twice, in this case the TMP75.
>
> What is the entity-manager configuration for your system?
> I suspect that the dbus-sensors Hwmon does not take into account
> some detail that is needs to related to entity-manager.
>
>
>
[-- Attachment #2: Type: text/html, Size: 7015 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2021-12-31 17:30 ` Bruce Mitchell
2021-12-31 20:12 ` Bruce Mitchell
@ 2022-01-03 17:20 ` Ed Tanous
2022-01-03 21:09 ` Patrick Williams
1 sibling, 1 reply; 13+ messages in thread
From: Ed Tanous @ 2022-01-03 17:20 UTC (permalink / raw)
To: Bruce Mitchell
Cc: Jayashree D, Ed Tanous, velumanit, Kumar Thangavel, OpenBMC Maillist
On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
<bruce.mitchell@linux.vnet.ibm.com> wrote:
>
> On 12/20/2021 10:29, Ed Tanous wrote:
> > On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> > <kumarthangavel.hcl@gmail.com> wrote:
> >>
> >> Hi All,
> >>
> >> Gentle Reminder on this.
> >>
> >> Thanks,
> >> Kumar.
> >>
> >> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <kumarthangavel.hcl@gmail.com> wrote:
> >>>
> >>> Hi All,
> >>>
> >>>
> >>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
> >>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> >
> > Bruce, this is your patch. Could you take a look at the below and
> > provide your input?
> >
> >>>
> >>>
> >>> While testing those changes in my platform, I found that each sensor in hwmon temp has been creating twice.
> >>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is created twice.
> >>>
> >>>
> >>> /sys/class/hwmon/hwmon2/temp2_input
> >>> /sys/class/hwmon/hwmon2/temp1_input
> >>>
> >>>
> >>> Before your change, hwmon temp sensor will check whether the path is already exists or not.
> >>> If it exists, it will skip and proceed with next path.
> >>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> >>>
> >>>
> >>> Could you please explain why it is creating twice in hwmon temp ?
> >>>
> >>>
> >>> Journalctl log before your changes applied :
> >>>
> >>>
> >>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
> >>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type : xyz.openbmc_project.Configuration.TMP421
> >>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
> >>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
> >>>
> >>>
> >>>
> >>> Journalctl log after your changes applied :
> >>>
> >>>
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>
> >>>
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> Kumar.
>
> I will give it quick look today. Also today is my last day at IBM.
>
Do you plan on continuing this beyond your tenure at IBM? If not, is
someone taking this feature over for you? Given it's been a few weeks
since this regression was reported, and I don't see any fixes in
review, I'm leaning toward reverting it on master for the time being
until someone puts up a patch to fix the issue.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2022-01-03 17:20 ` Ed Tanous
@ 2022-01-03 21:09 ` Patrick Williams
2022-01-04 7:36 ` Kumar Thangavel
2022-01-04 18:38 ` Ed Tanous
0 siblings, 2 replies; 13+ messages in thread
From: Patrick Williams @ 2022-01-03 21:09 UTC (permalink / raw)
To: Ed Tanous
Cc: Bruce Mitchell, OpenBMC Maillist, Jayashree D, Kumar Thangavel,
Ed Tanous, velumanit
Ed,
I think there are other commits needing the IIO functionality now. There is at least the pending commit for Humidity that we’d like to get merged. I think it is better to move forward with a fix rather than backwards with a revert at this point.
Kumar/Jayashree,
Can you dig into this and get to the bottom of it?
- Patrick
Sent from my iPhone
> On Jan 3, 2022, at 11:21 AM, Ed Tanous <ed@tanous.net> wrote:
>
> On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
> <bruce.mitchell@linux.vnet.ibm.com> wrote:
>>
>>> On 12/20/2021 10:29, Ed Tanous wrote:
>>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
>>> <kumarthangavel.hcl@gmail.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Gentle Reminder on this.
>>>>
>>>> Thanks,
>>>> Kumar.
>>>>
>>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <kumarthangavel.hcl@gmail.com> wrote:
>>>>>
>>>>> Hi All,
>>>>>
>>>>>
>>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
>>>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
>>>
>>> Bruce, this is your patch. Could you take a look at the below and
>>> provide your input?
>>>
>>>>>
>>>>>
>>>>> While testing those changes in my platform, I found that each sensor in hwmon temp has been creating twice.
>>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is created twice.
>>>>>
>>>>>
>>>>> /sys/class/hwmon/hwmon2/temp2_input
>>>>> /sys/class/hwmon/hwmon2/temp1_input
>>>>>
>>>>>
>>>>> Before your change, hwmon temp sensor will check whether the path is already exists or not.
>>>>> If it exists, it will skip and proceed with next path.
>>>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
>>>>>
>>>>>
>>>>> Could you please explain why it is creating twice in hwmon temp ?
>>>>>
>>>>>
>>>>> Journalctl log before your changes applied :
>>>>>
>>>>>
>>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
>>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type : xyz.openbmc_project.Configuration.TMP421
>>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
>>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
>>>>>
>>>>>
>>>>>
>>>>> Journalctl log after your changes applied :
>>>>>
>>>>>
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>>>
>>>>>
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
>>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Kumar.
>>
>> I will give it quick look today. Also today is my last day at IBM.
>>
>
> Do you plan on continuing this beyond your tenure at IBM? If not, is
> someone taking this feature over for you? Given it's been a few weeks
> since this regression was reported, and I don't see any fixes in
> review, I'm leaning toward reverting it on master for the time being
> until someone puts up a patch to fix the issue.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2022-01-03 21:09 ` Patrick Williams
@ 2022-01-04 7:36 ` Kumar Thangavel
2022-01-04 14:35 ` Matt Spinler
2022-01-04 18:38 ` Ed Tanous
1 sibling, 1 reply; 13+ messages in thread
From: Kumar Thangavel @ 2022-01-04 7:36 UTC (permalink / raw)
To: Patrick Williams
Cc: Bruce Mitchell, OpenBMC Maillist, Ed Tanous, Jayashree D,
Ed Tanous, velumanit
[-- Attachment #1: Type: text/plain, Size: 5036 bytes --]
Hi Patrick/Ed,
We are already working on this to fix this issue. Since that patch
was submitted by Bruce, we posted this in the mailing list to get his
opinion.
After fixing this issue, we will submit the patch in gerrit. We need help
in testing this fix in IBM platforms.
Thanks,
Kumar.
On Tue, Jan 4, 2022 at 2:39 AM Patrick Williams <patrick@stwcx.xyz> wrote:
> Ed,
>
> I think there are other commits needing the IIO functionality now. There
> is at least the pending commit for Humidity that we’d like to get merged. I
> think it is better to move forward with a fix rather than backwards with a
> revert at this point.
>
> Kumar/Jayashree,
>
> Can you dig into this and get to the bottom of it?
>
> - Patrick
> Sent from my iPhone
>
> > On Jan 3, 2022, at 11:21 AM, Ed Tanous <ed@tanous.net> wrote:
> >
> > On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
> > <bruce.mitchell@linux.vnet.ibm.com> wrote:
> >>
> >>> On 12/20/2021 10:29, Ed Tanous wrote:
> >>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> >>> <kumarthangavel.hcl@gmail.com> wrote:
> >>>>
> >>>> Hi All,
> >>>>
> >>>> Gentle Reminder on this.
> >>>>
> >>>> Thanks,
> >>>> Kumar.
> >>>>
> >>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <
> kumarthangavel.hcl@gmail.com> wrote:
> >>>>>
> >>>>> Hi All,
> >>>>>
> >>>>>
> >>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp
> Sensor.
> >>>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> >>>
> >>> Bruce, this is your patch. Could you take a look at the below and
> >>> provide your input?
> >>>
> >>>>>
> >>>>>
> >>>>> While testing those changes in my platform, I found that each sensor
> in hwmon temp has been creating twice.
> >>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is
> created twice.
> >>>>>
> >>>>>
> >>>>> /sys/class/hwmon/hwmon2/temp2_input
> >>>>> /sys/class/hwmon/hwmon2/temp1_input
> >>>>>
> >>>>>
> >>>>> Before your change, hwmon temp sensor will check whether the path is
> already exists or not.
> >>>>> If it exists, it will skip and proceed with next path.
> >>>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> >>>>>
> >>>>>
> >>>>> Could you please explain why it is creating twice in hwmon temp ?
> >>>>>
> >>>>>
> >>>>> Journalctl log before your changes applied :
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
> xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name :
> SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>>
> >>>>>
> >>>>>
> >>>>> Journalctl log after your changes applied :
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>>
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Kumar.
> >>
> >> I will give it quick look today. Also today is my last day at IBM.
> >>
> >
> > Do you plan on continuing this beyond your tenure at IBM? If not, is
> > someone taking this feature over for you? Given it's been a few weeks
> > since this regression was reported, and I don't see any fixes in
> > review, I'm leaning toward reverting it on master for the time being
> > until someone puts up a patch to fix the issue.
>
>
[-- Attachment #2: Type: text/html, Size: 8620 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2022-01-04 7:36 ` Kumar Thangavel
@ 2022-01-04 14:35 ` Matt Spinler
2022-01-04 15:01 ` Kumar Thangavel
0 siblings, 1 reply; 13+ messages in thread
From: Matt Spinler @ 2022-01-04 14:35 UTC (permalink / raw)
To: Kumar Thangavel, Patrick Williams
Cc: Bruce Mitchell, OpenBMC Maillist, Ed Tanous, Jayashree D,
Ed Tanous, velumanit
On 1/4/2022 1:36 AM, Kumar Thangavel wrote:
> Hi Patrick/Ed, We are already working on this to fix this issue. Since
> that patch was submitted by Bruce, we posted this in the mailing list
> to get his opinion. After fixing this issue, we will submit the patch
> in gerrit. We need help in testing ZjQcmQRYFpfptBannerStart
> ZjQcmQRYFpfptBannerEnd
> Hi Patrick/Ed,
>
> We are already working on this to fix this issue. Since that patch was
> submitted by Bruce, we posted this in the mailing list to get his
> opinion.
> After fixing this issue, we will submit the patch in gerrit. We need
> help in testing this fix in IBM platforms.
>
I can help test on an IBM system.
> Thanks,
> Kumar.
>
>
>
>
> On Tue, Jan 4, 2022 at 2:39 AM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> Ed,
>
> I think there are other commits needing the IIO functionality now.
> There is at least the pending commit for Humidity that we’d like
> to get merged. I think it is better to move forward with a fix
> rather than backwards with a revert at this point.
>
> Kumar/Jayashree,
>
> Can you dig into this and get to the bottom of it?
>
> - Patrick
> Sent from my iPhone
>
> > On Jan 3, 2022, at 11:21 AM, Ed Tanous <ed@tanous.net> wrote:
> >
> > On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
> > <bruce.mitchell@linux.vnet.ibm.com> wrote:
> >>
> >>> On 12/20/2021 10:29, Ed Tanous wrote:
> >>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> >>> <kumarthangavel.hcl@gmail.com> wrote:
> >>>>
> >>>> Hi All,
> >>>>
> >>>> Gentle Reminder on this.
> >>>>
> >>>> Thanks,
> >>>> Kumar.
> >>>>
> >>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel
> <kumarthangavel.hcl@gmail.com> wrote:
> >>>>>
> >>>>> Hi All,
> >>>>>
> >>>>>
> >>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon
> Temp Sensor.
> >>>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> >>>
> >>> Bruce, this is your patch. Could you take a look at the below and
> >>> provide your input?
> >>>
> >>>>>
> >>>>>
> >>>>> While testing those changes in my platform, I found that
> each sensor in hwmon temp has been creating twice.
> >>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP
> sensor is created twice.
> >>>>>
> >>>>>
> >>>>> /sys/class/hwmon/hwmon2/temp2_input
> >>>>> /sys/class/hwmon/hwmon2/temp1_input
> >>>>>
> >>>>>
> >>>>> Before your change, hwmon temp sensor will check whether the
> path is already exists or not.
> >>>>> If it exists, it will skip and proceed with next path.
> >>>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> >>>>>
> >>>>>
> >>>>> Could you please explain why it is creating twice in hwmon
> temp ?
> >>>>>
> >>>>>
> >>>>> Journalctl log before your changes applied :
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
> xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name :
> SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>>
> >>>>>
> >>>>>
> >>>>> Journalctl log after your changes applied :
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type
> : xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type
> : xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>>
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Kumar.
> >>
> >> I will give it quick look today. Also today is my last day at IBM.
> >>
> >
> > Do you plan on continuing this beyond your tenure at IBM? If
> not, is
> > someone taking this feature over for you? Given it's been a few
> weeks
> > since this regression was reported, and I don't see any fixes in
> > review, I'm leaning toward reverting it on master for the time being
> > until someone puts up a patch to fix the issue.
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2022-01-04 14:35 ` Matt Spinler
@ 2022-01-04 15:01 ` Kumar Thangavel
0 siblings, 0 replies; 13+ messages in thread
From: Kumar Thangavel @ 2022-01-04 15:01 UTC (permalink / raw)
To: Matt Spinler
Cc: Bruce Mitchell, OpenBMC Maillist, Ed Tanous, Jayashree D,
Ed Tanous, velumanit
[-- Attachment #1: Type: text/plain, Size: 6362 bytes --]
Thanks Matt.
On Tue, Jan 4, 2022 at 8:06 PM Matt Spinler <mspinler@linux.ibm.com> wrote:
>
>
> On 1/4/2022 1:36 AM, Kumar Thangavel wrote:
> > Hi Patrick/Ed, We are already working on this to fix this issue. Since
> > that patch was submitted by Bruce, we posted this in the mailing list
> > to get his opinion. After fixing this issue, we will submit the patch
> > in gerrit. We need help in testing ZjQcmQRYFpfptBannerStart
> > ZjQcmQRYFpfptBannerEnd
> > Hi Patrick/Ed,
> >
> > We are already working on this to fix this issue. Since that patch was
> > submitted by Bruce, we posted this in the mailing list to get his
> > opinion.
> > After fixing this issue, we will submit the patch in gerrit. We need
> > help in testing this fix in IBM platforms.
> >
>
> I can help test on an IBM system.
>
> > Thanks,
> > Kumar.
> >
> >
> >
> >
> > On Tue, Jan 4, 2022 at 2:39 AM Patrick Williams <patrick@stwcx.xyz>
> wrote:
> >
> > Ed,
> >
> > I think there are other commits needing the IIO functionality now.
> > There is at least the pending commit for Humidity that we’d like
> > to get merged. I think it is better to move forward with a fix
> > rather than backwards with a revert at this point.
> >
> > Kumar/Jayashree,
> >
> > Can you dig into this and get to the bottom of it?
> >
> > - Patrick
> > Sent from my iPhone
> >
> > > On Jan 3, 2022, at 11:21 AM, Ed Tanous <ed@tanous.net> wrote:
> > >
> > > On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
> > > <bruce.mitchell@linux.vnet.ibm.com> wrote:
> > >>
> > >>> On 12/20/2021 10:29, Ed Tanous wrote:
> > >>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> > >>> <kumarthangavel.hcl@gmail.com> wrote:
> > >>>>
> > >>>> Hi All,
> > >>>>
> > >>>> Gentle Reminder on this.
> > >>>>
> > >>>> Thanks,
> > >>>> Kumar.
> > >>>>
> > >>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel
> > <kumarthangavel.hcl@gmail.com> wrote:
> > >>>>>
> > >>>>> Hi All,
> > >>>>>
> > >>>>>
> > >>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon
> > Temp Sensor.
> > >>>>>
> >
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> > >>>
> > >>> Bruce, this is your patch. Could you take a look at the below
> and
> > >>> provide your input?
> > >>>
> > >>>>>
> > >>>>>
> > >>>>> While testing those changes in my platform, I found that
> > each sensor in hwmon temp has been creating twice.
> > >>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP
> > sensor is created twice.
> > >>>>>
> > >>>>>
> > >>>>> /sys/class/hwmon/hwmon2/temp2_input
> > >>>>> /sys/class/hwmon/hwmon2/temp1_input
> > >>>>>
> > >>>>>
> > >>>>> Before your change, hwmon temp sensor will check whether the
> > path is already exists or not.
> > >>>>> If it exists, it will skip and proceed with next path.
> > >>>>>
> >
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> > >>>>>
> > >>>>>
> > >>>>> Could you please explain why it is creating twice in hwmon
> > temp ?
> > >>>>>
> > >>>>>
> > >>>>> Journalctl log before your changes applied :
> > >>>>>
> > >>>>>
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> > "/sys/class/hwmon/hwmon2/temp2_input"
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
> > xyz.openbmc_project.Configuration.TMP421
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name :
> > SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> > /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> > /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> > "/sys/class/hwmon/hwmon2/temp1_input"
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> Journalctl log after your changes applied :
> > >>>>>
> > >>>>>
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> > "/sys/class/hwmon/hwmon2/temp2_input"
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type
> > : xyz.openbmc_project.Configuration.TMP421
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> > SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> > /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> > /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> > >>>>>
> > >>>>>
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> > "/sys/class/hwmon/hwmon2/temp1_input"
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type
> > : xyz.openbmc_project.Configuration.TMP421
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> > SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> > /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> > /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> Thanks,
> > >>>>>
> > >>>>> Kumar.
> > >>
> > >> I will give it quick look today. Also today is my last day at
> IBM.
> > >>
> > >
> > > Do you plan on continuing this beyond your tenure at IBM? If
> > not, is
> > > someone taking this feature over for you? Given it's been a few
> > weeks
> > > since this regression was reported, and I don't see any fixes in
> > > review, I'm leaning toward reverting it on master for the time
> being
> > > until someone puts up a patch to fix the issue.
> >
>
>
[-- Attachment #2: Type: text/html, Size: 9653 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2022-01-03 21:09 ` Patrick Williams
2022-01-04 7:36 ` Kumar Thangavel
@ 2022-01-04 18:38 ` Ed Tanous
2022-01-06 12:54 ` Kumar Thangavel
1 sibling, 1 reply; 13+ messages in thread
From: Ed Tanous @ 2022-01-04 18:38 UTC (permalink / raw)
To: Patrick Williams
Cc: Bruce Mitchell, OpenBMC Maillist, Ed Tanous, Jayashree D,
Kumar Thangavel, velumanit
On Mon, Jan 3, 2022 at 1:09 PM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> Ed,
>
> I think there are other commits needing the IIO functionality now. There is at least the pending commit for Humidity that we’d like to get merged. I think it is better to move forward with a fix rather than backwards with a revert at this point.
Sure, if there are patches available to fix the regression, I'm happy
to avoid the revert. I'll let this sit another day or two to see if
someone puts up a patch to fix the issue, but after that, we need to
unbreak master, and in the absence of a patch to fix it, a revert is
the next best option.
>
> Kumar/Jayashree,
>
> Can you dig into this and get to the bottom of it?
>
> - Patrick
> Sent from my iPhone
>
> > On Jan 3, 2022, at 11:21 AM, Ed Tanous <ed@tanous.net> wrote:
> >
> > On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
> > <bruce.mitchell@linux.vnet.ibm.com> wrote:
> >>
> >>> On 12/20/2021 10:29, Ed Tanous wrote:
> >>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> >>> <kumarthangavel.hcl@gmail.com> wrote:
> >>>>
> >>>> Hi All,
> >>>>
> >>>> Gentle Reminder on this.
> >>>>
> >>>> Thanks,
> >>>> Kumar.
> >>>>
> >>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <kumarthangavel.hcl@gmail.com> wrote:
> >>>>>
> >>>>> Hi All,
> >>>>>
> >>>>>
> >>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp Sensor.
> >>>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> >>>
> >>> Bruce, this is your patch. Could you take a look at the below and
> >>> provide your input?
> >>>
> >>>>>
> >>>>>
> >>>>> While testing those changes in my platform, I found that each sensor in hwmon temp has been creating twice.
> >>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor is created twice.
> >>>>>
> >>>>>
> >>>>> /sys/class/hwmon/hwmon2/temp2_input
> >>>>> /sys/class/hwmon/hwmon2/temp1_input
> >>>>>
> >>>>>
> >>>>> Before your change, hwmon temp sensor will check whether the path is already exists or not.
> >>>>> If it exists, it will skip and proceed with next path.
> >>>>> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> >>>>>
> >>>>>
> >>>>> Could you please explain why it is creating twice in hwmon temp ?
> >>>>>
> >>>>>
> >>>>> Journalctl log before your changes applied :
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type : xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name : SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>>
> >>>>>
> >>>>>
> >>>>> Journalctl log after your changes applied :
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp2_input"
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>>
> >>>>>
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : "/sys/class/hwmon/hwmon2/temp1_input"
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type : xyz.openbmc_project.Configuration.TMP421
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name : SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path : /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> >>>>>
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Kumar.
> >>
> >> I will give it quick look today. Also today is my last day at IBM.
> >>
> >
> > Do you plan on continuing this beyond your tenure at IBM? If not, is
> > someone taking this feature over for you? Given it's been a few weeks
> > since this regression was reported, and I don't see any fixes in
> > review, I'm leaning toward reverting it on master for the time being
> > until someone puts up a patch to fix the issue.
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmontempsensor issue in dbus-sensor
2022-01-04 18:38 ` Ed Tanous
@ 2022-01-06 12:54 ` Kumar Thangavel
0 siblings, 0 replies; 13+ messages in thread
From: Kumar Thangavel @ 2022-01-06 12:54 UTC (permalink / raw)
To: Ed Tanous
Cc: Bruce Mitchell, OpenBMC Maillist, Ed Tanous, Jayashree D, velumanit
[-- Attachment #1: Type: text/plain, Size: 5470 bytes --]
Hi All,
Please find the below patch to fix this issue.
https://gerrit.openbmc-project.xyz/c/openbmc/dbus-sensors/+/50153
Thanks,
Kumar.
On Wed, Jan 5, 2022 at 12:08 AM Ed Tanous <edtanous@google.com> wrote:
> On Mon, Jan 3, 2022 at 1:09 PM Patrick Williams <patrick@stwcx.xyz> wrote:
> >
> > Ed,
> >
> > I think there are other commits needing the IIO functionality now. There
> is at least the pending commit for Humidity that we’d like to get merged. I
> think it is better to move forward with a fix rather than backwards with a
> revert at this point.
>
> Sure, if there are patches available to fix the regression, I'm happy
> to avoid the revert. I'll let this sit another day or two to see if
> someone puts up a patch to fix the issue, but after that, we need to
> unbreak master, and in the absence of a patch to fix it, a revert is
> the next best option.
>
> >
> > Kumar/Jayashree,
> >
> > Can you dig into this and get to the bottom of it?
> >
> > - Patrick
> > Sent from my iPhone
> >
> > > On Jan 3, 2022, at 11:21 AM, Ed Tanous <ed@tanous.net> wrote:
> > >
> > > On Fri, Dec 31, 2021 at 9:31 AM Bruce Mitchell
> > > <bruce.mitchell@linux.vnet.ibm.com> wrote:
> > >>
> > >>> On 12/20/2021 10:29, Ed Tanous wrote:
> > >>> On Sun, Dec 19, 2021 at 9:11 PM Kumar Thangavel
> > >>> <kumarthangavel.hcl@gmail.com> wrote:
> > >>>>
> > >>>> Hi All,
> > >>>>
> > >>>> Gentle Reminder on this.
> > >>>>
> > >>>> Thanks,
> > >>>> Kumar.
> > >>>>
> > >>>> On Thu, Dec 16, 2021 at 1:56 PM Kumar Thangavel <
> kumarthangavel.hcl@gmail.com> wrote:
> > >>>>>
> > >>>>> Hi All,
> > >>>>>
> > >>>>>
> > >>>>> In dbus-sensors repo, I saw the patch for changes in Hwmon Temp
> Sensor.
> > >>>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7ab
> > >>>
> > >>> Bruce, this is your patch. Could you take a look at the below and
> > >>> provide your input?
> > >>>
> > >>>>>
> > >>>>>
> > >>>>> While testing those changes in my platform, I found that each
> sensor in hwmon temp has been creating twice.
> > >>>>> After analyzed the patch, for below 2 paths SP_OUTLET_TEMP sensor
> is created twice.
> > >>>>>
> > >>>>>
> > >>>>> /sys/class/hwmon/hwmon2/temp2_input
> > >>>>> /sys/class/hwmon/hwmon2/temp1_input
> > >>>>>
> > >>>>>
> > >>>>> Before your change, hwmon temp sensor will check whether the path
> is already exists or not.
> > >>>>> If it exists, it will skip and proceed with next path.
> > >>>>>
> https://github.com/openbmc/dbus-sensors/commit/544e7dc58cecef898fe7d684c3ba0fbce178cf2d#diff-bfc8d7ed4ade4b3519ad3b7fe091f9c79a60faf8a26f410c1568e5341b22b7abL96
> > >>>>>
> > >>>>>
> > >>>>> Could you please explain why it is creating twice in hwmon temp ?
> > >>>>>
> > >>>>>
> > >>>>> Journalctl log before your changes applied :
> > >>>>>
> > >>>>>
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Type :
> xyz.openbmc_project.Configuration.TMP421
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Name :
> SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Dbus path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> > >>>>> Dec 31 16:01:32 yosemitev2 hwmontempsensor[286]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> Journalctl log after your changes applied :
> > >>>>>
> > >>>>>
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp2_input"
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> xyz.openbmc_project.Configuration.TMP421
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> > >>>>>
> > >>>>>
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> "/sys/class/hwmon/hwmon2/temp1_input"
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Sensor type :
> xyz.openbmc_project.Configuration.TMP421
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Name :
> SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_TEMP
> > >>>>> Dec 31 16:01:54 yosemitev2 hwmontempsensor[327]: Path :
> /xyz/openbmc_project/sensors/temperature/SP_OUTLET_REMOTE_TEMP
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> Thanks,
> > >>>>>
> > >>>>> Kumar.
> > >>
> > >> I will give it quick look today. Also today is my last day at IBM.
> > >>
> > >
> > > Do you plan on continuing this beyond your tenure at IBM? If not, is
> > > someone taking this feature over for you? Given it's been a few weeks
> > > since this regression was reported, and I don't see any fixes in
> > > review, I'm leaning toward reverting it on master for the time being
> > > until someone puts up a patch to fix the issue.
> >
>
[-- Attachment #2: Type: text/html, Size: 8664 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-01-06 12:52 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 8:26 hwmontempsensor issue in dbus-sensor Kumar Thangavel
2021-12-20 5:12 ` Kumar Thangavel
2021-12-20 18:29 ` Ed Tanous
2021-12-31 17:30 ` Bruce Mitchell
2021-12-31 20:12 ` Bruce Mitchell
2022-01-03 7:10 ` Kumar Thangavel
2022-01-03 17:20 ` Ed Tanous
2022-01-03 21:09 ` Patrick Williams
2022-01-04 7:36 ` Kumar Thangavel
2022-01-04 14:35 ` Matt Spinler
2022-01-04 15:01 ` Kumar Thangavel
2022-01-04 18:38 ` Ed Tanous
2022-01-06 12:54 ` Kumar Thangavel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.