From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC81ECAAA1 for ; Fri, 16 Sep 2022 20:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbiIPUcE (ORCPT ); Fri, 16 Sep 2022 16:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiIPUcD (ORCPT ); Fri, 16 Sep 2022 16:32:03 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B765AB6D2C for ; Fri, 16 Sep 2022 13:32:01 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id a67so34218314ybb.3 for ; Fri, 16 Sep 2022 13:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=GRh26cFwQmVn7OIiMmR3DjGYjriMibnaOhbeY2+3sjM=; b=BfoyE0LkVmBBKGIHuxpDCE+BCln/CDNhvbxAl7sMmIyBU3SrU4fVaCUh2bS2EgKVGk ADDCoyn9+yimo2xfpSpUlaI6QmCJgYTZP75RwL3E7BBOSU5mnh7DvqJcGPPM85v7ujUL JVRuxaCXp6WnoG2HXf8o26x8KPSrJFQcdsR18WoODlHY/LvOf1TBv+HxbF37FYhy3AsD RudWNISblVl1rlRxGi057rp7nGt443lh9mGJPSnLml5yZw1roMH6XR2Q80PHea7iK4Uk 6bvknnPdHU0wKG6YUWaJZ0W84/xK4nknEWyxub1RUCsOM/Cj0IG1DG/Yp9mutqB7RmTx 7Qkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=GRh26cFwQmVn7OIiMmR3DjGYjriMibnaOhbeY2+3sjM=; b=ZzjkAp4WIschuIYwlaw9zSp6x/MkHv7WmTV6Pdid6gvFDruO9hk0/DQPMmpYw49YMQ 9zVidzwkfM/dlgCXtAtuGqSEv0hRf86VHJSYfsrZrFPH/V73iaNefhjqkUBfF4baxnfJ NaJyZSkaR/FJIa9iKZ/JXvN+49DmUbzh2fPY+Y/6GCy3hMMRz++ncJORRLgr9t+E6+Tp LGcT8cM8xBTMLwhzTlXsC5RsUjBJdEYm99EpKAkwA0Bu+yb7LJLEO/YHdcu0xUWN6TpB GkD5sbzBb7U0k/DZPeszwIiB8wynaJHl1rdmue8Gu3fvN2blOXEdjDBwD6Y84M7LgzpQ Hgng== X-Gm-Message-State: ACrzQf1w2xggGjj7uK1WQbc3tBUjjnSqV/85vR2Bd3g8WsVSrF64x2dg ncIKxDsXran81Ln7m23Eaq+LR0Qha1JCqa2kCQ1R3A== X-Google-Smtp-Source: AMsMyM47ZFSxFzPSeM9JxQQYj7YoU1ApWVX4CGB1O21SkKvkUUp0w154rWQAB652f3pFKP7WrHw01ot/5jKhwkb1hb8= X-Received: by 2002:a5b:2ce:0:b0:67a:6054:9eb0 with SMTP id h14-20020a5b02ce000000b0067a60549eb0mr5692895ybp.15.1663360320932; Fri, 16 Sep 2022 13:32:00 -0700 (PDT) MIME-Version: 1.0 References: <20220914142256.28775-1-ansuelsmth@gmail.com> <20220914142256.28775-3-ansuelsmth@gmail.com> <20220916191715.GA1079300-robh@kernel.org> <6324d1be.050a0220.9d842.7b47@mx.google.com> <6324d8e1.170a0220.aba35.ba4f@mx.google.com> <6324dc1b.df0a0220.97787.083c@mx.google.com> In-Reply-To: <6324dc1b.df0a0220.97787.083c@mx.google.com> From: Dmitry Baryshkov Date: Fri, 16 Sep 2022 23:31:49 +0300 Message-ID: Subject: Re: [PATCH v5 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml To: Christian Marangi Cc: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Alexey Dobriyan , Takashi Iwai , Christian Brauner , Ranjani Sridharan , Marc Herbert , James Smart , Justin Tee , Pierre-Louis Bossart , "Martin K. Petersen" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 16 Sept 2022 at 23:27, Christian Marangi wrote: > > On Fri, Sep 16, 2022 at 11:22:17PM +0300, Dmitry Baryshkov wrote: > > On Fri, 16 Sept 2022 at 23:13, Christian Marangi wrote: > > > > > > On Fri, Sep 16, 2022 at 11:06:35PM +0300, Dmitry Baryshkov wrote: > > > > On Fri, 16 Sept 2022 at 22:43, Christian Marangi wrote: > > > > > > > > > > On Fri, Sep 16, 2022 at 02:17:15PM -0500, Rob Herring wrote: > > > > > > On Wed, Sep 14, 2022 at 04:22:53PM +0200, Christian Marangi wrote: > > > > > > > Convert kpss-acc driver Documentation to yaml. > > > > > > > The original Documentation was wrong all along. Fix it while we are > > > > > > > converting it. > > > > > > > The example was wrong as kpss-acc-v2 should only expose the regs but we > > > > > > > don't have any driver that expose additional clocks. The kpss-acc driver > > > > > > > is only specific to v1. For this exact reason, limit all the additional > > > > > > > bindings (clocks, clock-names, clock-output-names and #clock-cells) to > > > > > > > v1 and also flag that these bindings should NOT be used for v2. > > > > > > > > > > > > Odd that a clock controller has no clocks, but okay. > > > > > > > > > > > > > > > > As said in the commit v2 is only used for regs. v2 it's only used in > > > > > arch/arm/mach-qcom/platsmp.c to setup stuff cpu hotplug and bringup. > > > > > > > > > > Should we split the 2 driver? To me the acc naming seems to be just > > > > > recycled for v2 and it's not really a clk controller. > > > > > > > > > > So keeping v2 in arm/msm/qcom,kpss-acc-v2.yaml and v1 moved to clock? > > > > > > > > I suspect that qcom,kpss-acc-v2 is misnamed as the "clock-controller". > > > > According to msm-3.10, these regions are used by the Krait core > > > > regulators. > > > > > > > > > > Well we need to understand how to handle this... change the compatible > > > it's a nono for sure. In platsmp.c they are used for cpu power control > > > so could be that they are actually used to regulators. I would honestly > > > move v1 to clock and leave v2 to arm/msm but I'm not cetain on what name > > > to assign to the 2 yaml. > > > > > > What do you think? > > > > This is fine for me. If somebody gets better understanding of > > underlying hardware and works on actually using these blocks, he will > > update the bindings. > > > > My only suggestion would be to rename kpss-acc-v2 nodes to > > 'power-controller@address' and document them so. > > > > Ok so something like this? > > power-controller@f9088000 { > compatible = "qcom,kpss-acc-v2"; > reg = <0xf9088000 0x1000>, > <0xf9008000 0x1000>; > }; > > (and I will have to fix dtbs warning as they will be unmatched I think.) > Yaml naming: > qcom,kpss-acc-v1.yaml > qcom,kpss-acc-v2.yaml > Right? Sounds good to me. I'd even say clock/qcom,kpss-acc-v1.yaml and arm/msm/qcom,kpss-acc-v2.yaml or maybe power/qcom,kpss-acc-v2.yaml > > > -- > Ansuel -- With best wishes Dmitry