From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FB4C433EF for ; Wed, 6 Jul 2022 12:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbiGFMCI (ORCPT ); Wed, 6 Jul 2022 08:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233270AbiGFMCE (ORCPT ); Wed, 6 Jul 2022 08:02:04 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08CD829C97 for ; Wed, 6 Jul 2022 05:02:03 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id ck6so17805818qtb.7 for ; Wed, 06 Jul 2022 05:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GS+uFCqn73s3FUnXQGK+mJpwi26ezGNzDSPMuucFva8=; b=C1PEfoHu1JZutIhSBq7xyrTzSwdP6gfzqlbmYagZ6SO614AVCSvZuTG/YcopNih2u0 XXZH06tjN/7HwT05MgoOtpKdZc8oBLn7RLDLCt5cjTeM5lb6gpuKj+2d7uLQXMnuvX3i wde7KD1Sv+YJl6PQ/byNoahvr0JX4PqEliAiGIwbso/soQMekhN0iDCes1q2wpwhil4A qWK6iHx1rd7r15nqFvFUJSefPwMIOTum21ZrKCZ3TdAeKdX7xqfXghTIDvA9LHIf/Pur HVAKjbv4je6GQwD13gprqb87kpQq8AjACvJVJSfZtJFwyb3sO7iaVNEoXXSOkX9z/ufc /o4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GS+uFCqn73s3FUnXQGK+mJpwi26ezGNzDSPMuucFva8=; b=r2l83stKk6a88gyt6ns+qcqEyCzMGFCA9cYYDl3nuOY5gF+fab8uu1Tg/rov+Rl0LA kCnED2O9lrNvzJQRFvUN2X3S/3LkP9M/r7Goz+516BmQHBL/pGagbte5yw4uH4PQQXMf XAaIGnGXg9gMAWU/01aZ8KEuG3vl5Du6QQEZWeqV+WaG3dNIC+6kzHr0IBz9eu7gjSdJ MYjnn6hlpOF5V5iVf2NPXzKhDwMI4Y5Hp/QRjALXih+cHgCTKSXh+GLBwuERcMsRq8Zn OU5MKzBkGlS2rMOdAnI63LqImhcQcpRQicsEs7nMiwjsUVUCZja67ePBeuf0qjGKUc5J FdHw== X-Gm-Message-State: AJIora/wEk6e0vKcFCbIBtl5YxtjwoZFXdPy8FxfGuOgkmv+cnj+vQmG m2Ns2rYE95i6uzXCwuD0WN97Gwt2MCZbnyKQrB6Zvg== X-Google-Smtp-Source: AGRyM1tF1EnvSFKXQDug6KASOTgwF0P8AMmoLtvHbfrVH6CtHl3jRQNThamLYnI3w6qH79JwwlKN3CNfi8dZU5i5lMU= X-Received: by 2002:ad4:5f8a:0:b0:473:2108:7fe0 with SMTP id jp10-20020ad45f8a000000b0047321087fe0mr1081454qvb.115.1657108921700; Wed, 06 Jul 2022 05:02:01 -0700 (PDT) MIME-Version: 1.0 References: <20220705133917.8405-1-ansuelsmth@gmail.com> <20220705133917.8405-10-ansuelsmth@gmail.com> <62c56477.1c69fb81.8ec4c.f1ac@mx.google.com> In-Reply-To: <62c56477.1c69fb81.8ec4c.f1ac@mx.google.com> From: Dmitry Baryshkov Date: Wed, 6 Jul 2022 15:01:50 +0300 Message-ID: Subject: Re: [PATCH 09/13] ARM: dts: qcom: add smem node for ipq8064 To: Christian Marangi Cc: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan McDowell Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 6 Jul 2022 at 13:31, Christian Marangi wrote: > > On Wed, Jul 06, 2022 at 10:39:16AM +0200, Krzysztof Kozlowski wrote: > > On 05/07/2022 15:39, Christian Marangi wrote: > > > Add missing smem node for ipq8064. > > > > > > Signed-off-by: Christian Marangi > > > Tested-by: Jonathan McDowell > > > --- > > > arch/arm/boot/dts/qcom-ipq8064.dtsi | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > > index b5aede3d7ccf..98527a7d885e 100644 > > > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > > > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > > @@ -908,6 +908,11 @@ lcc: clock-controller@28000000 { > > > #reset-cells = <1>; > > > }; > > > > > > + sfpb_mutex_block: syscon@1200600 { > > > + compatible = "syscon"; > > > > syscon alone is not allowed. > > > > Mh... This is problematic. How this should be handled? > This should be put in sfpb_mutex and change the driver to use regs if > present instead of syscon? If nothing else works, you can add two compat strings, for example: "qcom,ipq8064-sfpb-mutex", "syscon"; This way if we add an sfpb driver at some point, we can still use old dts files. -- With best wishes Dmitry