From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9832C11F69 for ; Thu, 1 Jul 2021 16:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA9D2613D9 for ; Thu, 1 Jul 2021 16:39:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229741AbhGAQmM (ORCPT ); Thu, 1 Jul 2021 12:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhGAQmM (ORCPT ); Thu, 1 Jul 2021 12:42:12 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3F7FC061764 for ; Thu, 1 Jul 2021 09:39:41 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id w13so4576690qtc.0 for ; Thu, 01 Jul 2021 09:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j1omKszLA96uDrGntnvvvB8tgKEGENuOVwCJ29kc0wQ=; b=X3rDAfHuhzkoWnwo5uurv5Exfv3mg3SGhQw6Ouw7diqQw1SJpU0uljBxmTl7XH02ij FZ48rAir+oVsJxyTJmUcOnMIPBL5+Jv7io2cjOkr2BQoRngsMbXvVUK8ZYY5Yl5KM0QE SujHUOV4olMx5BpJFkQJDpB7WVkRsakwwfBjT8OIcGV7lHybyVflPsJzUTe0B9J7gBYO Ts/RanidSkddmPkLs3/wkf8g5RdSHi6aytU2uJ+Xqj8HzahGq6YhVht7Kek5QF+E0fLl jvFRD5FpoYd9n1kPJUaQmjwzz8ict8ICq8q7ft3k6SpBD8JDFtCmEF9reoBnOnwZ8Prj Xglg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j1omKszLA96uDrGntnvvvB8tgKEGENuOVwCJ29kc0wQ=; b=aWCaaeez0aq/3rsi3ilThlyWPkhTu1ql25tXsmXN4HYiciKgQ0B967OxZZzoaUQid+ 9/65WSH+b7uU6HX7o1YwyYsUOmPihtpKegfiMiD2Bg/1MViTZi3vbr+W4rvCVbUIC/hO i7docZPg1DyM/fGIWdjB/zf0SoD+Yjr2hwYGA3zFIBoYffqi7kLHBB2EDF9dSh3SPqvs B2hpDFNLq8mYQLX4JJe0733i2yzsrNi7y5jMovux0eZSvJfBmLlwfAzAWwYZPhoUvp6M 252y357XfgsYvYqelRNYzcUA5XHj/euDG7cadfwPvIl9CgUZkhPMJVCmRmejBDgtyrvn q5yA== X-Gm-Message-State: AOAM533lYmcvQYCa9WGQvdTG32ExiyXvGR/SUnPsHk7QfFx2ztjMrkNg HPU9/dUl30X/K3t97+LFXCX58uksTUJ3ucmwynEm6Q== X-Google-Smtp-Source: ABdhPJwi3BsgWop/FymmZElECT1X2KqUjB7rfX7hjzyL3qQMDHaQuzKORjxJqwkf0XhL3JEvQDhLDk8MGXWhEfUtf9M= X-Received: by 2002:ac8:5b0d:: with SMTP id m13mr806896qtw.364.1625157580768; Thu, 01 Jul 2021 09:39:40 -0700 (PDT) MIME-Version: 1.0 References: <20210630133149.3204290-1-dmitry.baryshkov@linaro.org> <20210630133149.3204290-2-dmitry.baryshkov@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Thu, 1 Jul 2021 19:39:29 +0300 Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: clock: qcom,dispcc-sm8x50: add mmcx power domain To: Ulf Hansson Cc: Andy Gross , Bjorn Andersson , Rob Herring , Stephen Boyd , Taniya Das , Jonathan Marek , Michael Turquette , linux-arm-msm , DTML , linux-clk , "Bryan O'Donoghue" , Mark Brown , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 1 Jul 2021 at 19:17, Ulf Hansson wrote: > > On Wed, 30 Jun 2021 at 15:31, Dmitry Baryshkov > wrote: > > > > On sm8250 dispcc requires MMCX power domain to be powered up before > > clock controller's registers become available. For now sm8250 was using > > external regulator driven by the power domain to describe this > > relationship. Switch into specifying power-domain and required opp-state > > directly. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > .../bindings/clock/qcom,dispcc-sm8x50.yaml | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > index 0cdf53f41f84..48d86fb34fa7 100644 > > --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > @@ -55,6 +55,16 @@ properties: > > reg: > > maxItems: 1 > > > > + power-domains: > > + description: > > + A phandle and PM domain specifier for the MMCX power domain. > > + maxItems: 1 > > + > > Should you perhaps state that this is a parent domain? Or it isn't? > > Related to this and because this is a power domain provider, you > should probably reference the common power-domain bindings somewhere > here. Along the lines of this: > > - $ref: power-domain.yaml# > > As an example, you could have a look at > Documentation/devicetree/bindings/power/pd-samsung.yaml. I'll take a look. > > > + required-opps: > > + description: > > + Performance state to use for MMCX to enable register access. > > + maxItems: 1 > > According to the previous discussions, I was under the assumption that > this property belongs to a consumer node rather than in the provider > node, no? It is both a consumer and a provider. It consumes SM8250_MMCX from rpmhpd and provides MMSC_GDSC. > > > + > > required: > > - compatible > > - reg > > @@ -64,6 +74,15 @@ required: > > - '#reset-cells' > > - '#power-domain-cells' > > > > +# Either both properties are present or both are absent > > +dependencies: > > + power-domains: > > + required: > > + - required-opps > > + required-opps: > > + required: > > + - power-domains > > + > > additionalProperties: false > > > > examples: > > -- > > 2.30.2 > > > > Kind regards > Uffe -- With best wishes Dmitry