From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FC4C4332E for ; Wed, 13 Jan 2021 17:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F83823437 for ; Wed, 13 Jan 2021 17:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728339AbhAMRU3 (ORCPT ); Wed, 13 Jan 2021 12:20:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727707AbhAMRU2 (ORCPT ); Wed, 13 Jan 2021 12:20:28 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E943FC061575 for ; Wed, 13 Jan 2021 09:19:47 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id x13so2912159oic.5 for ; Wed, 13 Jan 2021 09:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mjg/jy0DZZvh04Gg0ZIjuk4S6kMRfKUqimeQdNDRAhY=; b=NOSxj9uFAtN+cQGRweNSMDktTTciP/m5r4eugWeqMVmqGUhaZZoEeVw3UlgDzgdZ1S zGwm0xBbCsqHEtpRR/SI0HTnITrKvX6xoay3aWHq0gbN5z5v6dpUM5ZS6gRZXKKeCPTJ 7b1Zmrcp8KmlAJ2aedEuaSRVabZuI2T9yAi01WDXkTG9BzaBopQMjdNi4NFfpElKQKxJ /44wANgcMPdCyC4Lzf99g2WYM6qOIicdqF8AoGx+Q7PoxE5PsPNVSeFCvnBuuDIdcpBC cXCl6AenutzNgOiU6WncKcGcHjtbiUr12+P4f6vVbI2xG124HYiQxZzHwHMyrrSGx0gY Ttvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjg/jy0DZZvh04Gg0ZIjuk4S6kMRfKUqimeQdNDRAhY=; b=dc4ljGtzTvS2ueGLvthj610OrIKuhaEHRs/VsAZsIWMrWlo3+vdau+l4hWMcsOnQJQ dLITnU4zrf1nB4EZQmSq0mKwFlIXlIpecztQaWt+mICtoXqn+RLj/jkddCOn+NWW5fLz FRaf89HWDLChCwuxtA7UJ0ypnhiHw4Zzg1AEdXZJoLb0lMn0Tf9hybowa7lCDM5ufSTH gELnDi1HeIfcOL3fDoirqmjIoKJWgM/wSEDM8zka9aKmg6GEN0xPS1irBVZylmDvUUH5 +/EtWt9MCvWxWR/+KopMaCfUwXF9HuA8qHeULzNtXBZox3gZyb4KRmlYSSrM4r+hu7yR Y8Pw== X-Gm-Message-State: AOAM533yPV6i2TWYPkqi5zCy5E4Aqhzxuj7FhMzg3/xorV211OxlK3dI gba5ukinnueWrDpiEOcoVikYyxhGE2YU3rN5+OkaSg== X-Google-Smtp-Source: ABdhPJyblEJ+ghunXPkjZ+L33I7pPCUNf5kVsgKX6Zykxco0gDU7ktSedzB8qJcsKFCITlg6Yk3YhXq9b1JhYPDZ2wQ= X-Received: by 2002:aca:b145:: with SMTP id a66mr201607oif.92.1610558387362; Wed, 13 Jan 2021 09:19:47 -0800 (PST) MIME-Version: 1.0 References: <20201204025509.1075506-1-dmitry.baryshkov@linaro.org> <20201205170830.4d56ecb7@archlinux> In-Reply-To: <20201205170830.4d56ecb7@archlinux> From: Dmitry Baryshkov Date: Wed, 13 Jan 2021 20:19:36 +0300 Message-ID: Subject: Re: [PATCH v10 00/15] qcom: pm8150: add support for thermal monitoring To: Jonathan Cameron Cc: Andy Gross , Bjorn Andersson , Rob Herring , Zhang Rui , Daniel Lezcano , Amit Kucheria , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pm@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-iio@vger.kernel.org, Manivannan Sadhasivam , Jishnu Prakash Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hello, On Sat, 5 Dec 2020 at 20:08, Jonathan Cameron wrote: > > On Fri, 4 Dec 2020 05:54:54 +0300 > Dmitry Baryshkov wrote: > > > This patch serie adds support for thermal monitoring block on Qualcomm's > > PMIC5 chips. PM8150{,b,l} and sm8250-mtp board device trees are extended > > to support thermal zones provided by this thermal monitoring block. > > Unlike the rest of PMIC thermal senses, these thermal zones describe > > particular thermistors, which differ between from board to board. > > I've just taken another look through the various IIO parts in here and > I think they are fine. > > My assumption is that given the timing this isn't going to make the merge > window now. Hence I'll be looking to do an immutable branch based on rc1 > once it's available (assuming everyone else is fine with this version). Another gracious ping. Daniel, any comments for the thermal part? Jonathan, there was a proposal to have an immutable branch for this series. Do you still plan to create it? If IIO parts are fine with you, it might be feasible to get that into 5.12 with thermal part either being part of the same patch series or coming later depending on Daniel's comments. > > Thanks, > > Jonathan > > > > > Changes since v9: > > - In patch 12 add comments to the code as requested by Daniel Lezcano. > > - Change copyright comment in qcom-spmi-adc-tm5.c to clearly note > > driver history. > > > > Changes since v8: > > - Simplified qcom_vadc_map_voltage_temp() code by removing ascending > > tables support > > - Simplified qcom-vadc-common volt/temp mapping code > > - Implement suggestions by Matthias Kaehlcke: message formatting, > > rewrite comments, remove unused variable initialization. > > > > Changes since v7: > > - Move qcom-vadc-common.h header to include/linux/iio/adc/ dir. > > - Use explicit sizeof(var) instead of hand-coding 1 when accessing > > adc-tm registers. > > - Remove buffer read from adc_tm5_init(). > > - Remove extra on-stack var from adc_tm5_get_temp(). > > - Minor formatting changes as suggested Daniel. > > > > Changes since v6: > > - Added include as noted by Jishnu Prakash. > > > > Changes since v5: > > - Reworked DT bindings: > > * Removed qcom,adc-channel, instead it is parsed from io-channels > > * Renamed qcom,hw-settle-time to include -us suffix > > - Re-added monitor enabling which got lost during refactored. Noted by > > Jishnu Prakash. > > - Use threaded IRQ handler as susggested by Jishnu. > > > > Changes since v4: > > - Added kernel-doc comments to ADC-TM structures > > - Used several sizeof(buf) instead of hand-conding register size > > > > Changes since v3: > > - Fix DT description to spell "thermal monitoring" instead of just TM > > - Fix warnings in DT example > > - Add EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name) > > - Fixed whitespace chanes in qcom-vadc-common.c > > - Removed error message if IIO chanel get returns -EPROBE_DEFER > > > > Changes since v2: > > - IIO: export of_iio_channel_get_by_name() function > > - dt-bindings: move individual io-channels to each thermal monitoring > > channel rather than listing them all in device node > > - added fallback defaults to of_device_get_match_data calls in > > qcom-spmi-adc5 and qcom-spmi-adc-tm5 drivers > > - minor typo fixes > > > > Changes since v1: > > - Introduce fixp_linear_interpolate() by Craig Tatlor > > - Lots of syntax/whitespace changes > > - Cleaned up register definitions per Jonathan's suggestion > > - Implemented most of the suggestions from Bjorn's and Jonathan's > > review > > > > > -- With best wishes Dmitry