From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311D112E61 for ; Fri, 29 Mar 2024 01:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711676693; cv=none; b=caUXQ2+bBv63pAOK2uNSS9YmlNqnRIrMUnvwhT6yRs9IxeSLF2FafCqhRjbCdMgkqT0h02CUd1ikGKRj44225ScDTV/M+9jLHClx+vIZETvl9yc0KU4RSKVKdjuaahIIyQKQWAhiiqMFRvYsnEGre5Cj+rBe0fuSJ414C+YK9+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711676693; c=relaxed/simple; bh=gEA8K8t4hqBPN9wzG8A+ksg0xWJK4mQ9uMlSu+sQHVw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=T4Um+wqnD8fcbmUu0CyHcocGlJa4wpRxbBaOesVqxrNxK6aoXK0kk83OSUlDSLNO4JXUplYu8vDULeJzdhD4dZtFI3f9j5mPTYn/nnzRtoGZvGRvtpKTll1/bw2GVtzYIZxkIDQ3yBj7u8Vgbs21GTyMdbyaKXwM9HqNSvR2guQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mM5Lhc0Y; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mM5Lhc0Y" Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-dbed179f0faso1884831276.1 for ; Thu, 28 Mar 2024 18:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711676691; x=1712281491; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gNux39GZ9PplhhfClr7WIbvdC+MvZFr9TXEFrMsn6O0=; b=mM5Lhc0YVM/b1yf9ozjetAr704YUJa1qPpL/bAcnBE8l1Zlze9DcDuVkAwDAUZ7BVk fDIs77jE7Ahx7HcT905rUyHUQeWVJZcFd7v2JFCk2BulBYxYT7mWXCfMLRPN1KhnZ2J/ crHWkjuZcJPcLz7HcXCSldqcNabXLp0RVGTcm+nz1YgB6acLHLd1KdUjUJw3zdvlQTkk OJkPem+Y6/RdTQTzgVOCKZPW1fjJgAO8fcY6NzeOB35hbOd0gA6fzc7Iazqre0VBmneJ 2dap+kosvCeOSfZoqQPJej+NFGjzSdUNxnRPl5HLyltnE7FOM7LMkVqau2TUJHvbpWz3 /Yrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711676691; x=1712281491; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gNux39GZ9PplhhfClr7WIbvdC+MvZFr9TXEFrMsn6O0=; b=VPdnjt2eAAGo6JVFZaW//z5qP6dMBWSgVsGbjl/73FOMOJPBjfNfUJaIj+Oo0GlhsF U++gb4jZqvFKyaOWBxmAqqMlI/n+LWBlPbM8j4mNSFaelYBCifb0cIHNIDyNYhKyztQH bBZB3olbBxDv6u+D9tl4b8Ig0Ge+MSA8BcG/U4uV/swVhg0MlsWMuJIq7TKzAnrQi2A6 3AD/LPAuHhxSBm2kffDml6bLTh5u+tRL1QDAkDLKmmjItvUKDMFKqmo5YYgQzc5KF90L ko6H/NtKhI7cX6yjn4tAWIwnKD3yv7W74XdepCTUGWaRU7NOWEq+/Jisy8ZWxOTV0cSW 9AaQ== X-Forwarded-Encrypted: i=1; AJvYcCXd8znU/r5J0j1hz7ymUqcFPr52O09hYDbsxWIB56F2N23ZJFHsbdGiY2/5TPliNkizhEaziErvsOn+eKgxlisDUsnIWS/B5FTBPMZf9g== X-Gm-Message-State: AOJu0YyJ5tpJliYCPnFWVe+ng5ZR/x617bTmoRYGBIA21Q9zpGkkMpz0 /Bd9kmbGnYFFahjG9IQD4Bctj3Js6r2IhPe46uNtk1/mYZiPS9/xG57TEAEzON73jrw/i+NE7F+ FD4HzOVd6ZBAJxsGbsPGE0E3xrgo8E/lCK8RawA== X-Google-Smtp-Source: AGHT+IGxfnvK0C6jYBVF3IdKUncdJRXqGZuc12A+brjW4rLyifQ3TUqQCJTqSsWeIO2NfwC901j3J8D6X4T+rMTwmHs= X-Received: by 2002:a25:2e44:0:b0:dc6:d258:c694 with SMTP id b4-20020a252e44000000b00dc6d258c694mr2970896ybn.19.1711676691033; Thu, 28 Mar 2024 18:44:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240326-rb3gen2-dp-connector-v2-0-a9f1bc32ecaf@quicinc.com> <20240326-rb3gen2-dp-connector-v2-2-a9f1bc32ecaf@quicinc.com> <20240329013743.GA3476498@hu-bjorande-lv.qualcomm.com> In-Reply-To: <20240329013743.GA3476498@hu-bjorande-lv.qualcomm.com> From: Dmitry Baryshkov Date: Fri, 29 Mar 2024 03:44:39 +0200 Message-ID: Subject: Re: [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output To: Bjorn Andersson Cc: Bjorn Andersson , cros-qcom-dts-watchers@chromium.org, Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" On Fri, 29 Mar 2024 at 03:37, Bjorn Andersson wrote: > > On Thu, Mar 28, 2024 at 09:17:45AM +0200, Dmitry Baryshkov wrote: > > On Thu, 28 Mar 2024 at 05:07, Bjorn Andersson wrote: > > > > > > On Thu, Mar 28, 2024 at 03:51:54AM +0200, Dmitry Baryshkov wrote: > > > > On Wed, 27 Mar 2024 at 04:04, Bjorn Andersson wrote: > > > > > > > > > > The RB3Gen2 board comes with a mini DP connector, describe this, enable > > > > > MDSS, DP controller and the PHY that drives this. > > > > > > > > > > Signed-off-by: Bjorn Andersson > > > > > --- > > > > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 40 ++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > > > index 63ebe0774f1d..f90bf3518e98 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > > > @@ -39,6 +39,20 @@ chosen { > > > > > stdout-path = "serial0:115200n8"; > > > > > }; > > > > > > > > > > + dp-connector { > > > > > + compatible = "dp-connector"; > > > > > + label = "DP"; > > > > > + type = "mini"; > > > > > + > > > > > + hpd-gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>; > > > > > > > > Is it the standard hpd gpio? If so, is there any reason for using it > > > > through dp-connector rather than as a native HPD signal? > > > > > > > > > > I added it because you asked for it. That said, I do like having it > > > clearly defined in the devicetree. > > > > I asked for the dp-connector device, not for the HPD function change. > > > > I didn't realize that you could have a dp-connector device without > defining the hpd-gpios, but it looks like you're right. > > Do we have any reason for using the internal HPD, when we're already > spending the memory to allocate the dp-connector device? No, no particular reason. I was trying to understand if there was any reason for that from your side. Then: Reviewed-by: Dmitry Baryshkov > PS. It's recommended that you dynamically switch to GPIO-based HPD in > lower-power scenarios, as this allow you to turn off the DP controller > and still detect plug events... I don't think rb3g2 is a low-power device, but I think this is still a valid argument. -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AECE8CD1288 for ; Fri, 29 Mar 2024 01:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WrHxrMhQfzPptMT9BsRbBHpX3UCRd9Q3jF2QjkNPI2k=; b=dWxTFjFMxM2saJ PvXjNjIB7ifvhJbqoPnMzeJ8UIaMycSIUjxNJ9R5OhiXMC1fu6F8DINpjGY3rrwtMMYF+b0Ft/AWI 0ezDiCDyHMwPcp07jegtgKOYazM9s8ZmdVLB6nm1KShi8UjPThYgfvA4EnMlM5baSKbL3DcQfim4b 4I836Xj8+gUiLbhfw3IlXjGtwISVcCPgRwFsKB/hF/Z1ZH9kcSYdQDmBm6adX6xJAvbvJJxcuRIYZ qNNk3ZYSlOu38snZKBDyk2RjtkeMIeZ6wvovwrNCb2S4puOiVagiefz1O9gKVdrO9LnvfU8v0an1o mZe7UgenHB1FKlGztP2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rq1Ie-0000000GPlv-49M4; Fri, 29 Mar 2024 01:44:57 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rq1Ic-0000000GPlJ-0EF0 for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2024 01:44:55 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-dc6cbe1ac75so1212084276.1 for ; Thu, 28 Mar 2024 18:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711676691; x=1712281491; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gNux39GZ9PplhhfClr7WIbvdC+MvZFr9TXEFrMsn6O0=; b=d7kOA5wv7KJ5Eg8d0qMNFTMM6PhkdPtC/m5lsyA9scTmIjuN+Pwn+7ju5JPky8aViH uL5Yo+ncZV+LcMXwbywLYlnhTb4ts6uEz4rRxUJiRlR/oL7EHT1eK/21uab5zbHgcdwd JlWxLz8UG4oBj0qX7QqMFvD9v9+KPMJNfOdQGRJYYVT+duVz5+isTQmbYhdmDejEA+gV 92TuoksA3IT7qHJ73kSipnYfSCKchU72OWTmP3nas1d2tff/VPqmX14KH6fyxFyp6FTj 0HmFFZixkngz1AonSuZSOXcQOGsMG7rvjn/BWPndqznzC3rcWhfmyaU+Ed9IiofXnrGc tyjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711676691; x=1712281491; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gNux39GZ9PplhhfClr7WIbvdC+MvZFr9TXEFrMsn6O0=; b=Ed4+EvftL8D/F9s6kCxiBZljAyh8u0LueuzQ5QXMh5WuklGbrMR2+xirQxtD9tEjDk hMer/TA7CK1cY9+YPiVGQPHldZgmCxAH+znX7qcHx+LO/uVq9NeefyhAcvEKWEPEvxep PJiGNFvlKisro2Grk08pz0WuE4D6A6ffHQdMW1VxuSps0EcrKeSMDzt4DuxhaMvefSES a1Q/3HLFs1yE61YlC7JPHdWpeZDrUbfRjPREWFLiiF+WhhRR+CozldvQdVV+SWGozYKl xFBxgOR7v7TgDh23D0Dcjsp5wHCvVib8Bs6+Qp5MfY/qHIO84tUDSEfcOwJEAJHPBu92 Fnnw== X-Forwarded-Encrypted: i=1; AJvYcCWdcHzlCU1MdfRkzQYFi6E/gEeHYm6gTztHFGaHC5fScLLLmhxCwhc46BxmBZ0+C2jTalOTbkELhDZaFXAIEXriCG5AoIIEsbdW5VxtTEomiW75+Tw= X-Gm-Message-State: AOJu0Yww4KQi9LX58gobNc3mN1TrWX37MkW/oFO5+HVQnys3Z3pNgPbL ijMY/ZmtrZT0PhSL+/71+HRBkwsQ/VLEp5td0N+st1PvpylUY721+9KXRcRe4TRs7otgNbWx4Vf z1oItAUMY0NNYvFRSAxUxuO5Q55d/5pvUVgJnSw== X-Google-Smtp-Source: AGHT+IGxfnvK0C6jYBVF3IdKUncdJRXqGZuc12A+brjW4rLyifQ3TUqQCJTqSsWeIO2NfwC901j3J8D6X4T+rMTwmHs= X-Received: by 2002:a25:2e44:0:b0:dc6:d258:c694 with SMTP id b4-20020a252e44000000b00dc6d258c694mr2970896ybn.19.1711676691033; Thu, 28 Mar 2024 18:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20240326-rb3gen2-dp-connector-v2-0-a9f1bc32ecaf@quicinc.com> <20240326-rb3gen2-dp-connector-v2-2-a9f1bc32ecaf@quicinc.com> <20240329013743.GA3476498@hu-bjorande-lv.qualcomm.com> In-Reply-To: <20240329013743.GA3476498@hu-bjorande-lv.qualcomm.com> From: Dmitry Baryshkov Date: Fri, 29 Mar 2024 03:44:39 +0200 Message-ID: Subject: Re: [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output To: Bjorn Andersson Cc: Bjorn Andersson , cros-qcom-dts-watchers@chromium.org, Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_184454_297604_1B8523D5 X-CRM114-Status: GOOD ( 28.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 29 Mar 2024 at 03:37, Bjorn Andersson wrote: > > On Thu, Mar 28, 2024 at 09:17:45AM +0200, Dmitry Baryshkov wrote: > > On Thu, 28 Mar 2024 at 05:07, Bjorn Andersson wrote: > > > > > > On Thu, Mar 28, 2024 at 03:51:54AM +0200, Dmitry Baryshkov wrote: > > > > On Wed, 27 Mar 2024 at 04:04, Bjorn Andersson wrote: > > > > > > > > > > The RB3Gen2 board comes with a mini DP connector, describe this, enable > > > > > MDSS, DP controller and the PHY that drives this. > > > > > > > > > > Signed-off-by: Bjorn Andersson > > > > > --- > > > > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 40 ++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > > > index 63ebe0774f1d..f90bf3518e98 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > > > @@ -39,6 +39,20 @@ chosen { > > > > > stdout-path = "serial0:115200n8"; > > > > > }; > > > > > > > > > > + dp-connector { > > > > > + compatible = "dp-connector"; > > > > > + label = "DP"; > > > > > + type = "mini"; > > > > > + > > > > > + hpd-gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>; > > > > > > > > Is it the standard hpd gpio? If so, is there any reason for using it > > > > through dp-connector rather than as a native HPD signal? > > > > > > > > > > I added it because you asked for it. That said, I do like having it > > > clearly defined in the devicetree. > > > > I asked for the dp-connector device, not for the HPD function change. > > > > I didn't realize that you could have a dp-connector device without > defining the hpd-gpios, but it looks like you're right. > > Do we have any reason for using the internal HPD, when we're already > spending the memory to allocate the dp-connector device? No, no particular reason. I was trying to understand if there was any reason for that from your side. Then: Reviewed-by: Dmitry Baryshkov > PS. It's recommended that you dynamically switch to GPIO-based HPD in > lower-power scenarios, as this allow you to turn off the DP controller > and still detect plug events... I don't think rb3g2 is a low-power device, but I think this is still a valid argument. -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel