From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E31C432BE for ; Mon, 30 Aug 2021 01:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7596360F12 for ; Mon, 30 Aug 2021 01:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236130AbhH3BSi (ORCPT ); Sun, 29 Aug 2021 21:18:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235813AbhH3BSh (ORCPT ); Sun, 29 Aug 2021 21:18:37 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F03ECC061575 for ; Sun, 29 Aug 2021 18:17:44 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id g11so10455675qtk.5 for ; Sun, 29 Aug 2021 18:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WfXFIu2YP/cyEtXqUoY+pbv5W2e1wSkIPAhVHrp+0/4=; b=W1ici69Kt2rAChENIXMHZGGffeOYJlATguvIpNwgAHVB7g5juXF2AiTxCQ6wfYSrFA PDa+pXiZVHWIgyW/S7pjve7GPhyvwpUz5M1ZNMF1e9dW21JQy7ZLuO59I53+J8wT3gpB 1SC+YO+ue2sAQKcWXpif7QJhykrUotm96p4T56hDFOYsi0KlRpuOPI1N/rJXugV1dSNU Z2itCS+9uIhP/9XHFxX4EzJmD3ObKjuwkF0rNFtLwStYcnPx8QFp5jYPmL8IZuLQMdyS 3H5fMitmMhO8ddUQPHreyR4Z+yEoBB+NgWgKoecdEhbWYz2HSttqszHbANPbPAEeiyaB Rh5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WfXFIu2YP/cyEtXqUoY+pbv5W2e1wSkIPAhVHrp+0/4=; b=kX0jH2NBiBJ7cKW1rkX3b0Sy0n5hjp81YozX6Oiu9tJG+U4FSPAzbf8dm+KCZr3sKX fZtnMFKj9NopkVEDb3V3EDZiw4BstYEyTdrkMj7elYxqxtPhgRcDix7HfhdK9R/tlCm9 aRp2AUceGlEglGPZnU1I8gJhMYpzYgMUu1AsSDmOfYpNfWICmIbwPqfFy7nIpKKVBT74 KcQ/ndcN2vML0hfzNnPza+UQRs1M90Y8ngvlWBqF6S+tqUAvr0kobg3EC29qXggs4PoL kW9kHgWnLHrAHJSgoLAZJhbQ54+PB/hoRVHkYpodYPig77Ls3qWEYTovGhaPQwD+t7D3 LovA== X-Gm-Message-State: AOAM5335q5l/Y+ocvu1vCV81STeptazsbVotxZMclmIsoJUCQNzhkRoK /1U0EdC+kUVVuaYDdX/gZ60VcOwntVGMJ4YkcEi8yQ== X-Google-Smtp-Source: ABdhPJx8aZaQ2hRtqSFrECAuYeiv3KsLCobfsAE1chhz9/GxB0w+F/Ai49RdNUU/F53c3wne99H6s6bjr/joVRjQkpU= X-Received: by 2002:ac8:66da:: with SMTP id m26mr18703305qtp.273.1630286263447; Sun, 29 Aug 2021 18:17:43 -0700 (PDT) MIME-Version: 1.0 References: <20210829203027.276143-1-marijn.suijten@somainline.org> <20210829203027.276143-3-marijn.suijten@somainline.org> In-Reply-To: From: Dmitry Baryshkov Date: Mon, 30 Aug 2021 04:17:32 +0300 Message-ID: Subject: Re: [PATCH 2/3] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent To: Marijn Suijten Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Bjorn Andersson , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Abhinav Kumar , Jonathan Marek , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , freedreno , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 30 Aug 2021 at 00:53, Marijn Suijten wrote: > > Hi Dmitry, > > On 8/29/21 10:39 PM, Dmitry Baryshkov wrote: > > Hi, > > > > On Sun, 29 Aug 2021 at 23:30, Marijn Suijten > > wrote: > >> > >> All DSI PHY/PLL drivers were referencing their VCO parent clock by a > >> global name, most of which don't exist or have been renamed. These > >> clock drivers seem to function fine without that except the 14nm driver > >> for the sdm6xx [1]. > >> > >> At the same time all DTs provide a "ref" clock as per the requirements > >> of dsi-phy-common.yaml, but the clock is never used. This patchset puts > >> that clock to use without relying on a global clock name, so that all > >> dependencies are explicitly defined in DT (the firmware) in the end. > > > > msm8974 (28nm-hpm) does not define the "ref" clock. So you'd have to: > > 1) add ref clock to the dtsi (should come in a separate patch). > > > Thanks for double-checking and noticing this! I've queued up this patch > for v2. > > > 2) add .name = "xo" as a fallback to the 28nm driver (to be compatible > > with older devices) > > > Are there msm8974 devices out there that might upgrade kernels, but not > firmware (DT)? On other boards (sdm630) I'm removing these from various > drivers as to not have any possibility of relying on global names, in > favour of having the clock dependencies fully specified in the DT. IIUC it is a general policy of trying to be (somewhat) backwards-compatible. For example because your dts might come from a different source/be a part of different build process/etc. > > > Other than that this looks good to me. > > > Any r-b/a-b/t-b I can pick up for the next round? Let's get those issues fixed and I'll respond with R-B tags -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D704BC4320A for ; Mon, 30 Aug 2021 01:17:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A121960F51 for ; Mon, 30 Aug 2021 01:17:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A121960F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 629C18990D; Mon, 30 Aug 2021 01:17:45 +0000 (UTC) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by gabe.freedesktop.org (Postfix) with ESMTPS id 735E98990D for ; Mon, 30 Aug 2021 01:17:44 +0000 (UTC) Received: by mail-qt1-x833.google.com with SMTP id s15so7088605qta.10 for ; Sun, 29 Aug 2021 18:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WfXFIu2YP/cyEtXqUoY+pbv5W2e1wSkIPAhVHrp+0/4=; b=W1ici69Kt2rAChENIXMHZGGffeOYJlATguvIpNwgAHVB7g5juXF2AiTxCQ6wfYSrFA PDa+pXiZVHWIgyW/S7pjve7GPhyvwpUz5M1ZNMF1e9dW21JQy7ZLuO59I53+J8wT3gpB 1SC+YO+ue2sAQKcWXpif7QJhykrUotm96p4T56hDFOYsi0KlRpuOPI1N/rJXugV1dSNU Z2itCS+9uIhP/9XHFxX4EzJmD3ObKjuwkF0rNFtLwStYcnPx8QFp5jYPmL8IZuLQMdyS 3H5fMitmMhO8ddUQPHreyR4Z+yEoBB+NgWgKoecdEhbWYz2HSttqszHbANPbPAEeiyaB Rh5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WfXFIu2YP/cyEtXqUoY+pbv5W2e1wSkIPAhVHrp+0/4=; b=Te+cGs2SuGHm9wzjV1AUxG/aXMYBz0E17h+Hp4c6BXKV5osgxUkhJ/L9ddmP4tKQmN fj8tbi7fo95y0jExBCLIjTwWVDRwUN9gKHS+CN2XLWiOeR6Hm2jG2kq2lLqL/gm/ZmEY wRJqiKWneFcUxhB0nIB5psBuati8pwY7/f7zxw+fbkBFeMpehzTiOe10LkeB7GeXRQQv kiBwYZKjwE6bemFe5RVLQ8smWQt/T8yNEuIOit1gtQG22Gcj18FPqrP4M/3nMUQDchOA tEHO3bwTG8z1PYf+6OU8giV9p3fUlXNCFMaplieAIs+u88U8FAikWLr8ZxHGORCjpiaQ p/bA== X-Gm-Message-State: AOAM532WI2HhET0jsOSpSu/8+QiErnKoKNB0sWhcqDd+X+XsjjSmpR9I /HwuYmW0Phk8dR5ysE+oXkvgpVIQH57XkKj1Xc7yyA== X-Google-Smtp-Source: ABdhPJx8aZaQ2hRtqSFrECAuYeiv3KsLCobfsAE1chhz9/GxB0w+F/Ai49RdNUU/F53c3wne99H6s6bjr/joVRjQkpU= X-Received: by 2002:ac8:66da:: with SMTP id m26mr18703305qtp.273.1630286263447; Sun, 29 Aug 2021 18:17:43 -0700 (PDT) MIME-Version: 1.0 References: <20210829203027.276143-1-marijn.suijten@somainline.org> <20210829203027.276143-3-marijn.suijten@somainline.org> In-Reply-To: From: Dmitry Baryshkov Date: Mon, 30 Aug 2021 04:17:32 +0300 Message-ID: Subject: Re: [PATCH 2/3] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent To: Marijn Suijten Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Bjorn Andersson , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Abhinav Kumar , Jonathan Marek , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , freedreno , open list Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 30 Aug 2021 at 00:53, Marijn Suijten wrote: > > Hi Dmitry, > > On 8/29/21 10:39 PM, Dmitry Baryshkov wrote: > > Hi, > > > > On Sun, 29 Aug 2021 at 23:30, Marijn Suijten > > wrote: > >> > >> All DSI PHY/PLL drivers were referencing their VCO parent clock by a > >> global name, most of which don't exist or have been renamed. These > >> clock drivers seem to function fine without that except the 14nm driver > >> for the sdm6xx [1]. > >> > >> At the same time all DTs provide a "ref" clock as per the requirements > >> of dsi-phy-common.yaml, but the clock is never used. This patchset puts > >> that clock to use without relying on a global clock name, so that all > >> dependencies are explicitly defined in DT (the firmware) in the end. > > > > msm8974 (28nm-hpm) does not define the "ref" clock. So you'd have to: > > 1) add ref clock to the dtsi (should come in a separate patch). > > > Thanks for double-checking and noticing this! I've queued up this patch > for v2. > > > 2) add .name = "xo" as a fallback to the 28nm driver (to be compatible > > with older devices) > > > Are there msm8974 devices out there that might upgrade kernels, but not > firmware (DT)? On other boards (sdm630) I'm removing these from various > drivers as to not have any possibility of relying on global names, in > favour of having the clock dependencies fully specified in the DT. IIUC it is a general policy of trying to be (somewhat) backwards-compatible. For example because your dts might come from a different source/be a part of different build process/etc. > > > Other than that this looks good to me. > > > Any r-b/a-b/t-b I can pick up for the next round? Let's get those issues fixed and I'll respond with R-B tags -- With best wishes Dmitry