From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2291C43334 for ; Wed, 8 Jun 2022 22:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbiFHW7F (ORCPT ); Wed, 8 Jun 2022 18:59:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231705AbiFHW7E (ORCPT ); Wed, 8 Jun 2022 18:59:04 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87BCF4EF56 for ; Wed, 8 Jun 2022 15:59:03 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id o68so16615996qkf.13 for ; Wed, 08 Jun 2022 15:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X9hlImzyEvBxvl0tBCS9rvUZQGqdth4+UM0LIHHP/pc=; b=qY+gKBjBgfP092SAeHRL4sRZ4XAGmRJK1yLkZ/bIXSH/CnhFAyg+dNJ030tm5BNXgY TWxVnmD/BONZSUFczbaTBBCNtSp928utbjynS6qnIUN/xy85AKs3cszkXM9LyiC/sYj6 jCzurspWKF9AlY4lYaRMsKgA84iKor9D6Hju7E1YDwWOANaC6ybTVvH57QV7jwJTsg2E sYIdnfADedR6+Olp0fJsePKCT4W6FYPi6XRmDJousdkgkZglntONzt1ERrtGIrFLGtkl 76ByOL8Br1PGC//d1JhvdrbsheodSJH9lTJ+jUCTqFXlVrQQ54dTWKDxBMxEXU0OW/7b zt/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X9hlImzyEvBxvl0tBCS9rvUZQGqdth4+UM0LIHHP/pc=; b=2uKtWww1hjnjk5sPViYN8llZtko3o9mNMVGAzXbtiKEF1P7UPlAkzwqsomptHsUGEn qsGrdn+GZ2gF41THzKQBieTmGy2ykV8w4C/nWZx0y6soR8wU4AIHi3ulKYNHfKDHgkms ialcBkvTmXlPggLEUVexwoNMThXILl551uKF7aAjOjrr1LdYrC7LwUf5JJYgbrDw2/f1 CZHaFPpaCbvX2sFIWyhMnbulTtkqVFcWBL4C+S/REL38Y9/ZQoWvkE1kNdOAtLynJ797 4yUf7KwMMOBH7PiVDbSJUOl1ioLdWZY+rfBwEKbmytNz0HmwqDCLK+vwMnZP5lIBaQKv 4+QA== X-Gm-Message-State: AOAM530EWknpP7Cwn9khIRZtFHfFYqbWXnTrwtEhx1NW6x95ydTFBvHA TcHdJS5u1fUk62rTJlP63+G4K9JZGVIxCZFfWcXs0VTNMeaNDVCt X-Google-Smtp-Source: ABdhPJwloqlLrxryB81tH2mmTWtotD1MwJqZdjuhJ822FbZIJ5roIbw1TX8CMKFMm0yFALwyZTgjVd6J1q7pOTTD9Ls= X-Received: by 2002:a37:a83:0:b0:6a6:7e4d:41dc with SMTP id 125-20020a370a83000000b006a67e4d41dcmr23472964qkk.59.1654729142674; Wed, 08 Jun 2022 15:59:02 -0700 (PDT) MIME-Version: 1.0 References: <20220608120723.2987843-1-dmitry.baryshkov@linaro.org> <20220608120723.2987843-8-dmitry.baryshkov@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Thu, 9 Jun 2022 01:58:51 +0300 Message-ID: Subject: Re: [PATCH v2 07/12] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform To: Stephen Boyd Cc: Abhinav Kumar , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Rob Clark , Rob Herring , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 9 Jun 2022 at 00:02, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-08 05:07:18) > > DB820c makes use of core-vcc-supply and core-vdda-supply, however the > > driver code doesn't support these regulators. Enable them for HDMI on > > 8996 platform. > > The 'vdda-supply' name makes me think this is another scenario where the > phy isn't powering on the analog supply when it should be and so the > controller driver is doing it instead. Is that the case here? Good question. There are different HDMI pins on 8996, with slight disagreement between the schematics and the datasheet. vcca_hdmi/vdd_hdmi1: 0.925V, Power for HDMI circuits =E2=80=93 low voltage vdda_hdmi/vdd_hdmi2: 1.8V, Power for HDMI circuits =E2=80=93 high voltage vdda_hdmi_pll/vdd_pll3, 1.8V, Power for PLL circuits I'm not sure which are required for the PHY and which are required for the core HDMI. However I'd note that we have a generic tendency of duplicating pins between the HDMI and the PHY devices. Compare this with 8064, where core-vdda-supply is also used both by the hdmi-tx and hdmi-phy devices. I think we unify 8x74/84 with 8996 and allow powering up the HDMI correctly even if it results in duplication between the -phy and -tx parts. --=20 With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56BA4C43334 for ; Wed, 8 Jun 2022 22:59:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 864CD113D01; Wed, 8 Jun 2022 22:59:04 +0000 (UTC) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C882113D01 for ; Wed, 8 Jun 2022 22:59:03 +0000 (UTC) Received: by mail-qk1-x732.google.com with SMTP id x75so13213253qkb.12 for ; Wed, 08 Jun 2022 15:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X9hlImzyEvBxvl0tBCS9rvUZQGqdth4+UM0LIHHP/pc=; b=qY+gKBjBgfP092SAeHRL4sRZ4XAGmRJK1yLkZ/bIXSH/CnhFAyg+dNJ030tm5BNXgY TWxVnmD/BONZSUFczbaTBBCNtSp928utbjynS6qnIUN/xy85AKs3cszkXM9LyiC/sYj6 jCzurspWKF9AlY4lYaRMsKgA84iKor9D6Hju7E1YDwWOANaC6ybTVvH57QV7jwJTsg2E sYIdnfADedR6+Olp0fJsePKCT4W6FYPi6XRmDJousdkgkZglntONzt1ERrtGIrFLGtkl 76ByOL8Br1PGC//d1JhvdrbsheodSJH9lTJ+jUCTqFXlVrQQ54dTWKDxBMxEXU0OW/7b zt/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X9hlImzyEvBxvl0tBCS9rvUZQGqdth4+UM0LIHHP/pc=; b=VsHZavevVzfuB4Rt0Z2RmedSkCch3/dywb/8WjcMsw7P6Xv/UD4MaO5zkh/9vBEVSM /m9t17WQKyPgIbqfG0EDM2/dsLLFl6oONpxN18/89uKpcto2FYXYM6EeO325ur+Gv4R1 ZhNhCbPXi1TjzDcWyNYNpG+UMO4YXen4FAf1+1Ud9K4Sn7AYmGW2657HgQtE5iSLa1ti m/PdMb/vjiD14YwWNy5Xm726aWZmGhJRRNO/FA4NA9jgAMrc1HCBbCqp282EfVIt+eQn 8kvvRt+2I2rshz9zhiuwBeZi/YIj1F0bngLPWd0PhzYRFb/gvV5//cpwtMlaF1AQ4FHr +6JA== X-Gm-Message-State: AOAM530gqG6Th6R9MdOSiOhRWSGrRIvcOla83NpAqEfWQZDmiGPEKiw3 U56o1sv6hwI2zdCukQFDQmcZqPGKGiDqaqN5oxcBpQ== X-Google-Smtp-Source: ABdhPJwloqlLrxryB81tH2mmTWtotD1MwJqZdjuhJ822FbZIJ5roIbw1TX8CMKFMm0yFALwyZTgjVd6J1q7pOTTD9Ls= X-Received: by 2002:a37:a83:0:b0:6a6:7e4d:41dc with SMTP id 125-20020a370a83000000b006a67e4d41dcmr23472964qkk.59.1654729142674; Wed, 08 Jun 2022 15:59:02 -0700 (PDT) MIME-Version: 1.0 References: <20220608120723.2987843-1-dmitry.baryshkov@linaro.org> <20220608120723.2987843-8-dmitry.baryshkov@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Thu, 9 Jun 2022 01:58:51 +0300 Message-ID: Subject: Re: [PATCH v2 07/12] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform To: Stephen Boyd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Andy Gross , dri-devel@lists.freedesktop.org, Abhinav Kumar , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 9 Jun 2022 at 00:02, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-08 05:07:18) > > DB820c makes use of core-vcc-supply and core-vdda-supply, however the > > driver code doesn't support these regulators. Enable them for HDMI on > > 8996 platform. > > The 'vdda-supply' name makes me think this is another scenario where the > phy isn't powering on the analog supply when it should be and so the > controller driver is doing it instead. Is that the case here? Good question. There are different HDMI pins on 8996, with slight disagreement between the schematics and the datasheet. vcca_hdmi/vdd_hdmi1: 0.925V, Power for HDMI circuits =E2=80=93 low voltage vdda_hdmi/vdd_hdmi2: 1.8V, Power for HDMI circuits =E2=80=93 high voltage vdda_hdmi_pll/vdd_pll3, 1.8V, Power for PLL circuits I'm not sure which are required for the PHY and which are required for the core HDMI. However I'd note that we have a generic tendency of duplicating pins between the HDMI and the PHY devices. Compare this with 8064, where core-vdda-supply is also used both by the hdmi-tx and hdmi-phy devices. I think we unify 8x74/84 with 8996 and allow powering up the HDMI correctly even if it results in duplication between the -phy and -tx parts. --=20 With best wishes Dmitry