From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3653C433EF for ; Wed, 6 Jul 2022 08:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbiGFIaD (ORCPT ); Wed, 6 Jul 2022 04:30:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232409AbiGFI3x (ORCPT ); Wed, 6 Jul 2022 04:29:53 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE84524965 for ; Wed, 6 Jul 2022 01:29:20 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id h19so17250931qtp.6 for ; Wed, 06 Jul 2022 01:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TUlB7D0EVtJKLbRYI/VBJaDjLfIkrBDiyc+MBceBNJw=; b=G+4ns2MicHyAnMKWBTswSLk6EMnGCvvVmN7Hh6rIeqhmdPtKQ+sAI9/ywTY/Zses9k VjXIzW37c9Sb540i+Ci+T0zf2G1M7KteiF8/GUeSb9j2DiKZmQOh+huhzdfX+vinM/2x n6KwhOJhqsV2teycqzlsQrzEh3Tx0WLw9Vcgxl3SZV4+pmnKhXZ7q+KnvKulNXrIw4gv HbWR3PHSB+4R1rCvCT20/L7WSZVSe2plyxa/3aFTEGQjnYH2a0Ak9l8hXJhO7kNpBc3+ W+ie0qxQ61m9mMby2eyf1/FSUjZdFwpbI1psikXNTgQ+gaZ1M13hV20o/0wT67sFFcLI d1Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TUlB7D0EVtJKLbRYI/VBJaDjLfIkrBDiyc+MBceBNJw=; b=P3AFvHIx2lDBQWAE4t/2D0oLMQ0hIN3YM2q7qeXSz/tGgMaMYEOqna2OvDYYy8/gLs HOdKxzk8aHFUuaaiupk+OKaFLVd8Qdq09PsMpAf3h1D6jvU6HZqorueDRwAT1awU7w4R vb0luSYcsMbeOCIgJQUImkUlxB9rw3b/gDDklthMyxudFoFTCHfiMIxHam99iN/GjoDg BLpaZmtp/nZJVmT1LkBlb+l/92WkO8oI2nyWN+yqVZJplAWiUxyfim8MH2boQhI/2oz2 qnc8e/11r2DOjx62LhI4l19roG3Z50JoVAYxblN4NBRQOPxUOA0Rl7IAnWD1U+F+6u/Y b5Rw== X-Gm-Message-State: AJIora8dbp+Hh964GecVwVDw1jNcVTPlp/Pl/3HKnv1ygy6gMINdhARR dE42dJ2h24W//hOXgGMa/BcFsf77ARbmMyPEYRuigA== X-Google-Smtp-Source: AGRyM1tp6chanGu4lEPBpPBMUDOPfkdef6yQ98JG92tsAoK2RG7slFYHuEBASN7lDE9c44Zpxb2+fBAWjf7GQLGInWE= X-Received: by 2002:ac8:5dca:0:b0:31e:85b8:8a18 with SMTP id e10-20020ac85dca000000b0031e85b88a18mr4988874qtx.370.1657096160170; Wed, 06 Jul 2022 01:29:20 -0700 (PDT) MIME-Version: 1.0 References: <20220705202837.667-1-ansuelsmth@gmail.com> <20220705202837.667-5-ansuelsmth@gmail.com> In-Reply-To: <20220705202837.667-5-ansuelsmth@gmail.com> From: Dmitry Baryshkov Date: Wed, 6 Jul 2022 11:29:09 +0300 Message-ID: Subject: Re: [PATCH 4/5] ARM: dts: qcom: add pxo/cxo clock-output-names for ipq8064 To: Christian Marangi Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 5 Jul 2022 at 23:56, Christian Marangi wrote: > > Drivers expect to call pxo/cxo_board clock as pxo/cxo. > Use clock-output-names to set the correct naming for these fixed clock > to save drivers that are migrating to parent_data and still use > parent_names. Please no. There is no reason to add these names. Let's follow the example of other platforms. > > Signed-off-by: Christian Marangi > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 1425a4e4283f..720e27e29627 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -302,12 +302,14 @@ cxo_board: cxo_board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <25000000>; > + clock-output-names = "cxo"; > }; > > pxo_board: pxo_board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <25000000>; > + clock-output-names = "pxo"; > }; > > sleep_clk: sleep_clk { > -- > 2.36.1 > -- With best wishes Dmitry