From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EA82C48260 for ; Fri, 16 Feb 2024 16:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TIHdOGbU+pu7nYSND56Vq9cLpO7U8MmXUOfSZJG4pTc=; b=JlfkC3uwJpOi2W 3lCYw9pIoRZhMklt2A45pcX1JqpF2+RkQGwNIk02fydB69lsMmgYfXQiKEdv8RJpc9a5L/IKIrvLS BXQD9j0bIIbwOUzCxBsCAsGgoId2rrqdszr1VYwbAZ4DVM1TdMQuVIiIDzA9K4kKWHx397/+1yOkb XuX8rvC63G5K9vM5uSSh5H28AJIh8XHHU0LYN1YB7wpvi93uxvYvX0WRmh7xlxXrDOOAGh3rhvch8 Hy2rRGt47dXkWZ03bC5UZHfuoNpoPrUiBzQHCV6PUmvDMe5fKyrW+scOuTKQRgd6eohZZabV6HgTz w5RornGVvuyDp4okkYHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb134-00000002yy0-0hHS; Fri, 16 Feb 2024 16:26:50 +0000 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb131-00000002yxV-0KJS for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 16:26:48 +0000 Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-dc74435c428so2010402276.2 for ; Fri, 16 Feb 2024 08:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708100803; x=1708705603; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=44tIHP3e27m9mssG+F+MhxgHY8yrYPkp9JDOgoTDz6k=; b=hRlKmX4EbbSVBkoD3xwqgX0JkdJ3Dm4061SWExQ1fUbau7txRGBdNGx2Y8QQSsW7m+ /A2otUVpRyQbULh1n9icKsH1AB/EVNmrzv2DpfnNfDEo5gQ5pjD8WDX/T6jIVKjYlepu gLF/rZwG4j2zD4WIW0TtrFm8MKrBeUJHe/D4IMgNs8gcPafeH2Xm/MoU0RwtoJ5aZSMF lTfps4WGZHxzitPaOViynfxqs7KGyJBnG2CjCbXFEUMrwWe6A06nbjAK0jvkopzl7WbB O7Ehj9CveAySznMXft/E+a6XwjGgYq5bE5I+prtmyt7uQmiaS+kvcg4p7BJtW+WmgGyM vZeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708100803; x=1708705603; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=44tIHP3e27m9mssG+F+MhxgHY8yrYPkp9JDOgoTDz6k=; b=daPG2+cohwtbTuT/EwYBa0CA06i/FiGMZVDEQwJZ/1DftZOnDuNoqeCu5znjvr6uf/ 9A5MsqQ4X7XI2JuuhJR0h0OLXQzbiflC2ypV77JqpcjFRo17zaAATIglEjE0v+bVWmw0 F0YofKYsNtlQ8kh2/Ro8TO8I6ioRD66q85XSlehDxl835IyiRpYKk0UqFBbJhx86QC4m no4D7QRhZiyCGfOfj2eryOd3hyQquN4qu4pPH6RE2xZvu80O83TsxAqwfcMLrV7zKj+S OFVGC7JiEyhxQcGDPQduHLIS9aPtP9GLmyN70f3DpMRapWhVlKrTfP+7ICxzpa82xehJ RwuQ== X-Forwarded-Encrypted: i=1; AJvYcCUzE5JE2qiu6JlxXhcOm2sQSn4fEq9AO2ZiWIjeCHgAIQj8d6lk2rCTUo48ZCT1oGWjEPCweVPT+thtzMNEeTXoAUuZTTY7SmGK7yvV0DdxUu83W4w= X-Gm-Message-State: AOJu0YxOmU7P2ofN4Zr6IxYtqLPJVHiEEINrMabSdvwgdnuTCjMtGbLH 95KyQqXuyg8PZycAdO7cOrqB14CuUB46kOe1iPrtuAbEId3db57EO6V62FpITDcx4x3+/47xriN 5RSooeJVi3ymMcKiRZ+b+ilJVq4vRQLAmvE567w== X-Google-Smtp-Source: AGHT+IFuPYMq3HZ+E6QHC5yDkivYMMpl37gr1Cmwb52o7W8sSopxMnfNkn0jZFsKmhZQB/3N98O6EzewnPB6rpzvq84= X-Received: by 2002:a25:2002:0:b0:dcc:9e88:b1a with SMTP id g2-20020a252002000000b00dcc9e880b1amr4736884ybg.7.1708100802770; Fri, 16 Feb 2024 08:26:42 -0800 (PST) MIME-Version: 1.0 References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> <11fda059-3d8d-4030-922a-8fef16349a65@quicinc.com> <17e2400e-6881-4e9e-90c2-9c4f77a0d41d@lunn.ch> <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> In-Reply-To: <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> From: Dmitry Baryshkov Date: Fri, 16 Feb 2024 18:26:31 +0200 Message-ID: Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe To: Kathiravan Thirumoorthy Cc: Andrew Lunn , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_082647_150265_D4CF9B78 X-CRM114-Status: GOOD ( 47.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 16 Feb 2024 at 17:33, Kathiravan Thirumoorthy wrote: > > > > On 2/14/2024 8:14 PM, Andrew Lunn wrote: > > On Wed, Feb 14, 2024 at 02:49:41PM +0530, Kathiravan Thirumoorthy wrote: > >> > >> > >> On 1/26/2024 1:35 AM, Andrew Lunn wrote: > >>> On Mon, Jan 22, 2024 at 11:26:58AM +0530, Kathiravan Thirumoorthy wrote: > >>>> gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk are > >>>> enabled by default and it's RCG is properly configured by bootloader. > >>> > >>> Which bootloader? Mainline barebox? > >> > >> > >> Thanks for taking time to review the patches. I couldn't get time to respond > >> back, sorry for the delay. > >> > >> I was referring to the U-boot which is delivered as part of the QSDK. I will > >> call it out explicitly in the next patch. > > > > I've never used QSDK u-boot, so i can only make comments based on my > > experience with other vendors build of u-boot. That experience is, its > > broken for my use cases, and i try to replace it as soon as possible > > with upstream. > > > > I generally want to TFTP boot the kernel and the DT blob. Sometimes > > vendor u-boot has networking disabled. Or the TFTP client is > > missing. If it is there, the IP addresses are fixed, and i don't want > > to modify my network to make it compatible with the vendor > > requirements. If the IP addresses can be configured, sometimes there > > is no FLASH support so its not possible to actually write the > > configuration to FLASH so that it does the right thing on reboot > > etc... > > > > Often the vendor u-boot is a black box, no sources. Can you give me a > > git URL for the u-boot in QSDK? If the sources are open, i could at > > least rebuild it with everything turned on. > > > You can get the source at > https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/tree/NHSS.QSDK.12.2?ref_type=heads > > You should be able to TFTP the images, write into the flash and > configure the IP and so on... > > > > > > But still, it is better that Linux makes no assumptions about what the > > boot loader has done. That makes it much easier to change the > > bootloader. > > > >>>> Some of the NSS clocks needs these clocks to be enabled. To avoid > >>>> these clocks being disabled by clock framework, drop these entries > >>>> from the clock table and enable it in the driver probe itself. > >>> > >>> If they are critical clocks, i would expect a device to reference > >>> them. The CCF only disabled unused clocks in late_initcall_sync(), > >>> which means all drivers should of probed and taken a reference on any > >>> clocks they require. > >> > >> > >> Some of the NSSCC clocks are enabled by bootloaders and CCF disables the > >> same (because currently there are no consumers for these clocks available in > >> the tree. These clocks are consumed by the Networking drivers which are > >> being upstreamed). > > > > If there is no network drivers, you don't need clocks to the > > networking hardware. So CCF turning them off seems correct. > > > Yeah agree with your comments. > > QSDK's u-boot enables the network support, so the required NSSCC clocks > are turned ON and left it in ON state. CCF tries to disables the unused > NSSCC clocks but system goes for reboot. > > > Reason being, to access the NSSCC clocks, these GCC clocks > (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) > should be turned ON. But CCF disables these clocks as well due to the > lack of consumer. This means that NSSCC is also a consumer of those clocks. Please fix both DT and nsscc driver to handle NSSNOC clocks. > > Once you have actual drivers, this should solve itself, the drivers > > will consume the clocks. > > > Given that, NSSCC is being built as module, there is no issue in booting > the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will > reset. > > Without the networking drivers, there is no need to install this module. > And as you stated, once the drivers are available, there will be no issues. > > So can I explain the shortcomings of installing this module without the > networking drivers in cover letter and drop this patch all together? No. Using allyesconfig or allmodconfig and installing the full modules set should work. > >> However looking back, gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, > >> gcc_nssnoc_nsscc_clk are consumed by the networking drivers only. So is it > >> okay to drop these clocks from the GCC driver and add it back once the > >> actual consumer needs it? > > > > But why should you remove them. If nothing is using them, they should > > be turned off. > > > > Andrew > -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D099012FB3E for ; Fri, 16 Feb 2024 16:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100806; cv=none; b=kiuNGfnizpjvUsZuIcUusG9mNT4UPF32D3m5gNWR8azzjAbbhHZbBj7XBnBjtelbeflYJk8Co2JeRnC3MgnkYsDQdbG+oaBfZlLGSx9UqRYp9RREf+YNh1TN1jmDlL0lpdQQhr250atLWKyFIy8sqGBYdl8+ojeJWeFYS/pd3jQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100806; c=relaxed/simple; bh=LcZm2kWHQ4w78fgPQiXn6fezOQZ4PZIfAqO2QKgVre4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=amF8hTc0DvBdjRAfEbbvGRhg1+nwGT1bGGvl0QHNX0Ka3AXxCqFS369P07/gOtkM0yjtWzqpuXhB/ZvFnzaNMv+/G5xpwyVZG3XzZX/q3FGgCZWWeOhb+aIG/YTGJjaVN/NWadEYKSymn6+tGyF/xb++6gZtfYf2PVskuvwyYgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GTlNlHgB; arc=none smtp.client-ip=209.85.219.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GTlNlHgB" Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-dcc4de7d901so1873142276.0 for ; Fri, 16 Feb 2024 08:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708100803; x=1708705603; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=44tIHP3e27m9mssG+F+MhxgHY8yrYPkp9JDOgoTDz6k=; b=GTlNlHgBjngckS2bqahEVfaHLmZT7hItTbsRUPRkylEaTS3U0rg1cZ7MBDcSDzQVW6 HnCoAEOq4cKV0xelIa8Hr4kciMMYPmKat7L2Bav7DXzj1VAmVJxgFrs1rJsNP0Rxc8Rx Tk3L8+4lVEkBhWSMGN4kapsJR00FXmEhddi4HgdtTSFuhdAthJRmW+p8ZQZvgCmJP/JE 7VBoyM4eR1yOOCRt3/SNR/2H1VD8DKnV0IH5KvzcoQv+fej3ML3ddZEExOv7xlQ8GNOi QeptJG7C3epNKhif52dnDqQLFqmeAD8iySp0sz+2lGFz7X+BYCnbAWwnX3EAGfb0TBQ0 JKwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708100803; x=1708705603; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=44tIHP3e27m9mssG+F+MhxgHY8yrYPkp9JDOgoTDz6k=; b=YaO3e8iAeS+iyUUJm2RSoaghhtX5cDPYfUHx2i55MFoMhE/OrEps7zv4y9OOdU1SHi 0E58tCzkaBoxnRJXamkgirmxdNLeYiwg73E/Nzps8bwktJZQ8fVg3V5ZRjxR/npcRqlZ XUErPKrg7K55kC7MqOOkhMG/mbwG50V3cG7c41wrrGQ2gbb5i527U+tfNVg1wm5gM92h QlQQqguFLMG4X4ePPNsTuJihDO7FG2ako+L/cRzhydk4QL2A7sG1v/KSwlKxiBUve5SC BxiTTLbO8eKi+XWH47Zb9osNegFiPEne7NmLC3JPBswZ8FjUAAa+OXuCiyeNrFYLspY1 qHDQ== X-Forwarded-Encrypted: i=1; AJvYcCU7GuYjQ0XzDV9bB1eCOBt0C/cwsNVXKiTaJTscYzgGthiW5ZfOOa/Ae780xGvO8YdIXCEM6Mhe777a8eVq4vXNNYk96/M522pruCuqsg== X-Gm-Message-State: AOJu0YyYQDx7UtUyzJPEo1S7In4yqVDY1j+18w7wd4veFMZpzHWfohjJ MBUttYa1AkLPKhA/CEavPsYjKVxBM9oqMBvQQHd2AMQdcUNO81nFrFulxaqG3VamXAVlOEitEPQ 3BYtWAv3vIJxszDw3x28eWZYkGhaHXbnBFEoQkw== X-Google-Smtp-Source: AGHT+IFuPYMq3HZ+E6QHC5yDkivYMMpl37gr1Cmwb52o7W8sSopxMnfNkn0jZFsKmhZQB/3N98O6EzewnPB6rpzvq84= X-Received: by 2002:a25:2002:0:b0:dcc:9e88:b1a with SMTP id g2-20020a252002000000b00dcc9e880b1amr4736884ybg.7.1708100802770; Fri, 16 Feb 2024 08:26:42 -0800 (PST) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> <11fda059-3d8d-4030-922a-8fef16349a65@quicinc.com> <17e2400e-6881-4e9e-90c2-9c4f77a0d41d@lunn.ch> <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> In-Reply-To: <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> From: Dmitry Baryshkov Date: Fri, 16 Feb 2024 18:26:31 +0200 Message-ID: Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe To: Kathiravan Thirumoorthy Cc: Andrew Lunn , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" On Fri, 16 Feb 2024 at 17:33, Kathiravan Thirumoorthy wrote: > > > > On 2/14/2024 8:14 PM, Andrew Lunn wrote: > > On Wed, Feb 14, 2024 at 02:49:41PM +0530, Kathiravan Thirumoorthy wrote: > >> > >> > >> On 1/26/2024 1:35 AM, Andrew Lunn wrote: > >>> On Mon, Jan 22, 2024 at 11:26:58AM +0530, Kathiravan Thirumoorthy wrote: > >>>> gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk are > >>>> enabled by default and it's RCG is properly configured by bootloader. > >>> > >>> Which bootloader? Mainline barebox? > >> > >> > >> Thanks for taking time to review the patches. I couldn't get time to respond > >> back, sorry for the delay. > >> > >> I was referring to the U-boot which is delivered as part of the QSDK. I will > >> call it out explicitly in the next patch. > > > > I've never used QSDK u-boot, so i can only make comments based on my > > experience with other vendors build of u-boot. That experience is, its > > broken for my use cases, and i try to replace it as soon as possible > > with upstream. > > > > I generally want to TFTP boot the kernel and the DT blob. Sometimes > > vendor u-boot has networking disabled. Or the TFTP client is > > missing. If it is there, the IP addresses are fixed, and i don't want > > to modify my network to make it compatible with the vendor > > requirements. If the IP addresses can be configured, sometimes there > > is no FLASH support so its not possible to actually write the > > configuration to FLASH so that it does the right thing on reboot > > etc... > > > > Often the vendor u-boot is a black box, no sources. Can you give me a > > git URL for the u-boot in QSDK? If the sources are open, i could at > > least rebuild it with everything turned on. > > > You can get the source at > https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/tree/NHSS.QSDK.12.2?ref_type=heads > > You should be able to TFTP the images, write into the flash and > configure the IP and so on... > > > > > > But still, it is better that Linux makes no assumptions about what the > > boot loader has done. That makes it much easier to change the > > bootloader. > > > >>>> Some of the NSS clocks needs these clocks to be enabled. To avoid > >>>> these clocks being disabled by clock framework, drop these entries > >>>> from the clock table and enable it in the driver probe itself. > >>> > >>> If they are critical clocks, i would expect a device to reference > >>> them. The CCF only disabled unused clocks in late_initcall_sync(), > >>> which means all drivers should of probed and taken a reference on any > >>> clocks they require. > >> > >> > >> Some of the NSSCC clocks are enabled by bootloaders and CCF disables the > >> same (because currently there are no consumers for these clocks available in > >> the tree. These clocks are consumed by the Networking drivers which are > >> being upstreamed). > > > > If there is no network drivers, you don't need clocks to the > > networking hardware. So CCF turning them off seems correct. > > > Yeah agree with your comments. > > QSDK's u-boot enables the network support, so the required NSSCC clocks > are turned ON and left it in ON state. CCF tries to disables the unused > NSSCC clocks but system goes for reboot. > > > Reason being, to access the NSSCC clocks, these GCC clocks > (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) > should be turned ON. But CCF disables these clocks as well due to the > lack of consumer. This means that NSSCC is also a consumer of those clocks. Please fix both DT and nsscc driver to handle NSSNOC clocks. > > Once you have actual drivers, this should solve itself, the drivers > > will consume the clocks. > > > Given that, NSSCC is being built as module, there is no issue in booting > the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will > reset. > > Without the networking drivers, there is no need to install this module. > And as you stated, once the drivers are available, there will be no issues. > > So can I explain the shortcomings of installing this module without the > networking drivers in cover letter and drop this patch all together? No. Using allyesconfig or allmodconfig and installing the full modules set should work. > >> However looking back, gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, > >> gcc_nssnoc_nsscc_clk are consumed by the networking drivers only. So is it > >> okay to drop these clocks from the GCC driver and add it back once the > >> actual consumer needs it? > > > > But why should you remove them. If nothing is using them, they should > > be turned off. > > > > Andrew > -- With best wishes Dmitry